From nobody Tue Feb 10 05:26:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92772+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92772+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661359908589628.2945641591651; Wed, 24 Aug 2022 09:51:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id A4SGYY1788612x75uOIElgQE; Wed, 24 Aug 2022 09:51:48 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.121]) by mx.groups.io with SMTP id smtpd.web12.13330.1661359907615871676 for ; Wed, 24 Aug 2022 09:51:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zkbi80xUzcsQb1yKdUEXcBTGpiUCg4AjjnmZDBoxzFMKA94YtXr8Yl9jA4qS+7TqXec+IGIVXUJ1fU6lmmaPYaFJNvpsEvYaKFZPWqPDZNojtDihpAYv4VhUqbVQqNTJ+nl22qt2e4z+6Ux0rSyL7oh4xnuQTk+DW5cr4/42qJkO0WpAWZhJ0awXhhZjEyHM/gB9x/8cUN70BehxntKtDNQpbZgL3wATRjl22YNXjHd+Q1JWALIjy8sdeC2Ytg5gkv18kr5K++KepqZV/gFIpgQhMpihiIV4a7/qP3MDZVDmFEg8lF8EDQVSdXQDaVuAvoqgkKWwt7w4OtmfXNCjug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+IztdDMjl4z0hhuwSpFyAecqzg9yDkjPFCjs5vrsJSo=; b=T1OZmTnyfbEBWvtqZBFQfa4U8TKfauuUABLKzBUtKYxZF7xIHNplhDRXT3fntNJav+C8+x+NXJ9uooJ6okuMjQPLwjf+V0WAjhmHy9cPHLeTPXDF8nH9uubHnteobN+4gAQdblxpD/bqU1GqMw6X+CIsqBQpb4+ptEWVsXtSGNUXBpAwscEsvvrkW/lD32a1krdKzblOwMzY2uwY8j6ceIkgFjANKmqz40MY4CrDtE6j+DQ9Q7PR7d2793EiD+PZi98hFQfyRuIAVkEF5PWOTzdXulQ9R6DkbrykndSf/lndinlUXG0pvJasiNnPScmW+fBgESYVwJUt7R5b3xyuKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM4PR01MB7642.prod.exchangelabs.com (2603:10b6:8:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 16:51:46 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.024; Wed, 24 Aug 2022 16:51:46 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [PATCH v2 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib Date: Wed, 24 Aug 2022 23:50:32 +0700 Message-Id: <20220824165032.1784305-7-nhi@os.amperecomputing.com> In-Reply-To: <20220824165032.1784305-1-nhi@os.amperecomputing.com> References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SGXP274CA0001.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0db9076a-7e90-43ea-ec51-08da85f0edee X-MS-TrafficTypeDiagnostic: DM4PR01MB7642:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: ahN7o1QmBskEWAkMzwgJq9dwcoTk/clD7NHSRaUSQTBV437Cisi985MeRi745JM/eWkfUG5hfBseV74/2ka9PItjoCbuDaWLRopEaUvscB6cDbvCiP4B+Y55QEjngZg0ZwcZLMp9AdJZRMAh1v1pncbbcSnBz/H2qaSsS1ahxt2Dzy3nVgMAra44ogstunqMJoMCH1ZueuTHpB9LGbQHIoqCwFtLFJXL4KTDyorsriPZBOYIDdDzHg0/rPD3z7uSVN72fR/mVxvqrPdy1e/E2KXDVu7DncWjhcLI7XTZWzNv3aQ9XqyuuNvoq1P3KruiKk7KEtfGRcB4GgZr+d2Dn3ertic6HAaPXpNj84U6AO/lUd8rat/kBABawtW1B1bpUBdK4ClxiJTwjM0CL1/050bguxauxQpbL/8TDQ4E832ns89UOveS5O9dGb61b8iaOekN+kNdX8SuFuDtpT++vP/8rdSm9BUrEJd7e5tAb2UL6I9clWpokN2ETwiRz1JhriVGqqQE4qlgB9NpP+gizz11/JG912MQEMW0Xm1vz9++j/XkDH8b6sSPf3X/Tftj7dK1a7bR/WY73mnxjxDK0c4kUPDl+xc3/oV4XBITwvVJMgvgWiQX74QNzdAU1F0DCbczdLD8yfvAa//lzA+Lh14pT9/aN0pe3PhBFRkPhONNs4K9hunpW8193FjW9JAXgCgnT3Nyk3PLCwHWBJfBVq/H4ntvc8qkjnrejM9Hii5O/ouRRi10VZNBKOKIQIODMLgxpv0f4ok4gQWHFlo13bR8/XDveSGSmuwJOS9TBvg= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qngot25AqwdFiO3jYedjOW95ytjJX1Hj6uZmbrwMvqAgiHqW4Zl1RzJvySYy?= =?us-ascii?Q?/Ybx1ZyQgDAYg8Dta6S8z3kvMGAyHtH3qICfV8gE3F+9WMsqUfr7DDkmIqCC?= =?us-ascii?Q?jrTfYo60jI9KDN9B/asb0vHjJWusrNpaBWRScm/Wj7EEbg4XE1QZVsXQ3bWq?= =?us-ascii?Q?7zty4rCxKDD+2g74obxVejK+Z+QKdcYbyr+5Oj20CCJiVa4o5GcVuS5Sqn/Y?= =?us-ascii?Q?2PRIOJDLcSNP1CJjumhk+2L1Hl1mqDBwpZGG1y3WlQJ8SABT52/5xL2tBKQc?= =?us-ascii?Q?a34R1nEP7xFTFhlWFAyRViufetMD2LtAAK0N1K+248HTQ2EmeWAaoF7XFFfl?= =?us-ascii?Q?E8eTIXAlhUB0uHHFV0OqSc1syQ0ObXiM7DGQums5yUo3uyY7WidYwei7+oGv?= =?us-ascii?Q?xi9Qjn27ITcK3OCn6gUjgixfn29pTurdWMa1eMYPL3REJULkVoly098ZAXxP?= =?us-ascii?Q?6uCT1JY2x2vbARR7Bivjd5Geoc/v+la6luM7iZHIKWB+zzrx0OuQM4pgwqZN?= =?us-ascii?Q?oEuhFIzLqaVpPIXVDlPEw0c8WA9wfHkcgntD8Xr69lW6Vb39obL3RIaVAcw1?= =?us-ascii?Q?Mw3f8hJ5EeYpexhJQaDn/R6pdkJv+7PiP1pFrxfIftohAmA4bwqYpSWM1RBl?= =?us-ascii?Q?fOuGEm070pcOGeHtnwS9fWIpusrClA34Ad/6Ony9FGkixlRZskcsxOh+MuYW?= =?us-ascii?Q?PA2Bb2/T7gJ452T4yeyFTRqTj5fKkW1k0DdUFGsbfE8mhwX0Q5MknenDbwpv?= =?us-ascii?Q?969Qb0+kd0i09VSpTMCbxtZNcO7BjFwl5HIGMyBoNC/C3ZI2b1jlezMo+HR9?= =?us-ascii?Q?hKcHBN7qesh1LY/BKnMnCEsfvCRROcLwEmPx3XFWOoAlIhqVxR71XixyKkOX?= =?us-ascii?Q?HBvcX7PDRr6utNNDPkZ2f5xjb2P1vbOcLYQ2nJJeRpqsmkGBV/4piPihSOkJ?= =?us-ascii?Q?qhC/cOCZWVRVT6MZ7TIlrlBThEPE1Km07IEGUrHXF7tmkVFrUHYMOXX7N8yw?= =?us-ascii?Q?afRkRZ9H9jp0CBELoUNNT0FFNGM/hj/cKML3SupZurOogfj4SefKBp+AcoUZ?= =?us-ascii?Q?pSCi9X24nz3TL4LBBtJsTCB/5gwGXdNBnYrVNjB6xf7cWlBF0f1yF/fBf1XU?= =?us-ascii?Q?zzMCMJ4rusIEZ8imP0TeE9oItpAS5DSG64c6Hn6nVe8Z1Tuu8YBmUBqkT7xz?= =?us-ascii?Q?BP6EbBnTyA3XgjdTY042Yk6vcziRpYepoRpf7AcHfkRtP3YLHfSJ5cS/MX8z?= =?us-ascii?Q?c5r+WtQ1Ft+SvJZv0TQQysdG9kW9iAPM0bfdoylhpEKNdSDiupXS1+eL6l8W?= =?us-ascii?Q?S/JEQgNK0eYpjoVK5aJKZOkPpDDijJZW+Y3quKMkWp7+a3l34cwV5A7vll2h?= =?us-ascii?Q?JyZU56H80iK2kX989QLDCZRP7/V9TqyE/jBAzqerS80XY1cnDuvLqbt8B7N5?= =?us-ascii?Q?v7eK9xEvrdgrJX/GjHLugnEaIY+9gH/G3cUfqXNUD3jdAZqbH0nYKOkOBG1a?= =?us-ascii?Q?EuSfSS4SCHUsyjifCUoi2nhm3TmGMIKnaU/W5p3rSK4xAhzRD+NsjUwKBH8v?= =?us-ascii?Q?ZJyXd6y19OjP3Njq68FOqrmWs/I0F0KpLU6r09EGJoHKmd73i83qRaJkx8v7?= =?us-ascii?Q?YlEGjTsndwQzN6FeQOJ0NRA=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0db9076a-7e90-43ea-ec51-08da85f0edee X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:51:45.9349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JmcOCpwo6qkqEfm8cJ3hmeJcevSD2uaQIbD21pcoSBB4LReHTuNP2BhsMFUfjf+mHWjtBMG6h+1PDh+jxEJXf4T2s6yhfS9naMf2mvU5Ge8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR01MB7642 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: BO3eznDaGhnJrM66VtBmUcnDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661359908; bh=7OJTXrkceTHeS1qjxChGNUF0eg18NICnB+WykfMku2c=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=agP7RWM8Q6dhbSmLazlvmzoN4iTilgvupgHjTBAaLy8Zgi+qWXKjc/GneaQ646aGXx2 kB8GUOPOirnjgfPlv3VJvUbrp3MW1l6e6yHuIuY1IxVd4fsDihlhOk9mClTjq9nFI3SJe C9q3teQQ8XE3cBlgO7NIk8A8Tolr5gTiq34= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661359910292100015 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen In some scenarios, the information of Bios Version, Bios Release and Embedded Controller Firmware Release are fetched during UEFI booting. This patch supports updating those fields dynamically when the PCDs are empty. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h | 21= +++++++++++++ ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 28= +++++++++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 32= +++++++++++++------- 3 files changed, 70 insertions(+), 11 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 1936619d9b5b..541274999e5c 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -37,6 +37,7 @@ typedef struct { } OEM_MISC_PROCESSOR_DATA; =20 typedef enum { + BiosVersionType00, ProductNameType01, SerialNumType01, UuidType01, @@ -247,4 +248,24 @@ OemGetSystemUuid ( OUT GUID *SystemUuid ); =20 +/** Fetches the BIOS release. + + @return The BIOS release. +**/ +UINT16 +EFIAPI +OemGetBiosRelease ( + VOID + ); + +/** Fetches the embedded controller firmware release. + + @return The embedded controller firmware release. +**/ +UINT16 +EFIAPI +OemGetEmbeddedControllerFirmwareRelease ( + VOID + ); + #endif // OEM_MISC_LIB_H_ diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/U= niversal/Smbios/OemMiscLibNull/OemMiscLib.c index 32f6d55c1a9a..788ccab9e8c1 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -254,3 +254,31 @@ OemGetSystemUuid ( ASSERT (FALSE); CopyGuid (SystemUuid, &gZeroGuid); } + +/** Fetches the BIOS release. + + @return The BIOS release. +**/ +UINT16 +EFIAPI +OemGetBiosRelease ( + VOID + ) +{ + ASSERT (FALSE); + return 0xFFFF; +} + +/** Fetches the embedded controller firmware release. + + @return The embedded controller firmware release. +**/ +UINT16 +EFIAPI +OemGetEmbeddedControllerFirmwareRelease ( + VOID + ) +{ + ASSERT (FALSE); + return 0xFFFF; +} diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFun= ction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFuncti= on.c index b49c4b754cab..e9106a8a2fec 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c @@ -1,5 +1,6 @@ /** @file =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2009, Intel Corporation. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved.
@@ -13,6 +14,7 @@ #include #include #include +#include #include #include =20 @@ -191,11 +193,11 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BIOS_VERSION); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); } else { - Version =3D (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString); - if (StrLen (Version) > 0) { - TokenToUpdate =3D STRING_TOKEN (STR_MISC_BIOS_VERSION); - HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); - } + OemUpdateSmbiosInfo ( + mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BIOS_VERSION), + BiosVersionType00 + ); } =20 Char16String =3D GetBiosReleaseDate (); @@ -251,13 +253,21 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) { } } =20 - SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(PcdGet16 (PcdSystemBios= Release) >> 8); - SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(PcdGet16 (PcdSystemBios= Release) & 0xFF); + if (PcdGet16 (PcdSystemBiosRelease) !=3D 0xFFFF) { + SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(PcdGet16 (PcdSystemBi= osRelease) >> 8); + SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(PcdGet16 (PcdSystemBi= osRelease) & 0xFF); + } else { + SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(OemGetBiosRelease () = >> 8); + SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(OemGetBiosRelease () = & 0xFF); + } =20 - SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16) - (PcdGet16 (PcdEmb= eddedControllerFirmwareRelease) >> 8); - SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16) - (PcdGet16 (PcdEmb= eddedControllerFirmwareRelease) & 0xFF); + if (PcdGet16 (PcdEmbeddedControllerFirmwareRelease) !=3D 0xFFFF) { + SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16)(PcdG= et16 (PcdEmbeddedControllerFirmwareRelease) >> 8); + SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16)(PcdG= et16 (PcdEmbeddedControllerFirmwareRelease) & 0xFF); + } else { + SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16)(OemG= etEmbeddedControllerFirmwareRelease () >> 8); + SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16)(OemG= etEmbeddedControllerFirmwareRelease () & 0xFF); + } =20 OptionalStrStart =3D (CHAR8 *)(SmbiosRecord + 1); UnicodeStrToAsciiStrS (Vendor, OptionalStrStart, VendorStrLen + 1); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92772): https://edk2.groups.io/g/devel/message/92772 Mute This Topic: https://groups.io/mt/93231059/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-