From nobody Tue Feb 10 05:26:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92768+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92768+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16613598984561013.8801565255819; Wed, 24 Aug 2022 09:51:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZQXNYY1788612xNNP2QcPvvK; Wed, 24 Aug 2022 09:51:38 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.107]) by mx.groups.io with SMTP id smtpd.web12.13326.1661359897314858680 for ; Wed, 24 Aug 2022 09:51:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVhSJCIbEkCXvrAvSyB+fA8FgjCG2KYx6xabl3UP6qqa0iVN8FLGjetp2cGV/jDeOZb/2gwB6ZTNHvXO3guTsPzhBYKg/hnsi9NsffKUQ+alM9BGayV14aKghpxNxEL7yjrK1LtNN1m4Isoq6/ay9OTVcHj1QE6T5kbCMzg1b8tYAmWhNXKUt95/IYqEjT5FJwnEx1uuB4+yFq9X67GwSd0uKlQ0rhR6By43k97cvoJbB0IjV+KE23osGcsNB5wQjSLKV0hm1iPooL8ZBVbxYWDlnQGyeyjeDDTeHumQ66WDZOkX/F5JwKkzbxSNjDCJu0IoOrk07GXi1zZrtr2Kig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=juGfD9WbN5Qm1b5g2/fefLIhY+j0TJsb7XIpryZ/GIA=; b=UA5Tm+gdM9YTT5e58LROajOJefJBO16fJ3hqa6qz081tMXTXxIYdMMt+fEC4F/dpoeZEILR38k0/nhAMRmWG9acolk6TohkeAd4g3KBwBKWe4zqeYKalMmLzIWnxkWlcy9uE9LTdTI63+5oyQIaq67QWxrt6w7IvqxAdZGzga2BFO6UrkeNMpRXPXbABbGBbIUzSyMtGWTVL+R+eWXISAzGj3yBefH/oUVtkbuslmMtyd1lvsZ56VHbOq+yYe67xkZbO/XZ4UfBlIP0aEv9fXT4OmaxBKYyNWE+zBMrluxjkY+9N/txEFJdor/D6R2SfRWVinADn7ljgQtYLujEHHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM4PR01MB7642.prod.exchangelabs.com (2603:10b6:8:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 16:51:35 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.024; Wed, 24 Aug 2022 16:51:35 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [PATCH v2 2/6] ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call Date: Wed, 24 Aug 2022 23:50:28 +0700 Message-Id: <20220824165032.1784305-3-nhi@os.amperecomputing.com> In-Reply-To: <20220824165032.1784305-1-nhi@os.amperecomputing.com> References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SGXP274CA0001.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eaa9a284-a8f0-4498-e37a-08da85f0e7b7 X-MS-TrafficTypeDiagnostic: DM4PR01MB7642:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: nZncfF1EL2SrOxC+0vGM1yABeQdFrsmCdaW39ewZU45/W4aV3sF9qrpP+MmJ+Sjg6cvInpaSnljY2TzNMhoZR4ZwYzsaLleoH69dcfkZGi83pLKSuKlOtMN9gGq3973HlQH/xS9rXwkNKghh/vAZvR5G0SBAIx8vpbqnSTI8tP3JfqJ9xtvkqEyhDd6k4P5PlqOwnwHZeqvwAHSUo42+jMXmp7RvxBQXNF60usqMirxNHoH0xX8vdYptd48tbg7F/p2ZTa7/zXPHbtjpeSZZEIa4LNYqDhSeLsHCIs6AAI0XR+K4AAs3g7m+CMripgC634dRH5wuYgIgRe/vc0INcHlWsKIU+ZbZvSGBL4AZx7JiVByLroYnvELALPv8jyCXED2HFFWNW1CYSP5D7H8VeIY00n8oOW/yk1vpJhDS6t9B4tGAw7NkM1V9/0HM/OBDmX/iQlj6aqHkdyI4Ay37tjeoZ0+rrOsqYs3VuOCDKjtHmsvD2xObQSSIWNgrR+ouHqw9z5LxYPrw5yowK5M3cuzbTln1AqUW213ThV6fXUtnflg2jf/lSnGRmTDGX4OubZg5wdv+0S6ckrXTpK3mBZqJYtJyF+TtSMfeM4B5Bq+DXG5v3ZIoTcVoHciDqhp9XNTnDB07wRAdW1BXcHDraI2WvCdNHAzhKQa0IUvv5jPP8JF1nEaraZZBXBhADmUlmmjyT9KKj5kJYNuFpGm1w7vAyCx0xQaSy1t1Q8py0XUYeOlFMf1krT7WU8wIkCAlu8rT7PS7V2jJMOrDDq/iew== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IcxVvQ7KAyXbcdHUcQb22dfwyLNJxmnZkJkHklTc7negFPr5sL21LGuovjlT?= =?us-ascii?Q?aFcT3JNc/pb/wQkk24/w8GOhgHGPMxq2/aMgHV6WVBkappySSMRKUau5UYtm?= =?us-ascii?Q?REEmNMyvK+dsA2eo5Y2YLv1uGq7AW4FCt4HQjbg7n0Wk9xBv7uMpvIjfMzWE?= =?us-ascii?Q?VN++dv/NnREohzXWYU9gx0WHSOZHQVZl4FahgZL0SgxlCrK9Hr1t94aXWNai?= =?us-ascii?Q?ZwYV5P8if0XTEINnN/M4dD5eTMX+Fh3Jqa0wzCc4kKS3ysPycj5e53PmmLax?= =?us-ascii?Q?+FTipVqsx6uZJ9Qc9b+sjxLsl/EHe8zPH8iDDcibFZ5d+AQO0MM5YWVL2y+M?= =?us-ascii?Q?1YdodeSAvIfxqpUpoW1VjCpVJo3JCJI497FCeZ5+QZDopCRB4u+8qFzGOTYx?= =?us-ascii?Q?k6DR7v7yE3KAQkVf6Wit++/AkqR0vzIB7yWV9ojIpkI5rRDeq0+VmBBC/zuS?= =?us-ascii?Q?1ie+vYhIY9z8tMsJuXGTO+aJWHRWARZMJM3UAO4A4V5CuioSHGtwYzOdEX9d?= =?us-ascii?Q?+y+K/dZGilsnzSSsWQFeBfpKPWtZXM41RmpdhGBRS/xfp6OIO7vFUYGggRpW?= =?us-ascii?Q?kxKdN4ZL4cjdGOAnQLWESJVdenEg636U3pPMZNGr8HjeSib3415DDIfZecp2?= =?us-ascii?Q?ZDB6Xi1VeW9HUDLOORO48ptxm7s/ygScWjrZkkXIWhqgPanOlo0qwNNurNtR?= =?us-ascii?Q?9QLO1O3J+fDyq/JO5XdQNQwSRSKUgsGgAO8t0K8N14iYMR1k2lSLS+j5VmbD?= =?us-ascii?Q?GFVSIgTu7hua5OTywc8ErNTTD2L0uMxE3ttD6JbkI6sZuEeLweRn8WvW2O63?= =?us-ascii?Q?8BlxXGlQqbMGjuwmZpYbkJzpsT/spiPcUDgxnUz69pYyHyaBj7rXzgu+bpND?= =?us-ascii?Q?RqDEeiVkyMoUFQd4k9xeVkW5aibvm1+G03iSEy7NsVo5J+Cc0FtzRU+IXwOv?= =?us-ascii?Q?4zWiXEWNIR6l38BsiZ5YWhqqI39eQvqaM5kDZWMdMrcQiQgIzaS2SzdgIvPM?= =?us-ascii?Q?j4lQ0vOt5R9ChRjWPVXUuq1vjP8dIzvq5spwhC7oYDLi0lo7uvXVByjIPzuw?= =?us-ascii?Q?ZGTKFf912ba3/TVoVPjk80jLkFEdamWDB5+En1b40J/PuUveWVTQAEW+FqAg?= =?us-ascii?Q?ZOYT1lQ93YYEsgx0vvi7w+XUcbjufmfJpLduGmNZlhR3MgjXGSxJfKVunJOF?= =?us-ascii?Q?QlgHPc7uBg+RtPOvXFXiIh2uFRbrdNKFtkHxvtBxToTzy6ng7JsWAUWSfdeU?= =?us-ascii?Q?v4S19lY3uOvnjr8Zvx3PdruLVSOowLZWaHo55OspAXbEOg8Y6a6CbbEetBZ9?= =?us-ascii?Q?8VMMmAyLD+GIRcisclz50XVGaEGr/9ZTwz2crsqKmsYfh+iYpb+/ztlwORxn?= =?us-ascii?Q?QWvQuqjKAscEHHpSeNZJ/XXwNeLgdGGB4BRM9HHjSvaKv5t6zyJfbI+fRK6o?= =?us-ascii?Q?wmxWA5EuC4ebSi6zrVzl3M/xhqlxq6nt36iS4hC5FqKQpKKhJBVRs50EP/EP?= =?us-ascii?Q?l8y7yrPtBBdadSu3OuzfYP9JF9rFNiCsC31P0aZBPuy8XxveuBcnsnMmdkoj?= =?us-ascii?Q?uyTx4G1Hkq9wL5aMkiSY+EBxME8b38Tv9bqWD2EJmbma3ozXDERbcfjcX/lq?= =?us-ascii?Q?Za9WH55GkQN7rfHSdmTC7Og=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: eaa9a284-a8f0-4498-e37a-08da85f0e7b7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:51:35.4297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4w4a7kfx71xXXSsbIiNVlLg9+WNs6KHezwI1k/lora/1SwMwStgEd01cRi1B5DM1HVRjp1goMD/WK0kqFhFjA8ha0Rm1dsPaXvwPG2gSz8w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR01MB7642 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: Wwy3axTVYJ7JN8sNGqRtppuKx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661359898; bh=2h4wM/ydDoCitLmEfpA+18O2d7BkdFMZ4WD22PQxOcc=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=kCJmmhIUdRNT/IUBFSA/TnU2BcNp0IbU51pSv8OxBe59CwxKfFFVKZrDlNkd8rgZRXs krXIgmpMySFKOnxbMQ460JWpxeyEiWfAm4Mlbalanh1QSV7uXgYTXlHLdEuYVqitGQMlE pDoq3aQV7E3qg9EtyMOX+u48CqGXd7So8xk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661359900239100011 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen According to "SMC Calling Convention" specification, section 7.4, return value of Arm Architecture Calls is stored at first argument of SMC aguments (ARM_SMC_ARGS). This value can be negative values indicating error or positive values (including zero) indicating success. Positive value would contain information of respective Function ID (Section 7.3.4 and 7.4.4). For that reason, "SMCCC_VERSION" and "SMCCC_ARCH_FEATURES" Function ID calls read return value from "SmcCallStatus" variable (Args.Arg0 - first argument of SMC call). But "SMCCC_ARCH_SOC_ID" Function ID call is reading return value from "SmcParam" variable (Args.Arg1 - second argument of SMC call) so it leads to unexpected results of "Jep106Code" and "SocRevision". This patch is to correct it. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | = 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorAr= mCommon.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm= Common.c index e0010a40e489..b961be213358 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon= .c +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon= .c @@ -2,7 +2,7 @@ Functions for processor information common to ARM and AARCH64. =20 Copyright (c) 2021, NUVIA Inc. All rights reserved.
- Copyright (c) 2021, Ampere Computing LLC. All rights reserved.
+ Copyright (c) 2021 - 2022, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -131,7 +131,7 @@ SmbiosGetSmcArm64SocId ( SmcCallStatus =3D ArmCallSmc1 (SMCCC_ARCH_SOC_ID, &SmcParam, NULL, NULL); =20 if (SmcCallStatus >=3D 0) { - *Jep106Code =3D (INT32)SmcParam; + *Jep106Code =3D SmcCallStatus; } else { Status =3D EFI_UNSUPPORTED; } @@ -140,7 +140,7 @@ SmbiosGetSmcArm64SocId ( SmcCallStatus =3D ArmCallSmc1 (SMCCC_ARCH_SOC_ID, &SmcParam, NULL, NULL); =20 if (SmcCallStatus >=3D 0) { - *SocRevision =3D (INT32)SmcParam; + *SocRevision =3D SmcCallStatus; } else { Status =3D EFI_UNSUPPORTED; } --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92768): https://edk2.groups.io/g/devel/message/92768 Mute This Topic: https://groups.io/mt/93231051/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-