From nobody Tue Feb 10 05:26:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92767+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92767+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661359896722907.1111094153463; Wed, 24 Aug 2022 09:51:36 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 1gbfYY1788612xNL8oAuob00; Wed, 24 Aug 2022 09:51:36 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.134]) by mx.groups.io with SMTP id smtpd.web08.13401.1661359894078672374 for ; Wed, 24 Aug 2022 09:51:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oWUZwDMBiWonh+0Z/1XnnxZwtP51uJYOm6GA01kSPu8//c6Te9rL2D5XjaqBm9BXrzoQCCjJKaMsWYmQ/rrQfQyfL5RZBonSHnsD/4up04WDyayrYG1HP/w/JlB9L+tmvhUguEnTRMk6mwqpXXvEAPjy+aSbOy+6bl64z5cNKU3EG2gZUaiLzVpcLTsHTVRjPb0CaDjWPGvqKZrBnj8m3jS92CNWWgC0q3jd91ymTdcofBdqKSORXc85AsQDmfiZsch1hWbn4UbErA+hitleg3+y1TekA4hobS6j0lxS1pQbc+hHblDI8RG0d93V8yvZ5dn5ormFqi+3NgyWUdv92w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vTlEiqvpuhcomQL3atLtXv6mwQvvHFKB8F1cBLy+MDE=; b=mIOClXAAXdp3gs7QZoIbrE234kduQtb+KSYduVCZlGNF+JnWtkKRiwivx5Bchi3xWblkqhg/y7esls0RANi0jWXzLqfV2C6r/ITLraSOogVqDhlVuDW4umZ3OePrOYexchw1rqOyWQrzPbd0g7cC7XBKn9yFfm2c6mp+RSnddHCXYXkrsUC/D3OSoy1/miCxMtU0Hd6UKil7lXjxsHDMbVVzx82tXWQ+UGeMgPYbLHmkGZ6eqHwhJjia2PWeK9sm3xzN5c/PQGPUg8Piu9JZaN6Wzasnxqn2DINhy0cDm60Wkt/6A81T0Wr4dU34ImRQBYJ0R8HPuP60EB5ccN/iTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM4PR01MB7642.prod.exchangelabs.com (2603:10b6:8:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 16:51:32 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.024; Wed, 24 Aug 2022 16:51:32 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [PATCH v2 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib Date: Wed, 24 Aug 2022 23:50:27 +0700 Message-Id: <20220824165032.1784305-2-nhi@os.amperecomputing.com> In-Reply-To: <20220824165032.1784305-1-nhi@os.amperecomputing.com> References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SGXP274CA0001.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 49044e99-44db-49a8-3e83-08da85f0e620 X-MS-TrafficTypeDiagnostic: DM4PR01MB7642:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: eXBXkBJJlbxtgI2czLiKZFYfZezB8msZxQJVFkvbp8qFjgc2Tc07/T3TIqfEidIbRpbtgFNtf2a+GU7BMvKUBepQM3rmlwglfbwvldfkCX8KGbdgLcaK72Vn4YcF28tfnQ/UPBk7Nv6caUrC9J6mt/KSboZzf2JGg7a60/Kkm+PhF3MKrHSrEhN/teutoTm4srUjgnMIf1pOF5+tx/siwAEJq2A/2svbAPr0YzV6sy80lXV9e//+7cCb2ERoKZo899DQ0ImeTjASi/KvLaC1SOVddCeN3vojumGbRGAX+j9bQrUXtJJzAY/HrTrrQLM7l9OvmHfnzPgXjngIBS0xtFRUn5FwbuJnM8Eig7McWsW7xFbpu3JMYTN7e4JZI2lCofmtBbT1p/VCDQl7tRoeeweSlvcUYM5r5ZTA6JbCCjCKB9TA0oNKP8ph/0D9Mc49DefW4wzxbLYoRkT/J51DznhIiRca7GuHYznjY1YdHFrDHTKfJPOBSD7VxWgySSSX7Yn1GP1jnM51+NOHpXrQlHNfpA9nr32LjrFLAhlWCynALKs4fsAsbmsl7Koe0WORvEgDinDB/FNvVUb4NGJzE37b0ac3AiiTHEqQrkoeXPwXFLBaKMTS8jp1VIUOD6eLIxl8M8aYDekom4nJP6Ef3sMTLCj4NYjjs5xQQ94409UcXGSr6/4a5A0c6JXcDsXnFZhDySyEHTfKMsQmEn22vEepqF/wEscKJNYU0e+xHk0yNxwAj7/QnSYS6MGSkY4IZaxkfgBdp2VLQIrKiznK5w== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R6q5pwUfxO5o1XHLCxQiBFNvvzprpGVvZ+9mXw8IMbaGZcnhO2T4Da6aNIgA?= =?us-ascii?Q?9RtmVbLikSRgVAmYaNsnIGxCBqkdwfBUTTA/FilZHLEgSnud5KwqGQ+caVuT?= =?us-ascii?Q?Es9gQILGonMsYDTy92TQx4ClBrIg6G8jzkEGWDwnr6KXw5Fe99UpRavpVD7Y?= =?us-ascii?Q?yxE9DnUXIW7dNC7l4ElyRKafnOilKI/lccpzvuIlIGHGcpipA6u/sDllBQ23?= =?us-ascii?Q?9OuYJpxjdBIBtzd3R/0ccJRGovFL+5CDigXlK4dBgdZDNptXG3AvuHQw6NfV?= =?us-ascii?Q?y9y265tTgMeA3URUYcjJDdVkACRvwiiKQgqVgdfmSJ/0XfyCe4Iym9O2mtpV?= =?us-ascii?Q?/C/6ZFyArCWacy1MNP4NjSU3m/EFZ13P/YqFdL8ezleasFgupNQOh3OfqCuL?= =?us-ascii?Q?BkUW/1MrGYe2uAu/7sMrpPhQ/iP1aLAUW4ZX5Xu97q+H8fscsLWnWmGq0vKC?= =?us-ascii?Q?Bu6Ff1gX7jiAw8sbPqtFxvibCwkP824byyZkltfxclOND4NgqPpJyo8OYkRm?= =?us-ascii?Q?2xfKz7xiBxUZekw1Kkc1jgxIxf7YZH7iPOAt/wTIfES617PcZiVeHGs1+iMR?= =?us-ascii?Q?A6PO7RV1yKRc2T5QmEsq1bm/2etarZJHj80yiJW8WOKSAnT/IQKjE4BEduRt?= =?us-ascii?Q?kMI9+GiTScc4gHtBhLDR3Pn1Ln7K+LFLWKTtPH+S+uY+2z/nZ+HdGHQtMrne?= =?us-ascii?Q?deARR8HkRdzGxFw4iIJi0CHvb+sh8X72H9wfAL/2YaCxwJavSg1qpr9O2lXS?= =?us-ascii?Q?DZD3D3rMUqAcDIZzOMDh6mTLwYGEH4ifbIpaineuUNFeFhTTbFq6hQpEs9bc?= =?us-ascii?Q?J/2e3ecDEprmSRduBKWVMkUhW43mqkSHI88Wj6mgpODQ5WG35SffnDtzIR6l?= =?us-ascii?Q?fNfqWOfp2nl3Qps05ibCX5c6nj+GtB+QZzB0ZF4PvqMf8GVv1ylrEAye2pXp?= =?us-ascii?Q?KHQ+PTUR6EWVvHXujUwvon5SXDqmYrTvBw/9xYWY9qSrIT42Gxev2UfDvOeE?= =?us-ascii?Q?t8ZnCeVLmftVE47zAfeVk+P/rTWAtwVX9pAlzu9McIxLQWD15bozzV5PQKKJ?= =?us-ascii?Q?Uka4T/Ul53XhU+XDk5vBZ7m/bSNVTF6wtzliieo/7URFnkAgeKa2ztsnqJBV?= =?us-ascii?Q?t13UDerYCj2M/7zzlo4cI5l5SXHisdjO8yPIyrcwwQiVLQz16kvq0ow9xuCN?= =?us-ascii?Q?E5Mu2iHtExerXcJcKb1MlcSdrVsJLF4Mit64BCFJtHP4iVx4//oXHBD6p3VU?= =?us-ascii?Q?o1CRMxGp+yeiv1DivZYIWZlEjAGUNi5RzFelvQizLeYohLFuY1e5VwQppyWr?= =?us-ascii?Q?/FWEuIEfIo93yJCu5r63THjvraTLsLGsZEjXjfkh7eqykkEcDCGej+/ErSr3?= =?us-ascii?Q?8ag+qo/Mun1ICPrllfc9eWJcqgcuu72UPHPvjCjsG95yQVSK5Xoh50ZLes5M?= =?us-ascii?Q?U57etw+oBBFNCRBvsEG6nH/8585SP6qvvTU9y0VFqJifT3nD1yJ3q/zdE4dv?= =?us-ascii?Q?9bQvq4A2qWUuJ51yCOc045sYglTFsVjmewFCsltWhOAXpWBBS8n98emIKuX0?= =?us-ascii?Q?Z0wBmaE9XwBq4TSZQp9DG1btBIs9xpQXxMPKmNXWPRW8PqJfOeyoABDbHG8O?= =?us-ascii?Q?Jrd8sFXObdjonyBrVzShM5w=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49044e99-44db-49a8-3e83-08da85f0e620 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:51:32.7894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 41jdNrVw/36g13SyTEgjXPCKi8TR9N3ra4LR87e+89+0rouU5SKQOO1nJMiZZn6mD7S2bBOM/G5gmyN9+RRcE6zlICjoacqnuFcZVJVOfyw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR01MB7642 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: mZ4AF0YvvhVwRAlrtuR5Quj4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661359896; bh=8jeli2OE1TO3Eqlnn2S1kohB+qVPGcu9nEO2HJ7qrZ8=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=Bv+mpRmtwmyAQlqbjSK983bpFGiY4/OiNnBl0iNHBdmIvQ0RSf921Jy6aeGQAHO0UCA yvkPsoyW7I171HfU+PwFRvEviK1FGwmk3qyaZzTxpD3up3/oCXMmu76bRiuTO43vHMa+B 6OEOPSrb/YGF/b72NRoCb92W68kzkmmzMQI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661359898171100006 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen In some scenarios, the processor version may be updated dynamically from pre-UEFI firmware during booting. But the processor version is fixed with PCD (PcdProcessorVersion), so it can not be updated it dynamically. This patch will support setting that value both statically and dynamically. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Acked-by: Ard Biesheuvel Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/OemMiscLib.h | 2 ++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 8 +++++= ++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 47cb30d84a62..330bb4b014de 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -1,5 +1,6 @@ /** @file * +* Copyright (c) 2022, Ampere Computing LLC. All rights reserved. * Copyright (c) 2021, NUVIA Inc. All rights reserved. * Copyright (c) 2015, Hisilicon Limited. All rights reserved. * Copyright (c) 2015, Linaro Limited. All rights reserved. @@ -58,6 +59,7 @@ typedef enum { SkuNumberType03, ProcessorPartNumType04, ProcessorSerialNumType04, + ProcessorVersionType04, SmbiosHiiStringFieldMax } OEM_MISC_SMBIOS_HII_STRING_FIELD; =20 diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass= .c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c index 0b9af9bd7e1c..3b12e26abf6e 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c @@ -1,6 +1,7 @@ /** @file ProcessorSubClass.c =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved. Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved. Copyright (c) 2015, Linaro Limited. All rights reserved. @@ -512,7 +513,6 @@ AllocateType4AndSetProcessorInformationStrings ( PartNumber =3D STRING_TOKEN (STR_PROCESSOR_PART_NUMBER); =20 SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorManufacturer, ProcessorManu= ); - SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorVersion, ProcessorVersion); SET_HII_STRING_IF_PCD_NOT_EMPTY (PcdProcessorAssetTag, AssetTag); =20 if (StrLen ((CHAR16 *)FixedPcdGetPtr (PcdProcessorSerialNumber)) > 0) { @@ -527,6 +527,12 @@ AllocateType4AndSetProcessorInformationStrings ( OemUpdateSmbiosInfo (mHiiHandle, PartNumber, ProcessorPartNumType04); } =20 + if (StrLen ((CHAR16 *)FixedPcdGetPtr (PcdProcessorVersion)) > 0) { + HiiSetString (mHiiHandle, ProcessorVersion, (CHAR16 *)FixedPcdGetPtr (= PcdProcessorVersion), NULL); + } else { + OemUpdateSmbiosInfo (mHiiHandle, ProcessorVersion, ProcessorVersionTyp= e04); + } + // Processor Designation StringBufferSize =3D sizeof (CHAR16) * SMBIOS_STRING_MAX_LENGTH; ProcessorStr =3D AllocateZeroPool (StringBufferSize); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92767): https://edk2.groups.io/g/devel/message/92767 Mute This Topic: https://groups.io/mt/93231050/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Feb 10 05:26:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92768+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92768+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16613598984561013.8801565255819; Wed, 24 Aug 2022 09:51:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZQXNYY1788612xNNP2QcPvvK; Wed, 24 Aug 2022 09:51:38 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.107]) by mx.groups.io with SMTP id smtpd.web12.13326.1661359897314858680 for ; Wed, 24 Aug 2022 09:51:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVhSJCIbEkCXvrAvSyB+fA8FgjCG2KYx6xabl3UP6qqa0iVN8FLGjetp2cGV/jDeOZb/2gwB6ZTNHvXO3guTsPzhBYKg/hnsi9NsffKUQ+alM9BGayV14aKghpxNxEL7yjrK1LtNN1m4Isoq6/ay9OTVcHj1QE6T5kbCMzg1b8tYAmWhNXKUt95/IYqEjT5FJwnEx1uuB4+yFq9X67GwSd0uKlQ0rhR6By43k97cvoJbB0IjV+KE23osGcsNB5wQjSLKV0hm1iPooL8ZBVbxYWDlnQGyeyjeDDTeHumQ66WDZOkX/F5JwKkzbxSNjDCJu0IoOrk07GXi1zZrtr2Kig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=juGfD9WbN5Qm1b5g2/fefLIhY+j0TJsb7XIpryZ/GIA=; b=UA5Tm+gdM9YTT5e58LROajOJefJBO16fJ3hqa6qz081tMXTXxIYdMMt+fEC4F/dpoeZEILR38k0/nhAMRmWG9acolk6TohkeAd4g3KBwBKWe4zqeYKalMmLzIWnxkWlcy9uE9LTdTI63+5oyQIaq67QWxrt6w7IvqxAdZGzga2BFO6UrkeNMpRXPXbABbGBbIUzSyMtGWTVL+R+eWXISAzGj3yBefH/oUVtkbuslmMtyd1lvsZ56VHbOq+yYe67xkZbO/XZ4UfBlIP0aEv9fXT4OmaxBKYyNWE+zBMrluxjkY+9N/txEFJdor/D6R2SfRWVinADn7ljgQtYLujEHHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM4PR01MB7642.prod.exchangelabs.com (2603:10b6:8:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 16:51:35 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.024; Wed, 24 Aug 2022 16:51:35 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [PATCH v2 2/6] ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call Date: Wed, 24 Aug 2022 23:50:28 +0700 Message-Id: <20220824165032.1784305-3-nhi@os.amperecomputing.com> In-Reply-To: <20220824165032.1784305-1-nhi@os.amperecomputing.com> References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SGXP274CA0001.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: eaa9a284-a8f0-4498-e37a-08da85f0e7b7 X-MS-TrafficTypeDiagnostic: DM4PR01MB7642:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: nZncfF1EL2SrOxC+0vGM1yABeQdFrsmCdaW39ewZU45/W4aV3sF9qrpP+MmJ+Sjg6cvInpaSnljY2TzNMhoZR4ZwYzsaLleoH69dcfkZGi83pLKSuKlOtMN9gGq3973HlQH/xS9rXwkNKghh/vAZvR5G0SBAIx8vpbqnSTI8tP3JfqJ9xtvkqEyhDd6k4P5PlqOwnwHZeqvwAHSUo42+jMXmp7RvxBQXNF60usqMirxNHoH0xX8vdYptd48tbg7F/p2ZTa7/zXPHbtjpeSZZEIa4LNYqDhSeLsHCIs6AAI0XR+K4AAs3g7m+CMripgC634dRH5wuYgIgRe/vc0INcHlWsKIU+ZbZvSGBL4AZx7JiVByLroYnvELALPv8jyCXED2HFFWNW1CYSP5D7H8VeIY00n8oOW/yk1vpJhDS6t9B4tGAw7NkM1V9/0HM/OBDmX/iQlj6aqHkdyI4Ay37tjeoZ0+rrOsqYs3VuOCDKjtHmsvD2xObQSSIWNgrR+ouHqw9z5LxYPrw5yowK5M3cuzbTln1AqUW213ThV6fXUtnflg2jf/lSnGRmTDGX4OubZg5wdv+0S6ckrXTpK3mBZqJYtJyF+TtSMfeM4B5Bq+DXG5v3ZIoTcVoHciDqhp9XNTnDB07wRAdW1BXcHDraI2WvCdNHAzhKQa0IUvv5jPP8JF1nEaraZZBXBhADmUlmmjyT9KKj5kJYNuFpGm1w7vAyCx0xQaSy1t1Q8py0XUYeOlFMf1krT7WU8wIkCAlu8rT7PS7V2jJMOrDDq/iew== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IcxVvQ7KAyXbcdHUcQb22dfwyLNJxmnZkJkHklTc7negFPr5sL21LGuovjlT?= =?us-ascii?Q?aFcT3JNc/pb/wQkk24/w8GOhgHGPMxq2/aMgHV6WVBkappySSMRKUau5UYtm?= =?us-ascii?Q?REEmNMyvK+dsA2eo5Y2YLv1uGq7AW4FCt4HQjbg7n0Wk9xBv7uMpvIjfMzWE?= =?us-ascii?Q?VN++dv/NnREohzXWYU9gx0WHSOZHQVZl4FahgZL0SgxlCrK9Hr1t94aXWNai?= =?us-ascii?Q?ZwYV5P8if0XTEINnN/M4dD5eTMX+Fh3Jqa0wzCc4kKS3ysPycj5e53PmmLax?= =?us-ascii?Q?+FTipVqsx6uZJ9Qc9b+sjxLsl/EHe8zPH8iDDcibFZ5d+AQO0MM5YWVL2y+M?= =?us-ascii?Q?1YdodeSAvIfxqpUpoW1VjCpVJo3JCJI497FCeZ5+QZDopCRB4u+8qFzGOTYx?= =?us-ascii?Q?k6DR7v7yE3KAQkVf6Wit++/AkqR0vzIB7yWV9ojIpkI5rRDeq0+VmBBC/zuS?= =?us-ascii?Q?1ie+vYhIY9z8tMsJuXGTO+aJWHRWARZMJM3UAO4A4V5CuioSHGtwYzOdEX9d?= =?us-ascii?Q?+y+K/dZGilsnzSSsWQFeBfpKPWtZXM41RmpdhGBRS/xfp6OIO7vFUYGggRpW?= =?us-ascii?Q?kxKdN4ZL4cjdGOAnQLWESJVdenEg636U3pPMZNGr8HjeSib3415DDIfZecp2?= =?us-ascii?Q?ZDB6Xi1VeW9HUDLOORO48ptxm7s/ygScWjrZkkXIWhqgPanOlo0qwNNurNtR?= =?us-ascii?Q?9QLO1O3J+fDyq/JO5XdQNQwSRSKUgsGgAO8t0K8N14iYMR1k2lSLS+j5VmbD?= =?us-ascii?Q?GFVSIgTu7hua5OTywc8ErNTTD2L0uMxE3ttD6JbkI6sZuEeLweRn8WvW2O63?= =?us-ascii?Q?8BlxXGlQqbMGjuwmZpYbkJzpsT/spiPcUDgxnUz69pYyHyaBj7rXzgu+bpND?= =?us-ascii?Q?RqDEeiVkyMoUFQd4k9xeVkW5aibvm1+G03iSEy7NsVo5J+Cc0FtzRU+IXwOv?= =?us-ascii?Q?4zWiXEWNIR6l38BsiZ5YWhqqI39eQvqaM5kDZWMdMrcQiQgIzaS2SzdgIvPM?= =?us-ascii?Q?j4lQ0vOt5R9ChRjWPVXUuq1vjP8dIzvq5spwhC7oYDLi0lo7uvXVByjIPzuw?= =?us-ascii?Q?ZGTKFf912ba3/TVoVPjk80jLkFEdamWDB5+En1b40J/PuUveWVTQAEW+FqAg?= =?us-ascii?Q?ZOYT1lQ93YYEsgx0vvi7w+XUcbjufmfJpLduGmNZlhR3MgjXGSxJfKVunJOF?= =?us-ascii?Q?QlgHPc7uBg+RtPOvXFXiIh2uFRbrdNKFtkHxvtBxToTzy6ng7JsWAUWSfdeU?= =?us-ascii?Q?v4S19lY3uOvnjr8Zvx3PdruLVSOowLZWaHo55OspAXbEOg8Y6a6CbbEetBZ9?= =?us-ascii?Q?8VMMmAyLD+GIRcisclz50XVGaEGr/9ZTwz2crsqKmsYfh+iYpb+/ztlwORxn?= =?us-ascii?Q?QWvQuqjKAscEHHpSeNZJ/XXwNeLgdGGB4BRM9HHjSvaKv5t6zyJfbI+fRK6o?= =?us-ascii?Q?wmxWA5EuC4ebSi6zrVzl3M/xhqlxq6nt36iS4hC5FqKQpKKhJBVRs50EP/EP?= =?us-ascii?Q?l8y7yrPtBBdadSu3OuzfYP9JF9rFNiCsC31P0aZBPuy8XxveuBcnsnMmdkoj?= =?us-ascii?Q?uyTx4G1Hkq9wL5aMkiSY+EBxME8b38Tv9bqWD2EJmbma3ozXDERbcfjcX/lq?= =?us-ascii?Q?Za9WH55GkQN7rfHSdmTC7Og=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: eaa9a284-a8f0-4498-e37a-08da85f0e7b7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:51:35.4297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4w4a7kfx71xXXSsbIiNVlLg9+WNs6KHezwI1k/lora/1SwMwStgEd01cRi1B5DM1HVRjp1goMD/WK0kqFhFjA8ha0Rm1dsPaXvwPG2gSz8w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR01MB7642 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: Wwy3axTVYJ7JN8sNGqRtppuKx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661359898; bh=2h4wM/ydDoCitLmEfpA+18O2d7BkdFMZ4WD22PQxOcc=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=kCJmmhIUdRNT/IUBFSA/TnU2BcNp0IbU51pSv8OxBe59CwxKfFFVKZrDlNkd8rgZRXs krXIgmpMySFKOnxbMQ460JWpxeyEiWfAm4Mlbalanh1QSV7uXgYTXlHLdEuYVqitGQMlE pDoq3aQV7E3qg9EtyMOX+u48CqGXd7So8xk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661359900239100011 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen According to "SMC Calling Convention" specification, section 7.4, return value of Arm Architecture Calls is stored at first argument of SMC aguments (ARM_SMC_ARGS). This value can be negative values indicating error or positive values (including zero) indicating success. Positive value would contain information of respective Function ID (Section 7.3.4 and 7.4.4). For that reason, "SMCCC_VERSION" and "SMCCC_ARCH_FEATURES" Function ID calls read return value from "SmcCallStatus" variable (Args.Arg0 - first argument of SMC call). But "SMCCC_ARCH_SOC_ID" Function ID call is reading return value from "SmcParam" variable (Args.Arg1 - second argument of SMC call) so it leads to unexpected results of "Jep106Code" and "SocRevision". This patch is to correct it. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar Acked-by: Ard Biesheuvel --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon.c | = 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorAr= mCommon.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm= Common.c index e0010a40e489..b961be213358 100644 --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon= .c +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCommon= .c @@ -2,7 +2,7 @@ Functions for processor information common to ARM and AARCH64. =20 Copyright (c) 2021, NUVIA Inc. All rights reserved.
- Copyright (c) 2021, Ampere Computing LLC. All rights reserved.
+ Copyright (c) 2021 - 2022, Ampere Computing LLC. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -131,7 +131,7 @@ SmbiosGetSmcArm64SocId ( SmcCallStatus =3D ArmCallSmc1 (SMCCC_ARCH_SOC_ID, &SmcParam, NULL, NULL); =20 if (SmcCallStatus >=3D 0) { - *Jep106Code =3D (INT32)SmcParam; + *Jep106Code =3D SmcCallStatus; } else { Status =3D EFI_UNSUPPORTED; } @@ -140,7 +140,7 @@ SmbiosGetSmcArm64SocId ( SmcCallStatus =3D ArmCallSmc1 (SMCCC_ARCH_SOC_ID, &SmcParam, NULL, NULL); =20 if (SmcCallStatus >=3D 0) { - *SocRevision =3D (INT32)SmcParam; + *SocRevision =3D SmcCallStatus; } else { Status =3D EFI_UNSUPPORTED; } --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92768): https://edk2.groups.io/g/devel/message/92768 Mute This Topic: https://groups.io/mt/93231051/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Feb 10 05:26:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92769+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92769+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661359904061658.9741321042766; Wed, 24 Aug 2022 09:51:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id mVNCYY1788612x4Primahv2h; Wed, 24 Aug 2022 09:51:42 -0700 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.114]) by mx.groups.io with SMTP id smtpd.web09.13415.1661359901724199115 for ; Wed, 24 Aug 2022 09:51:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ho45WyLYtQb/v/pEZIKO3ATRGj06ASajaRKIVAx3j5QbSngqgNzYcNavicEePkGem8QKloodiYxbY7lN0RJNOflKXt36AdVm0RH/FrOmMFQg4USQkrYI6PKH0u7WF8qS3nc5NfD3Xs/wz4qTykIKVNagsYiiMVm19XWUDClf3z7Yfqy3o0byDEFGlGox+Av3gjdPDV4ngW3ouztAuWNkAFq8lv7V3ljsSvRsvjcZaq2alm8AGPDA6uyWTxCxlari74/L9EF1R3qEiCeXtlXGZTkC9hI8lWnFG+5aMn2BM3sLlQJ5wnlkVXLARIVuwI5bXcHKta3kfeUWC+5hiQet0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hYOBVGq4rfvQwXHThVCm7WokNhJAL211EyyetMcqx70=; b=fR/NuOfvFqybjhjCuYaeV7vY7ZMgFz1tPN2nZ9nHxzUk0Vi9fNzP6OkMug7l2vzikNWlj27D/yeByNF+4jjz5pf69OrAEilGG2vAzCBVYQNNupGGRT9Gp4wwtKWxhF153J6MxumQtS1xfb4lKmmvWT85vGkIY9cOT4a5xRrtQA6I0aSjSeO8SKInqoh3G4w+GYXnQMdVuIqzpg3+0YnYr46SiaqSqxgkcsce4RlRAK+GQI55cohlJwTe25huFRsBWpj3XOPXmz3WjOvGJaOJuusaoa+dMW19hX7CFUpacifd/bQoo/k7Rf2LAQ+NMs2JnfpbMz4xrcGuxGSGsRzneQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM5PR0102MB3381.prod.exchangelabs.com (2603:10b6:4:9f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.19; Wed, 24 Aug 2022 16:51:38 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.024; Wed, 24 Aug 2022 16:51:37 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Nhi Pham , Rebecca Cran Subject: [edk2-devel] [PATCH v2 3/6] ArmPkg/SmbiosMiscDxe: Support fetching System UUID Date: Wed, 24 Aug 2022 23:50:29 +0700 Message-Id: <20220824165032.1784305-4-nhi@os.amperecomputing.com> In-Reply-To: <20220824165032.1784305-1-nhi@os.amperecomputing.com> References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SGXP274CA0001.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 260c4308-445e-4580-2930-08da85f0e927 X-MS-TrafficTypeDiagnostic: DM5PR0102MB3381:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: cacqYmAnRezDck4w+LKM/DnkegvowMQ4AJVEDfSs/4N2wfLfLbQMK+kqkDmv//c35VcNfCc417Xk5r+P1fuDcsUgVMtk2LVNEnBvyTpy1zGblVMEtn6C/Y7NGiscS54kIbU35cU41SpTspXV13DP12WXlg0uor6+BrOt8KyzZXKwKi2rwMLvQi/Xq0X2WwGqJJbddOFsNYsU61MrpMyXW02mJS+tVAP9xeVrigGuZ2D8oJU9/HoC05I8KlsPYV/blsbIKTbWB5B4jAjdlhcXjQn342siieqFiESW9xTQ67cg17Rsw9hkHOTad915DtzDwObni7D9n0Qascsb+hD5pgNojvAytw+2iPNPU3NZtdqOVrXRMr4JQSdmLdtW68uhIlV+kSRRMQDbekr6CCCeLwJokYW41a2Q+I7h0jNpGg4ukcO/Hf/Cy0PJwESSRK6X1dFfY/sbW8sAJKkqSgFYvv4JBgHlfXvkjYbvz/rCxi8XJvzciW/0SRq+NaWjExvKC5gC07GSfTGN9K13gH8UjECqY2RiYxJEXPioh9qVSwOCVXIrR3a8i/R8hJ/f+YVFENNo0bIQqim3VdWsrQ305wYyO0z18/+09dCTSAznpm9XDay+nv1t7gseBDWoo90N3zVIC59dOXu7PHtuT1v4FT68Anb9FFEx0ajaaGg9HivOnEm3+VOao2s8q0dQlLxv4uMGQgwEBWKEwAbIXSZTc6TSbgyqTzlTGBM3apsesYiIVC0PxrlLTN6ZYfPW25/Dnfx0Ed8ycizPrEH9RQ/YfQ== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U1Kd0wpfoJDjDlfFOtjpZajK5BB+D9cmDtDi4nHGYrlg2bsOni0ATROGMwdN?= =?us-ascii?Q?SEs1PyZrslsGuGvEk7dvCXiM0eftEJNS3qSq3mCZIdLmO8uVPU6glmNP/Hkr?= =?us-ascii?Q?6DGYySg6jp7DCjWlLLbiwMtdYSW7BRgZZAqYsT1rOpTRv/ZjUW/LrfZmQ5N0?= =?us-ascii?Q?T5Xc9iFc4ieXmjjK+Y915yF8CNeDv7mWkX8B3mFBk3bW1XFFrLWq3IAybFs7?= =?us-ascii?Q?J3VsxQQNSuFOrx4HliG6yI9jCBCf9Gi0dMAH/p8G5AGzGt9DgKs60Lxm3lhS?= =?us-ascii?Q?zwoeTVOOHS3Ko1H5HzThZB76hyDaczNGSaEVQJfNHgRrCsu1dEGcz1D7Da1e?= =?us-ascii?Q?yzciLdJIXQuRXsPU+1GZAhjhr2JAeQu4yhjZ6M4Ah0+9EMkiQNbtXREAl9MB?= =?us-ascii?Q?fXYiQ0W0E9EDi4Vng83ENrumWlIpdf2JZ9lwplzulryr/VN/+U/eb+mvuRbi?= =?us-ascii?Q?Kstg2/owLTsrpzvGNq60REmXPeeUf+mC3PNWuAZlwMOnAH9rIApV6TdvcFhB?= =?us-ascii?Q?tKY/hn9XQIQe9uFaD1df28CIYsFGJukls8zbZ4ZSTkTx+8HeC1lH+X66anNy?= =?us-ascii?Q?jEP3He0i5wlY5FcJEXgPgrT9yuBIE4ep687Vst0skJUT12prIrjGPYHUzEqJ?= =?us-ascii?Q?EjUrKy9efUNCpdXAiwhAuIx+yhEH3isGOHuVqhFDIAyk1ZSEPlVf5SM6Aiq6?= =?us-ascii?Q?XK1/T1kgie1E+fG+UYSe2XpnSF1WTJRN+ydc0nPDWFRaHaIkWSfvMEOrgZ5Y?= =?us-ascii?Q?m8XCJCphJWFHCAWFNYZlk3P6TwW8D9AhoqVqrhQUpbPMVgnNq+vvIszmbtGC?= =?us-ascii?Q?64daTYkk/GGROvTWBV5SOUaNUHTnnNKGny3zwXITZEaLLKFp4ZjQ7r0vZP85?= =?us-ascii?Q?+X5fj450kq02r/8AngmsRNWyr8fL0X7GEABhAZSHmGo24LOlYHl3FMnvixNQ?= =?us-ascii?Q?zRpze8woOVq8lGAFR6fbXJteT+7HXJweRv9OfDuMWDgQGafXe6OeVe64Aby7?= =?us-ascii?Q?SW/747w56HpCbybfMALRAFqwqviBaWNRvBmuqXgFyuX0535wRk9N7e365Xga?= =?us-ascii?Q?YjYjeCrsvZ9NwcQxRLUH7ehP85ZChqOY1pcBo33T/6OflCxszKqBLiq2Iw1T?= =?us-ascii?Q?tWhCOFrS//BcOnm7H2f5rErGS4gy9PtnbZTERyESQwCQFKtmNX02OuwCQd6k?= =?us-ascii?Q?oTLxDKccLo75cWO+4euK6IVQQGlI/fVrZJ6uFnMqVZr1ryh4UtxmR8hnoi+M?= =?us-ascii?Q?Er+NfLOmAaBZOe45cCm1b3f2kWZB+g7BmDI0kxX3+NZxJMfagyy1bDvF/mA2?= =?us-ascii?Q?pFQSmL65RlGAQIyFlp+nnOy4ZyCQTHOlJbYhNZL3Qlnadmah0Nh9glaNiRRR?= =?us-ascii?Q?BJtYBPatl5GfyCQprx8wC+GO+k+hbgeQJ/8R6rQtxg6ZMWbqYaNtZJFgIBId?= =?us-ascii?Q?y6Vh+4BCutW1662dKrMjACgfRYfG4PqZ6wn2mmyRErJlfalO38WXjJzXHPg3?= =?us-ascii?Q?IQP4VM8M2yiBOy9UDjEEvMzUKywQeZ7W9B8162UNrbZOJQPbXLHINZwiiK74?= =?us-ascii?Q?tFIhPlN9++4eVKU1VTNckFQ59eDAAP6MPm7z0HsnbmyTsiduf3dhpBWEkbOu?= =?us-ascii?Q?DSXjXZViLMrk8labOFOALBE=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 260c4308-445e-4580-2930-08da85f0e927 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:51:37.8992 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nqVn+FA5T4qHo3PZUVEvqcT/ddeYYuKooewmVWhjZRvFG5Hmx0JNa7wE5QjNgr4TOQAftzvFMReqNnQ090csHSMMfDV+Oo9/zyxJ1OIyiQA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0102MB3381 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: k5k7hba4vGTesKcqLwMFliXtx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661359902; bh=13E69TE/gjdPx9aluJlzI87MjsZvEVT1bmm1Nb+C7WA=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=VC70hoYZQp7zxZseLGRE5yZdl68bhRc7M+qB12tfU71NIQpoMSOxTVCNYHjQkDzkkLF bm7zbayj7gThGmubFfPzQ2nuZCU2gZNV17h4B7LYQuFfXNays/QEdL3VcfltJOQivykqU FTbZUoplRGI4XuvEOKUirovC7BkG1McXYPg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661359906559100006 Content-Type: text/plain; charset="utf-8" This adds an API to OemMiscLib for fetching the system UUID according to the platform. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar Acked-by: Ard Biesheuvel --- ArmPkg/Include/Library/OemMiscLib.h = | 12 ++++++++++++ ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c = | 18 ++++++++++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunctio= n.c | 3 ++- 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 330bb4b014de..d87737db9c2b 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -235,4 +235,16 @@ OemGetChassisNumPowerCords ( VOID ); =20 +/** + Fetches the system UUID. + + @param[out] SystemUuid The pointer to the buffer to store the System= UUID. + +**/ +VOID +EFIAPI +OemGetSystemUuid ( + OUT GUID *SystemUuid + ); + #endif // OEM_MISC_LIB_H_ diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/U= niversal/Smbios/OemMiscLibNull/OemMiscLib.c index 98970407a65e..32f6d55c1a9a 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -1,6 +1,7 @@ /** @file * OemMiscLib.c * +* Copyright (c) 2022, Ampere Computing LLC. All rights reserved. * Copyright (c) 2021, NUVIA Inc. All rights reserved. * Copyright (c) 2018, Hisilicon Limited. All rights reserved. * Copyright (c) 2018, Linaro Limited. All rights reserved. @@ -10,6 +11,7 @@ **/ =20 #include +#include #include #include #include @@ -236,3 +238,19 @@ OemGetChassisNumPowerCords ( ASSERT (FALSE); return 1; } + +/** + Fetches the system UUID. + + @param[out] SystemUuid The pointer to the buffer to store the System= UUID. + +**/ +VOID +EFIAPI +OemGetSystemUuid ( + OUT GUID *SystemUuid + ) +{ + ASSERT (FALSE); + CopyGuid (SystemUuid, &gZeroGuid); +} diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufac= turerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemMa= nufacturerFunction.c index 5cf72644d0b2..22fb5eccaa63 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFu= nction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFu= nction.c @@ -4,6 +4,7 @@ =20 Based on files under Nt32Pkg/MiscSubClassPlatformDxe/ =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved.
@@ -160,7 +161,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscSystemManufacturer) { =20 SmbiosRecord->Hdr.Length =3D sizeof (SMBIOS_TABLE_TYPE1); =20 - CopyGuid (&SmbiosRecord->Uuid, &InputData->Uuid); + OemGetSystemUuid (&SmbiosRecord->Uuid); =20 OptionalStrStart =3D (CHAR8 *)(SmbiosRecord + 1); UnicodeStrToAsciiStrS (Manufacturer, OptionalStrStart, ManuStrLen + 1); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92769): https://edk2.groups.io/g/devel/message/92769 Mute This Topic: https://groups.io/mt/93231052/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Feb 10 05:26:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92770+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92770+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661359904574124.00527671752411; Wed, 24 Aug 2022 09:51:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id JYQSYY1788612xg9NwRZIx4d; Wed, 24 Aug 2022 09:51:44 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.121]) by mx.groups.io with SMTP id smtpd.web10.13339.1661359903165124450 for ; Wed, 24 Aug 2022 09:51:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QYsizrb+a2NA6rg0n56PxoOLNqTqd9vW4F2UHl7RjpDd/yiyCS1tRv/1Qd96IC3qYZNO+AjC/4WNKB7FpvopKgV5RkmukHAko3+FCFafdU6medraMoeeGvfA+F0hFpCkNr8pNmr3+cYx9Z3VCw9XBtjkuHQlxaxnwS13F38F017Y43Rfmslyw9aSDXLEMBaUnzSNjv1zArcNjfTWtfU2pgieeIAOal2ytsSXUak9kqrwBnJ/GyXUkhsZI0nuE0zu0VXB6T+XlmWVYLVK0jj1/ywKOTOUZYMbUzvQMkAX0AB6qoBZpyO+N4fSE2UDh6w0B9lpaeF58dxfPn8VVqdT1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+2Jq3kPd1eZpd1UPRciy6+sj92W4s9h2DQMLu0Gv0JA=; b=bNp6XLnbWJkIi7Jm32sylggnXW8fplozb0wue4w6qlxDEAfddMvvSj1erEOmSK/AHn2xdmuNUHNSP1gO6vGt0kqWr1CDwBLmOmNvBNi+lGQldfMqgFEdxkOzFhjwV+YpdOmExFpwg2xW9ybRLEfv30LRdQBC3K7+Ai671BcVPK8W8H+toyVLRKtH3WuRgNRVWGN2xCmBIsXudpHOsBl54nLNXXlFuIeqvF2sc/0BQPcLB0cIDvyvCvYC2+b+c7Jy2Vgi8cudvpIEACjBFp5qoQ/DUOzP9QMyGIB6pNEpj0McPN2BQapntnk85eHs+ymo2uYlX0IoIffMVZ97RC4wrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by BL1PR01MB7865.prod.exchangelabs.com (2603:10b6:208:39c::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.24; Wed, 24 Aug 2022 16:51:40 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.024; Wed, 24 Aug 2022 16:51:40 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [PATCH v2 4/6] ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02" Date: Wed, 24 Aug 2022 23:50:30 +0700 Message-Id: <20220824165032.1784305-5-nhi@os.amperecomputing.com> In-Reply-To: <20220824165032.1784305-1-nhi@os.amperecomputing.com> References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SGXP274CA0001.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55b7885b-a5da-4802-cedd-08da85f0eac3 X-MS-TrafficTypeDiagnostic: BL1PR01MB7865:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: UkaL855Km0faSusfAjCEACZ1+TqKVeF/6RKLcI9RRQXGd1eonqd67XyWo4yzpaBpSRIvG3VhGEeNL+RfHgmjlmcgUGw6Lr5QTLO3vYO5O3qfii51EexvKZSOK5+hkrcP/NpNfgS2zEWk6QVA4AuIHngy+X8NCMRVvwdUHIegRGPTEXesjY4CwfnFM19jpCnKIROGkgEVi14kh14NpJOLzUKSV2yDvJ07xLzVAm0E8bbg1ELpnTXLBt9bNdjofVn7ZxTBPPtA4oRpbdE8NZ3TyTaVpf6NFMjiMvuLED97zSK+PFwcBut8tOQiiYlG3PGecQfrzfV5GlMYR4aTJuNq2LzX9adJadIPLNmf4my62xXiufNEd73zTHCwYZa+FvzL5LL/fKF0qu3sfXhdfW56EemQiKc4xTypDfY/E4+PqGxz59rvlpZjXmk6tgf0sRqBNN0r2trmfniJsxoVFkSPEVxqLjqohNrz4ESWMgj3pp8hQmX8Uz4Dj1TfQmpz8CxnvdJVFTesWk6cWvm5dP2dASnY6bISjeaOk6E2JhQY/rqkII9AgMmp5IQWTtuH+GP9ZDZPgDH0ch5oEW7PnaDFnnflxWCJ6QJ9eV0nOPLfMrv8khPz4IEL/6OqmKdIaxBjHxesyMfjxeHkDigaoITDYkOl0K2UINhPQTMMZ/nqlD5tUp4D+fFOIABgJkktUHQ6yyp7dkfIuLcbQYl2N0N8clv+LqjAOvPD78advW5WP4HQMhOCp4Sc1OzyNGtAQMRNr+hZCL16RhvG3gLwRAuLFg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9EKRZQOzprxFezq2lege0cQrZ87FN4zsLaMSe0ip6FVn967Y1Ui/D+l9YsJD?= =?us-ascii?Q?1tuSow2+jif8qIeK7ax5j582voj7F8G64rTVPyH8vwkU2COwffK6UscBfhlZ?= =?us-ascii?Q?XLSLZJ5nYCZBjSCzqh3xGd7YhGYZXggD7IDqEnuhOAZc29vzzV3rXk+jxVkZ?= =?us-ascii?Q?PDafkZ56fzwjuPKYN3AOeIuGJ4nSy8MBZiS26jrh3g2i7A7HdGAEa8rdUklM?= =?us-ascii?Q?oAXWDbwBM5DgqULz/3Cw0c/lOXSsfYrPAVTyhVXCIRbKLPK/eEJ4+pSdH+IM?= =?us-ascii?Q?TkRfH4eDMeU7K++5YoEL70d6waCXG5U+ct8lLnoyX3xUIg/gWGNjLWtPnE/Z?= =?us-ascii?Q?PNNuoiSTXfT4ThR2p3z6Ep2lwYYj/BJMAdRox6qxgwDObSMI66IiPYgK9ktj?= =?us-ascii?Q?v/1796QYfnVuxlxmYWCMSD3hr4m//hhiUaXG0FcV0Q/12kfj4lX1bb6gdmd1?= =?us-ascii?Q?wSr3Sq72OoQYtjstZhN4nAufj/m6Kx6Coon6GfmwxpuCNyq//Z4SYMdc3WsM?= =?us-ascii?Q?1sFlvZyxBeMtydLt/f7KpLZVEQ2CJShR/Glxs2aGjFedM5AzFKQnFibn21Co?= =?us-ascii?Q?5XQRDhsImoV2gTkEPpzxflVmVkMJ3Pluwesn1JMkgrLCb6uo3IRRpxgsEdF2?= =?us-ascii?Q?bfklMnovqC2lsXZ+5Qg54PELbVcrdD37IKF0f6DEq9Amcqry2bwsLuv8grD8?= =?us-ascii?Q?2BfyJddjnoODbYlPMyMS5zMHJzwU0x4wmDUf0lPLcGdrpnquGuz2y9LloG1T?= =?us-ascii?Q?z5P28T/xEsvHigHC9xV8QBTTkqkRBt+B904wk5WKUJNT3Hv8DRm7h0I678Up?= =?us-ascii?Q?lJJPxZ/RMQPhVaG4DWto24S4BW+ICmx6bNydTKErW3rL+7AZbcAe6Casiztp?= =?us-ascii?Q?VUzUqIGk/tVqzoldgRV3vKyNov5fsMohGtho2moW1+0tVxaDReUCqAgY7hzb?= =?us-ascii?Q?SrrlOjQ/XnBz2GVTGU4J0QoTcWYolhm2vuQqhaxJlZE1fx0gh9IAH2nOD43x?= =?us-ascii?Q?a1QYhrBYTtijZY/oFzMKQslEdlnlbCW+WgkwYoAVc72Qev50wb2Y4cuVqZUn?= =?us-ascii?Q?XbldN8ShkiZ8SbuugkAyDwc4Pfk6+zXjTwZwwWxdgZq2xmhGXuev5ylEmdF9?= =?us-ascii?Q?jYD/dtNJw09P0MBT0EjgjZ12lGduFfKZV9/tOFXRJGqQN2TUADSvZ3u1OaUE?= =?us-ascii?Q?gOJrKjV2DA1RJUB+15PxNcahzwDzza2t439YLAqiDUyjotGHl0KDZd21N3iC?= =?us-ascii?Q?4W7JkeiMLigqxLomYgtGmEfcuWtBiNpPuTNBWX56Pp7fk1A+TpN7gSBe63lJ?= =?us-ascii?Q?DXMXPWQ6t6LDXZhCwhRGu0HxUywNAi2yhdvqZH7IAphAYKB06Wj1RMs3lGpC?= =?us-ascii?Q?AMB/9ROneVXpDmnzzgvCMEK0vpCa5dJbQdu4wNHNsD6eTc8OQ5Wd94eTaVWa?= =?us-ascii?Q?tI9Hsf0yihCsJpPk+74h04t7LFioDclegcdAa8NrFoIqyqiyaZJ0pmhH2NbW?= =?us-ascii?Q?2e1rsCM1atEJ5uft3NdyWmc0nur42buVpRU1Kb/cCf9y7O5F5A2v8V315YzQ?= =?us-ascii?Q?ljjI4eqVV9B8Tg1mjVvdMv7BMc+tpb7Q8v90kqDItmOF+nPPxWC+YIdOFFW3?= =?us-ascii?Q?O8y2AF/lktHP9DBqPZwMaVw=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55b7885b-a5da-4802-cedd-08da85f0eac3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:51:40.5723 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q26yfqrZrJPkkONH6//cFB+ea/gEVhC6H/sgb66XSt7HlDnBy1sc9lIMACsK8pGJ9kx2eU118214Lb4iaAdBhM3cSlOfdvLTnY7TII0TKXU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR01MB7865 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: uLd0Ost8L9AMOQzzGmeGy3aix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661359904; bh=TfAbvdKAfGOu8slnw9yxp5asnnYhYixdQYyyECGWe88=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=GgobfZQSI79tewPmmmv+kV5uwpKQlCxzll/a+OXGYj8uuGUUMHoTQXNVuDCvF++xlr1 51i1LZC2rz6AtUXgwItzY/yScbmZWwJUT7gWoqlfZxLU3ir+fApoo5voSED8+fbOJK07S TYM+PclZTZEE50I5+PdZnOhVrwOruzOWaS0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661359906536100005 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen This patch fixes typo from "AssertTagType02" to "AssetTagType02". Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar Acked-by: Ard Biesheuvel --- ArmPkg/Include/Library/OemMiscLib.h = | 2 +- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunc= tion.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index d87737db9c2b..1936619d9b5b 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -44,7 +44,7 @@ typedef enum { VersionType01, SkuNumberType01, FamilyType01, - AssertTagType02, + AssetTagType02, SerialNumberType02, BoardManufacturerType02, ProductNameType02, diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManu= facturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseB= oardManufacturerFunction.c index 870610b17243..f61546955f12 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c @@ -4,6 +4,7 @@ =20 Based on files under Nt32Pkg/MiscSubClassPlatformDxe/ =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2009 - 2011, Intel Corporation. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved.
@@ -112,7 +113,7 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer) { OemUpdateSmbiosInfo ( mSmbiosMiscHiiHandle, STRING_TOKEN (STR_MISC_BASE_BOARD_ASSET_TAG), - AssertTagType02 + AssetTagType02 ); OemUpdateSmbiosInfo ( mSmbiosMiscHiiHandle, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92770): https://edk2.groups.io/g/devel/message/92770 Mute This Topic: https://groups.io/mt/93231053/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Feb 10 05:26:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92771+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92771+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 166135990609253.14898469947593; Wed, 24 Aug 2022 09:51:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7yHPYY1788612xzgWzmRwOty; Wed, 24 Aug 2022 09:51:45 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.117]) by mx.groups.io with SMTP id smtpd.web08.13403.1661359905057486003 for ; Wed, 24 Aug 2022 09:51:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b0gwfaTL7gIqve9RBs334/2utAl/9q5BKYDF7BnvYMmGJ+L5RHNavJ6RD0bBpYff63kP0nH3D7qP7TsATFL6ryjwllv/CbcCCyopgnWEX3O1NmwSX3qYoymsb+5eutmtTuWOcJ7Yrbr31h8eJ4+tkjl4xE7u+dQPzYqmtXx//pcqxPiodYKc53//WWWQTvPPWhHBttAzy+c4hkqmpTrV11FC1uo/eOFa2z9UEOW7cv9p0APMBqkT5QBHctpNSQkbWLoFLlbCH78bQv1vLzh/Ek4qGQPCbt0Ck+DMBCLPsv42szl/dLtPkGOUhfO9bb8z3obLynlG0tcHcI+Nk4t2uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/gpksYfVIJxMzdqg+0olpsGQhlP63FVrl4oEKn0L6l4=; b=GBMZhHGlREBwg5Aye2XPQdUHfzgSwOhy/vZokAvAzOCOvvRJgzqLk1rHHagvGhYBbOwCS/+/0V8YWznAceoOcdzEmg8uncDUtHujIOzL7cbGeY246/ISPErgqdr58Ud+cDJRB6Aftez537QnYJPYFlyqYf8YNIaI8DT4LFCG7lqzH++p/FGHZ1vaALFMSzq7b76PoyRDhh3oBKVhiviPfzfC4PEkAHLqYFjeZcGpTUNcHNL1vKBGwVLgH4zLJF3cwAvng0UhQ9MLs2H+XKfnZUM4IiM4CuvV0RGRlBEuYn233vIbAvG0Oy+X1io96nxCIKlqWV/yWUv4mRhT5EeBrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM4PR01MB7642.prod.exchangelabs.com (2603:10b6:8:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 16:51:43 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.024; Wed, 24 Aug 2022 16:51:43 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [PATCH v2 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2 Date: Wed, 24 Aug 2022 23:50:31 +0700 Message-Id: <20220824165032.1784305-6-nhi@os.amperecomputing.com> In-Reply-To: <20220824165032.1784305-1-nhi@os.amperecomputing.com> References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SGXP274CA0001.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a3b5df3-abfe-47e7-472a-08da85f0ec57 X-MS-TrafficTypeDiagnostic: DM4PR01MB7642:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: pUvgUp/X7cc/nkoFbfm8vUgeeG9Kjv8iWl29i8Gi+S4Q4M2fzAsQVoZ67ONHiocNxWgloS33f/UmnCF3lxAG8w1FLgQbm+z315140fusXi2hQZowHYY6356ws4AxpGMlolKbVChfxC6Dit3BPOC/rg5bmdwl/Q2xeMjwQsSXywv3wrblJDwk/CYz6yR1U1d0mEIwmoMVPjZycDGDzNygcSu22DTRbQVezxA0/EcTMPh6DgqI0qULdJWVBAUQqAbiabO6RmAvkp739qA2NE1FajdM02JrATg70ktil84SOlhtiBwekmWuk2YqIn/F1A7Rkl7SeM3bmYl49OQb+c7yr9hBDO2j8kWp6YDv+nOazx7SefxhnFT+Obk/taeJUH3sMam6jC6rj7Yu1ZmaL3ehCWOePlOIvUQKW2Inephg1QgpOXxmshV1tM+gFtU/2tckvAQ7wW62mer/hD0EOTLNzxQycXrsUydOorO6EPQzGzWEmgQ91fIx6LECUtLJiIF/3bTSXpvyk8KGSdzeT0CvoAanZvu3Fnn9lZQBz38bKTg+u9rwY02kBJ/8KZ1dcJRqeJoFiFNCNCnhsD7U/qUWA1MzrnM7yA4mYXr02Q4WkETY7V3MWznXlaZYxFzF+elqtQC9WQ7pafFUF5H7myF6Xm2YgbWskfybcBcZnCmgXV8+xAPwSt+R4oyvkOpw0xZrvlxZBkkMFwIx0JPGUl1upidN1V9LnU3R3mmcUhT//gmqiK5lIMVo2tAg8ExrXc10lI/v/WHgWnNimTOcE8O36A== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tSNlmNGpReuSTH9zp2o/oTYx2EoQv1Gn7Lx6jIyTP3d6p4lPYtbRZNMjBhhQ?= =?us-ascii?Q?CxA33uaesNFDNvLiP3G5umZQag6MXT9hwMqnuBeDcT6QhNEu0kHBgQrc5n/X?= =?us-ascii?Q?E7ztzz8nmr5TBdgPqCFpCBvxWgC7eSUL7soKcgOXm3gnLKnSTpzj6omszhhW?= =?us-ascii?Q?DGXRfRPjvIXWG5IRNpO5NOh/CLj1g9A96uDiusqB4loA32o8geEn+8VN4yVU?= =?us-ascii?Q?vup7aKd11vQY3B1mAOhUk/w/Ysyeq5luBa/pEMoLB77iTVyhfVF7ITwrJtW4?= =?us-ascii?Q?XgQrVKdLyYLZbwQfK+D5jEyc7d+vJODUUwe7fNi6eFpzmee/fgoRJW4RZjxb?= =?us-ascii?Q?NO6XkujtUXEyQofLBZ4QgOSvQYwsUNStKcI8tFWz1MrwefZ9TvmJKo6REChK?= =?us-ascii?Q?FKLn73TUV6bVz5GT5kBzNn70xejjt3+KBI6WabZ4izpfNaKTpVHoE3reV3Rz?= =?us-ascii?Q?G3gRVaZ/ajrjDoB0tKGobaVmCy/+Y3v1WQkUUU1zM5YTUCxcotAHEREnMgY+?= =?us-ascii?Q?lPbo3i7Ehwyui3biFODN8W+0M1TAufdAyTwAo+1DKgtvviXu6w92Uuxoba3N?= =?us-ascii?Q?97VfLUP1CrxTWsGlkZVeJvpUNw9SssQxuNIq781a8vryqlbCS8qTxUfQjrRs?= =?us-ascii?Q?67LO5qt4czQ2U/TiBnCg1y8uncoBKXK+d8mnd4L9v6QQyQNxsXledCZX8Ga8?= =?us-ascii?Q?w0F85svhO/x7WR6Y2R6sJqavyy+ogIqWXmaP2YSOjmU+qNNpMYyD+tp+Jg8s?= =?us-ascii?Q?JuggGGuyHjjJmLfQAM4mqWkvrHmrA45lAeekiMKdfOUAEWpjoEqPS2lMdLxJ?= =?us-ascii?Q?jmygWwPrmlb6bp4qC9IR4qu2YAG6mxKd5DHVQJ/Fm3ng5bkqg+fIN4wDvl9o?= =?us-ascii?Q?QvogW9UirNibGbbKAsOfrJ27jDr0UEpNAmqvCffSStgs6+jL7picPny6jx1g?= =?us-ascii?Q?1qmbxIpANHxubYNtW4fFsIeRrx0h9Mx5JtvnvyR2UcrYv2TPJDikQcMsHjER?= =?us-ascii?Q?u+sdVzjjzfNfJE8VjlR4bsY8qbqd0ojtVuX2Ywt29Dj4G+1lNIid5R6rqI01?= =?us-ascii?Q?/PuU+IXgWfe5GC+Vnp8A9aSZzpP1rH6QtfNAlPOtm9+6XAjNrxWt3Ba/QGPP?= =?us-ascii?Q?nhk6MqIUiGxGd2Y1v4G/vAiIPRJXy5R/T1P+aPGldWp83ajDzpf2bufGl9yD?= =?us-ascii?Q?GRPldBxr6z1pUTOPVZwFKb2KVYm8cE9/Ogjl58aBFH6O8PdmBbUtBJPK1FZn?= =?us-ascii?Q?SMXckJLnZrtHj5R/MFNQcVVT0FpIUvd5PwI/oqsZDKVO2MBO7F8tnhf+cDaT?= =?us-ascii?Q?4oVrAs+7zSKR18XRcTJOvifmlIJov729S9asESZPane5ODSIanlAAZ6wMD/b?= =?us-ascii?Q?d6R9u0eTcZFvmlysY0etAbemLAdfQYEXYLnuRMFC5Gbqybv5kKmJkn2Px13q?= =?us-ascii?Q?ncuCUGri36ULxWm6Rmmjd70f9OG+QmJqrr5Gws5XRx9KxHJqdl4MSLKF5ZjX?= =?us-ascii?Q?3qW0QWiXzFT/CFzJQ56aFQhjR4VuPCQVq33zukRvg7WLcc9U9QQBZ5R1BHSf?= =?us-ascii?Q?4EAzryVH11Ft4KS4y5nQ+foov67N8iVjjpTUcIHiVbP5v0fK6y3uMvWHnmKR?= =?us-ascii?Q?S0lcNGHqgOra8VoYzLrdHbE=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a3b5df3-abfe-47e7-472a-08da85f0ec57 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:51:43.2321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dXqrreharg1/o9C2oKey+JgAXPySyxGBdWkk8DZEcueFJMhh+NgJA+PVOb+KwiVNlHqsLAw+4Yt3VTBZg7RXv7qS4bW3y0Z5LCBlvfp1ZCU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR01MB7642 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: hzSAFT2H8jGbkDY2mYWvsHR7x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661359905; bh=tO2wkbxXEi+qoWuFUkTKSNaldaW9DB9VCk5ocGCVT2w=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=UqQ6KWLKib+Cu2FEYt/Bh1Dq7g0rT1PnGj5r0z3oP7mqHWvpq31sYEaE7epqeHtPGsD z2dZAPRPk6l7uAQRZLV/OEqcVOk4zHJiqSo+cTXVq4Zi4eGU/p5Exzg+6b88CZOHupQjP pYQyJ97bQu6JpvcNL6svMidatKilIuuD0No= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661359908263100011 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen This patch removes redundant updates of "BoardManufacturerType02" and "SerialNumberType02". Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar Acked-by: Ard Biesheuvel --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunc= tion.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManu= facturerFunction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseB= oardManufacturerFunction.c index f61546955f12..3441e7798860 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacture= rFunction.c @@ -120,16 +120,6 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBaseBoardManufacturer)= { STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER), SerialNumberType02 ); - OemUpdateSmbiosInfo ( - mSmbiosMiscHiiHandle, - STRING_TOKEN (STR_MISC_BASE_BOARD_MANUFACTURER), - BoardManufacturerType02 - ); - OemUpdateSmbiosInfo ( - mSmbiosMiscHiiHandle, - STRING_TOKEN (STR_MISC_BASE_BOARD_SERIAL_NUMBER), - SerialNumberType02 - ); OemUpdateSmbiosInfo ( mSmbiosMiscHiiHandle, STRING_TOKEN (STR_MISC_BASE_BOARD_SKU_NUMBER), --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92771): https://edk2.groups.io/g/devel/message/92771 Mute This Topic: https://groups.io/mt/93231056/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Feb 10 05:26:19 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92772+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92772+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1661359908589628.2945641591651; Wed, 24 Aug 2022 09:51:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id A4SGYY1788612x75uOIElgQE; Wed, 24 Aug 2022 09:51:48 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.121]) by mx.groups.io with SMTP id smtpd.web12.13330.1661359907615871676 for ; Wed, 24 Aug 2022 09:51:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zkbi80xUzcsQb1yKdUEXcBTGpiUCg4AjjnmZDBoxzFMKA94YtXr8Yl9jA4qS+7TqXec+IGIVXUJ1fU6lmmaPYaFJNvpsEvYaKFZPWqPDZNojtDihpAYv4VhUqbVQqNTJ+nl22qt2e4z+6Ux0rSyL7oh4xnuQTk+DW5cr4/42qJkO0WpAWZhJ0awXhhZjEyHM/gB9x/8cUN70BehxntKtDNQpbZgL3wATRjl22YNXjHd+Q1JWALIjy8sdeC2Ytg5gkv18kr5K++KepqZV/gFIpgQhMpihiIV4a7/qP3MDZVDmFEg8lF8EDQVSdXQDaVuAvoqgkKWwt7w4OtmfXNCjug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+IztdDMjl4z0hhuwSpFyAecqzg9yDkjPFCjs5vrsJSo=; b=T1OZmTnyfbEBWvtqZBFQfa4U8TKfauuUABLKzBUtKYxZF7xIHNplhDRXT3fntNJav+C8+x+NXJ9uooJ6okuMjQPLwjf+V0WAjhmHy9cPHLeTPXDF8nH9uubHnteobN+4gAQdblxpD/bqU1GqMw6X+CIsqBQpb4+ptEWVsXtSGNUXBpAwscEsvvrkW/lD32a1krdKzblOwMzY2uwY8j6ceIkgFjANKmqz40MY4CrDtE6j+DQ9Q7PR7d2793EiD+PZi98hFQfyRuIAVkEF5PWOTzdXulQ9R6DkbrykndSf/lndinlUXG0pvJasiNnPScmW+fBgESYVwJUt7R5b3xyuKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM4PR01MB7642.prod.exchangelabs.com (2603:10b6:8:62::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Wed, 24 Aug 2022 16:51:46 +0000 X-Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::bceb:a82f:b3ef:53b9%5]) with mapi id 15.20.5546.024; Wed, 24 Aug 2022 16:51:46 +0000 From: "Nhi Pham via groups.io" To: devel@edk2.groups.io, quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, sami.mujawar@arm.com, quic_rcran@quicinc.com Cc: patches@amperecomputing.com, Minh Nguyen , Nhi Pham , Rebecca Cran Subject: [edk2-devel] [PATCH v2 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib Date: Wed, 24 Aug 2022 23:50:32 +0700 Message-Id: <20220824165032.1784305-7-nhi@os.amperecomputing.com> In-Reply-To: <20220824165032.1784305-1-nhi@os.amperecomputing.com> References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> X-ClientProxiedBy: SGXP274CA0001.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::13) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0db9076a-7e90-43ea-ec51-08da85f0edee X-MS-TrafficTypeDiagnostic: DM4PR01MB7642:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: ahN7o1QmBskEWAkMzwgJq9dwcoTk/clD7NHSRaUSQTBV437Cisi985MeRi745JM/eWkfUG5hfBseV74/2ka9PItjoCbuDaWLRopEaUvscB6cDbvCiP4B+Y55QEjngZg0ZwcZLMp9AdJZRMAh1v1pncbbcSnBz/H2qaSsS1ahxt2Dzy3nVgMAra44ogstunqMJoMCH1ZueuTHpB9LGbQHIoqCwFtLFJXL4KTDyorsriPZBOYIDdDzHg0/rPD3z7uSVN72fR/mVxvqrPdy1e/E2KXDVu7DncWjhcLI7XTZWzNv3aQ9XqyuuNvoq1P3KruiKk7KEtfGRcB4GgZr+d2Dn3ertic6HAaPXpNj84U6AO/lUd8rat/kBABawtW1B1bpUBdK4ClxiJTwjM0CL1/050bguxauxQpbL/8TDQ4E832ns89UOveS5O9dGb61b8iaOekN+kNdX8SuFuDtpT++vP/8rdSm9BUrEJd7e5tAb2UL6I9clWpokN2ETwiRz1JhriVGqqQE4qlgB9NpP+gizz11/JG912MQEMW0Xm1vz9++j/XkDH8b6sSPf3X/Tftj7dK1a7bR/WY73mnxjxDK0c4kUPDl+xc3/oV4XBITwvVJMgvgWiQX74QNzdAU1F0DCbczdLD8yfvAa//lzA+Lh14pT9/aN0pe3PhBFRkPhONNs4K9hunpW8193FjW9JAXgCgnT3Nyk3PLCwHWBJfBVq/H4ntvc8qkjnrejM9Hii5O/ouRRi10VZNBKOKIQIODMLgxpv0f4ok4gQWHFlo13bR8/XDveSGSmuwJOS9TBvg= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qngot25AqwdFiO3jYedjOW95ytjJX1Hj6uZmbrwMvqAgiHqW4Zl1RzJvySYy?= =?us-ascii?Q?/Ybx1ZyQgDAYg8Dta6S8z3kvMGAyHtH3qICfV8gE3F+9WMsqUfr7DDkmIqCC?= =?us-ascii?Q?jrTfYo60jI9KDN9B/asb0vHjJWusrNpaBWRScm/Wj7EEbg4XE1QZVsXQ3bWq?= =?us-ascii?Q?7zty4rCxKDD+2g74obxVejK+Z+QKdcYbyr+5Oj20CCJiVa4o5GcVuS5Sqn/Y?= =?us-ascii?Q?2PRIOJDLcSNP1CJjumhk+2L1Hl1mqDBwpZGG1y3WlQJ8SABT52/5xL2tBKQc?= =?us-ascii?Q?a34R1nEP7xFTFhlWFAyRViufetMD2LtAAK0N1K+248HTQ2EmeWAaoF7XFFfl?= =?us-ascii?Q?E8eTIXAlhUB0uHHFV0OqSc1syQ0ObXiM7DGQums5yUo3uyY7WidYwei7+oGv?= =?us-ascii?Q?xi9Qjn27ITcK3OCn6gUjgixfn29pTurdWMa1eMYPL3REJULkVoly098ZAXxP?= =?us-ascii?Q?6uCT1JY2x2vbARR7Bivjd5Geoc/v+la6luM7iZHIKWB+zzrx0OuQM4pgwqZN?= =?us-ascii?Q?oEuhFIzLqaVpPIXVDlPEw0c8WA9wfHkcgntD8Xr69lW6Vb39obL3RIaVAcw1?= =?us-ascii?Q?Mw3f8hJ5EeYpexhJQaDn/R6pdkJv+7PiP1pFrxfIftohAmA4bwqYpSWM1RBl?= =?us-ascii?Q?fOuGEm070pcOGeHtnwS9fWIpusrClA34Ad/6Ony9FGkixlRZskcsxOh+MuYW?= =?us-ascii?Q?PA2Bb2/T7gJ452T4yeyFTRqTj5fKkW1k0DdUFGsbfE8mhwX0Q5MknenDbwpv?= =?us-ascii?Q?969Qb0+kd0i09VSpTMCbxtZNcO7BjFwl5HIGMyBoNC/C3ZI2b1jlezMo+HR9?= =?us-ascii?Q?hKcHBN7qesh1LY/BKnMnCEsfvCRROcLwEmPx3XFWOoAlIhqVxR71XixyKkOX?= =?us-ascii?Q?HBvcX7PDRr6utNNDPkZ2f5xjb2P1vbOcLYQ2nJJeRpqsmkGBV/4piPihSOkJ?= =?us-ascii?Q?qhC/cOCZWVRVT6MZ7TIlrlBThEPE1Km07IEGUrHXF7tmkVFrUHYMOXX7N8yw?= =?us-ascii?Q?afRkRZ9H9jp0CBELoUNNT0FFNGM/hj/cKML3SupZurOogfj4SefKBp+AcoUZ?= =?us-ascii?Q?pSCi9X24nz3TL4LBBtJsTCB/5gwGXdNBnYrVNjB6xf7cWlBF0f1yF/fBf1XU?= =?us-ascii?Q?zzMCMJ4rusIEZ8imP0TeE9oItpAS5DSG64c6Hn6nVe8Z1Tuu8YBmUBqkT7xz?= =?us-ascii?Q?BP6EbBnTyA3XgjdTY042Yk6vcziRpYepoRpf7AcHfkRtP3YLHfSJ5cS/MX8z?= =?us-ascii?Q?c5r+WtQ1Ft+SvJZv0TQQysdG9kW9iAPM0bfdoylhpEKNdSDiupXS1+eL6l8W?= =?us-ascii?Q?S/JEQgNK0eYpjoVK5aJKZOkPpDDijJZW+Y3quKMkWp7+a3l34cwV5A7vll2h?= =?us-ascii?Q?JyZU56H80iK2kX989QLDCZRP7/V9TqyE/jBAzqerS80XY1cnDuvLqbt8B7N5?= =?us-ascii?Q?v7eK9xEvrdgrJX/GjHLugnEaIY+9gH/G3cUfqXNUD3jdAZqbH0nYKOkOBG1a?= =?us-ascii?Q?EuSfSS4SCHUsyjifCUoi2nhm3TmGMIKnaU/W5p3rSK4xAhzRD+NsjUwKBH8v?= =?us-ascii?Q?ZJyXd6y19OjP3Njq68FOqrmWs/I0F0KpLU6r09EGJoHKmd73i83qRaJkx8v7?= =?us-ascii?Q?YlEGjTsndwQzN6FeQOJ0NRA=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0db9076a-7e90-43ea-ec51-08da85f0edee X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 16:51:45.9349 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JmcOCpwo6qkqEfm8cJ3hmeJcevSD2uaQIbD21pcoSBB4LReHTuNP2BhsMFUfjf+mHWjtBMG6h+1PDh+jxEJXf4T2s6yhfS9naMf2mvU5Ge8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR01MB7642 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nhi@os.amperecomputing.com X-Gm-Message-State: BO3eznDaGhnJrM66VtBmUcnDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1661359908; bh=7OJTXrkceTHeS1qjxChGNUF0eg18NICnB+WykfMku2c=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=agP7RWM8Q6dhbSmLazlvmzoN4iTilgvupgHjTBAaLy8Zgi+qWXKjc/GneaQ646aGXx2 kB8GUOPOirnjgfPlv3VJvUbrp3MW1l6e6yHuIuY1IxVd4fsDihlhOk9mClTjq9nFI3SJe C9q3teQQ8XE3cBlgO7NIk8A8Tolr5gTiq34= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1661359910292100015 Content-Type: text/plain; charset="utf-8" From: Minh Nguyen In some scenarios, the information of Bios Version, Bios Release and Embedded Controller Firmware Release are fetched during UEFI booting. This patch supports updating those fields dynamically when the PCDs are empty. Signed-off-by: Nhi Pham Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar Acked-by: Ard Biesheuvel --- ArmPkg/Include/Library/OemMiscLib.h | 21= +++++++++++++ ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 28= +++++++++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 32= +++++++++++++------- 3 files changed, 70 insertions(+), 11 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/O= emMiscLib.h index 1936619d9b5b..541274999e5c 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -37,6 +37,7 @@ typedef struct { } OEM_MISC_PROCESSOR_DATA; =20 typedef enum { + BiosVersionType00, ProductNameType01, SerialNumType01, UuidType01, @@ -247,4 +248,24 @@ OemGetSystemUuid ( OUT GUID *SystemUuid ); =20 +/** Fetches the BIOS release. + + @return The BIOS release. +**/ +UINT16 +EFIAPI +OemGetBiosRelease ( + VOID + ); + +/** Fetches the embedded controller firmware release. + + @return The embedded controller firmware release. +**/ +UINT16 +EFIAPI +OemGetEmbeddedControllerFirmwareRelease ( + VOID + ); + #endif // OEM_MISC_LIB_H_ diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/U= niversal/Smbios/OemMiscLibNull/OemMiscLib.c index 32f6d55c1a9a..788ccab9e8c1 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -254,3 +254,31 @@ OemGetSystemUuid ( ASSERT (FALSE); CopyGuid (SystemUuid, &gZeroGuid); } + +/** Fetches the BIOS release. + + @return The BIOS release. +**/ +UINT16 +EFIAPI +OemGetBiosRelease ( + VOID + ) +{ + ASSERT (FALSE); + return 0xFFFF; +} + +/** Fetches the embedded controller firmware release. + + @return The embedded controller firmware release. +**/ +UINT16 +EFIAPI +OemGetEmbeddedControllerFirmwareRelease ( + VOID + ) +{ + ASSERT (FALSE); + return 0xFFFF; +} diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFun= ction.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFuncti= on.c index b49c4b754cab..e9106a8a2fec 100644 --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c @@ -1,5 +1,6 @@ /** @file =20 + Copyright (c) 2022, Ampere Computing LLC. All rights reserved.
Copyright (c) 2021, NUVIA Inc. All rights reserved.
Copyright (c) 2009, Intel Corporation. All rights reserved.
Copyright (c) 2015, Hisilicon Limited. All rights reserved.
@@ -13,6 +14,7 @@ #include #include #include +#include #include #include =20 @@ -191,11 +193,11 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) { TokenToUpdate =3D STRING_TOKEN (STR_MISC_BIOS_VERSION); HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); } else { - Version =3D (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString); - if (StrLen (Version) > 0) { - TokenToUpdate =3D STRING_TOKEN (STR_MISC_BIOS_VERSION); - HiiSetString (mSmbiosMiscHiiHandle, TokenToUpdate, Version, NULL); - } + OemUpdateSmbiosInfo ( + mSmbiosMiscHiiHandle, + STRING_TOKEN (STR_MISC_BIOS_VERSION), + BiosVersionType00 + ); } =20 Char16String =3D GetBiosReleaseDate (); @@ -251,13 +253,21 @@ SMBIOS_MISC_TABLE_FUNCTION (MiscBiosVendor) { } } =20 - SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(PcdGet16 (PcdSystemBios= Release) >> 8); - SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(PcdGet16 (PcdSystemBios= Release) & 0xFF); + if (PcdGet16 (PcdSystemBiosRelease) !=3D 0xFFFF) { + SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(PcdGet16 (PcdSystemBi= osRelease) >> 8); + SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(PcdGet16 (PcdSystemBi= osRelease) & 0xFF); + } else { + SmbiosRecord->SystemBiosMajorRelease =3D (UINT8)(OemGetBiosRelease () = >> 8); + SmbiosRecord->SystemBiosMinorRelease =3D (UINT8)(OemGetBiosRelease () = & 0xFF); + } =20 - SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16) - (PcdGet16 (PcdEmb= eddedControllerFirmwareRelease) >> 8); - SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16) - (PcdGet16 (PcdEmb= eddedControllerFirmwareRelease) & 0xFF); + if (PcdGet16 (PcdEmbeddedControllerFirmwareRelease) !=3D 0xFFFF) { + SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16)(PcdG= et16 (PcdEmbeddedControllerFirmwareRelease) >> 8); + SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16)(PcdG= et16 (PcdEmbeddedControllerFirmwareRelease) & 0xFF); + } else { + SmbiosRecord->EmbeddedControllerFirmwareMajorRelease =3D (UINT16)(OemG= etEmbeddedControllerFirmwareRelease () >> 8); + SmbiosRecord->EmbeddedControllerFirmwareMinorRelease =3D (UINT16)(OemG= etEmbeddedControllerFirmwareRelease () & 0xFF); + } =20 OptionalStrStart =3D (CHAR8 *)(SmbiosRecord + 1); UnicodeStrToAsciiStrS (Vendor, OptionalStrStart, VendorStrLen + 1); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92772): https://edk2.groups.io/g/devel/message/92772 Mute This Topic: https://groups.io/mt/93231059/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-