From nobody Tue Feb 10 11:14:27 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92483+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92483+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1660681726; cv=none; d=zohomail.com; s=zohoarc; b=ihC2Hjxg2og9IpEIT49t5WOtb25BgdPShnK96tTzQLS54/gDE2k0UO/VZXPhX18aRsyjt8e19P1RMNjR55TwA/93UaL8AFtyJXNvUYGmsDyLmjllBW/mhEm1UBJijWhliArKwXCpi3a5FXOnm4tMz7cQIKK1GDBMWuDtF0mI0OM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660681726; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=9v2OOoxwHVGQL5QfhiaQO0NlUm53QE4d+NpWehN+fY4=; b=WIOYC+zs8qpumwd2na7PKLQOlHpdXD8Le31/k6ij4ci3PmcnLv4xeoZu03LK5w44enMbS7oxm78p5SxeKv1wh7cGkaSL79GzgOVLoSHOK72bQ/5JFHf6uFsDBrGmTQJXXbNxZ10lkeQ7ISWc2XO2eOzPR5h7qvUXszOb91EPeck= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92483+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660681726940820.4352304073245; Tue, 16 Aug 2022 13:28:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id uwULYY1788612xcnZuCbypiC; Tue, 16 Aug 2022 13:28:46 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.20604.1660681724133774125 for ; Tue, 16 Aug 2022 13:28:44 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 326F01424; Tue, 16 Aug 2022 13:28:44 -0700 (PDT) X-Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9048B3F66F; Tue, 16 Aug 2022 13:28:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud , Sunny Wang Subject: [edk2-devel] [PATCH v3 2/3] OvmfPkg/VirtioGpuDxe: Check QueryMode arguments Date: Tue, 16 Aug 2022 15:28:36 -0500 Message-Id: <20220816202837.3257608-3-dimitrije.pavlov@arm.com> In-Reply-To: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> References: <20220816202837.3257608-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Dimitrije.Pavlov@arm.com X-Gm-Message-State: OgTTrQaSh1pKpqucDW5c8V54x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660681726; bh=MC2Z/3oU7nutkMS1ftLil0Vu4EuxClmmWY34TxOlgcE=; h=Cc:Date:From:Reply-To:Subject:To; b=uQAa0+ToIo6KHetkE07/yA0n2UEnyGhOH6jAEANz2B0X0WtiBrnp5FLdIqYrF2BaX6x pIe6WrDoJxUjQB1I8RCHS5Ed8s2MJ2zudp6IdR93+l6ydzsdgFHqJsNhX29GxAXekY5fJ M37JgdbA+mdmff5uZXoQsb7szeljt9tYOgc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660681728640100005 Content-Type: text/plain; charset="utf-8" The current implementation does not check if Info or SizeInfo pointers are NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/VirtioGpuDxe/Gop.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c index 401db47672ec..16e92830d411 100644 --- a/OvmfPkg/VirtioGpuDxe/Gop.c +++ b/OvmfPkg/VirtioGpuDxe/Gop.c @@ -308,7 +308,10 @@ GopQueryMode ( { EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *GopModeInfo; =20 - if (ModeNumber >=3D This->Mode->MaxMode) { + if ((Info =3D=3D NULL) || + (SizeOfInfo =3D=3D NULL) || + (ModeNumber >=3D This->Mode->MaxMode)) + { return EFI_INVALID_PARAMETER; } =20 --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92483): https://edk2.groups.io/g/devel/message/92483 Mute This Topic: https://groups.io/mt/93067594/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-