From nobody Sat May 4 17:02:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92453+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92453+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660602160; cv=none; d=zohomail.com; s=zohoarc; b=N3cqQYt70NQwtbPxiXjI/a0U2JclHmx7prhLPKyEEzT3grWA8wMK6bj/3VtxWAwnnFUV17vZllT+eJNDt19oJvHiV6IEZm+L0a4MMFwB1npJ93biSbgovDbGh6BeShJYn9kRzFGNjrjEnVcxBbs3Ezyn9Tah/Ze53f8XH3VQU3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660602160; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=PTtDAJcExrwBW/AuWZKL0xf9LqbhazZhKx34yEqxGBM=; b=RU6VYLBgAX3YudxjiIGOEPRUq7uV8PS87ubEW9ZlGDR7afiFGkxjk3XAd38TqRFlBFfRPOC1UxrcO+lnzWaDqvOms2vp72FxBX2+cRgzZZhR8LOir4DR/2IgAx5xNTmViV+nAYDclK5HQqVCaNSXBUUFAFnr26WNELyW/q9Qkqs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92453+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660602160940803.822443733208; Mon, 15 Aug 2022 15:22:40 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZbYSYY1788612xhT2izMUWng; Mon, 15 Aug 2022 15:22:40 -0700 X-Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mx.groups.io with SMTP id smtpd.web12.8379.1660599838165467800 for ; Mon, 15 Aug 2022 14:43:58 -0700 X-Received: by mail-lf1-f54.google.com with SMTP id u1so12333540lfq.4 for ; Mon, 15 Aug 2022 14:43:57 -0700 (PDT) X-Gm-Message-State: AgmXOXeppSPKPeGVq9YWj7Ucx1787277AA= X-Google-Smtp-Source: AA6agR7iXeOvNSF05zcnmKMFYUZMfvqTcctRWBe2XUpfZRz6yAkuUwIF2AH8VQsuUEzgLV5Ymuketg== X-Received: by 2002:a05:6512:239f:b0:491:cd95:f67d with SMTP id c31-20020a056512239f00b00491cd95f67dmr3476978lfv.184.1660599836337; Mon, 15 Aug 2022 14:43:56 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id s2-20020a056512202200b0048a82fec50esm1195266lfs.305.2022.08.15.14.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 14:43:56 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: Mike Maslenkin , Liming Gao , Dandan Bi Subject: [edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVol.c Date: Mon, 15 Aug 2022 21:41:37 +0000 Message-Id: <20220815214138.15318-2-mike.maslenkin@gmail.com> In-Reply-To: <20220815214138.15318-1-mike.maslenkin@gmail.com> References: <20220815214138.15318-1-mike.maslenkin@gmail.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660602160; bh=eryJ/yh6WcyxNJCvyLrC+zhWIten/dyOlnwdx64RKTE=; h=Cc:Date:From:Reply-To:Subject:To; b=O5ud3kJInXMje9fCQMciDunzgEsxC+DvAwVpOd4n9QaxXbT/ajRurjL4xODSuTi92m9 Y/aGIewFdAMFUbID5sXmLHynO9nG0XOXP9xg5AvJOHyPv+9iFn95Q0HND1VinDsvh+6qq z2UCaXETzWgLHVsJHctHucSbwl+tANDpBpE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660602163090100007 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" FwVolHeader must be deallocated on error path. Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Mike Maslenkin --- MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c b/MdeModulePkg/Core/Dxe/Fw= Vol/FwVol.c index 153bfecafa77..0c1554ba4d63 100644 --- a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c +++ b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c @@ -659,6 +659,7 @@ NotifyFwVolBlock ( // FvDevice =3D AllocateCopyPool (sizeof (FV_DEVICE), &mFvDevice); if (FvDevice =3D=3D NULL) { + CoreFreePool (FwVolHeader); return; } =20 --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92453): https://edk2.groups.io/g/devel/message/92453 Mute This Topic: https://groups.io/mt/93047944/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 17:02:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92454+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92454+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1660602161; cv=none; d=zohomail.com; s=zohoarc; b=We3eK6x9o/NakAapAZMV2lxIHUjEBAQU0kYx+SZ0Xc88NBsSO4zEf7bpjkmo+iA70Xu+7S6UWi7LugQEFwroPqjm+/iAm9qtJ4XOl39PH+SqnNyGMTG0R/KfWdsT+VH8bhtN1cmS9a1LV1VrRuCV9yZTN6ab1QQlPifvzS+rGNQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660602161; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=9W+6eIY168ymK/UBR1tBP+CZI6Mr4LFEl0Wg6yvZ+ec=; b=PQ1lOBQRWsiDCdqx/saS6CfskbWzpJsL5E+ST3NNIP4MnIiUo+ijgiDA9mcZzqSPUY316vqBOVcINDRUH76P41toUWqSHh2M2gWQ2fG+VHYEMZ1HjuoHFRYwLVdBAVKspAhUI6NEkhJxGyytQn6rS8Kj1+4Rmn2eHAXqqIa2alw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92454+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660602161645867.1841954870976; Mon, 15 Aug 2022 15:22:41 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id X8wYYY1788612xfkFwtn09wu; Mon, 15 Aug 2022 15:22:41 -0700 X-Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mx.groups.io with SMTP id smtpd.web12.8380.1660599838818390419 for ; Mon, 15 Aug 2022 14:43:59 -0700 X-Received: by mail-lj1-f182.google.com with SMTP id bx38so8844485ljb.10 for ; Mon, 15 Aug 2022 14:43:58 -0700 (PDT) X-Gm-Message-State: CBfI6JwNh0pbfzFJktA3F1ilx1787277AA= X-Google-Smtp-Source: AA6agR4H7UZIgbh2nmfWxwpH7yU5OVI7PdyHAnz7jbd+tnvf1z+FBwTh/CwhpzhahPikwD2m3bj5RQ== X-Received: by 2002:a2e:9109:0:b0:261:7a73:5f20 with SMTP id m9-20020a2e9109000000b002617a735f20mr4628601ljg.366.1660599837013; Mon, 15 Aug 2022 14:43:57 -0700 (PDT) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id s2-20020a056512202200b0048a82fec50esm1195266lfs.305.2022.08.15.14.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Aug 2022 14:43:56 -0700 (PDT) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: Mike Maslenkin , Liming Gao , Dandan Bi Subject: [edk2-devel] [PATCH 2/2] MdeModulePkg/Core/Dxe: Fix memory leak issue in FwVolBlock.c Date: Mon, 15 Aug 2022 21:41:38 +0000 Message-Id: <20220815214138.15318-3-mike.maslenkin@gmail.com> In-Reply-To: <20220815214138.15318-1-mike.maslenkin@gmail.com> References: <20220815214138.15318-1-mike.maslenkin@gmail.com> Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660602161; bh=GYr1Vm9LvIS330GerIqXqp1u67rQ3TVoqk8RjSQPAWA=; h=Cc:Date:From:Reply-To:Subject:To; b=K6K4XmPiAPrGsK8DwROcszaYvOXW8ijCSAmLrFLOT87+wSJ9pTmIC+rftdZSuEN4L34 uHsTH0RawUMCAlokjbBJGyZRP8RMOO6UOjnGOnEa6/jECAXfilVWbIWHWosS5hD+Ej3Pc F/kRtEd9r97a9Qq8SrcINhZpIaFWpurTJfQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660602163101100009 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" FvbDev->LbaCache must be freed on error path before deallocating FvbDev. Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Mike Maslenkin --- MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c b/MdeModulePkg/C= ore/Dxe/FwVolBlock/FwVolBlock.c index d81334ce24d1..9f5f40e5cd49 100644 --- a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c +++ b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c @@ -551,6 +551,7 @@ ProduceFVBProtocolOnBuffer ( // FvbDev->DevicePath =3D (EFI_DEVICE_PATH_PROTOCOL *)AllocateCopyPool (s= izeof (FV_MEMMAP_DEVICE_PATH), &mFvMemmapDevicePathTemplate); if (FvbDev->DevicePath =3D=3D NULL) { + FreePool (FvbDev->LbaCache); FreePool (FvbDev); return EFI_OUT_OF_RESOURCES; } @@ -563,6 +564,7 @@ ProduceFVBProtocolOnBuffer ( // FvbDev->DevicePath =3D (EFI_DEVICE_PATH_PROTOCOL *)AllocateCopyPool (s= izeof (FV_PIWG_DEVICE_PATH), &mFvPIWGDevicePathTemplate); if (FvbDev->DevicePath =3D=3D NULL) { + FreePool (FvbDev->LbaCache); FreePool (FvbDev); return EFI_OUT_OF_RESOURCES; } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92454): https://edk2.groups.io/g/devel/message/92454 Mute This Topic: https://groups.io/mt/93047945/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-