From nobody Mon Feb 9 10:11:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92440+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92440+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1660581105; cv=none; d=zohomail.com; s=zohoarc; b=cOzNdkpUWJk/E48fK/RiuZGKd3Ov1V34Yjtvg3ZOHLEf4iKzh6vCDD9Mfyve9wn0X3rx4FA69E4K3VPkgGDktfY2u3DwikhpIg1iHO3sP+2J082mpLH82BMiulQZn4D0ACA53aytJT37uR4OavZGBFIiTDLuSJTaSBhlKxgPfi4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660581105; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=R1auXUd7dk/XWm9cPPD1TeBx9I/gYfLtOVcX1r1NdMk=; b=AkpJXmrDHtz+59pbTiAX86leQeSUr+MP8MGoqWO1+5FS4ytt29Rxgzmy1f5lNLXmj+PlFIIFu5z0VUJ9f5kxRzpvMI9Hbeki6QjC6KrMZCLrVV8SRSgcTq7SkkgFb9qrpEZwklow7yihlhYfYiyzqaFI+lBi4tkPQQLpPZr7W8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92440+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660581105667927.9079887572735; Mon, 15 Aug 2022 09:31:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 20uiYY1788612x9vP9VFhmxB; Mon, 15 Aug 2022 09:31:45 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4447.1660581104463055022 for ; Mon, 15 Aug 2022 09:31:44 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B87801477; Mon, 15 Aug 2022 09:31:44 -0700 (PDT) X-Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC5263F70D; Mon, 15 Aug 2022 09:31:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud Subject: [edk2-devel] [PATCH v2 2/3] OvmfPkg/VirtioGpuDxe: Check QueryMode arguments Date: Mon, 15 Aug 2022 11:31:18 -0500 Message-Id: <20220815163119.2877228-3-dimitrije.pavlov@arm.com> In-Reply-To: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> References: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Dimitrije.Pavlov@arm.com X-Gm-Message-State: Jbe4wXN02QRh1DRuHrQxRzc4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660581105; bh=AWf1Qc43bOh4hNFYKdeyCAzOiTWHrsiZLxDrFoyKtzo=; h=Cc:Date:From:Reply-To:Subject:To; b=Js/DrNTrDRXmhdiAFCNZUYpcMZQRnRJXoviohNrTE95Ti6sTBdjT6o4qEIKS8wDemf8 MhRWI2hZKMNruKurrdp0o3CsdxI+Hm6HcEEfk+a5viJoyXQmfg+AnEmPFN1AOWAm7z7PY QVoWEgwdUUM7jsC4/kCRMndQ6vwDlEJzUxs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660581107415100005 Content-Type: text/plain; charset="utf-8" The current implementation does not check if Info or SizeInfo pointers are NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov --- OvmfPkg/VirtioGpuDxe/Gop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c index 401db47672ec..bb68b1cdc2bc 100644 --- a/OvmfPkg/VirtioGpuDxe/Gop.c +++ b/OvmfPkg/VirtioGpuDxe/Gop.c @@ -308,7 +308,9 @@ GopQueryMode ( { EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *GopModeInfo; =20 - if (ModeNumber >=3D This->Mode->MaxMode) { + if (Info =3D=3D NULL || + SizeOfInfo =3D=3D NULL || + ModeNumber >=3D This->Mode->MaxMode) { return EFI_INVALID_PARAMETER; } =20 --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92440): https://edk2.groups.io/g/devel/message/92440 Mute This Topic: https://groups.io/mt/93040547/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-