From nobody Fri May 3 09:03:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92442+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92442+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1660581106; cv=none; d=zohomail.com; s=zohoarc; b=bXfLVl2hfKhwYNNDjQrX4ijYDwTIjnRopCu+kHLVcQ47tEUrJjDU9ZKjnvIVr3jTwf8/S/4RlPav2SDcSV9xNKPZ3luGKrRgWe166EOSCN0msWzUKBH+vDbKuIYYjQNMO5ZJaTjJKdf8fVJgtD++dLjwImuYuTLItERyGF23czg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660581106; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=YI7O8gi3mcloS9EqFJBE4UgrMb15XqhY/3V57rSwt2Q=; b=ca++C1pkFzV/jhNCvOvr/q46Sw3PWZgm57FMbk7/xRu6Ook6s0DDRAO3z3+N4V1BTqqWyNL6KmT9LDkPoU5WIfMGXrpzNopztIZ3FJzfTC+ZipPrcEFn5Zgz+ryHQLeKiREBciPkfFD05mWsalEEM7WefEgjdQufRmvoxPmtoXs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92442+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660581106446371.8464414746669; Mon, 15 Aug 2022 09:31:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id vs6pYY1788612xZjT6ianv3M; Mon, 15 Aug 2022 09:31:46 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.4378.1660581104585934324 for ; Mon, 15 Aug 2022 09:31:44 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98D84113E; Mon, 15 Aug 2022 09:31:44 -0700 (PDT) X-Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ACCDD3F70D; Mon, 15 Aug 2022 09:31:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud Subject: [edk2-devel] [PATCH v2 1/3] OvmfPkg/PlatformDxe: Check ExtractConfig and RouteConfig arguments Date: Mon, 15 Aug 2022 11:31:17 -0500 Message-Id: <20220815163119.2877228-2-dimitrije.pavlov@arm.com> In-Reply-To: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> References: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Dimitrije.Pavlov@arm.com X-Gm-Message-State: JqbaW3GzY11m8OJAp6pjXcDpx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660581106; bh=bX59HKOXWdIHTTKocNfDRfaXX9Qn5HXYG1rGH3tL7Zc=; h=Cc:Date:From:Reply-To:Subject:To; b=X1DluharWn8Qp/+nZJXZ2LD5iP5HKVNvlyhl4Ulls3g3zwlEREWjwyKgwDgFvrQGdC9 CIZCJvB8Vj81S0zspt/TGWP3q30HZwX68VMKNC0YKE7sYt9VJ7c8U6MISubE+/VB0/J8e tDf7PwKtbAJz2vfFEN78FRHfWs5tTqD4bxc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660581107420100006 Content-Type: text/plain; charset="utf-8" The current implementation does not check if Progress or Results pointers in ExtractConfig are NULL, or if Progress pointer in RouteConfig is NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/PlatformDxe/Platform.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/OvmfPkg/PlatformDxe/Platform.c b/OvmfPkg/PlatformDxe/Platform.c index 4bf22712c78f..d7be2ab65efa 100644 --- a/OvmfPkg/PlatformDxe/Platform.c +++ b/OvmfPkg/PlatformDxe/Platform.c @@ -232,6 +232,10 @@ ExtractConfig ( =20 DEBUG ((DEBUG_VERBOSE, "%a: Request=3D\"%s\"\n", __FUNCTION__, Request)); =20 + if (Progress =3D=3D NULL || Results =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + Status =3D PlatformConfigToFormState (&MainFormState); if (EFI_ERROR (Status)) { *Progress =3D Request; @@ -340,6 +344,10 @@ RouteConfig ( Configuration )); =20 + if (Progress =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + // // the "read" step in RMW // --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92442): https://edk2.groups.io/g/devel/message/92442 Mute This Topic: https://groups.io/mt/93040549/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 09:03:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92440+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92440+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1660581105; cv=none; d=zohomail.com; s=zohoarc; b=cOzNdkpUWJk/E48fK/RiuZGKd3Ov1V34Yjtvg3ZOHLEf4iKzh6vCDD9Mfyve9wn0X3rx4FA69E4K3VPkgGDktfY2u3DwikhpIg1iHO3sP+2J082mpLH82BMiulQZn4D0ACA53aytJT37uR4OavZGBFIiTDLuSJTaSBhlKxgPfi4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660581105; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=R1auXUd7dk/XWm9cPPD1TeBx9I/gYfLtOVcX1r1NdMk=; b=AkpJXmrDHtz+59pbTiAX86leQeSUr+MP8MGoqWO1+5FS4ytt29Rxgzmy1f5lNLXmj+PlFIIFu5z0VUJ9f5kxRzpvMI9Hbeki6QjC6KrMZCLrVV8SRSgcTq7SkkgFb9qrpEZwklow7yihlhYfYiyzqaFI+lBi4tkPQQLpPZr7W8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92440+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660581105667927.9079887572735; Mon, 15 Aug 2022 09:31:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 20uiYY1788612x9vP9VFhmxB; Mon, 15 Aug 2022 09:31:45 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.4447.1660581104463055022 for ; Mon, 15 Aug 2022 09:31:44 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B87801477; Mon, 15 Aug 2022 09:31:44 -0700 (PDT) X-Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC5263F70D; Mon, 15 Aug 2022 09:31:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud Subject: [edk2-devel] [PATCH v2 2/3] OvmfPkg/VirtioGpuDxe: Check QueryMode arguments Date: Mon, 15 Aug 2022 11:31:18 -0500 Message-Id: <20220815163119.2877228-3-dimitrije.pavlov@arm.com> In-Reply-To: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> References: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Dimitrije.Pavlov@arm.com X-Gm-Message-State: Jbe4wXN02QRh1DRuHrQxRzc4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660581105; bh=AWf1Qc43bOh4hNFYKdeyCAzOiTWHrsiZLxDrFoyKtzo=; h=Cc:Date:From:Reply-To:Subject:To; b=Js/DrNTrDRXmhdiAFCNZUYpcMZQRnRJXoviohNrTE95Ti6sTBdjT6o4qEIKS8wDemf8 MhRWI2hZKMNruKurrdp0o3CsdxI+Hm6HcEEfk+a5viJoyXQmfg+AnEmPFN1AOWAm7z7PY QVoWEgwdUUM7jsC4/kCRMndQ6vwDlEJzUxs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660581107415100005 Content-Type: text/plain; charset="utf-8" The current implementation does not check if Info or SizeInfo pointers are NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/VirtioGpuDxe/Gop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/VirtioGpuDxe/Gop.c b/OvmfPkg/VirtioGpuDxe/Gop.c index 401db47672ec..bb68b1cdc2bc 100644 --- a/OvmfPkg/VirtioGpuDxe/Gop.c +++ b/OvmfPkg/VirtioGpuDxe/Gop.c @@ -308,7 +308,9 @@ GopQueryMode ( { EFI_GRAPHICS_OUTPUT_MODE_INFORMATION *GopModeInfo; =20 - if (ModeNumber >=3D This->Mode->MaxMode) { + if (Info =3D=3D NULL || + SizeOfInfo =3D=3D NULL || + ModeNumber >=3D This->Mode->MaxMode) { return EFI_INVALID_PARAMETER; } =20 --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92440): https://edk2.groups.io/g/devel/message/92440 Mute This Topic: https://groups.io/mt/93040547/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 3 09:03:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92441+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92441+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1660581106; cv=none; d=zohomail.com; s=zohoarc; b=RYvpR2XdILX9CCSpDtTkXoWQ/+2eqbI7doIODTAlS1+9s1Q6zTyVI95jaXxK5kofo+Q9TJrotCxr47CV2LY2R6jcKn1HJ4SpiEExVhZ7ce7X2PU+S9XeyzdR5etyKrPZIUQ9pBSEarHd48TrDvH/sTP6sHb4RPiDkMNfkDnGfZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660581106; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=x/slmXGMqqZ/X63w8c53LNo3nKDYg9z1EsCvCOm6Sv0=; b=P42WkndFriBCZEORQdbZ/umBndAArKblI2oxojHbNq0RBiyp8HWJ3qP7p6+1uBjrocgpccD2lEZ05Ghta3oFA0E/SCAVDm8bKObjLfzNY/tdCH4v4SP+h8YKYl6fIEcZMMjC5qBC2RDFVAxr3A9US002T/jSza/ob/3JwrU+MGM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92441+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660581106933888.5238788799321; Mon, 15 Aug 2022 09:31:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qvAoYY1788612xnFtVfSioBr; Mon, 15 Aug 2022 09:31:46 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.4507.1660581104525471732 for ; Mon, 15 Aug 2022 09:31:44 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D86521480; Mon, 15 Aug 2022 09:31:44 -0700 (PDT) X-Received: from mammon-apollo-f36.austin.arm.com (mammon-apollo-f36.austin.arm.com [10.118.12.61]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC0783F70D; Mon, 15 Aug 2022 09:31:43 -0700 (PDT) From: "Dimitrije Pavlov" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Liming Gao , Sunny Wang , Jeff Booher-Kaeding , Samer El-Haj-Mahmoud Subject: [edk2-devel] [PATCH v2 3/3] OvmfPkg/VirtioFsDxe: Check GetDriverName arguments Date: Mon, 15 Aug 2022 11:31:19 -0500 Message-Id: <20220815163119.2877228-4-dimitrije.pavlov@arm.com> In-Reply-To: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> References: <20220815163119.2877228-1-dimitrije.pavlov@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Dimitrije.Pavlov@arm.com X-Gm-Message-State: 9Mv3fdN9QVEwY8MEOpfK7L22x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660581106; bh=4RaRoP1H6S8xzsY9zj4Xp3jT4yTO1FVKpvJoPM+In0c=; h=Cc:Date:From:Reply-To:Subject:To; b=bYmplEuO2rILAZSRC0KDAwmpxJ9S4jioSkp6csQouz807fKYlYOchk7Qvaraox7hm5X T+oWTXgftd8qAg9Hse9OXKBsUtZasWT4b3UEi30bYIECgemfBu07RZ/MgQ+OcQMxa0ia7 9nlzwLzUmffebPDvBASmrf7Y/ShcO691vnQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660581107426100007 Content-Type: text/plain; charset="utf-8" The current implementation does not check if Language or DriverName are NULL. This causes the SCT test suite to crash. Add a check to return EFI_INVALID_PARAMETER if any of these pointers are NULL. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Liming Gao Cc: Sunny Wang Cc: Jeff Booher-Kaeding Cc: Samer El-Haj-Mahmoud Signed-off-by: Dimitrije Pavlov Reviewed-by: Sunny Wang --- OvmfPkg/VirtioFsDxe/DriverBinding.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/VirtioFsDxe/DriverBinding.c b/OvmfPkg/VirtioFsDxe/Driv= erBinding.c index 86eb9cf0ba51..3d80ff0f91f5 100644 --- a/OvmfPkg/VirtioFsDxe/DriverBinding.c +++ b/OvmfPkg/VirtioFsDxe/DriverBinding.c @@ -218,6 +218,10 @@ VirtioFsGetDriverName ( OUT CHAR16 **DriverName ) { + if (Language =3D=3D NULL || DriverName =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + if (AsciiStrCmp (Language, "en") !=3D 0) { return EFI_UNSUPPORTED; } --=20 2.37.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92441): https://edk2.groups.io/g/devel/message/92441 Mute This Topic: https://groups.io/mt/93040548/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-