From nobody Sat May 4 16:00:11 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92236+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1660027788131975.0594067104638; Mon, 8 Aug 2022 23:49:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id o5PPYY1788612xEEdOSrjlcU; Mon, 08 Aug 2022 23:49:47 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.80]) by mx.groups.io with SMTP id smtpd.web10.8910.1660027786620034739 for ; Mon, 08 Aug 2022 23:49:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l/SeUEOBlxNoHr3Sngi2vtChJZTTHidIFo8tU6q1BBnn9N6w1uU2jOY7IC9rbMxZq1Etvm0eroqzLfwqCn62QByfCjtc2X3mpaS9sUSIuEE7MYlGUfXeO6c30Zhdp/HwB6XUma4ZAqx6W14k+YTPH6MFdNykPV/D3x+9uFC8VuIUjJf3P4n3+fWVWbzjuMx0c86YHxphdLseIziaseHHPXx+9tY+Q6oKZxYQc3xzoy4fqi1khNi5LrZ+DaeQSlWVEcK2vOmme9MN/bmepkXIbVlbmxya+9AwNRF8jkNjNETyY+olqX4f5mKhbky1UGUPOxG1A8b3eIcxC2GRzIpBYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BUdVqzkOdIa285t0O45fCeHClXDj/4aCR1pYtWVeLJ4=; b=kBOXG0kZXvlJahC6PZSPL832pYtSyWvX+MJpfPT51qNbZPzEDH5WKDtwLQab1wReEI0o9kNRjoLD4S7SuN2k3ZW04kWaa+rO+ot/DkCi6i2MreH9LF4twKeGz2M+IQC1OklYYhnr6GDC6/mMdC8GLnKu+J43SUwvdw2EeCz3QCc4uwoEzEvLappfpvd97vTepOzH464Ax6Cj1OL4kVtNUxlEzNMlVZOKio/AkEH8mhVMuLRPayDEpr7CbKKBPSyHE9OsMPY9TmskchEGvNODNsXHw/pm2o1n/ODQxQm1sAtpyVKbaTBtZisbsB8tLVFEnzLHPkA1jbgEGdglEV1wGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none X-Received: from DS7PR03CA0013.namprd03.prod.outlook.com (2603:10b6:5:3b8::18) by MN0PR12MB6173.namprd12.prod.outlook.com (2603:10b6:208:3c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Tue, 9 Aug 2022 06:49:44 +0000 X-Received: from DM6NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b8:cafe::f2) by DS7PR03CA0013.outlook.office365.com (2603:10b6:5:3b8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.16 via Frontend Transport; Tue, 9 Aug 2022 06:49:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92236+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C X-Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT031.mail.protection.outlook.com (10.13.172.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5504.14 via Frontend Transport; Tue, 9 Aug 2022 06:49:43 +0000 X-Received: from SATLEXMB08.amd.com (10.181.40.132) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 9 Aug 2022 01:49:43 -0500 X-Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB08.amd.com (10.181.40.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 23:49:42 -0700 X-Received: from BLR-LAB-SFW01.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Tue, 9 Aug 2022 01:49:41 -0500 From: "Abdul Lateef Attar via groups.io" To: CC: Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH v1 1/1] ShellPkg: Adds Local APIC parser to AcpiView Date: Tue, 9 Aug 2022 12:19:10 +0530 Message-ID: <20220809064910.4350-2-abdattar@amd.com> In-Reply-To: <20220809064910.4350-1-abdattar@amd.com> References: <20220809064910.4350-1-abdattar@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d681b0c3-4fb2-4540-b60d-08da79d35779 X-MS-TrafficTypeDiagnostic: MN0PR12MB6173:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: i/RgNRoDjpDUEl5cPkSlZi6UJSlzHbsMf/l5v+0txF8ab2ktm2wwmwDMNRq3vTZfg3oKQ4/5R6Apc5yqYN3KkOUOru3KWGU87rAs/m18FI63+Go/COmUkHoeoo3RHsfuK4/B0TtTMB7T/hW/tmO2K3pOggZRQcjGSrJUfYl1G3sZ0AjvDxeW7bK6IRqphFmm7DMjE8/NrRXyOu/+FqUogZcXAqiDsJtvpCs/rl018gbAxkPHqI4ezVwpRPW7FxZOSWf0w8p/VfsfjGQ9MY/kKvdLfAX5bgDhPbCsU06mSZhgwd4kEXB5JKy4Qv4Cg1EImQd+BsMZMDiaLA5/Yccbpu5KKjyYs1nOm1ucEt4SoBIoewO4N1TrqdwGyKsTjDKs007yZcF4fg5PT0dhT5DDBIOJDYCzguSiNsIHvRYt7wCqIjllO2qSsJGh5lCNDkfb5Q43CTNMxCq4lDF/mT6773ap+dswLpbCVck86OJKhYu5UzBjBtp7OsIUX1SVauspqjsgTnRljuAwij62iZ2qFcbcRM0qcTKIuVLxlqdPZXVq3ydWn4ueRpEbcJyklKtS33fKU8A+ujNKPUMzcIfTIDAvD7CRAfiAATZbdIaly3w/2/lHatDjZDeLOa+ESzsh0Wrht/KnAna2YxtKUbznoH3pIOH4QlPXWwlrGafX8fQY4b/1Jc3OpXbrXrwpeL4KJBLkO1vY3KLnnn9pgjARUvaupKljIjFyEToLBgS+QFvzBX/8DjQTEqvICUwa59M0arrZWkka/mc1qQEAaHb1y1J0EAyUN6e5d5lMbvZCvionwiloiLP+Gnp4kPrUrx/cMVez0QT+mSw2HmtBEUiAjQ== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 06:49:43.8063 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d681b0c3-4fb2-4540-b60d-08da79d35779 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6173 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abdattar@amd.com X-Gm-Message-State: 4oIMw7sfwpoCAjWOmAuJ2pWqx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1660027787; bh=as6yYIFo2nNMwFOFUcyGgRIMDGSJqcUJ/eeENSzlXGA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=tBb00Gzr4goJpHsAKfAR+ifZgyDPlUdg//uT86sZBVXznq9lRu1nGJ68St4d5NSm+Vd 3pYmZHNR/3AbNoa4vBsWOI56wfBA1XB5e8MYGXbBNxJxneo6pWaWWxrBKq46MSJ0c4GyH Qemz6mIJUlFYF8VqQ5tUC98ZZghR4bO0TiY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1660027789245100005 Content-Type: text/plain; charset="utf-8" Parse Type 0 or Local APIC structure. Also parse the Local APIC Flags as bitfields. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Abdul Lateef Attar Reviewed-by: Zhichao Gao --- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 7= 4 ++++++++++++++++++-- 1 file changed, 67 insertions(+), 7 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/Madt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPa= rser.c index aaa68c99f514..41edcb9ffd1d 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c @@ -2,6 +2,7 @@ MADT table parser =20 Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. + Copyright (c) 2022, AMD Incorporated. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -206,17 +207,65 @@ STATIC CONST ACPI_PARSER InterruptSourceOverride[] = =3D { { L"Flags", 2, 8, L"0x%x", NULL, NULL, NULL, NULL } }; =20 +STATIC CONST ACPI_PARSER LocalApicFlags[] =3D { + { L"Enabled", 1, 0, L"%d", NULL, NULL, NULL, NULL }, + { L"Online Capable", 1, 1, L"%d", NULL, NULL, NULL, NULL }, + { L"Reserved", 30, 2, L"%d", NULL, NULL, NULL, NULL } +}; + +/** + This function traces Bit Flags fields. + If no format string is specified the Format must be NULL. + + @param [in] Format Optional format string for tracing the data. + @param [in] Ptr Pointer to the start of the buffer. +**/ +VOID +EFIAPI +DumpLocalApicBitFlags ( + IN CONST CHAR16 *Format OPTIONAL, + IN UINT8 *Ptr + ) +{ + if (Format !=3D NULL) { + Print (Format, *(UINT32 *)Ptr); + return; + } + + Print (L"0x%X\n", *(UINT32 *)Ptr); + ParseAcpiBitFields ( + TRUE, + 2, + NULL, + Ptr, + 4, + PARSER_PARAMS (LocalApicFlags) + ); +} + +/** + An ACPI_PARSER array describing the Processor Local APIC Structure. + **/ +STATIC CONST ACPI_PARSER ProcessorLocalApic[] =3D { + { L"Type", 1, 0, L"0x%x", NULL, NULL, NUL= L, NULL }, + { L"Length", 1, 1, L"%d", NULL, NULL, NUL= L, NULL }, + + { L"ACPI Processor UID", 1, 2, L"0x%x", NULL, NULL, NUL= L, NULL }, + { L"APIC ID", 1, 3, L"0x%x", NULL, NULL, NUL= L, NULL }, + { L"Flags", 4, 4, NULL, DumpLocalApicBitFlags, NULL, NUL= L, NULL } +}; + /** An ACPI_PARSER array describing the Processor Local x2APIC Structure. **/ STATIC CONST ACPI_PARSER ProcessorLocalX2Apic[] =3D { - { L"Type", 1, 0, L"0x%x", NULL, NULL, NULL, NULL }, - { L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL }, - { L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL }, + { L"Type", 1, 0, L"0x%x", NULL, NULL, NU= LL, NULL }, + { L"Length", 1, 1, L"%d", NULL, NULL, NU= LL, NULL }, + { L"Reserved", 2, 2, L"0x%x", NULL, NULL, NU= LL, NULL }, =20 - { L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL }, - { L"Flags", 4, 8, L"0x%x", NULL, NULL, NULL, NULL }, - { L"ACPI Processor UID", 4, 12, L"0x%x", NULL, NULL, NULL, NULL } + { L"X2APIC ID", 4, 4, L"0x%x", NULL, NULL, NU= LL, NULL }, + { L"Flags", 4, 8, NULL, DumpLocalApicBitFlags, NULL, NU= LL, NULL }, + { L"ACPI Processor UID", 4, 12, L"0x%x", NULL, NULL, NU= LL, NULL } }; =20 /** @@ -441,7 +490,18 @@ ParseAcpiMadt ( ); break; } - + case EFI_ACPI_6_3_PROCESSOR_LOCAL_APIC: + { + ParseAcpi ( + TRUE, + 2, + "PROCESSOR LOCAL APIC", + InterruptContollerPtr, + *MadtInterruptControllerLength, + PARSER_PARAMS (ProcessorLocalApic) + ); + break; + } case EFI_ACPI_6_3_PROCESSOR_LOCAL_X2APIC: { ParseAcpi ( --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92236): https://edk2.groups.io/g/devel/message/92236 Mute This Topic: https://groups.io/mt/92910245/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-