From nobody Fri Apr 19 23:30:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92054+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92054+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1659463488; cv=none; d=zohomail.com; s=zohoarc; b=TN/KmVBOyjWBEi+6071A5h1Y66EOh3T4ycL8TJcQlOacmbMLIAtnt1fSSY7NvUVAwZw6ZBdiB4j6kuLNv0LczlmxF3qnsCIlix+RbBAemvMh0VvRojJ0WJGCeZD8xNvpMiFIS2Xnbcf2KMhYOnRAtTcVcDK9Xdn0E0UgzNxK8Lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659463488; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Eu65O1REQsWLwVaWOBvDIltCZI8HxfLSrmbrIvqaiaw=; b=UbsyO6T8H7Ai/hBOPuTolv16hLBvch4rO4EU+D/1Mt1exmJpUZr8svnq0Ycx+/c0fkc0KMME9ToWybt6xAZVkfUSWWIJWa13QpGqZ/LZuQEVBQBjYWen+6VVRq8mya4tsHRKX5BSQWd0iD+z8OdxD1BiTtR1jBEZA1bXYMF/8U4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92054+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659463488779294.19844122020015; Tue, 2 Aug 2022 11:04:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id h18aYY1788612xNe1zOjXJsJ; Tue, 02 Aug 2022 11:04:48 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.9519.1659463487615594545 for ; Tue, 02 Aug 2022 11:04:47 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id E7F1B20FF4EF; Tue, 2 Aug 2022 11:04:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E7F1B20FF4EF From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH v1 1/5] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier Date: Tue, 2 Aug 2022 14:04:14 -0400 Message-Id: <20220802180418.880-2-mikuback@linux.microsoft.com> In-Reply-To: <20220802180418.880-1-mikuback@linux.microsoft.com> References: <20220802180418.880-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: B8takOkqtVMieV1khqPFrToUx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659463488; bh=6gPW9YQjU87RTTHRic8KvyqMT2r6wCHryYgIZ1TFciQ=; h=Cc:Date:From:Reply-To:Subject:To; b=lW5FamWxsUKTKYbrkSdny+6hClIX+bPzp4zU0aJRjurQ7uZwEV79P2aw9ShzcUYiqoz Ska8kRViSbPAMEF/peIBPh4c4tsXABw91V0PM5Yc7SKWuQqhja20xN0c9Fnis7ELb38mx PKyvjQVq2ntzhACmBhRMjst6s4dcsn5RB1s= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659463489411100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki These debug messages are repeated in both NorFlashBlockIoReadBlocks() and NorFlashBlockIoWriteBlocks(): "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%ld, BufferSize=3D0x%x" "bytes (%d kB), BufferPtr @ 0x%08x)\n" Although this requires 5 arguments, only 4 are provided. The kilobyte value was never given. This change removes that specifier so the 4 arguments match the 4 specifiers in the debug macro. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Michael Kubacki Reviewed-by: Ard Biesheuve; --- ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c b/ArmP= latformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c index 5afab0a79fa2..e671108e2bcf 100644 --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c @@ -54,7 +54,7 @@ NorFlashBlockIoReadBlocks ( Instance =3D INSTANCE_FROM_BLKIO_THIS (This); Media =3D This->Media; =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D%l= d, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, B= ufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoReadBlocks(MediaId=3D0x%x, Lba=3D%l= d, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSiz= eInBytes, Buffer)); =20 if (!Media) { Status =3D EFI_INVALID_PARAMETER; @@ -89,7 +89,7 @@ NorFlashBlockIoWriteBlocks ( =20 Instance =3D INSTANCE_FROM_BLKIO_THIS (This); =20 - DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%= ld, BufferSize=3D0x%x bytes (%d kB), BufferPtr @ 0x%08x)\n", MediaId, Lba, = BufferSizeInBytes, Buffer)); + DEBUG ((DEBUG_BLKIO, "NorFlashBlockIoWriteBlocks(MediaId=3D0x%x, Lba=3D%= ld, BufferSize=3D0x%x bytes, BufferPtr @ 0x%08x)\n", MediaId, Lba, BufferSi= zeInBytes, Buffer)); =20 if ( !This->Media->MediaPresent ) { Status =3D EFI_NO_MEDIA; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92054): https://edk2.groups.io/g/devel/message/92054 Mute This Topic: https://groups.io/mt/92776307/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 19 23:30:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92055+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92055+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1659463494; cv=none; d=zohomail.com; s=zohoarc; b=IfPWiylMWxwCCqdX9INz9Q9n6kWHZgiaI1A5T+Xv81HrmTJbgkWLG9+wZ0LfRfp4DDaNPXG7gUr78WQAvr1820NRz9RwCZXL4ij6Ek7wP4fgqDM+kAsLI31Zscv0ezCvw5asxakB26zT7fS4usLp7kbC8q7mVuvsvQFy2qk7DQQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659463494; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=mq8y4rT6kKbqrLZTtQhZE8FqwikSMxXzJP0yeISvY8M=; b=BZs+owExh5amqktDOi59+r+e3SqiLef98CC/pmc6M8st3y/fsW4skfxQQIGVTP/JYnb0PjccvhDgvQAksA894DzG62hCdTbgeS4As7j1XQzJUSCR+PYixfof88uDHlljD07rGXQuPXV6wmApNTxhskRsrK6CJvBpGP9eoRbt9CY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92055+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659463494194806.770840941175; Tue, 2 Aug 2022 11:04:54 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5SmsYY1788612xZjpnWdgm2d; Tue, 02 Aug 2022 11:04:53 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.9593.1659463493225633700 for ; Tue, 02 Aug 2022 11:04:53 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 7959D20FF4EA; Tue, 2 Aug 2022 11:04:52 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7959D20FF4EA From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ray Ni Subject: [edk2-devel] [PATCH v1 2/5] FatPkg/FatPei: Remove extraneous debug message argument Date: Tue, 2 Aug 2022 14:04:15 -0400 Message-Id: <20220802180418.880-3-mikuback@linux.microsoft.com> In-Reply-To: <20220802180418.880-1-mikuback@linux.microsoft.com> References: <20220802180418.880-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: TPy7mFGtLpbAVv52wcMA7MKBx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659463493; bh=RPdW868GdS1Vh/+/xjm5Z12S/pME2LlDTpno/hBLKN4=; h=Cc:Date:From:Reply-To:Subject:To; b=ZAujYPjbeoKKxsB83mRgaZBioWglS6/+bBiGrCU0eNxPEe2Yf1uRMWo0BVjzPWAnXkM oedOUp4TKpiNSAdTJ759xIkw4i/16I9vtzoW+WBIYH0hHjZl2SK9zfLsoPeARl5GR0EMH 0UJAQT9jFnJgnmEFWks2sjwBxEuNgAvJ9M8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659463495378100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki This debug macro should take one argument based on the number of print specifiers defined. However, two arguments are given. It looks like the code may have been refactored such that the second argument was moved to a new print and this argument was not removed. In any case, it should not be there now. Cc: Ray Ni Signed-off-by: Michael Kubacki --- FatPkg/FatPei/Gpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FatPkg/FatPei/Gpt.c b/FatPkg/FatPei/Gpt.c index 0a1a25ceeff1..9e17ce88086f 100644 --- a/FatPkg/FatPei/Gpt.c +++ b/FatPkg/FatPei/Gpt.c @@ -361,7 +361,7 @@ PartitionCheckGptEntryArray ( =20 PrivateData->BlockDeviceCount++; =20 - DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx", PartitionEntryBuffer[= Index].StartingLBA, BlockDevPtr->LastBlock)); + DEBUG ((DEBUG_INFO, "Find GPT Partition [0x%lx", PartitionEntryBuffer[= Index].StartingLBA)); DEBUG ((DEBUG_INFO, ", 0x%lx]\n", BlockDevPtr->LastBlock)); DEBUG ((DEBUG_INFO, " BlockSize %x\n", BlockDevPtr->BlockSize)= ); } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92055): https://edk2.groups.io/g/devel/message/92055 Mute This Topic: https://groups.io/mt/92776308/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 19 23:30:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92056+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92056+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1659463497; cv=none; d=zohomail.com; s=zohoarc; b=InQcjm32Pqy/RH8ZvkUTbTZZ+NtUQuM/e/lb6kwzespfNswSc8LD7C4qb9yphyyS85hD4oUemwyWPSHQea+24+fiEOMTJwGQOUtqUEV9ImpwT/v1k248gkcLIPGnfWASfu/U4JySz5/Cct5fXt/C9aMuvxscN9nmQK50q2AvkF4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659463497; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=vGFmFbomnnnnL4C1q67MBvLdAKkM3iGaB2yIb3wTVNA=; b=ko6/PqA0HL4hPMSHchud+LCtUBCJ7yeNDpIvqRnDO3MAVzvreeJdmzLQNaZQvYRBrAnv+ICQ7PRDjXDjYVFZTMpkFUY2jyqkYtGZOyYOEx7jrKF/30v5As5UAxGzA42A9VvoL0EjyNc6JhxLKhGaxLBRtpKmfQamzH7prKAiSYU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92056+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659463497134868.9994714302019; Tue, 2 Aug 2022 11:04:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ScojYY1788612xCaRIYZiAEr; Tue, 02 Aug 2022 11:04:56 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.9701.1659463496288972346 for ; Tue, 02 Aug 2022 11:04:56 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 25E1820FF4EA; Tue, 2 Aug 2022 11:04:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 25E1820FF4EA From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Dandan Bi , Guomin Jiang , Hao A Wu , Jian J Wang , Liming Gao , Ray Ni Subject: [edk2-devel] [PATCH v1 3/5] MdeModulePkg: Fix imbalanced debug macros Date: Tue, 2 Aug 2022 14:04:16 -0400 Message-Id: <20220802180418.880-4-mikuback@linux.microsoft.com> In-Reply-To: <20220802180418.880-1-mikuback@linux.microsoft.com> References: <20220802180418.880-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: vdsealMaLphzsRZ7fosHCawdx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659463496; bh=eezPO5ujakgJ4f4JjQyt6BiLCB2LfT6IoGbGSFJvPU0=; h=Cc:Date:From:Reply-To:Subject:To; b=Q8lpkPaSSDuTwWsT3a4jyrfrQ69Ytbyh0SKkMfqMVICFB8vddDsY35S4Ab6sIn689cl FBSRHqCYJSCipTwgMxTsVbdqAeMFHdeFvD3sO88fAkm+R/XSTa6Xpg7ea3sOVPsokz15m MBeo4nKNGl3wb6KHoFS3E8Q0txvlcmhuSh8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659463499412100007 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Updates debug macros in the package that have an imbalanced number of print specifiers to arguments. These changes try to preserve what was likely intended by the author. In cases information was missing due to the bug, the specifier may be removed since it was not previously accurately printing the expected value. Cc: Dandan Bi Cc: Guomin Jiang Cc: Hao A Wu Cc: Jian J Wang Cc: Liming Gao Cc: Liming Gao Cc: Ray Ni Signed-off-by: Michael Kubacki Reviewed-by: Hao A Wu Reviewed-by: Liming Gao --- MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c = | 2 +- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c = | 8 ++++---- MdeModulePkg/Core/Dxe/Image/Image.c = | 2 +- MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgres= sLibGraphics.c | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c b/MdeModulePk= g/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c index 53b63ab52b93..dd45167a009e 100644 --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c @@ -64,7 +64,7 @@ DumpCapabilityReg ( DEBUG ((DEBUG_INFO, " Driver Type D %a\n", Capability->DriverTypeD= ? "TRUE" : "FALSE")); DEBUG ((DEBUG_INFO, " Driver Type 4 %a\n", Capability->DriverType4= ? "TRUE" : "FALSE")); if (Capability->TimerCount =3D=3D 0) { - DEBUG ((DEBUG_INFO, " Retuning TimerCnt Disabled\n", 2 * (Capability= ->TimerCount - 1))); + DEBUG ((DEBUG_INFO, " Retuning TimerCnt Disabled\n")); } else { DEBUG ((DEBUG_INFO, " Retuning TimerCnt %dseconds\n", 2 * (Capabilit= y->TimerCount - 1))); } diff --git a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c b/MdeModulePkg/Bus/= Usb/UsbBusDxe/UsbEnumer.c index 5495b324b381..aed34596f469 100644 --- a/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c +++ b/MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c @@ -941,7 +941,7 @@ UsbEnumeratePort ( // which probably is caused by short circuit. It has to wait syste= m hardware // to perform recovery. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: Critical Over Current\n", Po= rt)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: Critical Over Current (port = %d)\n", Port)); return EFI_DEVICE_ERROR; } =20 @@ -951,7 +951,7 @@ UsbEnumeratePort ( // over current. As a result, all ports are nearly power-off, so // it's necessary to detach and enumerate all ports again. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 2.0 device Recovery Over Curre= nt\n", Port)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 2.0 device Recovery Over Curre= nt (port %d)\n", Port)); } =20 if (USB_BIT_IS_SET (PortState.PortChangeStatus, USB_PORT_STAT_C_ENABLE))= { @@ -961,7 +961,7 @@ UsbEnumeratePort ( // on 2.0 roothub does. When over-current has influence on 1.1 devic= e, the port // would be disabled, so it's also necessary to detach and enumerate= again. // - DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 1.1 device Recovery Over Curre= nt\n", Port)); + DEBUG ((DEBUG_ERROR, "UsbEnumeratePort: 1.1 device Recovery Over Curre= nt (port %d)\n", Port)); } =20 if (USB_BIT_IS_SET (PortState.PortChangeStatus, USB_PORT_STAT_C_CONNECTI= ON)) { @@ -969,7 +969,7 @@ UsbEnumeratePort ( // Case4: // Device connected or disconnected normally. // - DEBUG ((DEBUG_INFO, "UsbEnumeratePort: Device Connect/Disconnect Norma= lly\n", Port)); + DEBUG ((DEBUG_INFO, "UsbEnumeratePort: Device Connect/Disconnect Norma= lly (port %d)\n", Port)); } =20 // diff --git a/MdeModulePkg/Core/Dxe/Image/Image.c b/MdeModulePkg/Core/Dxe/Im= age/Image.c index 68bde5c15c52..06cc6744b8c6 100644 --- a/MdeModulePkg/Core/Dxe/Image/Image.c +++ b/MdeModulePkg/Core/Dxe/Image/Image.c @@ -1741,7 +1741,7 @@ CoreStartImage ( if ((Image->ExitDataSize !=3D 0) || (Image->ExitData !=3D NULL)) { DEBUG ((DEBUG_LOAD, "StartImage: ExitDataSize %d, ExitData %p", (UINT3= 2)Image->ExitDataSize, Image->ExitData)); if (Image->ExitData !=3D NULL) { - DEBUG ((DEBUG_LOAD, " (%hs)", Image->ExitData)); + DEBUG ((DEBUG_LOAD, " (%s)", Image->ExitData)); } =20 DEBUG ((DEBUG_LOAD, "\n")); diff --git a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayU= pdateProgressLibGraphics.c b/MdeModulePkg/Library/DisplayUpdateProgressLibG= raphics/DisplayUpdateProgressLibGraphics.c index 83053464e06e..6b012fed35db 100644 --- a/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdatePr= ogressLibGraphics.c +++ b/MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdatePr= ogressLibGraphics.c @@ -148,7 +148,7 @@ FindDim ( (VOID **)&BootLogo ); if ((BootLogo =3D=3D NULL) || (EFI_ERROR (Status))) { - DEBUG ((DEBUG_ERROR, "Failed to locate gEdkiiBootLogo2ProtocolGuid. N= o Progress bar support. \n", Status)); + DEBUG ((DEBUG_ERROR, "Failed to locate gEdkiiBootLogo2ProtocolGuid Sta= tus =3D %r. No Progress bar support. \n", Status)); return; } =20 --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92056): https://edk2.groups.io/g/devel/message/92056 Mute This Topic: https://groups.io/mt/92776309/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 19 23:30:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92057+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92057+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1659463499; cv=none; d=zohomail.com; s=zohoarc; b=iktvvCNzAQ1LheOfi/eVLWM7shJ1JdUWXDDROIr/tBrnaFzB5mi440uoSQDJpenykhUdh4W3PJxqdGg7eUvdxIFW2tofu6CeJ7g9hRI12S6x818Xdbns+FXVqjR81iKC9aypOsfOMWPZ4Kt2oTRwKaaFSIOKeymPHDq4XCqLRF4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659463499; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=wYLDkeaZhqIcNcpQcdUk91Carq20I9U1DYx4nJ7WRNw=; b=b1OjjA1TexLvNRQ/f4Uc2rlaOMjoC3nFA2FCUo/5XENNMMQmn2d30Uy2Lje1ZR2f9Xm7uMza2dK7h7/EAWwHd6+vF6p6qpMI2vQpRbZ1RL3aHrtnPcqP3uFk3PlFZa21gDpwjiNg86QqA/jHCjmoDDnBTe0zpFjpKcsdNEY8V8g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92057+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659463499739544.4038582236446; Tue, 2 Aug 2022 11:04:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7ZrNYY1788612xxM1WzaBysm; Tue, 02 Aug 2022 11:04:59 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.9594.1659463498746878535 for ; Tue, 02 Aug 2022 11:04:58 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 0D3F420FF4EF; Tue, 2 Aug 2022 11:04:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 0D3F420FF4EF From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Abner Chang , Nickle Wang Subject: [edk2-devel] [PATCH v1 4/5] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument Date: Tue, 2 Aug 2022 14:04:17 -0400 Message-Id: <20220802180418.880-5-mikuback@linux.microsoft.com> In-Reply-To: <20220802180418.880-1-mikuback@linux.microsoft.com> References: <20220802180418.880-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: mSINbb32tzBvf2enIHw1MfTDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659463499; bh=2GIsLny/IJVr/kprogdyTSRRu3IX6LqfausHrTJfDW4=; h=Cc:Date:From:Reply-To:Subject:To; b=vS8XcydNlLRZxu0gsVcttwnIoSKVConDcn7ZFKrah9PrDyfHAKRx9988qr1LxH1DcrE 6HhQoyqaADDU5M2KsuTnA3pc72LwzUYK1oRFKH80eVpmAP/MSyQ+0fqHFnUjUgykKL09e pf9EiKA3yVSyVPJyZHVPeoOir4L7D6t5lsc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659463501440100009 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The debug macro argument in this change is removed since it does have a corresponding print specifier in the debug message string. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Michael Kubacki Reviewed-by: Abner Chang --- RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c b/RedfishP= kg/RedfishRestExDxe/RedfishRestExProtocol.c index f224104ad673..4b61fc01adc4 100644 --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c @@ -224,7 +224,7 @@ ReSendRequest:; DEBUG ((DEBUG_INFO, "HTTP_STATUS_200_OK\n")); =20 if (SendChunkProcess =3D=3D HttpIoSendChunkHeaderZeroContent) { - DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunk= s.", ResponseData->Response.StatusCode)); + DEBUG ((DEBUG_INFO, "This is chunk transfer, start to send all chunk= s.")); SendChunkProcess++; goto ReSendRequest; } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92057): https://edk2.groups.io/g/devel/message/92057 Mute This Topic: https://groups.io/mt/92776310/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri Apr 19 23:30:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92058+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92058+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1659463503; cv=none; d=zohomail.com; s=zohoarc; b=FC1nAepQ03iia/eHWk7E/7YhdglqdjkTnklvK5O+JsQU80Ja2umym+oIVnSSqDOBYmMdIMiXqRMLBXKPgaTJto1SR1mvzthdWgdCHbrvsOAE/gBPtyoxfalx3kF8ZIsOta0LSLx8CMkTC1ccLHtkFhlF3oBeu1TLLH1/lPyVynE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659463503; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=IDt2O5/aI7i0ZTge6dsbsmpjH5eBoGdaApvnHdScYLU=; b=KQSl74EHA74wp9UEAWuPOS+txJZwbborwHtSxuJ9bWvelyavPJfoUOeHDUNf0Lod67T7TLuZqOmMHizajJD6i3V6tht4ToRT7RnFOzAwOtmlB10wFU1GdWxBhbMAriD19LxyQLb5LARL7Dw/4wcjcVPrQGKK8hZ3nXxeaWXlHkw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92058+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659463503767829.164935248563; Tue, 2 Aug 2022 11:05:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id q2ZuYY1788612xYkzOtktAMg; Tue, 02 Aug 2022 11:05:03 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.9701.1659463502521789244 for ; Tue, 02 Aug 2022 11:05:02 -0700 X-Received: from localhost.localdomain (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 7A1F120FF4EA; Tue, 2 Aug 2022 11:05:01 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7A1F120FF4EA From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar Subject: [edk2-devel] [PATCH v1 5/5] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Date: Tue, 2 Aug 2022 14:04:18 -0400 Message-Id: <20220802180418.880-6-mikuback@linux.microsoft.com> In-Reply-To: <20220802180418.880-1-mikuback@linux.microsoft.com> References: <20220802180418.880-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: ItjnTILPtNe09p9rPBtjLb2Jx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659463503; bh=ZbXMI+GC0vehDdlC6dLvYtH+Q8PfcClQ7xrnx6Ktf+E=; h=Cc:Date:From:Reply-To:Subject:To; b=tmfoQB13kdRWMCsvShzdyL4BRJsNpMwtXWmuOqfrDol5UwbY8jvauvxbH1hCubAyPw2 cedh25empGmLikLKR5Gi2iey1Gcq6HSh8B7vDEeYJbFG4FcKeLwRA4IAF1fyMrKxAInIb RlHe95l3+I4+4OqNA4uOHtJrRAOuPSx0ZCs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659463505460100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The debug macro modified in this change was missing a print specifier for a debug message argument given. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Michael Kubacki Reviewed-by: Jiewen Yao --- SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLibCo= mmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalP= resenceLibCommon.c b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2P= hysicalPresenceLibCommon.c index 1fbfc00547cd..f2ab4f125007 100644 --- a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresence= LibCommon.c +++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresence= LibCommon.c @@ -176,7 +176,7 @@ Tcg2PhysicalPresenceLibSubmitRequestToPreOSFunctionEx ( // Sync PPRQ/PPRM from PP Variable if PP submission fails // if (ReturnCode !=3D TCG_PP_SUBMIT_REQUEST_TO_PREOS_SUCCESS) { - DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync PPRQ/PPRM= with PP variable.\n", Status)); + DEBUG ((DEBUG_ERROR, "[TPM2] Submit PP Request failure! Sync PPRQ/PPRM= with PP variable. Status =3D %r\n", Status)); DataSize =3D sizeof (EFI_TCG2_PHYSICAL_PRESENCE); ZeroMem (&PpData, DataSize); Status =3D mTcg2PpSmmVariable->SmmGetVariable ( --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92058): https://edk2.groups.io/g/devel/message/92058 Mute This Topic: https://groups.io/mt/92776313/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-