From nobody Thu Apr 25 16:20:12 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92042+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92042+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659422195631172.5024161080131; Mon, 1 Aug 2022 23:36:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id B96lYY1788612xLDUqtFBVqT; Mon, 01 Aug 2022 23:36:35 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.41]) by mx.groups.io with SMTP id smtpd.web10.3203.1659422192943743426 for ; Mon, 01 Aug 2022 23:36:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M5RX1G0Xka5XVfETC+qm8SCfgPtXbA9NJlb8vTYzjgwU81spq3WxKDsQd2M4zK5cTVkjjb9qU3bx6SZMAh107/+sVQCMZdjt/M0BtCebH5tWCBsHd6C5g0v2h56H3Yst11jpdYGwLc0OX2MEh8vklfLeVkC+O/U4FXegIiPO06kaSXoCfAhtIGLGzaV2E4qhiKSEOHqE37hWAAgcUFOHdt5p6PX5Ep781rFDPZCf8p9RYk0KSGcBC20D9J4dMsho9AoJry57lT38XB+hEvQ4NQExCiIR2zwliYlDWx0GSBkg/Rm1+4qpydDUZtEEj92GthqHxudQhZHEb23Y4rSQGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x+SWklLVfgcEoLfXGIOXk3sogl8ol6d7J6Lqb2/nJg4=; b=ROe7qdsDK9qQHiJBX/Emw4fzgqyubXAiHa8vdRECXEP9tCguxi7VKr5SYDu6pH/s6nLu3YzZQ85R28d8By+V6C2GRcT3VPE5nZIvQw8j5tbNWgl+R3AKqOvmtGR0G1u2zAxi5SMAwUhdscteH5O4EiwadGIHVVQxgXEXotB2GNS/8fo+b+fFJ/Bv7cEy+HCUFV0QtPDcsC0EUA2quijYfiEe6W+6DMM4g/cwcpAffls6PqbhkeAgUzoyelUyi8VX1tOtg2adehZ6Prly4Uv+NznBFtFt6mLsrNtZnDAI3Qna/11LWJu3QMnmc4ze/u/Bge1uCzlDgq1Z8xVhnGjYSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from BN0PR10MB5029.namprd10.prod.outlook.com (2603:10b6:408:115::16) by BN6PR10MB1905.namprd10.prod.outlook.com (2603:10b6:404:ff::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Tue, 2 Aug 2022 06:36:31 +0000 X-Received: from BN0PR10MB5029.namprd10.prod.outlook.com ([fe80::6118:60cc:a016:e4c6]) by BN0PR10MB5029.namprd10.prod.outlook.com ([fe80::6118:60cc:a016:e4c6%6]) with mapi id 15.20.5482.016; Tue, 2 Aug 2022 06:36:30 +0000 From: "sivaparvathi C via groups.io" To: "devel@edk2.groups.io" , Sivaparvathi Chellaiah CC: Vasudevan Sambandan , Sundaresan S Subject: [edk2-devel] [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line Thread-Topic: [PATCH]Shell screen will show a redundant symbol after using Hexedit command under command line Thread-Index: AQHYpjoz3cwBQlBJPU2Nlw5VHXvOag== Date: Tue, 2 Aug 2022 06:36:30 +0000 Message-ID: <20220802063609.1183-1-sivaparvathic@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f301ae2-03fd-46f8-a120-08da745155eb x-ms-traffictypediagnostic: BN6PR10MB1905:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: OnmLv6mJNdklzB4bFYLsyV48PUJHTGuS+dTRxKqMUho1pyuYxX2CbPyJgjsoVW+bLc59dKs8fujFtA0fjmhqaGuPRZi7RrigPltuYfxFDe8wmlHrOrgin9AMt4uuXr/aRnO6Vv5sOsNShV29Zxkz2yqjLgnCkU6v3wPC0xeJQ4b4dR0FLrXUtNRzPFHb5wFWTnoM5E37TZB71bBGuQnLao0SXhP5TtVspwDqPwcwWHNozoTq2DaiEX3JxeKHrJDhmSrBBc1ZjiyGnARwLz2fyFpctFXP5OiZhZvlTkxFquSX3VcATkz3Gl80arZ2tLXHjXI7Rv25d7yDCy+G4Ajhbl9sC/4AdHBKAeOClUaFdUoCwoh62gI+GHxN89VVLfY+fl6krkkM6383oh8cda+ZKmYHYIdn0hLfuC+Met036HHvoNV4I04toxz/4HyyeD/NG+o5DeaUNQV/QCQZ02ict/2PqX9Ng7lAbLLpeKPHijb4UhmapNJaoW/O8XdFyrHnGE5wX2GjO6dffJlO/K6JLr+SNH7ZM/68AoGKjyQ3trWkzxt8GjfIX+MOyPS77cm+jza2Ch3FFGkqbIn3LUkldeJYociEstbx54xO5YQa8SlrM877HJmvePC1X3DNJIamUBm8BA8RFbBVykcDPEU8ELne/o+c0sa441G4pqtZcCHoNcu1ZZ06SEoCEtJZ3wV3yDpscV52IVQykhoPtY9O3DVg2M/meE8DyBn7bg1j/IWjLHYPwNKSv4U4Boe+JKKGSlnzKTk2Tlp7uwsb4Miya27s0flxebduLam+WjbiZJ8xQk3HL5bWoqv1FhzsStJi x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Pw+DAAfcaImNBHjQHvMEfVqhYGoP+F+3D+hoUkyBkB0Di1JQ4dN7++RVfM?= =?iso-8859-1?Q?9SAIlMGXH2AbAKGWt/Y5k6unfi0RyZDjEcv/ZtUSSQCVgiLgTE/95hnHUT?= =?iso-8859-1?Q?gnNcJcv0/WdJt7T/Ihbj3rbmLzu1rBbpwmYQ75iRdLtHsUcvN5k98rk9GS?= =?iso-8859-1?Q?SdgALLizOJAB5v8MldWPvN+bhux40+hyFkrea1Oud4DRY08v09jYSOg1Xt?= =?iso-8859-1?Q?wYBf5EUEVYHkhoPOd8n6rQFK5hc2iaAXG/wWwkR4MLvCMtOr7JtKZiOtlc?= =?iso-8859-1?Q?UyKHeSyI5az12j/JJFL7+RN1E5api37BwVAbdzdOKLppiSfT90EDix+jH9?= =?iso-8859-1?Q?j59gAqZgG1DVaOvBkafMWqE6rOUKTm3/SDboicPmhkCdNiZEMwIPDMO/Tv?= =?iso-8859-1?Q?cv4lnVjP8Awd0ubfzNV7tF+KdU4BCFXr3ZEbekWMfn2CgbMg561ZpDZBrw?= =?iso-8859-1?Q?VNpP9YAfxZVJUgDrZp8aglt1Cg5qfnx/SDEBxzTn3ZPVL1HzIFcqYW8hKz?= =?iso-8859-1?Q?GubKhx68C5/XWfaZn8uMwMfGZP3lyWwaDusOsmixpYKHjL+m7/GpdfX3tc?= =?iso-8859-1?Q?dd5y2hMls9h26ReclBCjm1P5AL+/5eEc2wwUm+gk5R28ILIM7NWtvJK812?= =?iso-8859-1?Q?eSbOz2qHQ5GOley0snRpuIUksn8lyYGgZ63GFfvjkx7M43I1aCd148oeTW?= =?iso-8859-1?Q?GdEXIf8nGEpl01aPeraeaVLON3UXjmiphR/HajIlJPEvm7ITwG4bhp6bwG?= =?iso-8859-1?Q?2Twiefd/BQBihGfFzY+ME2xkL46OAu8UgU1w6qzVNITae94Eej/lsURq3s?= =?iso-8859-1?Q?uRXipR/uIZ7M/J9aZBC1qd6rGqlgyvxNLu1qf2gTO5Sz+H79YF/kvxZDBJ?= =?iso-8859-1?Q?1tl6cMo4Fwouxay3/woTPUY7Q/PqBdb9kgc1gqXrk7vWo/WtzADNhdO4B+?= =?iso-8859-1?Q?kqSJ2Aa6vh93WddjAHwAf00x2L/VVI6uSdASTsU+eJuXUwwRsVGx2aHf3d?= =?iso-8859-1?Q?pg/3DQ5GC+AkhnWHSwd2pBxpkqHAaBO18XhpAot7ZD+KQ2OBT5JwIbRpl7?= =?iso-8859-1?Q?QC5QfgM/5DSo7tz3mxM0bPk77WrcuCnbRqJidPLm85PjDWkmrb8b2YKIbT?= =?iso-8859-1?Q?LDQq0YGedQ/QByezJTZrJDPsxCgB2a63YT7367O7m99Z1h+OhIPurGWYl6?= =?iso-8859-1?Q?zEPSNz2QwbGkDkyU/OZCO8lzLgqdThtgUFzVDuGztbkavSyZQ0Qgx4axrp?= =?iso-8859-1?Q?eKTDPV2xXE9kvAPF2iXV+5yp6VCYMVSr95Vlj/X2I7X9bEI/VjgsdASd9w?= =?iso-8859-1?Q?30ppkLwqk4Uqu2a0kPW5faGpvb15zMKVa0ReXPx2to+xL9FG7i6U6mGMZT?= =?iso-8859-1?Q?zfamX3ELoWTBXHktqyVj0vTc2Zun5rG8wPdqApympaNwlFcUyzv3wmpjWE?= =?iso-8859-1?Q?gh8bcTt2gQFkbD4NzAbM4K0w9VMKYHKK6MJsAeaHqt9FFf0Dk7IbpOFaPq?= =?iso-8859-1?Q?IK7M9UJqe9VYzhAlPp0/yDewt5p26N4Of2C5hfJCc0t3tbzzs4wd+siyc8?= =?iso-8859-1?Q?z2hCOMWW2OgWiBk9V+wP0GdEKhIon+g545JZBCYGMRKWvfncYR/V7m8bom?= =?iso-8859-1?Q?UhS7X6REaTOXWzrvgs7a29iM16EN2hjrGYuuepSoIdVhMBA8/oJDEmAQ?= =?iso-8859-1?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5029.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f301ae2-03fd-46f8-a120-08da745155eb X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2022 06:36:30.8985 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tuC3CXijvxE9yN1PPyX5l0Q8vl1M0fAyF1vCJ76ld/I+kaHQ8j64Qj0gzY+dfZuUeSIyKXqBbpHDGseDkhpysQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1905 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sivaparvathic@ami.com X-Gm-Message-State: 6qHS6hw6A546fMFlNYYAXy6yx1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659422195; bh=+1s+Gj0C01Um8IKOlB9DDNl0NfRLDAntqDj5b1VGuxk=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=W3lXMvwVAvnWv6JfjQ3d6v9N+g1lxNKZIx9kxWv+Bs47et0Ovm+Atba526DQC9eKo36 NrFme2FhGPhfDMyTzenswbCmjIKl867eZR43Vpf8BS0Yqp1+PfO/nl1XhiqwV3f3Pv8MF STxgEIpoKBVxYF1mZgQ2UIwsVKdukGI+2I4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659422196283100001 Content-Type: text/plain; charset="utf-8" Added changes to clear the redundant symbol after using Hexedit cmd in shell screen page. During ClearScreen(),first screen was cleared and cursor was set to new position(0,0) ,but the visible state of cursor is always 1. in setcursorposition(),cursor was disabled during that time,old cursor data is drawn to screen. Signed-off-by: sivaparvathic@ami.com --- .../Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c | 2 ++ .../Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEdito= r.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c index 58beaaf9c5..58df2e022b 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/MainTextEditor.c @@ -1627,6 +1627,7 @@ MainEditorCleanup ( ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_EDIT_LIBEDITOR_FILEBU= FFER_CLEANUP), gShellDebug1HiiHandle); } + gST->ConOut->EnableCursor (gST->ConOut, FALSE); // // restore old mode // @@ -1644,6 +1645,7 @@ MainEditorCleanup ( gST->ConOut->ClearScreen (gST->ConOut); + gST->ConOut->EnableCursor (gST->ConOut, TRUE); return EFI_SUCCESS; } diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEdi= tor.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c index 0eb917acf7..8b3d5225db 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/MainHexEditor.c @@ -1833,6 +1833,7 @@ HMainEditorCleanup ( ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN (STR_HEXEDIT_LIBEDITOR_CLI= PBOARD_CLEAN), gShellDebug1HiiHandle); } + gST->ConOut->EnableCursor (gST->ConOut, FALSE); // // restore old mode // @@ -1845,6 +1846,7 @@ HMainEditorCleanup ( EFI_TEXT_ATTR (HOriginalColors.Foreground, HOriginalColor= s.Background) ); gST->ConOut->ClearScreen (gST->ConOut); + gST->ConOut->EnableCursor (gST->ConOut, TRUE); return EFI_SUCCESS; } -- 2.31.0.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92042): https://edk2.groups.io/g/devel/message/92042 Mute This Topic: https://groups.io/mt/92765913/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-