From nobody Fri Apr 19 11:14:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+92041+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+92041+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659416406163259.6820758197116; Mon, 1 Aug 2022 22:00:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dq9xYY1788612xCNsZqbXzAS; Mon, 01 Aug 2022 22:00:04 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.60]) by mx.groups.io with SMTP id smtpd.web12.2646.1659416403756456291 for ; Mon, 01 Aug 2022 22:00:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k27mZl7VOwUq6LGLrQlA0T3cpwHkfrwLokYZ4Y/0rv8ITqOcjDZNGEshv1i33TY6p3DIKOwuhpz6P91XpUzZPjgRiylx0KNMmnrbj4CGSzAE0MRSIW09alYSjXcsW+PTGIjcFYTgeHUrptGrf13ci1oI6wlEnPESGB+wdppqZkDdD5xc2LockzISquzeBTq/XNOuhcBKdq7c1ANcA+wtUiy63Xuj0h7wVr0ObiBtZVdcCNcjz4pqGf58da/A8rihsvCC3BGBg1MzMzAz10o3h2zC588ck3iPTTxYwvNWLGkP/vlSAQy4bFFNpfZJdPHiUjLAV2CAi8U0Ji8lbSYGpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5NIgG+9cGWVHLjhcJzHzSyQkOWOKf2pckSo0VcXdUdE=; b=muoApJU9MAcKEr8FNj5WFjIhRjOn59wB8DWhOcUVlWt4byAdOS4mztHDTNZzTBhmt1JyQcVWl71AGps6Sg8iVMwpe+Hj8pQVILfNEA5jiVzAxDhqqvdXhu4BpBzRWKEMVW/T6rUB7SMkz1H1osJJYAybJrtymds5ZGrJOTsT9AWiCgzdsl1jwb2kMZp7FDeBzXLEpyWM+ECkfniwE47FSM7MRY6Q1tI9S5wuAPYNhLjwPZP9mtj+AMOWdPICIgo+zHM5f15S4XzpSdbCjGiTiT7yfX0Cl0wjZ5hK8u4dKthr0qnbX/qEyQH9OLtYWhHR7bLuZSNQG2KoyCiKijDO4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ami.com; dmarc=pass action=none header.from=ami.com; dkim=pass header.d=ami.com; arc=none X-Received: from DS7PR10MB5040.namprd10.prod.outlook.com (2603:10b6:5:3b0::8) by BN7PR10MB2754.namprd10.prod.outlook.com (2603:10b6:406:c6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Tue, 2 Aug 2022 05:00:00 +0000 X-Received: from DS7PR10MB5040.namprd10.prod.outlook.com ([fe80::78f7:67f1:2606:e2c4]) by DS7PR10MB5040.namprd10.prod.outlook.com ([fe80::78f7:67f1:2606:e2c4%3]) with mapi id 15.20.5482.016; Tue, 2 Aug 2022 05:00:00 +0000 From: "sivaparvathi C via groups.io" To: "devel@edk2.groups.io" CC: Vasudevan Sambandan , Sundaresan S , Sivaparvathi Chellaiah Subject: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205 Thread-Topic: [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205 Thread-Index: AQHYpiy4zCyVxau01EKVj3gjB/KQkg== Date: Tue, 2 Aug 2022 05:00:00 +0000 Message-ID: <20220802045922.791-1-sivaparvathic@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 340b542a-4ee8-4edb-c8ec-08da7443dab0 x-ms-traffictypediagnostic: BN7PR10MB2754:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: CNZLybGoDO8GVhW7DBcq1dAHv0kvxYX2HKIEhkWEkGBUrJAsznu0WNci5gE4Ypxkho9Wysss/7p+4IvZYAiFahhS6fRbXe9oLXRLUC2J4ZPqS2x9I4XrfGgGdUcs+1rj7BmuIYxnln8kJNBmbND8cfacT2JLCwCKAcXlz/jG3kWKHLBKau86cF9cTQOQ2vf1xCLJftEXJLFhOeUlYNz0PSxaU+Zl+oc05ls4G6OW6jVvPCd7lYGLDTC9FEKXDJu3NQer30lBdTTM+yGDir4npIOaGHrtdNn/0LyqUhnazlBVRK6CKu8PCWsR6uFw28t0LPMFnAZ1VTPVB5V1TK//6jRncoZoSuUi5aUKamQHcHA9i2QPVSUI5dHDk5EvB0ZIeirbWS/N8VCew7kJEn9OXEAjX6scX6S51+ulZ5oAzonkiOOF2qhaLMFEiTf00m7Q7QDI6vxvXtqQaebpoiOGEHM/xMfN8ZVyAumvlE45PJL4OAzANTb2r/S1fNcPJjxZtM8UxwFohC7mxe/gVxt8wbUTrElYQyoh44pwXQv99a2a5y8yFUm2c8LID31znDV2quW14LpzuT5gd3glh2kh3VQdMSNXsSWvlaykDs593q6skMAIZq8qkranguYEmIm3QG5CrDVRyOd6OAeMNZ9Fdzuov2R+N53BIZu//2TMwzVK24tbjOvBblVxfbswivbujNdvuZCGFjtagadXwQ/hBbkc6exCZeTiUhY09FgXx49Rm81o2EvwedtpHAzRdl2il5NcDyrq4jzx0w9qTkbrEoKr51t3ZxFF38DPdtXebB2OQJPZQJ/Dh2pur8tzx13p x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?DZMtz3MfF018NHp57JTMGJ8l0Ly+W1BemmT4Eu444mIIoNUZ2OhW2egAdp?= =?iso-8859-1?Q?6xFHw6Rp1zPt69SQmxVbVv/tPDjP/Glrkk4IRY4/zL3stQa9ibzs8Gg9Y1?= =?iso-8859-1?Q?sGVrKkY1/yntCQ/Qc7PHJ19FHHEUuN9G5kO4yG93fbJnuzT+blwGB+NaTr?= =?iso-8859-1?Q?4rQI7kKb5PgkJIScl3817AcekL1DGSSXpE1y46hKE/d9iYWnz+gqPzBTLz?= =?iso-8859-1?Q?cUp/40jhC23tB73YbvNVp7nMUw6mIYXRHEXscIThyzmoi24kI+5AhNkIMY?= =?iso-8859-1?Q?1cmwxT6diHuw3yYviV+ohXzUivd/9X7agjbZDcq2zeHl2Ny49EJ7jfXwRq?= =?iso-8859-1?Q?xyS6J0qXnPt1Wtzb+pACA8eGibrwLNU8UjYLHIS3SSpNefPja+oT1OqdWH?= =?iso-8859-1?Q?RdWGo6gpRBBArolM9XGEM4ynn9K1E3rH8WQCpTd5l2KplAuv80jJPPaarI?= =?iso-8859-1?Q?t2rWoJi+HApPpkurHq2Bak9Cafy/a/ZaylrXm9rZmdiNB1lDPvJ0XlRRpG?= =?iso-8859-1?Q?y1h5EbCtx91EklgA8ieH9zj4hw+MQiMw2FJyilVcAxY2QoQOHUcymDTNqx?= =?iso-8859-1?Q?zep0Plg/zcW9bA+TFaZxxqvM7OPUhYZf1eH8Xaq0tMRMMLGeWL3YzuHnEc?= =?iso-8859-1?Q?i4Co6eyjnKN9d0vtsecdznjLwx59Mp+6Pxk2Vqi3ibX0y60uiCKWiD8GMR?= =?iso-8859-1?Q?E9LljTFaIXzAEjNn7kXc2+HDVfGM9SnaE1CXzESsmjdze3vER/+Z/G+iNl?= =?iso-8859-1?Q?nnIzetp6pM0DvoWzoAUgulk2QEEW6APlrk1NFXV9aa0VhgO9HUldLYwFZx?= =?iso-8859-1?Q?EFNBnEKyJtDsqcJTWHzrr10NIzxRyUmqw1QsgEalNK/flAhObqAJrlC0Et?= =?iso-8859-1?Q?rE1elygcxlPOOQbshECHBcIR/XtPNHoOqUhTpDsmbl9/IfM0+/kXCbTqgm?= =?iso-8859-1?Q?QRtzm5sOy+Wwtn2aB/bUeYNx6htRckmieY6NGbJ8z6Z9yKdtPqOU7Uo8R6?= =?iso-8859-1?Q?mVqA0zOxVXLApaPZ6Qt3beJzdGqToZJICTvjrWWIMxP+mfwe/tZrn5zu4Q?= =?iso-8859-1?Q?9GS5Rh8Xj5v5mJLiTjF7ry/sI0tfIYMU7nqwh84LYk+iRbMOmeJf+QvXX1?= =?iso-8859-1?Q?jJxymSzuVYzFIXl+L0YdXPQbxIn1/oJAzLedNUgA79pZIzN+7A+765yfCd?= =?iso-8859-1?Q?caaq7GPrbWPVYo4M8E5d+rYdyX2hHRyWumcVJIaGnEH+e+jau8cgs3L34L?= =?iso-8859-1?Q?r2Fs4C3ifNJoA0D9GzIbd1gag5jMzqCco7l6pnixJkgCmzYazJKm2+0euw?= =?iso-8859-1?Q?C9C9kpL6E4eojfnnQ42Oaku4w57aznP+keB/Ujz29NyfS1nqHVqJZ1UR1W?= =?iso-8859-1?Q?9cbDwG12M4E/nSDfZIkJeoUPm6cp1iUEfVpNAUt8H6MM5r29s8V9vO3jCs?= =?iso-8859-1?Q?OLrlI4Q6US+FjiG5TFMkK0cDTQu6bACnCJCJ9l253EL6pdZFvAewjl13It?= =?iso-8859-1?Q?NhLMnqVhIsNPk/ARkJlh5yoIUALICAPu94kM6O2zDT4D8l4Ls7lT382mi9?= =?iso-8859-1?Q?f5lSNUwr+VyDj13HFlgX8FDbkgJc0uhkj8KjYyMfLO4JRf4x0Ba8ZOP2GB?= =?iso-8859-1?Q?wnzOdYyUOcc1M1HvjdIKo1Pj19rCj9RSLCcEm+BF1BRGdF8z5svGxb7Q?= =?iso-8859-1?Q?=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: ami.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5040.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 340b542a-4ee8-4edb-c8ec-08da7443dab0 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2022 05:00:00.6527 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 27e97857-e15f-486c-b58e-86c2b3040f93 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: syPuJ1ioMDIGdxe6FrpIbrjghoRzb5EuROz+auYEXQfFOqonYaoIv2/VdfAwndShL7AaipsT9vU205vmh4LVxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2754 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sivaparvathic@ami.com X-Gm-Message-State: lzVpiP7TuG6EDbeghPKvs7cyx1787277AA= Content-Language: en-US Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659416404; bh=6L/x/wi4SghvuKYQtGQGqxbstQMNqP9og/szI1W5gwo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=OmA9dC9r3lNkzRlHDTVNuQkNS7aq+ZV1RKkIFgjnFizlG3gmBKtxkk/y4OaxShEhFxg acgy8DgC/+uGUUQWKsc/wPGvdvMni0J8yk+gthWVdw7ps0AYrSqeHDzUihfin2rP1L2AU cpMV1jWIEikdWorgkgDz4lYB5UmvCUWVOWc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659416407335100003 Content-Type: text/plain; charset="utf-8" Attached changes to resolve the coverity Issues Signed-off-by: sivaparvathic@ami.com To: sivaparvathic@ami.com --- MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c | 3 +++ MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c | 10 +++++----- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c b/MdeModulePkg/Bus/= Scsi/ScsiBusDxe/ScsiBus.c index 9ea69ee740..2cc61bb942 100644 --- a/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c +++ b/MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBus.c @@ -531,6 +531,9 @@ SCSIBusDriverBindingStart ( // then create handle and install scsi i/o protocol. // Status =3D ScsiScanCreateDevice (This, Controller, &ScsiTargetId, Lun,= ScsiBusDev); + if (Status =3D=3D EFI_OUT_OF_RESOURCES) { + goto ErrorExit; + } } return EFI_SUCCESS; diff --git a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c b/MdeModulePkg/Bu= s/Scsi/ScsiDiskDxe/ScsiDisk.c index 98e84b4ea8..5f4ead7669 100644 --- a/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c +++ b/MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDisk.c @@ -4247,7 +4247,7 @@ BackOff: if ((TargetStatus =3D=3D EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) || = (EFI_ERROR (ReturnStatus))) { DEBUG ((DEBUG_ERROR, "ScsiDiskRead10: Check Condition happened!\n")); - Status =3D DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice= ->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action); + DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData= , SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action); if (Action =3D=3D ACTION_RETRY_COMMAND_LATER) { *NeedRetry =3D TRUE; return EFI_DEVICE_ERROR; @@ -4371,7 +4371,7 @@ BackOff: if ((TargetStatus =3D=3D EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) || = (EFI_ERROR (ReturnStatus))) { DEBUG ((DEBUG_ERROR, "ScsiDiskWrite10: Check Condition happened!\n")); - Status =3D DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice= ->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action); + DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData= , SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action); if (Action =3D=3D ACTION_RETRY_COMMAND_LATER) { *NeedRetry =3D TRUE; return EFI_DEVICE_ERROR; @@ -4494,7 +4494,7 @@ BackOff: if ((TargetStatus =3D=3D EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) || = (EFI_ERROR (ReturnStatus))) { DEBUG ((DEBUG_ERROR, "ScsiDiskRead16: Check Condition happened!\n")); - Status =3D DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice= ->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action); + DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData= , SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action); if (Action =3D=3D ACTION_RETRY_COMMAND_LATER) { *NeedRetry =3D TRUE; return EFI_DEVICE_ERROR; @@ -4618,7 +4618,7 @@ BackOff: if ((TargetStatus =3D=3D EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDITION) || = (EFI_ERROR (ReturnStatus))) { DEBUG ((DEBUG_ERROR, "ScsiDiskWrite16: Check Condition happened!\n")); - Status =3D DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice= ->SenseData, SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action); + DetectMediaParsingSenseKeys (ScsiDiskDevice, ScsiDiskDevice->SenseData= , SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), &Action); if (Action =3D=3D ACTION_RETRY_COMMAND_LATER) { *NeedRetry =3D TRUE; return EFI_DEVICE_ERROR; @@ -4728,7 +4728,7 @@ ScsiDiskNotify ( if (Request->TargetStatus =3D=3D EFI_EXT_SCSI_STATUS_TARGET_CHECK_CONDIT= ION) { DEBUG ((DEBUG_ERROR, "ScsiDiskNotify: Check Condition happened!\n")); - Status =3D DetectMediaParsingSenseKeys ( + DetectMediaParsingSenseKeys ( ScsiDiskDevice, Request->SenseData, Request->SenseDataLength / sizeof (EFI_SCSI_SENSE_DATA), -- 2.31.0.windows.1 -The information contained in this message may be confidential and propriet= ary to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephone= at 770-246-8600, and then delete or destroy all copies of the transmission. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92041): https://edk2.groups.io/g/devel/message/92041 Mute This Topic: https://groups.io/mt/92765259/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-