From nobody Fri Mar 29 11:00:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91956+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91956+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1659063457; cv=none; d=zohomail.com; s=zohoarc; b=dZWOMmYMYP23r8db26NmvWKGlJZyiwe46/G2tJ3D52Xmalr6mpz5FCipXDTxPxXwHuuZrP0c5ppNmTRRLRuCzERwVsizEZeeNe/WOb+6iV+xDCfz1r8grRVSP6hg3dUWnbCFHP+q0WG3/8kj79ZGpc6ylJp7Gvh3TyjHXmhcGz0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659063457; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=/AM6w2BVhYb9/XmgsUVI3YBtS8xhgJbxptkSOiCEBIU=; b=RjQq4cfZcVYgpJr492vP2/pqxg1sHyj+Gz+Z3fpqyNU+xXCg+8AgiN0YoRS9US1fdWI2FfPE58e0quyr8rbrKhh3juMTApfSzwBz/vztS/QicSZciZNWlWZKTnlFFByDuyocHvvuLABgZTfoHE6tv/rUrQC4WmidjsaKu0A8CFA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91956+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1659063457100385.41358296826104; Thu, 28 Jul 2022 19:57:37 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id bgFQYY1788612xJniirDlLxw; Thu, 28 Jul 2022 19:57:36 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.3847.1659063455931091447 for ; Thu, 28 Jul 2022 19:57:36 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10422"; a="350381176" X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="350381176" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 19:57:35 -0700 X-IronPort-AV: E=Sophos;i="5.93,200,1654585200"; d="scan'208";a="601138185" X-Received: from cchiu4-mobl.gar.corp.intel.com ([10.212.196.229]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2022 19:57:35 -0700 From: "Chiu, Chasel" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Star Zeng Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix GenCfgOpt bug for FSPI_UPD support. Date: Thu, 28 Jul 2022 19:57:24 -0700 Message-Id: <20220729025724.2040-1-chasel.chiu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,chasel.chiu@intel.com X-Gm-Message-State: tXG8wm67uUQssPtpecSUDmkix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1659063456; bh=6gll4kxCcERgXt/IjHqzm1SW9kuQWBDSEeCWeLw3z+I=; h=Cc:Date:From:Reply-To:Subject:To; b=eePeOo2qifSwwQMARdLZmMXn0GPtVxbQ9VsFDkmt6dVI7+ZK593R1l9wKBYRTPSHopg XglB7C7FgAQf6Z5xiSrj4pa37/B/4nVjjhbtTm6fygl5eyYp1LSGPzjPsmXFuSSWrCZFJ C8rL3kWUzKDQlgBINZ3nYP6TgULkWAFd7VQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1659063457708100001 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3993 Fixed a logic bug in GenCfgOpt.py to skip FSPI_UPD when platforms do not support. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu Reviewed-by: Star Zeng --- IntelFsp2Pkg/Tools/GenCfgOpt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py b/IntelFsp2Pkg/Tools/GenCfgOpt= .py index 71c48f10e0..13be81ddbc 100644 --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py @@ -1301,7 +1301,7 @@ EndList elif '_S' in SignatureStr[6:6+2]: TxtBody.append("#define FSPS_UPD_SIGNATURE = %s /* '%s' */\n\n" % (Item['value'], SignatureStr)) elif '_I' in SignatureStr[6:6+2]: - if NoFSPI =3D=3D True: + if NoFSPI =3D=3D False: TxtBody.append("#define FSPI_UPD_SIGNATURE = %s /* '%s' */\n\n" % (Item['value'], SignatureStr)) TxtBody.append("\n") =20 --=20 2.35.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91956): https://edk2.groups.io/g/devel/message/91956 Mute This Topic: https://groups.io/mt/92683969/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-