From nobody Fri Apr 19 01:40:20 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91887+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91887+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1658911496; cv=none; d=zohomail.com; s=zohoarc; b=SZxShEr74QYTqobOcpxOrhjpF+CTgzYEnvxsIho26JK0Ipf6mOLL7WwDoW1DNAOQGmqPidjXqEHSMQbO/B0xmAAQ/JI2c8JHsLEHg+bfUubN7n4PyC/Foxu2OsjjxxIZIfN0kIQfrf51nEca4l3InKqpH240Bml0HoPHpgaBP3g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658911496; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=8Cujg09fPgD6FthFRMY4MnYY2HmRrzO8jDKM1YENznM=; b=keckUj2p5Ep/3xdmugZhkhEE8A00hVRzBTGjwpCEGnkP5j8tgs2xxoKlLOQXLUpFfirrTToNwNFxJ8YJ6cJ25ViqY7k0KfXqoeZ5WhGZucyFYz6++UuQnXk6pxC4Yu02aTax9URiHY4oHDOXWw3etyHTb/RjTjaZ6i0QmPSpWDM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91887+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658911496426972.6651120181021; Wed, 27 Jul 2022 01:44:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7S1rYY1788612xRh4x9FOdqL; Wed, 27 Jul 2022 01:44:54 -0700 X-Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mx.groups.io with SMTP id smtpd.web12.17392.1658911493719284802 for ; Wed, 27 Jul 2022 01:44:54 -0700 X-Received: by mail-lf1-f52.google.com with SMTP id z25so26198404lfr.2 for ; Wed, 27 Jul 2022 01:44:53 -0700 (PDT) X-Gm-Message-State: VKjIWqbp2rGyxHDRlEcLcb2Tx1787277AA= X-Google-Smtp-Source: AGRyM1uJLlZJjbhCLqA/EeNxmgoJwbkJ6XRQxrXuLqnRoeWANu4Bk5GInXEfLA92IIgn4O1CO551Lg== X-Received: by 2002:a05:6512:2399:b0:48a:a38e:28d8 with SMTP id c25-20020a056512239900b0048aa38e28d8mr2585978lfv.162.1658911491597; Wed, 27 Jul 2022 01:44:51 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id b9-20020a056512070900b00489c8c6c055sm1060988lfs.50.2022.07.27.01.44.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 01:44:51 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: jian.j.wang@intel.com, gaoliming@byosoft.com.cn, dandan.bi@intel.com, shenglei.zhang@intel.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH] MdeModulePkg/DumpDynPcd: Remove unsupported format specifiers Date: Wed, 27 Jul 2022 11:45:03 +0300 Message-Id: <20220727084503.24035-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658911494; bh=9lo2nCKvCOHIlPJ7jU3b+CexRvlaXEcM0Nj03/Tf3Go=; h=Cc:Date:From:Reply-To:Subject:To; b=d6a0MGcLOHUtyh8c/mXqtSYOWqdKzs647MqjAnVBSICNW20ghnnQeemaqEYpx6zDJNf JxPm09n1zspQYWGSjhFDb3e3WuzN7ZOFV2ZNYkKOUP1wm91ySBG9/o1lzZUW6HOWWnUAR ABBP1Frl+1RnQPkmDg7RUDM+pCWmLS4FxNc= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658911496992100001 Content-Type: text/plain; charset="utf-8" Some print statements use format specifiers like %N/%H/%E/%B that are only supported in the shell print functions. In the ordinary 'Print' function they are just displayed as letters N/H/E/B. Remove these unsupported format specifiers from the 'Print' statements to fix the issue. Signed-off-by: Konstantin Aladyshev --- .../Application/DumpDynPcd/DumpDynPcd.c | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c b/MdeModulePk= g/Application/DumpDynPcd/DumpDynPcd.c index b8571c4556..013198963e 100644 --- a/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c +++ b/MdeModulePkg/Application/DumpDynPcd/DumpDynPcd.c @@ -361,7 +361,7 @@ DumpPcdInfo ( Uint8 =3D mPiPcd->Get8 (TokenSpace, TokenNumber); } =20 - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D 0x%x - V= alue =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint8); + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - Value= =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint8); break; case EFI_PCD_TYPE_16: if (TokenSpace =3D=3D NULL) { @@ -370,7 +370,7 @@ DumpPcdInfo ( Uint16 =3D mPiPcd->Get16 (TokenSpace, TokenNumber); } =20 - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D 0x%x - V= alue =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint16); + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - Value= =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint16); break; case EFI_PCD_TYPE_32: if (TokenSpace =3D=3D NULL) { @@ -379,7 +379,7 @@ DumpPcdInfo ( Uint32 =3D mPiPcd->Get32 (TokenSpace, TokenNumber); } =20 - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D 0x%x - V= alue =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint32); + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - Value= =3D 0x%x\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint32); break; case EFI_PCD_TYPE_64: if (TokenSpace =3D=3D NULL) { @@ -388,7 +388,7 @@ DumpPcdInfo ( Uint64 =3D mPiPcd->Get64 (TokenSpace, TokenNumber); } =20 - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D 0x%x - V= alue =3D 0x%lx\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint64); + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - Value= =3D 0x%lx\n", TokenNumber, RetString, PcdInfo->PcdSize, Uint64); break; case EFI_PCD_TYPE_BOOL: if (TokenSpace =3D=3D NULL) { @@ -397,7 +397,7 @@ DumpPcdInfo ( Boolean =3D mPiPcd->GetBool (TokenSpace, TokenNumber); } =20 - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D 0x%x - V= alue =3D %a\n", TokenNumber, RetString, PcdInfo->PcdSize, Boolean ? "TRUE" = : "FALSE"); + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x - Value= =3D %a\n", TokenNumber, RetString, PcdInfo->PcdSize, Boolean ? "TRUE" : "F= ALSE"); break; case EFI_PCD_TYPE_PTR: if (TokenSpace =3D=3D NULL) { @@ -406,7 +406,7 @@ DumpPcdInfo ( PcdData =3D mPiPcd->GetPtr (TokenSpace, TokenNumber); } =20 - Print (L" Token =3D 0x%08x - Type =3D %H%-17s%N - Size =3D 0x%x\n",= TokenNumber, RetString, PcdInfo->PcdSize); + Print (L" Token =3D 0x%08x - Type =3D %-17s - Size =3D 0x%x\n", Tok= enNumber, RetString, PcdInfo->PcdSize); DumpHex (2, 0, PcdInfo->PcdSize, PcdData); break; default: @@ -509,7 +509,7 @@ ProcessPcd ( // // The specified PCD is not found, print error. // - Print (L"%EError. %NNo matching PCD found: %s.\n", InputPcdName); + Print (L"Error. No matching PCD found: %s.\n", InputPcdName); return EFI_NOT_FOUND; } =20 @@ -548,25 +548,25 @@ DumpDynPcdMain ( =20 Status =3D gBS->LocateProtocol (&gEfiPcdProtocolGuid, NULL, (VOID **)&mP= iPcd); if (EFI_ERROR (Status)) { - Print (L"DumpDynPcd: %EError. %NPI PCD protocol is not present.\n"); + Print (L"DumpDynPcd: Error. PI PCD protocol is not present.\n"); return Status; } =20 Status =3D gBS->LocateProtocol (&gEfiGetPcdInfoProtocolGuid, NULL, (VOID= **)&mPiPcdInfo); if (EFI_ERROR (Status)) { - Print (L"DumpDynPcd: %EError. %NPI PCD info protocol is not present.\n= "); + Print (L"DumpDynPcd: Error. PI PCD info protocol is not present.\n"); return Status; } =20 Status =3D gBS->LocateProtocol (&gPcdProtocolGuid, NULL, (VOID **)&mPcd); if (EFI_ERROR (Status)) { - Print (L"DumpDynPcd: %EError. %NPCD protocol is not present.\n"); + Print (L"DumpDynPcd: Error. PCD protocol is not present.\n"); return Status; } =20 Status =3D gBS->LocateProtocol (&gGetPcdInfoProtocolGuid, NULL, (VOID **= )&mPcdInfo); if (EFI_ERROR (Status)) { - Print (L"DumpDynPcd: %EError. %NPCD info protocol is not present.\n"); + Print (L"DumpDynPcd: Error. PCD info protocol is not present.\n"); return Status; } =20 @@ -575,13 +575,13 @@ DumpDynPcdMain ( // Status =3D GetArg (); if (EFI_ERROR (Status)) { - Print (L"DumpDynPcd: %EError. %NThe input parameters are not recognize= d.\n"); + Print (L"DumpDynPcd: Error. The input parameters are not recognized.\n= "); Status =3D EFI_INVALID_PARAMETER; return Status; } =20 if (Argc > 2) { - Print (L"DumpDynPcd: %EError. %NToo many arguments specified.\n"); + Print (L"DumpDynPcd: Error. Too many arguments specified.\n"); Status =3D EFI_INVALID_PARAMETER; return Status; } @@ -600,7 +600,7 @@ DumpDynPcdMain ( goto Done; } else { if (StrStr (Argv[1], L"-") !=3D NULL) { - Print (L"DumpDynPcd: %EError. %NThe argument '%B%s%N' is invalid.\= n", Argv[1]); + Print (L"DumpDynPcd: Error. The argument '%s' is invalid.\n", Argv= [1]); goto Done; } } --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91887): https://edk2.groups.io/g/devel/message/91887 Mute This Topic: https://groups.io/mt/92645389/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-