From nobody Fri Apr 19 10:11:41 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91886+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91886+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658902372; cv=none; d=zohomail.com; s=zohoarc; b=gA1fM1BVANUjMHRhq77AlEbfxe/oMwfinV8PLzzoUlsp4oVAflTU3wCxum+dhLnW61blP66KX3ocrH3c+Ln5CRnYu/gM+9xRidqVg2212v54O+1AAHsmwqBMSKEis4bzwFSsCM69KPqX99GOU9XmBFCalWXWaeRpb5+F7yWvQlM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658902372; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=pNb4zPo3ySl/EdjgeaX9Utz7qQN74ylMIfM8pAMxTNw=; b=TX+3cEfnrlQkWoaauInOT5xb9mjhfwIi6o73FdAdcF6z4IQpVRX9fjP3KHP9WBD+Z+xoqTHE64Y0ChqvgOiuMX4SHY6lQXO9N4nM4R7At3mRyoLmj5br8pqPs4RSDukSmbp/6Bw0CDvulni45LK7IFJ41rZhZTStBWEo72pFXOU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91886+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658902372021628.2340578158453; Tue, 26 Jul 2022 23:12:52 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PCufYY1788612x4k4gg6CNVL; Tue, 26 Jul 2022 23:12:51 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.16819.1658902370064559118 for ; Tue, 26 Jul 2022 23:12:50 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10420"; a="313931529" X-IronPort-AV: E=Sophos;i="5.93,195,1654585200"; d="scan'208";a="313931529" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 23:12:19 -0700 X-IronPort-AV: E=Sophos;i="5.93,195,1654585200"; d="scan'208";a="659053161" X-Received: from lins2x-desk1.gar.corp.intel.com ([10.225.33.149]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 23:12:15 -0700 From: "JackX Lin" To: devel@edk2.groups.io Cc: JackX Lin , JackX Lin , Chasel Chiu , Dong Eric , Jiewen Yao , Ray Ni , Rangasai V Chaganty , Donald Kuo , Chandana C Kumar Subject: [edk2-devel] [edk2-platforms: PATCH] Modify processor _UID ordering by CPU default fused in MADT Date: Wed, 27 Jul 2022 14:11:49 +0800 Message-Id: <20220727061149.1495-1-jackx.lin@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,JackX.Lin@intel.com X-Gm-Message-State: cz7yHSxcVj7Yfk9CYwzvRO9Ix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658902371; bh=eqLs4PTnJzqLyWr4vReZsdwj2FUIqpcmdz/u7eWUYiI=; h=Cc:Date:From:Reply-To:Subject:To; b=tZRzXEe7Thd20T/KVkCuxSgfNeQBkUWfdtgXzVLXQu14X+pqGl6/M/fA+VWmmVxOf3h NcdiQ9Pxt1TN0ynUDjm3HKGOLeBj2YQvGRZujF3yiPDoNpFWpJfRUKtXfO6vCCUr9HCk5 v184NbvH+pPo8G3FWwmJSr2ynd6VKOc8pIM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658902374212100001 Content-Type: text/plain; charset="utf-8" BIOS should not reordering cpu processor_uid Signed-off-by: JackX Lin Cc: Chasel Chiu Cc: Dong Eric Cc: Jiewen Yao Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Donald Kuo Cc: Chandana C Kumar Cc: JackX Lin --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 14 +-------= ------ 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index c7e87cbd7d..f4c45336c5 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -173,7 +173,6 @@ SortCpuLocalApicInTable ( EFI_CPU_ID_ORDER_MAP *CpuIdMapPtr; UINT32 CoreThreadMask; EFI_CPU_ID_ORDER_MAP *TempCpuApicIdOrderTable; - UINT32 Socket; =20 Index =3D 0; Status =3D EFI_SUCCESS; @@ -198,6 +197,7 @@ SortCpuLocalApicInTable ( CpuIdMapPtr->Thread =3D ProcessorInfoBuffer.Location.Thread; CpuIdMapPtr->Flags =3D ((ProcessorInfoBuffer.StatusFlag & PROCESSO= R_ENABLED_BIT) !=3D 0); CpuIdMapPtr->SocketNum =3D ProcessorInfoBuffer.Location.Package; + CpuIdMapPtr->AcpiProcessorUid =3D (ProcessorInfoBuffer.Location.Pack= age << mNumOfBitShift) + CurrProcessor; =20 //update processorbitMask if (CpuIdMapPtr->Flags =3D=3D 1) { @@ -280,18 +280,6 @@ SortCpuLocalApicInTable ( } } =20 - // - // 5. Re-assign AcpiProcessorId for AcpiProcessorUid uses purpose. - // - for (Socket =3D 0; Socket < FixedPcdGet32 (PcdMaxCpuSocketCount); Socket= ++) { - for (CurrProcessor =3D 0, Index =3D 0; CurrProcessor < mNumberOfCpus; = CurrProcessor++) { - if (mCpuApicIdOrderTable[CurrProcessor].Flags && (mCpuApicIdOrderTab= le[CurrProcessor].SocketNum =3D=3D Socket)) { - mCpuApicIdOrderTable[CurrProcessor].AcpiProcessorUid =3D (mCpuApic= IdOrderTable[CurrProcessor].SocketNum << mNumOfBitShift) + Index; - Index++; - } - } - } - //keep for debug purpose DEBUG ((DEBUG_INFO, "APIC ID Order Table ReOrdered\n")); DebugDisplayReOrderTable (mCpuApicIdOrderTable); --=20 2.32.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91886): https://edk2.groups.io/g/devel/message/91886 Mute This Topic: https://groups.io/mt/92644220/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-