From nobody Mon Feb 9 19:05:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91781+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91781+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=hpe.com ARC-Seal: i=1; a=rsa-sha256; t=1658712966; cv=none; d=zohomail.com; s=zohoarc; b=gER9V3MSFWHB3pCRr9yZZRP+UyjIoVZU2EL3wqDnr6nOYZDtF7teIS9F9eejkPLvH0bUuLQ1hFC60uWqFml2OFunUP1TM+olU85YP6HO+MCwXFLjUNjAGuz6Z8gun59o9SUN2xERssO1zGWktdGtW8L9N8IUQv5z+byNycOCZTg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658712966; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=tTfijWiPYoYtG2s7dje9Ogu6mHjaKq6zRSQpXgZ30to=; b=cvxWO1BE+zire4NR/pa0PBPOTT8dyW5Z1VCgy1TXmKy3fanhSjRNaXWVWH/qKdAM55GNvlqd4eyPcerdnKz8ktwY2mjpSBKYma/1iv870mc4yVXQ/ggsUA6QZfNbF1gEeU2VrEZUrdOzcvqPAreseXTEKAg5Xo78khi94jQ5exY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91781+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16587129660871006.7865373291254; Sun, 24 Jul 2022 18:36:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id V3KiYY1788612xRTZR2yhC8V; Sun, 24 Jul 2022 18:36:05 -0700 X-Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.23175.1658712964473961430 for ; Sun, 24 Jul 2022 18:36:04 -0700 X-Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26OLCcOY003737; Mon, 25 Jul 2022 01:36:02 GMT X-Received: from p1lg14879.it.hpe.com (p1lg14879.it.hpe.com [16.230.97.200]) by mx0b-002e3701.pphosted.com (PPS) with ESMTPS id 3hhdsn14jf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 Jul 2022 01:36:01 +0000 X-Received: from p1lg14886.dc01.its.hpecorp.net (unknown [10.119.18.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by p1lg14879.it.hpe.com (Postfix) with ESMTPS id E54E3D2E0; Mon, 25 Jul 2022 01:36:00 +0000 (UTC) X-Received: from WAFM3XJD5N.asiapacific.hpqcorp.net (unknown [16.231.227.36]) by p1lg14886.dc01.its.hpecorp.net (Postfix) with ESMTP id 93F16800EC6; Mon, 25 Jul 2022 01:35:59 +0000 (UTC) From: "Nickle Wang" To: devel@edk2.groups.io Cc: Abner Chang , Yang Atom , Nick Ramirez Subject: [edk2-devel] [edk2-staging][PATCH v2 02/15] edk2-staging/RedfishClientPkg: Introduce Redfish version library Date: Mon, 25 Jul 2022 09:35:42 +0800 Message-Id: <20220725013555.926-3-nickle.wang@hpe.com> In-Reply-To: <20220725013555.926-1-nickle.wang@hpe.com> References: <20220725013555.926-1-nickle.wang@hpe.com> MIME-Version: 1.0 X-Proofpoint-GUID: EEkLsR6bI9yGQMg83nSiYFWPapt-aQv4 X-Proofpoint-ORIG-GUID: EEkLsR6bI9yGQMg83nSiYFWPapt-aQv4 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nickle.wang@hpe.com X-Gm-Message-State: jGKDKfeuUFlHtkEY216zvdbHx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658712965; bh=JX42xJ45Sq5gtjsq3CtNecfjoEL9y0Ec2/4NBCqnG9M=; h=Cc:Date:From:Reply-To:Subject:To; b=OsBMnzIpYEh9J0ghxbI3EjIY/dOPym5YJtOLF9FC6XmFSuyhHu+9w+VpKDXainns7mA 369Wv7hQwBSG5Uhl/KVf1q5YEq/yJqpU7exIxVkM/oQmNi3uhC7iZAt9W06IiGKSYfInY Em+3RggCO8kTL6qHS/yjQLDsCQj3RUnUktU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658712967877100006 Content-Type: text/plain; charset="utf-8" Add RedfishVersionLib in order to get Redfish version hosted at BMC. When there is trouble to get Redfish support version, the default version is retrieved from pre-defined PCD value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez Reviewed-by: Abner Chang --- .../Include/Library/RedfishVersionLib.h | 30 +++ RedfishClientPkg/Include/RedfishBase.h | 21 ++ .../RedfishVersionLib/RedfishVersionLib.c | 203 ++++++++++++++++++ .../RedfishVersionLib/RedfishVersionLib.inf | 50 +++++ RedfishClientPkg/RedfishClientLibs.dsc.inc | 1 + RedfishClientPkg/RedfishClientPkg.dec | 4 +- 6 files changed, 308 insertions(+), 1 deletion(-) create mode 100644 RedfishClientPkg/Include/Library/RedfishVersionLib.h create mode 100644 RedfishClientPkg/Include/RedfishBase.h create mode 100644 RedfishClientPkg/Library/RedfishVersionLib/RedfishVersi= onLib.c create mode 100644 RedfishClientPkg/Library/RedfishVersionLib/RedfishVersi= onLib.inf diff --git a/RedfishClientPkg/Include/Library/RedfishVersionLib.h b/Redfish= ClientPkg/Include/Library/RedfishVersionLib.h new file mode 100644 index 0000000000..319f22bd37 --- /dev/null +++ b/RedfishClientPkg/Include/Library/RedfishVersionLib.h @@ -0,0 +1,30 @@ +/** @file + This file defines the Redfish version Library interface. + + (C) Copyright 2022 Hewlett Packard Enterprise Development LP
+ + SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef REDFISH_VERSION_LIB_H_ +#define REDFISH_VERSION_LIB_H_ + +/** + Query HTTP request to BMC with given redfish service and return redfish + version information. If there is troulbe to get Redfish version on BMC, + The value of PcdDefaultRedfishVersion is returned. + + It's call responsibility to release returned buffer. + + @param[in] Service Redfish service instance + + @retval EFI_STRING Redfish version string. NULL while error occurs. + +**/ +EFI_STRING +RedfishGetVersion ( + IN REDFISH_SERVICE *Service + ); + +#endif diff --git a/RedfishClientPkg/Include/RedfishBase.h b/RedfishClientPkg/Incl= ude/RedfishBase.h new file mode 100644 index 0000000000..cf320bb0eb --- /dev/null +++ b/RedfishClientPkg/Include/RedfishBase.h @@ -0,0 +1,21 @@ +/** @file + Redfish base header file. + + (C) Copyright 2022 Hewlett Packard Enterprise Development LP
+ + SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef EFI_REDFISH_BASE_H_ +#define EFI_REDFISH_BASE_H_ + +#define IS_EMPTY_STRING(a) ((a) =3D=3D NULL || (a)[0] =3D=3D '\0') +#define REDFISH_DEBUG_TRACE DEBUG_INFO + +/// +/// This GUID is used for an EFI Variable that stores the Redfish data. +/// +EFI_GUID mRedfishVariableGuid =3D {0x91c46a3d, 0xed1a, 0x477b, {0xa5, 0x33= , 0x87, 0x2d, 0xcd, 0xb0, 0xfc, 0xc1}}; + +#endif diff --git a/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c= b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c new file mode 100644 index 0000000000..0a2ace7726 --- /dev/null +++ b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.c @@ -0,0 +1,203 @@ +/** @file + Redfish version library implementation + + (C) Copyright 2022 Hewlett Packard Enterprise Development LP
+ + SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define REDFISH_VERSION_DEFAULT_STRING L"v1" +#define REDFISH_ROOT_URI "/redfish" + +REDFISH_SERVICE *mCacheService; +EFI_STRING mVersionCache; +UINTN mVersionStringSize; + +/** + Cache the redfish service version for later use so we don't have to query + HTTP request everytime. + + @param[in] Service Redfish service instance + @param[in] Version Version string to cache + + @retval EFI_SUCCESS Version is saved in cache successfully. + @retval Others + +**/ +EFI_STATUS +CacheVersion ( + IN REDFISH_SERVICE *Service, + IN EFI_STRING Version + ) +{ + if (Service =3D=3D NULL || IS_EMPTY_STRING (Version)) { + return EFI_INVALID_PARAMETER; + } + + if (mCacheService =3D=3D Service) { + return EFI_ALREADY_STARTED; + } + + mCacheService =3D Service; + if (mVersionCache !=3D NULL) { + FreePool (mVersionCache); + } + + mVersionStringSize =3D StrSize (Version); + mVersionCache =3D AllocateCopyPool (mVersionStringSize, Version); + if (mVersionCache =3D=3D NULL) { + mCacheService =3D NULL; + return EFI_OUT_OF_RESOURCES; + } + + return EFI_SUCCESS; +} + +/** + Query HTTP request to BMC with given redfish service and return redfish + version information. If there is troulbe to get Redfish version on BMC, + The value of PcdDefaultRedfishVersion is returned. + + It's call responsibility to release returned buffer. + + @param[in] Service Redfish service instance + + @retval EFI_STRING Redfish version string. NULL while error occurs. + +**/ +EFI_STRING +RedfishGetVersion ( + IN REDFISH_SERVICE *Service + ) +{ + EFI_STATUS Status; + EFI_STRING VersionString; + REDFISH_RESPONSE Response; + EDKII_JSON_VALUE JsonValue; + EDKII_JSON_VALUE N; + CHAR8 *Key; + EDKII_JSON_VALUE Value; + + VersionString =3D NULL; + + if (Service =3D=3D NULL) { + goto ON_ERROR; + } + + // + // Use cache to prevent HTTP connection. + // + if (Service =3D=3D mCacheService) { + return AllocateCopyPool (mVersionStringSize, mVersionCache); + } + + // + // Get resource from redfish service. + // + Status =3D RedfishGetByUri ( + Service, + REDFISH_ROOT_URI, + &Response + ); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "%a, RedfishGetByService to %a failed: %r\n", __F= UNCTION__, REDFISH_ROOT_URI, Status)); + if (Response.Payload !=3D NULL) { + RedfishDumpPayload (Response.Payload); + RedfishFreeResponse ( + NULL, + 0, + NULL, + Response.Payload + ); + Response.Payload =3D NULL; + } + + goto ON_ERROR; + } + + JsonValue =3D RedfishJsonInPayload (Response.Payload); + if (JsonValue =3D=3D NULL || !JsonValueIsObject (JsonValue)) { + goto ON_ERROR; + } + + EDKII_JSON_OBJECT_FOREACH_SAFE (JsonValue, N, Key, Value) { + if (Key[0] =3D=3D 'v' && JsonValueIsString (Value)) { + VersionString =3D JsonValueGetUnicodeString (Value); + break; + } + } + + if (VersionString !=3D NULL) { + CacheVersion (Service, VersionString); + return VersionString; + } + +ON_ERROR: + + VersionString =3D (CHAR16 *)PcdGetPtr (PcdDefaultRedfishVersion); + if (VersionString =3D=3D NULL) { + VersionString =3D REDFISH_VERSION_DEFAULT_STRING; + } + + return AllocateCopyPool (StrSize (VersionString), VersionString); +} + +/** + + Initial redfish version library instace. + + @param[in] ImageHandle The image handle. + @param[in] SystemTable The system table. + + @retval EFI_SUCEESS Install Boot manager menu success. + @retval Other Return error status. + +**/ +EFI_STATUS +EFIAPI +RedfishVersionLibConstructor ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + mCacheService =3D NULL; + mVersionCache =3D NULL; + mVersionStringSize =3D 0; + + return EFI_SUCCESS; +} + + +/** + Release allocated resource. + + @param[in] ImageHandle Handle that identifies the image to be unlo= aded. + @param[in] SystemTable The system table. + + @retval EFI_SUCCESS The image has been unloaded. + +**/ +EFI_STATUS +EFIAPI +RedfishVersionLibDestructor ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + if (mVersionCache !=3D NULL) { + FreePool (mVersionCache); + } + + return EFI_SUCCESS; +} diff --git a/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.i= nf b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.inf new file mode 100644 index 0000000000..34d13d64f1 --- /dev/null +++ b/RedfishClientPkg/Library/RedfishVersionLib/RedfishVersionLib.inf @@ -0,0 +1,50 @@ +## @file +# +# (C) Copyright 2022 Hewlett Packard Enterprise Development LP
+# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## + +[Defines] + INF_VERSION =3D 0x00010006 + BASE_NAME =3D RedfishVersionLib + FILE_GUID =3D 396A7508-B611-49F7-9C81-DAD96B526B61 + MODULE_TYPE =3D DXE_DRIVER + VERSION_STRING =3D 1.0 + LIBRARY_CLASS =3D RedfishVersionLib| DXE_DRIVER + CONSTRUCTOR =3D RedfishVersionLibConstructor + DESTRUCTOR =3D RedfishVersionLibDestructor + +# +# VALID_ARCHITECTURES =3D IA32 X64 EBC +# + +[Sources] + RedfishVersionLib.c + +[Packages] + MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec + RedfishPkg/RedfishPkg.dec + RedfishClientPkg/RedfishClientPkg.dec + +[LibraryClasses] + BaseLib + DebugLib + MemoryAllocationLib + PcdLib + RedfishLib + JsonLib + +[Protocols] + +[Pcd] + gEfiRedfishClientPkgTokenSpaceGuid.PcdDefaultRedfishVersion + +[BuildOptions] + # + # NOTE: /wd4706 disables the following Visual Studio compiler warning in= Jansson: + # "C4706: assignment within conditional expression" + # + MSFT:*_*_*_CC_FLAGS =3D /wd4706 diff --git a/RedfishClientPkg/RedfishClientLibs.dsc.inc b/RedfishClientPkg/= RedfishClientLibs.dsc.inc index ce1c27d884..1cf0406912 100644 --- a/RedfishClientPkg/RedfishClientLibs.dsc.inc +++ b/RedfishClientPkg/RedfishClientLibs.dsc.inc @@ -29,3 +29,4 @@ ConverterCommonLib|RedfishClientPkg/ConverterLib/edk2library/ConverterCo= mmonLib/ConverterCommonLib.inf =20 RedfishEventLib|RedfishClientPkg/Library/RedfishEventLib/RedfishEventLib= .inf + RedfishVersionLib|RedfishClientPkg/Library/RedfishVersionLib/RedfishVers= ionLib.inf diff --git a/RedfishClientPkg/RedfishClientPkg.dec b/RedfishClientPkg/Redfi= shClientPkg.dec index 39b2f5baf8..2ce51d14af 100644 --- a/RedfishClientPkg/RedfishClientPkg.dec +++ b/RedfishClientPkg/RedfishClientPkg.dec @@ -22,6 +22,7 @@ [LibraryClasses] RedfishFeatureUtilityLib|Include/Library/RedfishFeatureUtilityLib.h RedfishEventLib|Include/Library/RedfishEventLib.h + RedfishVersionLib|Include/Library/RedfishVersionLib.h =20 [LibraryClasses.Common.Private] ## @libraryclass Redfish Helper Library @@ -52,4 +53,5 @@ # { 0x7CE88FB3, 0x4BD7, 0x4679, { 0x87, 0xA8, 0xA8, 0xD8, 0xDE, 0xE5, 0x= 0D, 0x2B }} # gEfiRedfishClientPkgTokenSpaceGuid.PcdEdkIIRedfishFeatureDriverStartupEv= entGuid|{0xB3, 0x8F, 0xE8, 0x7C, 0xD7, 0x4B, 0x79, 0x46, 0x87, 0xA8, 0xA8, = 0xD8, 0xDE, 0xE5, 0x0D, 0x2B}|VOID*|0x10000003 - + ## Default Redfish version string + gEfiRedfishClientPkgTokenSpaceGuid.PcdDefaultRedfishVersion|L"v1"|VOID*|= 0x10000004 --=20 2.32.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91781): https://edk2.groups.io/g/devel/message/91781 Mute This Topic: https://groups.io/mt/92596782/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-