From nobody Mon May 6 03:31:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91639+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91639+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1658409110; cv=none; d=zohomail.com; s=zohoarc; b=ffoQqM2eCIJQiIyPxt72KtAijKMgUrqW524lwA6VzLe2cdDtT+urq7QaNGZfmIdlFWpQYlCRx+B4EtrWTjcVXGZGF0BdEs9UPmjuUX8rTAPppZzTqO8vvN9Ugy/608np5mYrMn7gYvUn+0koStzqTCtYlqKsALP7lm5kICUmysI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658409110; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=iHLLXmEVnKW3vayW3INQH3iX+qH3OZyn694L/idm1qw=; b=b68dWWREzTw1WuJat+x+XaZuncWFDXl5v45ata0iyH1r0BRug8VvrB0Tp6ek+0qHzl4JorA11Ah5/ScmqDtGDz+mxRDQXooNSOnIdgDBltq/DzoXN/dQpVtTHoBivjZvciuCzP+VCLemnXqrtPJlj2MwhbEnXcP2c6/8JOi1nlw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91639+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658409110177921.1140225313802; Thu, 21 Jul 2022 06:11:50 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id nJxIYY1788612xnXcB72SFJj; Thu, 21 Jul 2022 06:11:49 -0700 X-Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mx.groups.io with SMTP id smtpd.web10.6141.1658409108582074374 for ; Thu, 21 Jul 2022 06:11:48 -0700 X-Received: by mail-lj1-f171.google.com with SMTP id r14so1772142ljp.2 for ; Thu, 21 Jul 2022 06:11:48 -0700 (PDT) X-Gm-Message-State: DUqnWtZz9gUJ2oiIuGaZrXigx1787277AA= X-Google-Smtp-Source: AGRyM1vC2WJAt4UTSzzo7yJEq/3bz3qCngwNu/vnp/Dee1zUMypVB6/QQX4Xs9jXYyfiBReOHYPCMg== X-Received: by 2002:a05:651c:1609:b0:25a:86a5:9eab with SMTP id f9-20020a05651c160900b0025a86a59eabmr18468544ljq.61.1658409106546; Thu, 21 Jul 2022 06:11:46 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id i11-20020a2e940b000000b0025a7304653csm283256ljh.40.2022.07.21.06.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 06:11:45 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH] BaseTools/VolInfo: Increase GUID base name string Date: Thu, 21 Jul 2022 16:11:48 +0300 Message-Id: <20220721131148.12360-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658409109; bh=bWxBVmA+CYJQPUmzmEsVrIrLExEAfYYj9IMbmIOzA6Y=; h=Cc:Date:From:Reply-To:Subject:To; b=Z/pP6w53hbQnxvvVDOX/DBB+Ht0MIt/5FbCmaiyNsnhkTN2VNZVMnHgbzkrVZKPvlj5 8rvNHkgXwtbGoLy9EHWrtG9i4ES9uJpZUIq3E2MaCGgCllGbC7JI0p9A5JUXwyiRiQqyS 1ol3THjhLJ+0QZCW/2hSGp67WyesqXVVfco= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658409110511100001 Content-Type: text/plain; charset="utf-8" The current string lenght (=3D60) is not enough for cases where basename is a path to Build folder. Drop custom define and use MAX_LINE_LEN from the BaseTools codebase instead. Signed-off-by: Konstantin Aladyshev Reviewed-by: Bob Feng --- BaseTools/Source/C/VolInfo/VolInfo.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolI= nfo/VolInfo.c index 4628e756d7..d9be3d8c18 100644 --- a/BaseTools/Source/C/VolInfo/VolInfo.c +++ b/BaseTools/Source/C/VolInfo/VolInfo.c @@ -51,15 +51,13 @@ EFI_GUID gEfiCrc32GuidedSectionExtractionProtocolGuid = =3D EFI_CRC32_GUIDED_SECTIO =20 #define EFI_SECTION_ERROR EFIERR (100) =20 -#define MAX_BASENAME_LEN 60 // not good to hardcode, but let's be reason= able - // // Structure to keep a list of guid-to-basenames // typedef struct _GUID_TO_BASENAME { struct _GUID_TO_BASENAME *Next; INT8 Guid[PRINTED_GUID_BUFFER_SIZE]; - INT8 BaseName[MAX_BASENAME_LEN]; + INT8 BaseName[MAX_LINE_LEN]; } GUID_TO_BASENAME; =20 static GUID_TO_BASENAME *mGuidBaseNameList =3D NULL; --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91639): https://edk2.groups.io/g/devel/message/91639 Mute This Topic: https://groups.io/mt/92526015/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-