From nobody Tue Apr 30 02:22:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91530+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91530+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1658238278; cv=none; d=zohomail.com; s=zohoarc; b=i6ig0Zn8otFsM9V2lOOvQocw2FTWBC9cWcQHzkbusUuR/iLzJ8wMZjAOcfJpFvbos594UEbL1tpL5GrI5GJlTNqkZHCS09m5bRyTnlbEyD71hXavxl0wkymoPmY8lh3AOAQffYMJEJ9+BsANf5DVMizea0oG8gbxFXb/weAg8Wg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658238278; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=jcqB9/EFzyl3Z7ogSmliwQ/MxSMWakcz30TEOIiPNTA=; b=d+O0H5BkImgf9uP+nQJ2kZ9m+jneWYLnd5Qm41NLaB+2nui8+BOPW8ZH7v6IZRWHJMHWjRByJS+XdiPetZlpkm+iTZc7cGEB73hIU6r79iSmMBmq2ByU3Xg7A1MdnVQgHbmZNF6OxYruv4tHraJ8rDoql/cFbjV7jnQxquW34Ig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91530+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658238278394246.44150970320482; Tue, 19 Jul 2022 06:44:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id h8L7YY1788612xQmpf5b4nzz; Tue, 19 Jul 2022 06:44:38 -0700 X-Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by mx.groups.io with SMTP id smtpd.web12.40778.1658238276903541328 for ; Tue, 19 Jul 2022 06:44:37 -0700 X-Received: by mail-lj1-f182.google.com with SMTP id o12so17430234ljc.3 for ; Tue, 19 Jul 2022 06:44:36 -0700 (PDT) X-Gm-Message-State: SBEWrdtxOEVZZNYl10yGsrSTx1787277AA= X-Google-Smtp-Source: AGRyM1usc/RhUMZ/963+xV3hMqu6dE+kxti5LO9j/ScT+41S5syV3sRQUkomk5uILtv2aS9tUwf0jw== X-Received: by 2002:a2e:87ca:0:b0:25d:795c:6db7 with SMTP id v10-20020a2e87ca000000b0025d795c6db7mr15443001ljj.241.1658238274767; Tue, 19 Jul 2022 06:44:34 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id e9-20020a2eb1c9000000b0025d762cee0esm2677804lja.10.2022.07.19.06.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 06:44:34 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH] BaseTools/VolInfo: Correct buffer for GenCrc32 tool Date: Tue, 19 Jul 2022 16:44:35 +0300 Message-Id: <20220719134435.8054-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658238278; bh=QpL1vlR8k043bNfH9zxGPE8X1+eU8/MfBRH2cMq7m88=; h=Cc:Date:From:Reply-To:Subject:To; b=kQFwSF575lhdmojGEtYV8JDCB/KvkE5tKM9l/nnBm6z1U4rEtD6EkeJO5L1Q4KoVOLz gT0Ppb7lBQ6QhM9zF8dqyhslOFLldkygukwHPg+ke2Ca2u1/d3VqbMr8sXiG8P95Ob4px 6wQy0wJMu9GYgV0eB6bKRtYX3gbPZKGqqrg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658238279881100002 Content-Type: text/plain; charset="utf-8" If the guided section was encoded with GenCrc32 tool the resulting 'EFI_GUID_DEFINED_SECTION.DataOffset' field points to the start of the meaningfull data that follows the CRC32 value. But if we want to decode the section with GenCrc32 tool we need to provide a buffer that includes the CRC32 value itself. Signed-off-by: Konstantin Aladyshev Reviewed-by: Bob Feng --- BaseTools/Source/C/VolInfo/VolInfo.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolI= nfo/VolInfo.c index f450796f9c..47a8f80f46 100644 --- a/BaseTools/Source/C/VolInfo/VolInfo.c +++ b/BaseTools/Source/C/VolInfo/VolInfo.c @@ -1999,6 +1999,13 @@ Returns: ); free (ExtractionTool); =20 + if (!CompareGuid ( + EfiGuid, + &gEfiCrc32GuidedSectionExtractionProtocolGuid + ) + ) { + DataOffset -=3D 4; + } Status =3D PutFileImage ( ToolInputFile, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91530): https://edk2.groups.io/g/devel/message/91530 Mute This Topic: https://groups.io/mt/92482555/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-