From nobody Mon Feb 9 09:08:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91652+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91652+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1658424091; cv=none; d=zohomail.com; s=zohoarc; b=I4ckRa2S4ogariTD2wrQiUoj6BTP7qjFhpYwQ2LbMmm5NI2LmSR7JG0lcrAJvRPhXeALT0LtWt6GM2U5b0wcUD3ObxRr2c0SclAISlUecH0hqUwlboH+25OPxLD3bevsd7kWDWkyr2oEE4f03u+MrToWsg5XJxB7eR1sxei0yOc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658424091; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=e4Wc6aN219B6fewTlEW3MPBb9bBC7QDXyh6CocPOEnM=; b=alIrUkM60ugR9rEqCA8yYsX0ez+a8qSdNMKd2WYwqr6r2/VYRotbA47cefSGOXcFwBqFPK1RV1cKVs+Ppkxd6lfSQkPZLXpC7UdRBneesIZ5REFHGn0QQlVps1YyFRJgvGXaun6xCW6+L9/K8tMYtyh+1gEiZn2mDdZXWRaZdN4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91652+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658424091990192.355111042359; Thu, 21 Jul 2022 10:21:31 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id F2odYY1788612xbQx2yAJVIA; Thu, 21 Jul 2022 10:21:31 -0700 X-Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mx.groups.io with SMTP id smtpd.web11.39809.1658232643333907367 for ; Tue, 19 Jul 2022 05:10:43 -0700 X-Received: by mail-lj1-f171.google.com with SMTP id by8so13518848ljb.13 for ; Tue, 19 Jul 2022 05:10:43 -0700 (PDT) X-Gm-Message-State: oIebGSVFhDLvihPC0Ubo393qx1787277AA= X-Google-Smtp-Source: AGRyM1vVFkI6FQ6LU6kNnsKBkcM90Hw98m6Akv0ScldcMdAKWxsEgd2UvI9fn4sTVDwpv3bwrXCrnQ== X-Received: by 2002:a2e:a7cf:0:b0:25d:6b92:9c1a with SMTP id x15-20020a2ea7cf000000b0025d6b929c1amr13814596ljp.107.1658232641464; Tue, 19 Jul 2022 05:10:41 -0700 (PDT) X-Received: from localhost.localdomain ([207.180.219.167]) by smtp.gmail.com with ESMTPSA id z20-20020a2eb534000000b0025d6ecbc897sm2668245ljm.46.2022.07.19.05.10.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2022 05:10:41 -0700 (PDT) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-devel] [edk2-platforms][PATCH 06/10] Ext4Pkg: Drop dir entry name_len limit extra check Date: Tue, 19 Jul 2022 18:10:12 +0600 Message-Id: <20220719121016.29380-7-savvamtr@gmail.com> In-Reply-To: <20220719121016.29380-1-savvamtr@gmail.com> References: <20220719121016.29380-1-savvamtr@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,savvamtr@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658424091; bh=tfnbq1J/mC6QbXdwJiA88xiDCjw+jev1oolbjl70Z6k=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=tp1hWUSd3IIoVxhH636Gy5Mxvn+9zq7AfUatu/l3RRECk7Zbw/Hvth4XRymGnLExFJ8 XBit/qy4tAB2jm0nX+SbkFaIsj0kF8zhDaH87Kjps8co0mOu5eDr8mm68lpchdVwIGXva 3URUD2hm8P88r4ZHTy4DFoOC7TuZD9so3YY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658424093468100016 Content-Type: text/plain; charset="utf-8" Field name_len has type CHAR8, while filename limit is 255 (EXT4_NAME_MAX), so because structure EXT4_DIR_ENTRY would be unchangeable in future, we could drop this check without any assertions Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Directory.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Directory.c b/Features/Ext4Pkg/Ext4Dx= e/Directory.c index 682f66ad5525..96c84c24243e 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Directory.c +++ b/Features/Ext4Pkg/Ext4Dxe/Directory.c @@ -160,17 +160,6 @@ Ext4RetrieveDirent ( return EFI_VOLUME_CORRUPTED; } =20 - // Ignore names bigger than our limit. - - /* Note: I think having a limit is sane because: - 1) It's nicer to work with. - 2) Linux and a number of BSDs also have a filename limit of 255. - */ - if (Entry->name_len > EXT4_NAME_MAX) { - BlockOffset +=3D Entry->rec_len; - continue; - } - // Unused entry if (Entry->inode =3D=3D 0) { BlockOffset +=3D Entry->rec_len; --=20 2.37.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91652): https://edk2.groups.io/g/devel/message/91652 Mute This Topic: https://groups.io/mt/92531468/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-