From nobody Mon Feb 9 09:34:48 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91650+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91650+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1658424091; cv=none; d=zohomail.com; s=zohoarc; b=VUE9/dTwiWBRmVE8DEiC2jfw74gxsndQL8om9QFyMc0obrsst/NC/J+3RqVHrxUg9C3g+PiphornQNPcucgnvX0gek07VHsJK8xNOQHtu5NMZlpjflKBA8P3RxR2B/OsF1zPfI71Z0jKtTZDNBSL/SqN8lGHPc5z0QYQHTyGi1Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658424091; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=onV0gY/1/2qft4+nU42Ig++mCkewBIP6uXaPqpU71Ts=; b=LTtZty4d+mG4GcGEHgbkyY0fbfaDLNmG0YUyWoupIobSy7c7uh3+UuMPlCTYVKsUisn4itCj9ksaiOo5JwWIUGYwiIW0v5Jh+QJdoWePvulDU6uACpB4Fw9QTNs2xGSAKMcgmAamzDPH23dFD327MdVHioeQgJX1oapR8R9t/aM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91650+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658424091441243.4380087033163; Thu, 21 Jul 2022 10:21:31 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 3VytYY1788612xt4IW8QFiSw; Thu, 21 Jul 2022 10:21:31 -0700 X-Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by mx.groups.io with SMTP id smtpd.web11.39808.1658232639998351887 for ; Tue, 19 Jul 2022 05:10:40 -0700 X-Received: by mail-lj1-f181.google.com with SMTP id v15so13383512ljc.1 for ; Tue, 19 Jul 2022 05:10:39 -0700 (PDT) X-Gm-Message-State: qOFeZFhfyUBkqWoMsA4BCIfEx1787277AA= X-Google-Smtp-Source: AGRyM1u5H5yJ3nH9Ps5OU2gv65jtJnv3tIzFyQLkvuL4M5LQrVF6uJ4cDvATy5GJYF4bxScm03u+9w== X-Received: by 2002:a2e:9dd0:0:b0:25d:46d7:6bd with SMTP id x16-20020a2e9dd0000000b0025d46d706bdmr14464072ljj.502.1658232638067; Tue, 19 Jul 2022 05:10:38 -0700 (PDT) X-Received: from localhost.localdomain ([207.180.219.167]) by smtp.gmail.com with ESMTPSA id z20-20020a2eb534000000b0025d6ecbc897sm2668245ljm.46.2022.07.19.05.10.36 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2022 05:10:37 -0700 (PDT) From: "Savva Mitrofanov" To: devel@edk2.groups.io Cc: =?UTF-8?q?Marvin=20H=C3=A4user?= , Pedro Falcato , Vitaly Cheptsov Subject: [edk2-devel] [edk2-platforms][PATCH 04/10] Ext4Pkg: Use assertion in Ext4CalculateChecksum Date: Tue, 19 Jul 2022 18:10:10 +0600 Message-Id: <20220719121016.29380-5-savvamtr@gmail.com> In-Reply-To: <20220719121016.29380-1-savvamtr@gmail.com> References: <20220719121016.29380-1-savvamtr@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,savvamtr@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658424091; bh=/GLPqArL7TfOp/Npi10gT+sFMZZYoxlZAbJ8U+miqVI=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=LhLVi8LAh6N9cI5mnJKGGbSAFE1rtXvVGXJOO2lvqGeHQT8ddp//EKdMEciVkdxKTFw LqOMUT7dakN3HEEhYVlL0sMtsqUBb0WKpUf2rWh70NB+zmy5i5dgQEJEKc1Ockge+gaar liis0mH6S5rdoscgWrlqPMF8QbrdpwnG8QU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658424093459100015 Content-Type: text/plain; charset="utf-8" Replaced UNREACHABLE with ASSERT (FALSE) in case of new checksum algorithms, due to it is an invariant violation rather than unreachable path Cc: Marvin H=C3=A4user Cc: Pedro Falcato Cc: Vitaly Cheptsov Signed-off-by: Savva Mitrofanov --- Features/Ext4Pkg/Ext4Dxe/Superblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Features/Ext4Pkg/Ext4Dxe/Superblock.c b/Features/Ext4Pkg/Ext4D= xe/Superblock.c index 47fc3a65507a..42762b6aa780 100644 --- a/Features/Ext4Pkg/Ext4Dxe/Superblock.c +++ b/Features/Ext4Pkg/Ext4Dxe/Superblock.c @@ -342,7 +342,7 @@ Ext4CalculateChecksum ( // For some reason, EXT4 really likes non-inverted CRC32C checksums,= so we stick to that here. return ~CalculateCrc32c(Buffer, Length, ~InitialValue); default: - UNREACHABLE (); + ASSERT (FALSE); return 0; } } --=20 2.37.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91650): https://edk2.groups.io/g/devel/message/91650 Mute This Topic: https://groups.io/mt/92531466/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-