From nobody Mon Apr 29 03:25:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91526+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91526+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1658224188; cv=none; d=zohomail.com; s=zohoarc; b=R8WQJSeCJX488+ylQjVSh9mqKsiJwskGSGDDIvUVmrurPnZCysofDsO7f3xRGumQSnRbvScckdQozOjaMl7QYfAsKF5jgj7kkbjtOagrcndkDrO+Dc94PKYL3pxicUvq7xernJgjZ0/+FXmbDhMKRoG4qTgZ/YPyQ0uDQb2D0nA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658224188; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=D5OLu0JXZGSymq/4N0ggYb7ZDbuc4QsAXAzmcwfhW7A=; b=TosrvSC13/Dkcp7QrJ+b4fD9FLn94C7p2oxO7nydqak0iu98iQWvOjNcSw6AZBqm44OOdaU3UG864mhpDpr4VXTQIruJExl0pz2xMags2ekEh9NA9d7FbEaQtmFEKzHhqjKa2ggI1+E0bWI80gXpFpaRYnhyn44fToYOesfhDrs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91526+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658224188022585.9935345977055; Tue, 19 Jul 2022 02:49:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id aDHsYY1788612x8lcH6RhS2t; Tue, 19 Jul 2022 02:49:46 -0700 X-Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) by mx.groups.io with SMTP id smtpd.web11.38742.1658224185600713663 for ; Tue, 19 Jul 2022 02:49:45 -0700 X-Received: by mail-lj1-f169.google.com with SMTP id w2so16720030ljj.7 for ; Tue, 19 Jul 2022 02:49:45 -0700 (PDT) X-Gm-Message-State: jvdWGYcJxlSVyKgo5W7wmKaDx1787277AA= X-Google-Smtp-Source: AGRyM1vUBTXaak0eRaBDuFctmFHyz4H9qUw2JXqe6g5oqlaEgkghiwUZQHFu1979WaaUWFz6Lu8DJg== X-Received: by 2002:a2e:9f4e:0:b0:25d:659b:8ba6 with SMTP id v14-20020a2e9f4e000000b0025d659b8ba6mr13548975ljk.69.1658224183590; Tue, 19 Jul 2022 02:49:43 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id u4-20020a2eb804000000b0025d6cc7513bsm2568455ljo.116.2022.07.19.02.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 02:49:43 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: bob.c.feng@intel.com, gaoliming@byosoft.com.cn, yuwei.chen@intel.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH] BaseTools/VolInfo: Fix EFI_SECTION_GUID_DEFINED parsing Date: Tue, 19 Jul 2022 12:49:42 +0300 Message-Id: <20220719094942.992-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658224186; bh=K913PGms3HTYxnCQuquiqVVtyE6pTvjYq2AIUJj01MM=; h=Cc:Date:From:Reply-To:Subject:To; b=RHxVJ/7zHhBbkBpuEh4ljW6wOQu/dD3kOliAL6snKeOI5RzRFwoobG5CgTzBSyrsxUt dtWwj3K8gr6jD1ZwMrEdSVKYa3hnh9IAunaRVsn9eMKYFGaYp/0jprw7AE7HuEIyKcBS4 OC6oZmHPlpz1eD0xcX1obZHHzOvGhTi6g+Q= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658224189744100003 Content-Type: text/plain; charset="utf-8" Currently 'PutFileImage' function is called with arguments that are not advanced on each section parsing. This would lead to an error if EFI_SECTION_GUID_DEFINED is not the first in a file. Use correct arguments to fix the issue. Signed-off-by: Konstantin Aladyshev Reviewed-by: Liming Gao --- BaseTools/Source/C/VolInfo/VolInfo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/VolInfo/VolInfo.c b/BaseTools/Source/C/VolI= nfo/VolInfo.c index ed56587058..c1f81f2dcb 100644 --- a/BaseTools/Source/C/VolInfo/VolInfo.c +++ b/BaseTools/Source/C/VolInfo/VolInfo.c @@ -2000,8 +2000,8 @@ Returns: Status =3D PutFileImage ( ToolInputFile, - (CHAR8*) SectionBuffer + DataOffset, - BufferLength - DataOffset + (CHAR8*)Ptr + DataOffset, + SectionLength - DataOffset ); =20 system (SystemCommand); --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91526): https://edk2.groups.io/g/devel/message/91526 Mute This Topic: https://groups.io/mt/92479030/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-