From nobody Mon Feb 9 08:29:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91454+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91454+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1658150328; cv=none; d=zohomail.com; s=zohoarc; b=ZBzHp4Wm0/t8hf7lAhPOYJfImsLG645uInaH+7OEHSTRRCZB7xyY6gIjGdmlMhGfA5mWsxS6J76IyZD3sVvV+K1eN/Tfw54UvyYf17++dcJg4X1odM/Y7R2bxjlkj+9MUf2VkazS/GtUSumv+UGNoNEzKLRBF2kpGLJeTYIDFTU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658150328; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=NH9pPbtUpJgMByPzHbw3dUuZ7/fl1KugRLoukySgQL4=; b=KV9LYdME9hGorOeuF6fSrr5zc4jg5YNmCWoP+3NyFn4e3RRceL0rDMevoR7f6kG31VxWx8/pKjJyf/YELroCN0B23IX3CkgtNY/vZ3P86LGYnZeFb5BdNrc2tGhRgYu25MhbsBLh33LwhZ4TOI3Ylgo22EazP9RArXN3+rBy4sQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91454+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1658150328440820.9923995129944; Mon, 18 Jul 2022 06:18:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id v35DYY1788612xPeSLQNO4jK; Mon, 18 Jul 2022 06:18:48 -0700 X-Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.26914.1658150326443022020 for ; Mon, 18 Jul 2022 06:18:46 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10411"; a="287363892" X-IronPort-AV: E=Sophos;i="5.92,281,1650956400"; d="scan'208";a="287363892" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 06:18:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,281,1650956400"; d="scan'208";a="624724967" X-Received: from shwdeopenlab706.ccr.corp.intel.com ([10.239.183.102]) by orsmga008.jf.intel.com with ESMTP; 18 Jul 2022 06:18:42 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Zhiguang Liu , Eric Dong Subject: [edk2-devel] [PATCH 03/10] CpuPageTableLib: Fix a bug when a bit is 1 in Attribute, 0 in Mask Date: Mon, 18 Jul 2022 21:18:24 +0800 Message-Id: <20220718131831.660-4-ray.ni@intel.com> In-Reply-To: <20220718131831.660-1-ray.ni@intel.com> References: <20220718131831.660-1-ray.ni@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com X-Gm-Message-State: 8NI1VCF8te0tfCbG4jCAOqZOx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1658150328; bh=jLG01Yy0J8Xj8oeogHSXF7cC2ez4kBii3hAiOaWP5fc=; h=Cc:Date:From:Reply-To:Subject:To; b=wlF6tiZE5mi+o6OCU5WJcRlcC30KGXhPYdNOTvP7MaQ8IyxnZO8AXMYDSlYt9TzodL+ h5GcSSK3YvnLqdcjV2IrUSRvSGg8+OcWZWj7NFL1DAmFiK8tj03v8U4sOzHUqm7XeuHTn OPgYkpKBU0LuwBqb7Q9qp12bhfn+c/3/LYM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1658150329545100011 Content-Type: text/plain; charset="utf-8" To reproduce the issue: UINTN PageTable; VOID *Buffer; UINTN PageTableBufferSize; IA32_MAP_ATTRIBUTE Attribute; IA32_MAP_ATTRIBUTE Mask; RETURN_STATUS Status; Attribute.Uint64 =3D 0; Mask.Uint64 =3D 0; PageTableBufferSize =3D 0; PageTable =3D 0; Buffer =3D NULL; Attribute.Bits.Present =3D 1; Attribute.Bits.Nx =3D 1; Mask.Bits.Present =3D 1; Mask.Uint64 =3D MAX_UINT64; // // Create page table to cover [0, 10M) // Status =3D PageTableMap ( &PageTable, PagingMode, Buffer, &PageTableBufferSize, 0, (UINT64)SIZE_2MB * 5, &Attribute, &Mask ); ASSERT (Status =3D=3D RETURN_BUFFER_TOO_SMALL); Buffer =3D AllocatePages (EFI_SIZE_TO_PAGES (PageTableBufferSize)); Status =3D PageTableMap ( &PageTable, PagingMode, Buffer, &PageTableBufferSize, 0, (UINT64)SIZE_2MB * 5, &Attribute, &Mask ); ASSERT (Status =3D=3D RETURN_SUCCESS); // // Change the mapping for [0, 4KB) // No change actually. Just clear Nx bit in Mask. // Mask.Bits.Nx =3D 0; PageTableBufferSize =3D 0; Status =3D PageTableMap ( &PageTable, PagingMode, NULL, &PageTableBufferSize, 0, (UINT64)SIZE_4KB, &Attribute, &Mask ); ASSERT (Status =3D=3D RETURN_SUCCESS); // FAIL!! The root cause is when comparing the existing mapping attributes against the requested one, Mask is not used but it should be used. Signed-off-by: Zhiguang Liu Reviewed-by: Ray Ni Cc: Eric Dong --- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c b/UefiCpu= Pkg/Library/CpuPageTableLib/CpuPageTableMap.c index 17bca5e351..429b014b7b 100644 --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c @@ -308,7 +308,7 @@ PageTableLibMapInLevel ( // PleBAttribute.Uint64 =3D PageTableLibGetPleBMapAttribute (&ParentPagin= gEntry->PleB, &NopAttribute); if ((IA32_MAP_ATTRIBUTE_ATTRIBUTES (&PleBAttribute) & IA32_MAP_ATTRIBU= TE_ATTRIBUTES (Mask)) - =3D=3D IA32_MAP_ATTRIBUTE_ATTRIBUTES (Attribute)) + =3D=3D (IA32_MAP_ATTRIBUTE_ATTRIBUTES (Attribute) & IA32_MAP_ATTRI= BUTE_ATTRIBUTES (Mask))) { // // This function is called when the memory length is less than the r= egion length of the parent level. --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91454): https://edk2.groups.io/g/devel/message/91454 Mute This Topic: https://groups.io/mt/92458159/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-