From nobody Tue Feb 10 02:50:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91263+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657636320813468.0343921695089; Tue, 12 Jul 2022 07:32:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id YgpHYY1788612xhxw5JRVk9L; Tue, 12 Jul 2022 07:32:00 -0700 X-Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.89]) by mx.groups.io with SMTP id smtpd.web09.9983.1657636319496383120 for ; Tue, 12 Jul 2022 07:32:00 -0700 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XnPMnuKIkmE14PpdY3TqQW+JoNLLA81ZBX8rajFSxkeQdXNYq1wBH/9ziD6vScBXU9iC/d2RgIlyUm4RxrjahILETPVMVsXf3JrOd4f2ioc5Cw4cWTYc7oH1YpmB9hU7bmU1qRK3x9paMHk0nGQGjzUbYn4bp/JYKlP67pSsxecoUe8xjK/9PyTuvdbXPzQhRWD1nYbbKdVm6Nhf967uCga4589YTD9G5zwPcVfkhl1mqh/yXVvWoXexU39QNEwYtCGCLnXOKV/Rvw0Gp31WAON/D1G05wKnVHi+coIk4ocPTm7ZVrI6pS7knX505LAa0q/FoVzthdi7d9DjGvnHTw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JFijKxXiPpcYd99fvUapkXh7HZxHDlWm2buaF7jlr/o=; b=H5Dju5CV8Zf4PULt9vkQPMr12y5ZQLmfuE04kATyFaxMEWs8nJGEegexxVWj80RvsunHpKYJ6YJ56qIHzFz73PYX953WiypYKRqkXARAx0ruGGjB0yOJp2W4TRUuVUekJ42PRNjsFjg5j9PuVVo48QWWO3RDQZd5d5IqlfM4T9KRcL9EV5HsW2KuKHIyt682fb3zxR6VyeOxyy3sUxGAlJyBWUZb+1CD8of2pMsU5K0pnsOQ2NOBAeJohg/r6deOWy7ZpnSFanbbBmgUxDS0WWwTcMWqEdgnVcRkrToJ8XNKZq+cFKsaRyc0c42rWWcFGXX+KGu5KoNys35oMBFxCw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) X-Received: from DB7PR05CA0033.eurprd05.prod.outlook.com (2603:10a6:10:36::46) by PR3PR08MB5596.eurprd08.prod.outlook.com (2603:10a6:102:88::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Tue, 12 Jul 2022 14:31:56 +0000 X-Received: from DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::1c) by DB7PR05CA0033.outlook.office365.com (2603:10a6:10:36::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Tue, 12 Jul 2022 14:31:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91263+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT044.mail.protection.outlook.com (100.127.142.189) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 14:31:56 +0000 X-Received: ("Tessian outbound 13cb25bfb745:v122"); Tue, 12 Jul 2022 14:31:56 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 51caef041dbd4e34 X-CR-MTA-TID: 64aa7808 X-Received: from 3582e2e51cc6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 380BDE67-0E01-422D-8499-ED4559BA2604.1; Tue, 12 Jul 2022 14:31:48 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3582e2e51cc6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 12 Jul 2022 14:31:48 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S1zt7WzIoWhBgO1CGuQ3yHyfvycAiTPCXOWO7kxuqkknmhvKDzF32KHa9X1vgdrOuE71IIe+SzKhggXXumAP8K8TdxZ+opO1HmlNdMA6qETxvKS5chZTBV4PuBUwk+zBFY/Kt3uvMXdNpZ1wyhuQV5YRekSapGck4KXfJR9g+3cPIDk0FbrtbkZIeduiQRAQuWkcc8CqarY7NwpKP+fgXicfYGatAtvH2J2ICSWEJt87WwdorGx8SE0LhjfP9nkgzb4tb/UorSdvv6lGgA9Z/CcyyVRgDuizLfNYmDuNYvoHrzhu4Zp/J5mow8MfU+2AUwMPEo1ehuQZDQud532kFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JFijKxXiPpcYd99fvUapkXh7HZxHDlWm2buaF7jlr/o=; b=Ny96Hp+fsPKctohtGhy1Zb+lbwF//kz9nmvj3cYuq13pPz2sU4nyczgnHVEGEOPiXYWYyCIsN/8iE+S/K4H2GB2Ja/Qfu4Y/H76ltJgKxOQUIiUvRMAXXGjI1rLLKw0SZb78tm/yu3sfBsRqCHLr32e38qgolzccN2xfESdjJ1Zen3CQ/01o4BLcZYmPVUXf9f9eeaNymCFsZXH8VD+HNngqXBLlZbTUqUaxLVCdi++Vc7dbvBf5Mn98CUm6216123j9zAbm/Vb3JStOniUS9vA3nuML1AZQxGIoDHYomuOXzHf6so0pxjO7xsCvjg2djnnHr/1Tc863Z/dqHmZDog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS9PR06CA0393.eurprd06.prod.outlook.com (2603:10a6:20b:461::34) by DBBPR08MB5962.eurprd08.prod.outlook.com (2603:10a6:10:202::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Tue, 12 Jul 2022 14:31:46 +0000 X-Received: from AM5EUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::d2) by AS9PR06CA0393.outlook.office365.com (2603:10a6:20b:461::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 14:31:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT025.mail.protection.outlook.com (10.152.16.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 14:31:46 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 12 Jul 2022 14:31:44 +0000 X-Received: from E114225.Arm.com (10.1.196.36) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 12 Jul 2022 14:31:43 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , Subject: [edk2-devel] [PATCH v5 3/8] DynamicTablesPkg: IORT set reference to Id array only if present Date: Tue, 12 Jul 2022 15:31:36 +0100 Message-ID: <20220712143141.18516-4-sami.mujawar@arm.com> In-Reply-To: <20220712143141.18516-1-sami.mujawar@arm.com> References: <20220712143141.18516-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 85c454f9-cd9f-474c-9d71-08da64134595 X-MS-TrafficTypeDiagnostic: DBBPR08MB5962:EE_|DBAEUR03FT044:EE_|PR3PR08MB5596:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CzONwzAriYNKjm9dzLyFXYYhWZodfujZgdG3U99opt8c6U45LJdZc3bIDROEu39e4Igbl6Rgc8KlO6z0dSvHt6tYAR2gvBL0p6EzfLxGCnbWVoSqMPH5NpFL+SjEWjT1gddcW8IndJfgm6uJr6YCBN2wYjuouFHixzkpKPUnEEoI2dhF07JLQtmBhP3g0FQNY3wg3G51w/L7GRsPopgsuCp+Jb53VNEUqEIPYJm0u0F9E3N2UgYkcROh2os3VjTdG2ohjYG/jXwuMdHaPlcFvZFg0ECrEhlN6i+/yT3wdrkw4MWNrUApeWU9CtZQlZUFxZB8f7U+ETL1JP0AOTzQd9y9AQKztHSrawRtkbs7pynuMEoCeWzt9HlDvJySKrk5YFTcu2Do0Sn1c9IjwCHVLP0NWJKqeK6dZb/BWtsZuHbiIzOz3gL4Lm6bojR6A+eguhMo8wgegV4B1jCPpmH3MEdq0OVWQiXX2/zvs4qtbuPbxSf9FC6ARvRBJHVRlOoQn0xZ23icy9Q86savslbocg/zpJ68mLAf8dqMmyNw+mY7wvfmdExBETgr0Brq0ge+2/Dy7EPC5ZaqN4mtEiOaNtQVrw/viZbC4xvRI6Wc/VDHd4s8kkNS+vCTPC0khOySbi9NduNvLjcwmvh8PQkOIqZc6yWuSyorR+AErSs4WD8ut0xebaAZBY4yu9btTU5An5f8ObWC7QqW9gEicc/t0pD2vxF3yXKFgcNc6yM10AJTtIit9axcL7qrJQKAD5Gwd2hWRaJZyH1QjRlS3EjpBd/cSZIRN7/vxdLCOJ8emxMk9Qm21jUw86H4RXlPr46C96bvKgjTUgaGDZDERadeP+qSdV7t+mleIkPjZ5JhX78= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(136003)(346002)(46966006)(40470700004)(36840700001)(8676002)(26005)(82310400005)(4326008)(81166007)(356005)(82740400003)(44832011)(5660300002)(478600001)(40460700003)(86362001)(8936002)(7696005)(70206006)(70586007)(316002)(6666004)(36756003)(2616005)(41300700001)(54906003)(36860700001)(2906002)(6916009)(40480700001)(336012)(83380400001)(1076003)(426003)(186003)(47076005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5962 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 07d2f6db-d025-45c4-2187-08da64133fd8 X-Microsoft-Antispam-Message-Info: 2NgKC52zYumnNLjZ0QqY00eKYVWEXCtxDJEfuMwxX4YTfuAQjGYnOjyXD6r+I5EJuUeuNne4AA3GfFBSW2J17lDqbhv9R24iR3aMhxT7Sgdo9UOnI8cJIII1bkZsUMT6pfSHu/k/Mu0OK6n7AjWYKYL2WmEoj/BDIf+VLJUoDPyBTNYrt1Z0W6ZhgbCirdAOO58WZBU1WrlxMJ9noO1tHQDdMXBpeBSnW08fefMUl/DfJqwbKAr0EyrCFLp+AWostrMzJxczv/upR/MDqfNBJbp4Hy3cScdKzd2vlWB3X7fEL3rOU/6dRkmC4Q770xtMYEXkEZqgOMypGkxo/Adnp6b/rh7VIDeeI1PqGoGB72SbRkxvF3fU7IKerbS02a7HaurPn+39fdFNBRYfPjBkTEukdT+bIlDM40HlLmkiIwEgE05zBSOu+9ijt/xa6RjIP2Zkoz2l1cnPbuue2hENlhlQRQ6bcnnRJQ6dS1IvTucNyLWx8GKYJaXRgLEuX1mPjz2X8VgHZCeaZS9zV7A7bN5S16AQ5HpHZ6BvglX9+4gPJfsMrIT+NBfeVrV/gIIzgzSjtlt6F5lallcaJ8jvyU1WazX4winDd0MKiyzfnXE0//UsioQUSPeAgCD14vuIfCXzxTHqPWysK+ysmBgHqeUy5pV/qNb69E4vwQa9NsJFcEvb7o5Kh99LhAAsfuQcGE9QVyQPFnWW04MEKtrHWKJ/JDo2Dlr5PvDc1gTRo7EVgOJF0E1d/DyDk3bh+Rhb0dHSs5kpspqQwZHKpROLtFsUC5M7Av0KZR4KNwfxBwJZNa4/q/JY+PSeZfS8zGbj X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:31:56.0779 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85c454f9-cd9f-474c-9d71-08da64134595 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5596 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: pxEfwOVXAacbnxAYya3XeXvjx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657636320; bh=7QXF8pgm7NFOyJ/6ICEUOUZeZ9Vp2mAPVbsGFCEBb78=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=QziZoXiLkiCo0UnRbehhDR4XaL/Hikd1VjAXtJyVE/UVX5LwaFuXjBtb+xON5V3FA65 hCxvRYwzGJdQCj86X0Dorsdxm2DkQg8a1y9ztpSuVSQqSy/DSlBPuG12aVU3dEWA5k9Ex g9jPaXI5Tj4pNAnhRwMgIACbU3JMEbsvMyo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657636322896100017 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IORT table generator is setting up a reference to ID array for nodes even when the ID Mapping count is zero. This is not an issue as an OS would only access the ID Reference if the ID mapping count is not zero. However, it would be good to set the reference to ID array to zero when the ID Mapping count is zero rather than populating it with an incorrect value. Signed-off-by: Sami Mujawar Reviewed-by: Pierre Gondois --- Notes: v5: - No code change since v1. Re-sending with v5 series. [SAMI] =20 v4: - No code change since v1. Re-sending with v4 series. [SAMI] =20 v3: - No code change since v1. Re-sending with v3 series. [SAMI] =20 v2: - No code change since v1. Re-sending with v2 series. [SAMI] DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 27 ++++= +++++++--------- 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c index daf9ff00c3deab4005814bbfcf1650469d1e7d92..a4dd3d4a895e0a1ae305c937d9a= 413665fb8e171 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c @@ -876,9 +876,9 @@ AddNamedComponentNodes ( NcNode->Node.NumIdMappings =3D NodeList->IdMappingCount; =20 ObjectNameLength =3D AsciiStrLen (NodeList->ObjectName) + 1; - NcNode->Node.IdReference =3D - (UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAPPING_NAMED_COMP_NODE) + - (ALIGN_VALUE (ObjectNameLength, 4))); + NcNode->Node.IdReference =3D (NodeList->IdMappingCount =3D=3D 0) ? + 0 : ((UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAP= PING_NAMED_COMP_NODE) + + (ALIGN_VALUE (ObjectNameLengt= h, 4)))); =20 // Named Component specific data NcNode->Flags =3D NodeList->Flags; @@ -1007,7 +1007,8 @@ AddRootComplexNodes ( RcNode->Node.Revision =3D 1; RcNode->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; RcNode->Node.NumIdMappings =3D NodeList->IdMappingCount; - RcNode->Node.IdReference =3D sizeof (EFI_ACPI_6_0_IO_REMAPPING_RC_NO= DE); + RcNode->Node.IdReference =3D (NodeList->IdMappingCount =3D=3D 0) ? + 0 : sizeof (EFI_ACPI_6_0_IO_REMAPPING_RC_= NODE); =20 // Root Complex specific data RcNode->CacheCoherent =3D NodeList->CacheCoherent; @@ -1188,11 +1189,12 @@ AddSmmuV1V2Nodes ( SmmuNode->Node.Revision =3D 0; SmmuNode->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; SmmuNode->Node.NumIdMappings =3D NodeList->IdMappingCount; - SmmuNode->Node.IdReference =3D sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMM= U_NODE) + - (NodeList->ContextInterruptCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU= _INT)) + - (NodeList->PmuInterruptCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU= _INT)); + SmmuNode->Node.IdReference =3D (NodeList->IdMappingCount =3D=3D 0) ? + 0 : (sizeof (EFI_ACPI_6_0_IO_REMAPPING_= SMMU_NODE) + + (NodeList->ContextInterruptCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING= _SMMU_INT)) + + (NodeList->PmuInterruptCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING= _SMMU_INT))); =20 // SMMU v1/v2 specific data SmmuNode->Base =3D NodeList->BaseAddress; @@ -1360,8 +1362,8 @@ AddSmmuV3Nodes ( SmmuV3Node->Node.Revision =3D 2; SmmuV3Node->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; SmmuV3Node->Node.NumIdMappings =3D NodeList->IdMappingCount; - SmmuV3Node->Node.IdReference =3D - sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU3_NODE); + SmmuV3Node->Node.IdReference =3D (NodeList->IdMappingCount =3D=3D 0)= ? + 0 : sizeof (EFI_ACPI_6_0_IO_REMAPPING= _SMMU3_NODE); =20 // SMMUv3 specific data SmmuV3Node->Base =3D NodeList->BaseAddress; @@ -1491,7 +1493,8 @@ AddPmcgNodes ( PmcgNode->Node.Revision =3D 1; PmcgNode->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; PmcgNode->Node.NumIdMappings =3D NodeList->IdMappingCount; - PmcgNode->Node.IdReference =3D sizeof (EFI_ACPI_6_0_IO_REMAPPING_PMC= G_NODE); + PmcgNode->Node.IdReference =3D (NodeList->IdMappingCount =3D=3D 0) ? + 0 : sizeof (EFI_ACPI_6_0_IO_REMAPPING_P= MCG_NODE); =20 // PMCG specific data PmcgNode->Base =3D NodeList->BaseAddress; --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91263): https://edk2.groups.io/g/devel/message/91263 Mute This Topic: https://groups.io/mt/92334074/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-