From nobody Fri May 17 08:24:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91076+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91076+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657078728; cv=none; d=zohomail.com; s=zohoarc; b=N8zIeGSg7rUgtsB2UbS260LpVznBLyHq3CzFDOnmHC0EaZT5lLWVDfMIzqb5rtP74e9DDzw+xyXF6ch+hDJyqAHAFA3xSKhBzuf6Er6uFXN1PcQNF0KVrqFLj0EVpuLRNsxtc33pfPW9ehD10Imt1VT6gI3+7V+E4lQLLDFtwqM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657078728; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=GgfG9jnEmtzMHr592YLT/4DVh6/fZ5558AEKQMRXnzs=; b=XQ7LNgC1+Ra/Fs550piEPCE8EXJC+uoIE0rocBSyCLUZ63lbDmYhmjZ4ydl543mvqGH45XddsBpnhVIdOkYf0LLrBcEiCrgjVPBgLhMz72MITaqG9NaywXIZT6iSB+BbSH6oLjQYSo4p1pbI5JOAa6H8LywaPcRgAEBySXyISoI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91076+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657078728017138.19596493437462; Tue, 5 Jul 2022 20:38:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tc5WYY1788612xzQBQIEO0zh; Tue, 05 Jul 2022 20:38:47 -0700 X-Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mx.groups.io with SMTP id smtpd.web12.2157.1657078726858443186 for ; Tue, 05 Jul 2022 20:38:47 -0700 X-Received: by mail-pg1-f171.google.com with SMTP id z14so13065721pgh.0 for ; Tue, 05 Jul 2022 20:38:46 -0700 (PDT) X-Gm-Message-State: fO9bOReCWd8ZcgCrZ9qQTDqvx1787277AA= X-Google-Smtp-Source: AGRyM1tmwsPJ1D2WkNuBJ17ML4y5r3x+UkleQeuXmmym2/Kyvp18mS9ycNyqJmH4TPXKsUCnnqy51w== X-Received: by 2002:a63:e05:0:b0:412:91db:a653 with SMTP id d5-20020a630e05000000b0041291dba653mr2178656pgl.446.1657078726241; Tue, 05 Jul 2022 20:38:46 -0700 (PDT) X-Received: from localhost.localdomain ([192.182.149.255]) by smtp.gmail.com with ESMTPSA id a140-20020a621a92000000b005289fbef7c4sm864251pfa.140.2022.07.05.20.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 20:38:45 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [edk2-staging][PATCH v1 1/7] EDK2 Code First: PI Specification: New peripheral subclass for TPM Date: Tue, 5 Jul 2022 20:38:12 -0700 Message-Id: <20220706033818.1493-2-kuqin12@gmail.com> In-Reply-To: <20220706033818.1493-1-kuqin12@gmail.com> References: <20220706033818.1493-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657078727; bh=TGrXERdxj/wZ+HAbi2vvYP1LtDfCjz4pq9GlmBBYT20=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=qT089Dmy6zjXOkwQMaUs1EEfH+tSh68G5AwU//cjyyx1brrGxNAwWqupW6IknN7Cjqk Olt6v3xKFUIZN1UHydUWC+igpPPdkO9cCqryaIkLjW/5Pd6KdihFPbUyQx4V7Ey9L7142 adfQWbZ+N3fVq6wcbUR1V7Mrdj1hjzjbEs4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657078728400100004 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3966 This change includes specification update markdown file that describes the proposed PI Specification v1.7 Errata A in detail and potential impact to the existing codebase. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Kun Qin --- CodeFirst/BZ3966-SpecChange.md | 60 ++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/CodeFirst/BZ3966-SpecChange.md b/CodeFirst/BZ3966-SpecChange.md new file mode 100644 index 000000000000..8a1541bdd577 --- /dev/null +++ b/CodeFirst/BZ3966-SpecChange.md @@ -0,0 +1,60 @@ +# Title: Introduction of `EFI_PERIPHERAL_TPM` Peripheral Subclass Definiti= on + +## Status: Draft + +## Document: UEFI Platform Initialization Specification Version 1.7 Errata= A + +## License + +SPDX-License-Identifier: CC-BY-4.0 + +## Submitter: [TianoCore Community](https://www.tianocore.org) + +## Summary of the change + +Add `EFI_PERIPHERAL_TPM` into Peripheral Subclass definition. + +## Benefits of the change + +Current status code covered various [peripheral subclass definitions](http= s://github.com/tianocore/edk2/blob/master/MdePkg/Include/Pi/PiStatusCode.h). + +As Trusted Platform Module (TPM) becomes more available on the modern syst= ems, status reports from such peripheral are playing more important roles i= n anaylzing the secruity state and healthiness of a system. However, periph= eral subclass definitions do not cover TPM as of today. + +Standardizing the TPM peripheral subclass definition could facilitate the = parsing of peripheral reported errors and avoid potential definition collis= ions from implementation based subclass usages. + +The request of this change intends to expand definitions of `EFI_PERIPHERA= L_**` under Periperhal Subclass definitions to cover the TPM subclass. + +## Impact of the change + +Occupy a new macro definitions of subclass under `Defined Subclasses: User= -Accessible Peripheral Class`. + +## Detailed description of the change [normative updates] + +### Specification Changes + +1. In PI Specification v1.7 Errata A: Vol. 3, Table 3-30: Defined Subclass= es: User-Accessible Peripheral Class, add one new rows below `EFI_PERIPHERA= L_DOCKING` definition and adjust the rest of reserved definitions according= ly: + + | Subclass | Code Name | Description | + | --- | --- | --- | + | Trusted Platform Module | EFI_PERIPHERAL_TPM | The peripheral referr= ed to is a Trusted Platform Module | + | 0x0F=E2=80=930x7F | Reserved for future use by this specification | = | + +1. In PI Specification v1.7 Errata A: Vol. 3, Table 3-84: Defined Subclass= es: User-Accessible Peripheral Class, add one new rows below `EFI_PERIPHERA= L_DOCKING` definition and adjust the rest of reserved definitions according= ly: + + | Subclass | Code Name | + | --- | --- | + | Trusted Platform Module | EFI_PERIPHERAL_TPM | + | 0x0F=E2=80=930x7F | Reserved for future use by this specification. | + +1. In PI Specification v1.7 Errata A: Vol. 3, Section 6.7.2.1 Subclass Def= initions: Prototype, add one new definitions below `EFI_PERIPHERAL_DOCKING`= definition: + + ```c + #define EFI_PERIPHERAL_TPM \ + (EFI_PERIPHERAL | 0x000E0000) + ``` + +### Code Changes + +1. Add macro definitions in `MdePkg/Include/Pi/PiStatusCode.h` to match ne= w specification. +1. Replace existing references of `gEfiSecurityPkgTokenSpaceGuid.PcdStatus= CodeSubClassTpmDevice` from SecurityPkg with new definition. +1. Updated the default value of `gEfiSecurityPkgTokenSpaceGuid.PcdStatusCo= deSubClassTpmDevice` to `(EFI_PERIPHERAL | 0x000E0000)` for consistency and= backwards compatibility outside of SecurityPkg. --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91076): https://edk2.groups.io/g/devel/message/91076 Mute This Topic: https://groups.io/mt/92200212/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 08:24:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91077+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91077+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657078728; cv=none; d=zohomail.com; s=zohoarc; b=Uukj+NlDUtrfO3hA+jLJQF0OkCqxKkn/N02fvNcr7+1vBzvmglpxiLPXmeGe/fYkUXUKTGjBTdzI3Zp1rw9RzY6xujaFf6UKHB3mbA8mC15mveKTGWVpNZW3uC1Wxm0jBqYFPf+JvDAiJR6Ccignu4R14Dtt0Orhiia7IIYKGGE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657078728; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=tVjwAOa7ymaETGrNMKiZr1ziEJg6JpgU4A3kfQGpDb8=; b=RNsdgiHIofh3trwoLenfJYI7I3CFlarE6FPsEQGKQ75YFwwnltXR17Nxq0qiVtHS6f6VrPOGNy2Ury/2Ol98GxivEQNiTK/bKJZ8EoZF11ZllPdDr6/pDQqbD9MSDkHSBJwbwvBkBZ3dhYSo/XcK4mum3x/b/v83fb4LzdsQXMM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91077+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657078728553370.36827857731214; Tue, 5 Jul 2022 20:38:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Gmh2YY1788612x3tfmgyNK85; Tue, 05 Jul 2022 20:38:48 -0700 X-Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mx.groups.io with SMTP id smtpd.web12.2158.1657078727605470293 for ; Tue, 05 Jul 2022 20:38:47 -0700 X-Received: by mail-pj1-f54.google.com with SMTP id o31-20020a17090a0a2200b001ef7bd037bbso9226179pjo.0 for ; Tue, 05 Jul 2022 20:38:47 -0700 (PDT) X-Gm-Message-State: 2BekSHPy3vKqYG4R5YtPXFT1x1787277AA= X-Google-Smtp-Source: AGRyM1vs+7HWXN6TKPD2Iu29J6+6IBFT5413L2U+frDv5YGHThaslfIUFizaOduEOSCt0aTVsxWo9g== X-Received: by 2002:a17:90b:3802:b0:1ed:2434:eb44 with SMTP id mq2-20020a17090b380200b001ed2434eb44mr48263062pjb.85.1657078727104; Tue, 05 Jul 2022 20:38:47 -0700 (PDT) X-Received: from localhost.localdomain ([192.182.149.255]) by smtp.gmail.com with ESMTPSA id a140-20020a621a92000000b005289fbef7c4sm864251pfa.140.2022.07.05.20.38.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 20:38:46 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [edk2-staging][PATCH v1 2/7] MdePkg: MmCommunication: Add TPM subclass definition to MdePkg Date: Tue, 5 Jul 2022 20:38:13 -0700 Message-Id: <20220706033818.1493-3-kuqin12@gmail.com> In-Reply-To: <20220706033818.1493-1-kuqin12@gmail.com> References: <20220706033818.1493-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657078728; bh=SGcMI85UYaxSGubRcm+GntMG5Me4DJMcuOrpGgPRDaw=; h=Cc:Date:From:Reply-To:Subject:To; b=JUZC2YrHVcSECxNdlS8jq7hq4vDESEDp0RURUZmdQIzZdSujoejhtcMfEKdlpQuwxBC 4T6/1x7g0G8AxW0S62YdFvXOfHL/NC5Cmll8U1vb+5haJCmIimTE2FCQv1lFR9MuBRewX A/vixsrNw2TdMEeIeBAs2ovlfYnuTK1+jho= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657078730369100011 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3966 This change introduces a new peripheral subclass definition. The new subclass definition will cover system reboot events under the status reports from Trusted Platform Modules (TPMs). These definition could provide helpful datapoints to OEMs to analyze system security state and healthiness, as well as avoid definition collision with other existing peripheral subclass definitions. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Kun Qin --- MdePkg/Include/Pi/PiStatusCode.h | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/Include/Pi/PiStatusCode.h b/MdePkg/Include/Pi/PiStatusC= ode.h index ef2aea7364bc..d65b65654053 100644 --- a/MdePkg/Include/Pi/PiStatusCode.h +++ b/MdePkg/Include/Pi/PiStatusCode.h @@ -363,6 +363,7 @@ typedef struct { #define EFI_PERIPHERAL_LCD_DEVICE (EFI_PERIPHERAL | 0x000B0000) #define EFI_PERIPHERAL_NETWORK (EFI_PERIPHERAL | 0x000C0000) #define EFI_PERIPHERAL_DOCKING (EFI_PERIPHERAL | 0x000D0000) +#define BZ3966_EFI_PERIPHERAL_TPM (EFI_PERIPHERAL | 0x000E000= 0) ///@} =20 /// --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91077): https://edk2.groups.io/g/devel/message/91077 Mute This Topic: https://groups.io/mt/92200214/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 08:24:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91078+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91078+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657078730; cv=none; d=zohomail.com; s=zohoarc; b=IgsWAdhC7isXdQUp6ACbaE9BXaN92wyBD/2fRA7CyLjgq6BKwB/wf0wm9NMLQcEbl6FnWqDr1y4fDA5tsE0GrLj2dLl+1XhAlH7vKkY835RfzduPZZSBJfSkhdTFRKkyvdzA3YBeCOeJ9iAlQghx8XE2/5n4A1q5Cextf2uZVA4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657078730; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=S7Dqe3ocJUKs1dJd/NMoIEzBGfiYqioa8yTsHhuUzjI=; b=YIlV/iCDKPTjkB6O9WJZZ+bRnvnI36gZltc7qZp7ptSZhVLaJ1981I2bezbT5nKWjyaf7eNtVLhhb8mLMOrGxgSbk5huWF9w7wVA1L+DSCi3Z4PaCAW7AxSl7zX6E/OYCJ8BAo1292QQrVpmIZWEIXJPfQv6nhZ2ezcm9zuWyCk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91078+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657078730250549.3629749487849; Tue, 5 Jul 2022 20:38:50 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id INRgYY1788612xrtRyJeTFAh; Tue, 05 Jul 2022 20:38:49 -0700 X-Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mx.groups.io with SMTP id smtpd.web08.2228.1657078728607152715 for ; Tue, 05 Jul 2022 20:38:48 -0700 X-Received: by mail-pl1-f170.google.com with SMTP id y18so4591786plb.2 for ; Tue, 05 Jul 2022 20:38:48 -0700 (PDT) X-Gm-Message-State: Jh65iUX6Hd97cbumvy7deY6Rx1787277AA= X-Google-Smtp-Source: AGRyM1sUXAEDlVysjE7p85qFa5LFtP0yn4p2kFExds1ETlA59ZQmjbRontEkdIWKR2Rbwtr1Uz1uWA== X-Received: by 2002:a17:902:e889:b0:16a:3c79:f92f with SMTP id w9-20020a170902e88900b0016a3c79f92fmr44419750plg.51.1657078727903; Tue, 05 Jul 2022 20:38:47 -0700 (PDT) X-Received: from localhost.localdomain ([192.182.149.255]) by smtp.gmail.com with ESMTPSA id a140-20020a621a92000000b005289fbef7c4sm864251pfa.140.2022.07.05.20.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 20:38:47 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar Subject: [edk2-devel] [edk2-staging][PATCH v1 3/7] SecurityPkg: Tcg2Dxe: Replace PcdStatusCodeSubClassTpmDevice Date: Tue, 5 Jul 2022 20:38:14 -0700 Message-Id: <20220706033818.1493-4-kuqin12@gmail.com> In-Reply-To: <20220706033818.1493-1-kuqin12@gmail.com> References: <20220706033818.1493-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657078729; bh=YWza4HXH9tdFMcYTxaITGd6rZGEvkYjH/n4xg5Kzz3k=; h=Cc:Date:From:Reply-To:Subject:To; b=UIGdLBn79cHaTRBQhTIx1PLax8dQmufrgvy0UKOhCCpxSCHRYKiIJMPZymTykq0UAdC P0xgkPjjQQ2p+RX8pgeHPFpC3VtZFI0URwovHZISN3evuMr/7Xfbpj/trt4eUKn+iK6Ce 6JYMKvj3jedkUZ7CwitHZF6/2Xl6lH99JY8= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657078732366100023 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3966 This change replaces the references of PcdStatusCodeSubClassTpmDevice with newly defined EFI_PERIPHERAL_TPM. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin --- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++-- SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tc= g2Dxe.c index f6ea8b2bbf18..d6d2994f400b 100644 --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c @@ -1256,7 +1256,7 @@ TcgDxeHashLogExtendEvent ( mTcgDxeData.BsCap.TPMPresentFlag =3D FALSE; REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MINOR, - (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERRO= R) + (BZ3966_EFI_PERIPHERAL_TPM | EFI_P_EC_INTERFACE_ERROR) ); } =20 @@ -1342,7 +1342,7 @@ Tcg2HashLogExtendEvent ( mTcgDxeData.BsCap.TPMPresentFlag =3D FALSE; REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MINOR, - (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ER= ROR) + (BZ3966_EFI_PERIPHERAL_TPM | EFI_P_EC_INTERFACE_ERROR) ); } } else { diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf b/SecurityPkg/Tcg/Tcg2Dxe/= Tcg2Dxe.inf index 7dc7a2683d71..b40bdfc1c975 100644 --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.inf @@ -98,7 +98,6 @@ [Pcd] gEfiSecurityPkgTokenSpaceGuid.PcdTpmPlatformClass = ## SOMETIMES_CONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdFirmwareDebuggerInitialized = ## SOMETIMES_CONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTpmInstanceGuid = ## CONSUMES - gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice = ## SOMETIMES_CONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTcg2HashAlgorithmBitmap = ## CONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTcg2NumberOfPCRBanks = ## CONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTcgLogAreaMinLen = ## CONSUMES --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91078): https://edk2.groups.io/g/devel/message/91078 Mute This Topic: https://groups.io/mt/92200215/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 08:24:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91079+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91079+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657078729; cv=none; d=zohomail.com; s=zohoarc; b=fBXR9M0QDJ+Si0tJlfjz3tezB6ubzHL81+fYu3P4/gAuCgY89CjEPClH8jz0SK4iaAFmzguyxerLFLmOVk+Gadvi/sOv2isV+F/nDjdAqt2pE6ixjggx5Dx1WUHTiW7Lv4nKfWsA3OVCAR68865PlYfnlNuEVycagXzAJypHbqc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657078729; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=761c8dz+eN0TZ7zayB7h5lctCY3J4K4CBLcfI73v2Ro=; b=nG6PC8RWLD8ladblubsfykmBe4lgTryMLLi3mYq7l0W5iax1oVbOTqohLXUg38ain75aJEArLmrKR28ge9kiGaRHlgVWB/Ma34c8D0Pd9a8sDEBOdahcJbTEJabTOsA+GagfS8HVoWOtdV7XGGE7v/advAAVPkUGfRdOVLyPF30= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91079+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657078729942142.67705075644506; Tue, 5 Jul 2022 20:38:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZERRYY1788612xColqrtWqTw; Tue, 05 Jul 2022 20:38:49 -0700 X-Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mx.groups.io with SMTP id smtpd.web12.2157.1657078726858443186 for ; Tue, 05 Jul 2022 20:38:49 -0700 X-Received: by mail-pg1-f171.google.com with SMTP id z14so13065773pgh.0 for ; Tue, 05 Jul 2022 20:38:49 -0700 (PDT) X-Gm-Message-State: 3uTTZgt1wuLzD90tkO18I0itx1787277AA= X-Google-Smtp-Source: AGRyM1tL6+aW2w02ym6aPAthRWKiwtaEPK1L3bXI1Hs8bzxlYCw6uzSItp0QNW4IRTh54CZ8N2ZZfw== X-Received: by 2002:a63:2c90:0:b0:40c:fe76:59ef with SMTP id s138-20020a632c90000000b0040cfe7659efmr31912709pgs.288.1657078728606; Tue, 05 Jul 2022 20:38:48 -0700 (PDT) X-Received: from localhost.localdomain ([192.182.149.255]) by smtp.gmail.com with ESMTPSA id a140-20020a621a92000000b005289fbef7c4sm864251pfa.140.2022.07.05.20.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 20:38:48 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar Subject: [edk2-devel] [edk2-staging][PATCH v1 4/7] SecurityPkg: Tcg2Pei: Replace PcdStatusCodeSubClassTpmDevice Date: Tue, 5 Jul 2022 20:38:15 -0700 Message-Id: <20220706033818.1493-5-kuqin12@gmail.com> In-Reply-To: <20220706033818.1493-1-kuqin12@gmail.com> References: <20220706033818.1493-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657078729; bh=SoPkmGOfdsK17SSiot6sgoA0QRk1g9VjPlA26nB/wRw=; h=Cc:Date:From:Reply-To:Subject:To; b=ibCyIZ91cFJtFCoQQQOj6JtmP4m/eop4XgpFEksieH60jKSoUThZ1tcrcfUNz74EPo+ ystf6Xe7bPQSyHna41wNxtSNxcQfgUftFAhswB0Q03n9IYv5S8bdU3xgeE2CiD2qhNENO fD79i7+PXI6fXzG8mEp5LiLIh4CfF1N1enE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657078730379100012 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3966 This change replaces the references of PcdStatusCodeSubClassTpmDevice with newly defined EFI_PERIPHERAL_TPM. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin --- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++-- SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c b/SecurityPkg/Tcg/Tcg2Pei/Tc= g2Pei.c index 26bb5282a58b..4fe474aade49 100644 --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c @@ -501,7 +501,7 @@ HashLogExtendEvent ( BuildGuidHob (&gTpmErrorHobGuid, 0); REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MINOR, - (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERRO= R) + (BZ3966_EFI_PERIPHERAL_TPM | EFI_P_EC_INTERFACE_ERROR) ); } =20 @@ -1150,7 +1150,7 @@ PeimEntryMA ( BuildGuidHob (&gTpmErrorHobGuid, 0); REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MINOR, - (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERRO= R) + (BZ3966_EFI_PERIPHERAL_TPM | EFI_P_EC_INTERFACE_ERROR) ); } =20 diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf b/SecurityPkg/Tcg/Tcg2Pei/= Tcg2Pei.inf index 17ad1161265d..98a26b0ad87c 100644 --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.inf @@ -82,7 +82,6 @@ [Pcd] gEfiSecurityPkgTokenSpaceGuid.PcdTpm2InitializationPolicy ## = CONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTpm2SelfTestPolicy ## = SOMETIMES_CONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTpm2ScrtmPolicy ## = CONSUMES - gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice ## = SOMETIMES_CONSUMES ## SOMETIMES_CONSUMES ## SOMETIMES_PRODUCES gEfiSecurityPkgTokenSpaceGuid.PcdTpm2HashMask --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91079): https://edk2.groups.io/g/devel/message/91079 Mute This Topic: https://groups.io/mt/92200216/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 08:24:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91080+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91080+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657078731; cv=none; d=zohomail.com; s=zohoarc; b=NRJk6e8BiDg2QHqzIKhDyKBMLFggmsR7uKDhPGlRMFCDeaU7dw064G6dukluOsp00xMewv98kgXI4a0XWxqakgbXxmeoWnabnrWkdh8VEh2CREE1I9qGn/mekF+NfQkyz25bsmgfHGzyPJupdosvor2yzvz+NZciuzDwNvp66bs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657078731; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=VrrSL7qwNlPCFN8Vb8Tps50qocM0kJENOgegveA3DSc=; b=Bm7XfJr0BvRVNHYbQ3Tnw9IheASO+RVuQ8kboaZ9PxPl2ozCoJFPQ5uHK94BZQOdzM6ty4Yhrq8Wwnh1cCOlxfhLM/QIaVsPt3SiLM+trr14p8DYmpJ8PR5fZyTSIx4eHjWzqZ1WX1xyV16L1tukYM9IrfzLFtKn7K1K3iPPucE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91080+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657078731408574.7117744501999; Tue, 5 Jul 2022 20:38:51 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ukBKYY1788612xVXUXU5a8AP; Tue, 05 Jul 2022 20:38:50 -0700 X-Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mx.groups.io with SMTP id smtpd.web12.2159.1657078729807317453 for ; Tue, 05 Jul 2022 20:38:49 -0700 X-Received: by mail-pj1-f48.google.com with SMTP id fz10so7931991pjb.2 for ; Tue, 05 Jul 2022 20:38:49 -0700 (PDT) X-Gm-Message-State: t1utqZubfl2pwXh8L9zGUUX6x1787277AA= X-Google-Smtp-Source: AGRyM1toYVwAIb3gFLYt9ugqmU1qx448W1qBxL9PCxNO5gcEDSW6sVZhnSkgqZgDnbivKPH6Jswg7Q== X-Received: by 2002:a17:90b:4a0c:b0:1ec:d90c:601d with SMTP id kk12-20020a17090b4a0c00b001ecd90c601dmr46442784pjb.154.1657078729213; Tue, 05 Jul 2022 20:38:49 -0700 (PDT) X-Received: from localhost.localdomain ([192.182.149.255]) by smtp.gmail.com with ESMTPSA id a140-20020a621a92000000b005289fbef7c4sm864251pfa.140.2022.07.05.20.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 20:38:49 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar Subject: [edk2-devel] [edk2-staging][PATCH v1 5/7] SecurityPkg: TcgDxe: Replace PcdStatusCodeSubClassTpmDevice Date: Tue, 5 Jul 2022 20:38:16 -0700 Message-Id: <20220706033818.1493-6-kuqin12@gmail.com> In-Reply-To: <20220706033818.1493-1-kuqin12@gmail.com> References: <20220706033818.1493-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657078730; bh=j1c7ob/dmvOMFSxo7O8IbZtQ+hAOhsazUT2XOjtH/mI=; h=Cc:Date:From:Reply-To:Subject:To; b=XCu6SmLlFemUw9CC0uXYjiRzS37/YP2gY660MT12SHQMVv9bPCoxc1sZBKIj6x3H9AW 9BM/zEcQ8OrzhZhQEIOyTqYI1sXwW1712bejn4gir3smQOKi0xXP8MdccQHxPbnToJelI iPtvatcWYyIPCNjOjVLY5WfFN37cbU6WFYY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657078732365100021 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3966 This change replaces the references of PcdStatusCodeSubClassTpmDevice with newly defined EFI_PERIPHERAL_TPM. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin --- SecurityPkg/Tcg/TcgDxe/TcgDxe.c | 2 +- SecurityPkg/Tcg/TcgDxe/TcgDxe.inf | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c b/SecurityPkg/Tcg/TcgDxe/TcgDx= e.c index ee6c6273033b..779125b1beb4 100644 --- a/SecurityPkg/Tcg/TcgDxe/TcgDxe.c +++ b/SecurityPkg/Tcg/TcgDxe/TcgDxe.c @@ -593,7 +593,7 @@ TcgDxeHashLogExtendEventI ( TcgData->BsCap.TPMPresentFlag =3D FALSE; REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MINOR, - (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERRO= R) + (BZ3966_EFI_PERIPHERAL_TPM | EFI_P_EC_INTERFACE_ERROR) ); Status =3D EFI_DEVICE_ERROR; } diff --git a/SecurityPkg/Tcg/TcgDxe/TcgDxe.inf b/SecurityPkg/Tcg/TcgDxe/Tcg= Dxe.inf index c93b377b34ff..be0f4a64958c 100644 --- a/SecurityPkg/Tcg/TcgDxe/TcgDxe.inf +++ b/SecurityPkg/Tcg/TcgDxe/TcgDxe.inf @@ -70,7 +70,6 @@ [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultOemRevision ## SOMETI= MES_CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorId ## SOMETI= MES_CONSUMES gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiDefaultCreatorRevision ## SOMETI= MES_CONSUMES - gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice ## SOMETI= MES_CONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTcgLogAreaMinLen ## CONSUM= ES =20 [Depex] --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91080): https://edk2.groups.io/g/devel/message/91080 Mute This Topic: https://groups.io/mt/92200217/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 08:24:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91081+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91081+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657078731; cv=none; d=zohomail.com; s=zohoarc; b=VxdMa+CacsTA2EXrvk6hYnGdamiQOH3BC+6cJTsBGYdA6+u9JDz7RxaKQEHSc0Y1YWjN/FuKMsfh5aMUk/S75vEUZ+RLNdGZlPgUMeQJ+CqGhVjrUEhu4rH01qt9pja8DnvhHSiutyB6fuGF9f+NCR6LsCMwbEiM7AyFGILW07A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657078731; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=dbeqzwv6PUyiJX1Zk/GGYAKQHel7O9B9RZdet5fewg8=; b=nGWb9ighz18jqYNZJC4KzUEryWwHEygN6aK8/2wwQRQecWE+o2Vw80mPJFs1qzNGkHDwega8trHb0wmDNx3/nsj1jJsuNI+ZWohfELUstpycWrNyE4JhRGIhBDGZA/GK+6Tcy4euKiJxlVk1x8EnCjLbJAdnAFnSpwCQjjtc/BY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91081+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1657078731464660.1604694715203; Tue, 5 Jul 2022 20:38:51 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id vwMcYY1788612xRTEDRvAPSC; Tue, 05 Jul 2022 20:38:51 -0700 X-Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mx.groups.io with SMTP id smtpd.web10.2186.1657078730587005925 for ; Tue, 05 Jul 2022 20:38:50 -0700 X-Received: by mail-pj1-f53.google.com with SMTP id z12-20020a17090a7b8c00b001ef84000b8bso8645381pjc.1 for ; Tue, 05 Jul 2022 20:38:50 -0700 (PDT) X-Gm-Message-State: tpDVc3ScRnV0Uk1KWdSvZicwx1787277AA= X-Google-Smtp-Source: AGRyM1sS3R4coKnmYdDpYVogzWUbDKg1QzcK5qfioG3nygi53ecxD6Lr5DATcamH3zu+tB2+u0y5UA== X-Received: by 2002:a17:90b:3e86:b0:1ec:fc46:9e05 with SMTP id rj6-20020a17090b3e8600b001ecfc469e05mr46613965pjb.0.1657078730005; Tue, 05 Jul 2022 20:38:50 -0700 (PDT) X-Received: from localhost.localdomain ([192.182.149.255]) by smtp.gmail.com with ESMTPSA id a140-20020a621a92000000b005289fbef7c4sm864251pfa.140.2022.07.05.20.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 20:38:49 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar Subject: [edk2-devel] [edk2-staging][PATCH v1 6/7] SecurityPkg: TcgPei: Replace PcdStatusCodeSubClassTpmDevice Date: Tue, 5 Jul 2022 20:38:17 -0700 Message-Id: <20220706033818.1493-7-kuqin12@gmail.com> In-Reply-To: <20220706033818.1493-1-kuqin12@gmail.com> References: <20220706033818.1493-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657078731; bh=CLsAyKjGMPuofJ76yZVXUO1sI0CqTWk4svwk9FQIEMk=; h=Cc:Date:From:Reply-To:Subject:To; b=QxQDYmyARn9EL4Gry801VQYfv7FKmwAXWn9G6MtEfylyTyY0Sj+1z7Y6vAhz49a4HVj uF+BHjMbLB+cL+T23NC8H4lx24CF7gJ9KOmLW2b5ITSfuIDfCwzaKq94wScaeUddZ2mY2 djY+BdWEetXpcUxhzMiEwqs95R5fDjgxCGM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657078732365100022 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3966 This change replaces the references of PcdStatusCodeSubClassTpmDevice with newly defined EFI_PERIPHERAL_TPM. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin --- SecurityPkg/Tcg/TcgPei/TcgPei.c | 4 ++-- SecurityPkg/Tcg/TcgPei/TcgPei.inf | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/SecurityPkg/Tcg/TcgPei/TcgPei.c b/SecurityPkg/Tcg/TcgPei/TcgPe= i.c index 5aa80511aa81..dd9f996df9fe 100644 --- a/SecurityPkg/Tcg/TcgPei/TcgPei.c +++ b/SecurityPkg/Tcg/TcgPei/TcgPei.c @@ -355,7 +355,7 @@ HashLogExtendEvent ( BuildGuidHob (&gTpmErrorHobGuid, 0); REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MINOR, - (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERRO= R) + (BZ3966_EFI_PERIPHERAL_TPM | EFI_P_EC_INTERFACE_ERROR) ); Status =3D EFI_DEVICE_ERROR; } @@ -922,7 +922,7 @@ PeimEntryMA ( BuildGuidHob (&gTpmErrorHobGuid, 0); REPORT_STATUS_CODE ( EFI_ERROR_CODE | EFI_ERROR_MINOR, - (PcdGet32 (PcdStatusCodeSubClassTpmDevice) | EFI_P_EC_INTERFACE_ERRO= R) + (BZ3966_EFI_PERIPHERAL_TPM | EFI_P_EC_INTERFACE_ERROR) ); } =20 diff --git a/SecurityPkg/Tcg/TcgPei/TcgPei.inf b/SecurityPkg/Tcg/TcgPei/Tcg= Pei.inf index 2e3e7e0575d5..f49bb09062e3 100644 --- a/SecurityPkg/Tcg/TcgPei/TcgPei.inf +++ b/SecurityPkg/Tcg/TcgPei/TcgPei.inf @@ -78,7 +78,6 @@ [Pcd] gEfiSecurityPkgTokenSpaceGuid.PcdTpmInstanceGuid ## C= ONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTpmInitializationPolicy ## C= ONSUMES gEfiSecurityPkgTokenSpaceGuid.PcdTpmScrtmPolicy ## S= OMETIMES_CONSUMES - gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice ## S= OMETIMES_CONSUMES =20 [Depex] gEfiPeiMasterBootModePpiGuid AND --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91081): https://edk2.groups.io/g/devel/message/91081 Mute This Topic: https://groups.io/mt/92200218/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 08:24:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+91082+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91082+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1657078732; cv=none; d=zohomail.com; s=zohoarc; b=RG+sZHqTukTDJBKxpt1pNyYBxlGwHbQwqs+8PI+ACrebbrDhJNzmAvmBvi/vMof1/8+HDAPaHZP2DGgg5vJnZuFr85xUUvcgNUmUcMh4yjHlSyBhlClj82by7TzxGB/yHGlgmO+G80giD5dHKcNRqkxqLCIFRcT/rOLIt2f2QPs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657078732; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=b+GRnz7o9sATc745aOzUVQx7g1mdbgOpsqROZPNLAaE=; b=gPxJW/JBPhNGNj94UXdC4iPm6A8iLLvUJQ95AL9zHk9HrD0NrzpbssYX6K+pGN8pY0trUq3nqCHHNY4tB+Z7hNk6BMXiMCaN4vbMNeYOJE8A4c98LDwoxSc2dqlkMxb7htPV5tXx1p944LsehN3WqTHm47C5On1Lmwq5Z/CDAO0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+91082+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 165707873233973.73900816280911; Tue, 5 Jul 2022 20:38:52 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4TfsYY1788612xdZ5Ordtrng; Tue, 05 Jul 2022 20:38:52 -0700 X-Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mx.groups.io with SMTP id smtpd.web11.2169.1657078731449893289 for ; Tue, 05 Jul 2022 20:38:51 -0700 X-Received: by mail-pf1-f179.google.com with SMTP id n12so13301247pfq.0 for ; Tue, 05 Jul 2022 20:38:51 -0700 (PDT) X-Gm-Message-State: 0YgG1eSWySpPalgYpARfqA8tx1787277AA= X-Google-Smtp-Source: AGRyM1tGkqlDKFthq+EdOexG6r7CcldoYL70HR0f829MgPCfHW/B+uFQYkkybd1MAGdT/NdwyhvkZw== X-Received: by 2002:aa7:8390:0:b0:528:5e9:9d31 with SMTP id u16-20020aa78390000000b0052805e99d31mr35938917pfm.30.1657078730816; Tue, 05 Jul 2022 20:38:50 -0700 (PDT) X-Received: from localhost.localdomain ([192.182.149.255]) by smtp.gmail.com with ESMTPSA id a140-20020a621a92000000b005289fbef7c4sm864251pfa.140.2022.07.05.20.38.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 20:38:50 -0700 (PDT) From: "Kun Qin" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Qi Zhang , Rahul Kumar Subject: [edk2-devel] [edk2-staging][PATCH v1 7/7] SecurityPkg: SubClassTpm: Updated default value Date: Tue, 5 Jul 2022 20:38:18 -0700 Message-Id: <20220706033818.1493-8-kuqin12@gmail.com> In-Reply-To: <20220706033818.1493-1-kuqin12@gmail.com> References: <20220706033818.1493-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1657078732; bh=Wey3RzLqKopbNbxCPZv7suep8f1SvMry1gtS8DbpOMs=; h=Cc:Date:From:Reply-To:Subject:To; b=O8wleTrHcYkOlGRWiK+1DP+ZDFOaxIY+OirBnCaSAI0/Yh97sOWgbkG6E7YDD1IY+iZ 8wAfLffwM892Tlqufhb0fhwxEcOVvBtl8ZEVdHnrjVeT5wcihF+MdRwBuVTzfHyec2aAH Afqjt9WNqqngGUCuo9wJCzM26lHmjuyQv2o= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1657078734385100031 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3966 This change updated the default value of TPM device subclass PCD to `0x010E0000` in order to match the definition of EFI_PERIPHERAL_TPM from PI specification. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Kun Qin --- SecurityPkg/SecurityPkg.dec | 6 +++--- SecurityPkg/SecurityPkg.uni | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec index 0ee75efc1a97..cc93ebb54f99 100644 --- a/SecurityPkg/SecurityPkg.dec +++ b/SecurityPkg/SecurityPkg.dec @@ -310,10 +310,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] gEfiSecurityPkgTokenSpaceGuid.PcdTpmPlatformClass|0|UINT8|0x00000006 =20 ## Progress Code for TPM device subclass definitions.

- # EFI_PERIPHERAL_TPM =3D (EFI_PERIPHERAL | 0x000D0000) =3D 0x010D0000<= BR> + # EFI_PERIPHERAL_TPM =3D (EFI_PERIPHERAL | 0x000E0000) =3D 0x010E0000<= BR> # @Prompt Status Code for TPM device definitions - # @ValidList 0x80000003 | 0x010D0000 - gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|0x010D0000|= UINT32|0x00000007 + # @ValidList 0x80000003 | 0x010E0000 + gEfiSecurityPkgTokenSpaceGuid.PcdStatusCodeSubClassTpmDevice|0x010E0000|= UINT32|0x00000007 =20 ## Defines the IO port used to trigger a software System Management Inte= rrupt (SMI).

# Used as the SMI Command IO port by security functionality that trigge= rs a software SMI such diff --git a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni index 68587304d779..6c28b8021333 100644 --- a/SecurityPkg/SecurityPkg.uni +++ b/SecurityPkg/SecurityPkg.uni @@ -169,7 +169,7 @@ #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdStatusCodeSubClassTpmDevice_P= ROMPT #language en-US "Status Code for TPM device definitions" =20 #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdStatusCodeSubClassTpmDevice_H= ELP #language en-US "Progress Code for TPM device subclass definitions.
\n" - = "EFI_PERIPHERAL_TPM =3D (EFI_PERIPHERAL | 0x000D0000)= =3D 0x010D0000
" + = "EFI_PERIPHERAL_TPM =3D (EFI_PERIPHERAL | 0x000E0000)= =3D 0x010E0000
" =20 #string STR_gEfiSecurityPkgTokenSpaceGuid_PcdRsa2048Sha256PublicKeyBuffer_= PROMPT #language en-US "One or more SHA 256 Hashes of RSA 2048 bit public = keys used to verify Recovery and Capsule Update images" =20 --=20 2.35.1.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91082): https://edk2.groups.io/g/devel/message/91082 Mute This Topic: https://groups.io/mt/92200219/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-