From nobody Tue Feb 10 05:45:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90870+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90870+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1656515096; cv=none; d=zohomail.com; s=zohoarc; b=UIoeer7zLR+7c5jYpDaCRdeO9S1JJ8aXT/xEbDinDgHuEwCjyS+0B7yZ4d3sqHEhdXI6tiXFMkzKgRSkigOcmmksr3fgpxgQxliH+IT++FeuiVzGbjvX1dPKYo4cWvP8xLQUoUaaBUrEEmR4CjoZ1KMkFKxg/mzZeJCk908zLXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1656515096; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=fMEY15sQMqGgJKHstnwmdeHIMJVP4u3619tNQf1/Jw4=; b=WwG0IPwbQBPlNfxaIGkZoGIx3AxymJeDqZeF/7bkngvAWqPtt9Y6/slYgdAGDE6YPRCSw9xxNH5XX57smutQC8ENvcTc3e31zjkpq/RH2cxNsoZPfdsLI8txh1/fiKRLSXawbGDxI8z7phP5Vj5J6VO4w971D7rUHo7A91diC6Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90870+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1656515095948990.9508070013469; Wed, 29 Jun 2022 08:04:55 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qZJBYY1788612xHDJpfvPKOO; Wed, 29 Jun 2022 08:04:54 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.12724.1656515094270228188 for ; Wed, 29 Jun 2022 08:04:54 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 30A6B19F0; Wed, 29 Jun 2022 08:04:54 -0700 (PDT) X-Received: from pierre123.arm.com (unknown [10.57.42.208]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A773B3F792; Wed, 29 Jun 2022 08:04:51 -0700 (PDT) From: "PierreGondois" To: devel@edk2.groups.io Cc: Sami Mujawar , Leif Lindholm , Ard Biesheuvel , Rebecca Cran , Michael D Kinney , Liming Gao , Jiewen Yao , Jian J Wang Subject: [edk2-devel] [PATCH v3 18/21] SecurityPkg/RngDxe: Add debug warning for NULL PcdCpuRngSupportedAlgorithm Date: Wed, 29 Jun 2022 17:02:34 +0200 Message-Id: <20220629150241.2597898-26-Pierre.Gondois@arm.com> In-Reply-To: <20220629150241.2597898-1-Pierre.Gondois@arm.com> References: <20220629150241.2597898-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com X-Gm-Message-State: A7jHaWIf3CIoMPT7xRwEYbmzx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656515094; bh=XvyYFMIe/xsCk55vd45GkkAf8doDr3y1FGUqvVIyfeQ=; h=Cc:Date:From:Reply-To:Subject:To; b=MY+Sh8wQiT1ZMPE6ZrJ8xYtne/swddalDL5HNfGuxYRgV1TYwrEs3vrMxyzLP6zxzSQ PdNWpDTEzJxck8Mk1kXzkPZFXshm9rMqJaoMTxrVk8PapnYeakqbkqOZBE2a4cRP5S4Dn G3aSOt5LZLnQ5DaosdmthVP8dAdOLAAb4eI= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656515097573100003 Content-Type: text/plain; charset="utf-8" From: Pierre Gondois PcdCpuRngSupportedAlgorithm should allow to identify the the algorithm used by the RNDR CPU instruction to generate a random number. Add a debug warning if the Pcd is not set. Signed-off-by: Pierre Gondois --- .../RandomNumberGenerator/RngDxe/AArch64/RngDxe.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c b/Se= curityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c index ee3f1ee78434..ffa32a29dc6a 100644 --- a/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c +++ b/SecurityPkg/RandomNumberGenerator/RngDxe/AArch64/RngDxe.c @@ -63,6 +63,16 @@ RngInitAvailableAlgoArray ( sizeof (EFI_RNG_ALGORITHM) ); mAvailableAlgoArrayCount++; + + DEBUG_CODE_BEGIN (); + if (IsZeroGuid (PcdGetPtr (PcdCpuRngSupportedAlgorithm))) { + DEBUG (( + DEBUG_WARN, + "PcdCpuRngSupportedAlgorithm should be a non-zero GUID\n" + )); + } + + DEBUG_CODE_END (); } =20 // Raw algorithm (Trng) --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90870): https://edk2.groups.io/g/devel/message/90870 Mute This Topic: https://groups.io/mt/92066755/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-