From nobody Fri May 17 11:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90814+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90814+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1656440423020506.0039937086392; Tue, 28 Jun 2022 11:20:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ckLKYY1788612xGPWgQ95Lvp; Tue, 28 Jun 2022 11:20:22 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.1743.1656440421667725313 for ; Tue, 28 Jun 2022 11:20:21 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D970153B; Tue, 28 Jun 2022 11:20:21 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A64AF3F792; Tue, 28 Jun 2022 11:20:19 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Pierre Gondois , Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH V2 1/7] Platform/Sgi: Fix ACPI Low Power Idle states for SGI575 Date: Tue, 28 Jun 2022 23:50:06 +0530 Message-Id: <20220628182012.1179982-2-pranav.madhu@arm.com> In-Reply-To: <20220628182012.1179982-1-pranav.madhu@arm.com> References: <20220628182012.1179982-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: uab7PnU10DCuHGBHaY51o2i9x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656440422; bh=EYjeIja5FRo0oGe9+29Ye6bHE0F1SmggjaQMZaBJPe0=; h=Cc:Date:From:Reply-To:Subject:To; b=Kth4ylqQxmD6BzqT0ytyncSbPrlFwWEzktffbo/TkH5HkE1iyZREQ7kzznAM7l+V4W0 Cg0nhyTg76qolYcFi0WXAjeELHSxUExwo8O8isWlg98mMQfq3oABh6Q7Iidc6yLzX5zrQ P79KSlDsYaYBpDZGIFVuKbMb0fYSQbTe7gY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656440425145100007 Content-Type: text/plain; charset="utf-8" SGI-575 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl b/Platform/ARM/= SgiPkg/AcpiTables/Sgi575/Dsdt.asl index 80075ee1238b..f4e84e806a65 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl @@ -57,7 +57,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD", "AR= MSGI", EFI_ACPI_ARM_OEM 1150, // Wake latency (uS) 1, // Flags 1, // Arch Context Flags - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No Parent State 0x00000020, // Integer Entry method ResourceTemplate () { // Null Residency Counter @@ -72,14 +72,14 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD", "= ARMSGI", EFI_ACPI_ARM_OEM =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -102,7 +102,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD", "= ARMSGI", EFI_ACPI_ARM_OEM 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 1, // Parent node can be in any shallower state ResourceTemplate () { // Register Entry method Register (FFixedHW, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90814): https://edk2.groups.io/g/devel/message/90814 Mute This Topic: https://groups.io/mt/92050003/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 11:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90815+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90815+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 165644042488726.290990160373326; Tue, 28 Jun 2022 11:20:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dQDAYY1788612x7AjBsZdJmp; Tue, 28 Jun 2022 11:20:24 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.1745.1656440423796118573 for ; Tue, 28 Jun 2022 11:20:24 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B412152B; Tue, 28 Jun 2022 11:20:23 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B3D853F792; Tue, 28 Jun 2022 11:20:21 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Pierre Gondois , Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH V2 2/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge Date: Tue, 28 Jun 2022 23:50:07 +0530 Message-Id: <20220628182012.1179982-3-pranav.madhu@arm.com> In-Reply-To: <20220628182012.1179982-1-pranav.madhu@arm.com> References: <20220628182012.1179982-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: NQ3UWidUgccbYRjLrGRZt3YNx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656440424; bh=+2FLoppgvL+ZWFMeicufCSS4U9nolGSfRbhFg45FgyM=; h=Cc:Date:From:Reply-To:Subject:To; b=kqLwSmPZs9DWHavM3mHq+vgdr/J52srGCvPLfBC+xoG3pCHq5qL+zZkXbscj9fGE9xf Z5x44itZkG9Hrbxj6WjK8laajW3k3yNYB+mz3G72/oLURMDK8/EqIM4SQ6GnAjL4N6G3z cyVfXwZ58OFw3l6v+T9W9WtxH3AhSJSTDBo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656440425147100008 Content-Type: text/plain; charset="utf-8" RD-N1-Edge platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl b/Platform/AR= M/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl index bd8efa544a59..7b4bbd36d8c0 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl @@ -58,7 +58,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "A= RMSGI", 1150, // Wake latency (uS) 1, // Flags 1, // Arch Context Flags - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No Parent State 0x00000020, // Integer Entry method ResourceTemplate () { // Null Residency Counter @@ -73,14 +73,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -103,7 +103,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 1, // Parent node can be in any shallower state ResourceTemplate () { // Register Entry method Register (FFixedHW, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90815): https://edk2.groups.io/g/devel/message/90815 Mute This Topic: https://groups.io/mt/92050004/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 11:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90816+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90816+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1656440426602596.4876442656409; Tue, 28 Jun 2022 11:20:26 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id RnKyYY1788612xPdWu1qEhT0; Tue, 28 Jun 2022 11:20:26 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.1776.1656440425685850991 for ; Tue, 28 Jun 2022 11:20:25 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98B76152B; Tue, 28 Jun 2022 11:20:25 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C176F3F792; Tue, 28 Jun 2022 11:20:23 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Pierre Gondois , Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH V2 3/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge-X2 Date: Tue, 28 Jun 2022 23:50:08 +0530 Message-Id: <20220628182012.1179982-4-pranav.madhu@arm.com> In-Reply-To: <20220628182012.1179982-1-pranav.madhu@arm.com> References: <20220628182012.1179982-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: NqjADERgPVlsSPzLKDD3VT9Ax1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656440426; bh=fDzjU8qkmzjtBd5TLk++go0xyePZkqK8nqqxekSv2lQ=; h=Cc:Date:From:Reply-To:Subject:To; b=KsWlrrLgHqvas4J+SJ3YEeOmWd0ZmmjM2X0DWEvZZDnQMLJHkP08za7LLLz0nIIVZyu vRIyqX9w+dfb1DEPFlA80qvLwVWU9Xxs5Sr22d5rOsvHCmmSVfBE5mht+zrKDRrHlm/yU gJm32p/gexfUfRnLLF3my4Xzv5nAwrEuz6I= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656440427147100013 Content-Type: text/plain; charset="utf-8" RD-N1-Edge-X2 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl b/Platform/= ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl index 9cb2b175418c..28e255c6de6e 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl @@ -60,7 +60,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "A= RMSGI", 1150, // Wake latency (uS) 1, // Flags 1, // Arch Context Flags - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No Parent State 0x00000020, // Integer Entry method ResourceTemplate () { // Null Residency Counter @@ -75,14 +75,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -105,7 +105,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 1, // Parent node can be in any shallower state ResourceTemplate () { // Register Entry method Register (FFixedHW, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90816): https://edk2.groups.io/g/devel/message/90816 Mute This Topic: https://groups.io/mt/92050006/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 11:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90817+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90817+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1656440428861954.4759690132137; Tue, 28 Jun 2022 11:20:28 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Y14mYY1788612xWJxanzbEIT; Tue, 28 Jun 2022 11:20:28 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.1746.1656440427741696762 for ; Tue, 28 Jun 2022 11:20:27 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5D80153B; Tue, 28 Jun 2022 11:20:27 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id CEBE73F792; Tue, 28 Jun 2022 11:20:25 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Pierre Gondois , Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH V2 4/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1 Date: Tue, 28 Jun 2022 23:50:09 +0530 Message-Id: <20220628182012.1179982-5-pranav.madhu@arm.com> In-Reply-To: <20220628182012.1179982-1-pranav.madhu@arm.com> References: <20220628182012.1179982-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: YKn5ugYMngNBxFhRChIyQDPLx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656440428; bh=YVvlBfnRyceWm88An7/Ht8EooH0NTuE6m6d78ea/KOc=; h=Cc:Date:From:Reply-To:Subject:To; b=f0OA6615NsaE2oTFBjZW/2uRPI2vyjNc8kcL+Hz+s2TvHVAE915yrIw+KDFJ7Bwsv9U dL2R7J10sxzup3TiqrpFC1cfRwTwzsUCUzXGv+u/u9RseTbkmMx0uzC4Zx7QaptocEOlK 9e11gnW72y0baaly684k65vb5a+9MXedaB4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656440429130100017 Content-Type: text/plain; charset="utf-8" RD-V1 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl b/Platform/ARM/Sg= iPkg/AcpiTables/RdV1/Dsdt.asl index db9c19780e16..3c9c878dd880 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl @@ -64,14 +64,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -94,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "A= RMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency - 1, // Parent node can be in any shallower state + 0, // Residency Counter Frequency + 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, 32, // Bit Width --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90817): https://edk2.groups.io/g/devel/message/90817 Mute This Topic: https://groups.io/mt/92050007/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 11:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90818+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90818+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1656440431026279.27873198686757; Tue, 28 Jun 2022 11:20:31 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id i2F8YY1788612x8jxeYrBPLV; Tue, 28 Jun 2022 11:20:30 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.1745.1656440429831109016 for ; Tue, 28 Jun 2022 11:20:30 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B2C68152B; Tue, 28 Jun 2022 11:20:29 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DBC063F792; Tue, 28 Jun 2022 11:20:27 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Pierre Gondois , Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH V2 5/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1-MC Date: Tue, 28 Jun 2022 23:50:10 +0530 Message-Id: <20220628182012.1179982-6-pranav.madhu@arm.com> In-Reply-To: <20220628182012.1179982-1-pranav.madhu@arm.com> References: <20220628182012.1179982-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: mCPqkxcDzPQhl7oYWdtJYQDrx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656440430; bh=M2k+n78fMR2u14h5shYwkJI0XxIiLkPioUpfbFpYxmA=; h=Cc:Date:From:Reply-To:Subject:To; b=Xe3aK4ZK2Jtza+AJ9ZhWboFB0q0PLvQgF9phweOU2lUU/6PpStgzI83HXuZ2rv7PmS4 bbIf6GD1eJvcTd8prV6sim60/LfYGpNXEYFyNsC4oFT/3fHb8si4unLzMY8S4ipnmAh5s dmiIekWeoqK1XzyWr0v1pEMDEL+hJrao2ww= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656440433170100023 Content-Type: text/plain; charset="utf-8" RD-V1-MC platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl b/Platform/ARM/= SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl index e084d82de7c0..152a3076fedd 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl @@ -64,14 +64,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -94,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "A= RMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency - 1, // Parent node can be in any shallower state + 0, // Residency Counter Frequency + 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, 32, // Bit Width --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90818): https://edk2.groups.io/g/devel/message/90818 Mute This Topic: https://groups.io/mt/92050010/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 11:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90819+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90819+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1656440432946512.1190237279694; Tue, 28 Jun 2022 11:20:32 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id EDXPYY1788612xwCIX7OOCwC; Tue, 28 Jun 2022 11:20:32 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.1748.1656440431850760016 for ; Tue, 28 Jun 2022 11:20:32 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C08A1152B; Tue, 28 Jun 2022 11:20:31 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E90D83F792; Tue, 28 Jun 2022 11:20:29 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Pierre Gondois , Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH V2 6/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2 Date: Tue, 28 Jun 2022 23:50:11 +0530 Message-Id: <20220628182012.1179982-7-pranav.madhu@arm.com> In-Reply-To: <20220628182012.1179982-1-pranav.madhu@arm.com> References: <20220628182012.1179982-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: Wl4YTwhYS8vus4098B4jWTqxx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656440432; bh=dVmExg/vpUzmKu+ByqFbihIaSa5h00PIO6eDraD8Pgg=; h=Cc:Date:From:Reply-To:Subject:To; b=FBpIvtg1vCWrfFZcOLycYkf/0CBT3mO6mtGv+K9RYQ3Hq3FHLnLnyQLfgtKsi7XG1Vy UdyXO7KaoXJULS/6EMhYqslzddH2RUvwosAO7WA88dfRf5q9VxCcYZHesjmGC8ZLqJXO5 craLF5Fh0bb+tuyl4szNMITfGyE0FhBRV7g= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656440433187100024 Content-Type: text/plain; charset="utf-8" RD-N2 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. As the cpus are directly connected to the interconnect on this platform, remove the cluster _LPI control method as well. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 78 +------------------- 1 file changed, 4 insertions(+), 74 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl b/Platform/ARM/Sg= iPkg/AcpiTables/RdN2/Dsdt.asl index ccd98f829652..0f63ca42d505 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl @@ -62,38 +62,16 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Return (Arg3) } =20 - Name (CLPI, Package () { /* LPI for Cluster, support 1 LPI state */ - 0, // Version - 0, // Level Index - 1, // Count - Package () { // Power Gating state for Cluster - 2500, // Min residency (uS) - 1150, // Wake latency (uS) - 1, // Flags - 1, // Arch Context Flags - 100, // Residency Counter Frequency - 0, // No Parent State - 0x00000020, // Integer Entry method - ResourceTemplate () { // Null Residency Counter - Register (SystemMemory, 0, 0, 0, 0) - }, - ResourceTemplate () { // Null Usage Counter - Register (SystemMemory, 0, 0, 0, 0) - }, - "LPI2-Cluster" - }, - }) - Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -116,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "= ARMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency - 1, // Parent node can be in any shallower state + 0, // Residency Counter Frequency + 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, 32, // Bit Width @@ -139,9 +117,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL00) { // Cluster 0 Name (_HID, "ACPI0010") Name (_UID, 0) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP00) { // Neoverse N2 core 0 Name (_HID, "ACPI0007") @@ -166,9 +141,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL01) { // Cluster 1 Name (_HID, "ACPI0010") Name (_UID, 1) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP01) { // Neoverse N2 core 1 Name (_HID, "ACPI0007") @@ -193,9 +165,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL02) { // Cluster 2 Name (_HID, "ACPI0010") Name (_UID, 2) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP02) { // Neoverse N2 core 2 Name (_HID, "ACPI0007") @@ -220,9 +189,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL03) { // Cluster 3 Name (_HID, "ACPI0010") Name (_UID, 3) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP03) { // Neoverse N2 core 3 Name (_HID, "ACPI0007") @@ -247,9 +213,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL04) { // Cluster 4 Name (_HID, "ACPI0010") Name (_UID, 4) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP04) { // Neoverse N2 core 4 Name (_HID, "ACPI0007") @@ -274,9 +237,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL05) { // Cluster 5 Name (_HID, "ACPI0010") Name (_UID, 5) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP05) { // Neoverse N2 core 5 Name (_HID, "ACPI0007") @@ -301,9 +261,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL06) { // Cluster 6 Name (_HID, "ACPI0010") Name (_UID, 6) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP06) { // Neoverse N2 core 6 Name (_HID, "ACPI0007") @@ -328,9 +285,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL07) { // Cluster 7 Name (_HID, "ACPI0010") Name (_UID, 7) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP07) { // Neoverse N2 core 7 Name (_HID, "ACPI0007") @@ -355,9 +309,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL08) { // Cluster 8 Name (_HID, "ACPI0010") Name (_UID, 8) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP08) { // Neoverse N2 core 8 Name (_HID, "ACPI0007") @@ -382,9 +333,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL09) { // Cluster 9 Name (_HID, "ACPI0010") Name (_UID, 9) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP09) { // Neoverse N2 core 9 Name (_HID, "ACPI0007") @@ -409,9 +357,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL10) { // Cluster 10 Name (_HID, "ACPI0010") Name (_UID, 10) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP10) { // Neoverse N2 core 10 Name (_HID, "ACPI0007") @@ -436,9 +381,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL11) { // Cluster 11 Name (_HID, "ACPI0010") Name (_UID, 11) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP11) { // Neoverse N2 core 11 Name (_HID, "ACPI0007") @@ -463,9 +405,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL12) { // Cluster 12 Name (_HID, "ACPI0010") Name (_UID, 12) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP12) { // Neoverse N2 core 12 Name (_HID, "ACPI0007") @@ -490,9 +429,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL13) { // Cluster 13 Name (_HID, "ACPI0010") Name (_UID, 13) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP13) { // Neoverse N2 core 13 Name (_HID, "ACPI0007") @@ -517,9 +453,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL14) { // Cluster 14 Name (_HID, "ACPI0010") Name (_UID, 14) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP14) { // Neoverse N2 core 14 Name (_HID, "ACPI0007") @@ -544,9 +477,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL15) { // Cluster 15 Name (_HID, "ACPI0010") Name (_UID, 15) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP15) { // Neoverse N2 core 15 Name (_HID, "ACPI0007") --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90819): https://edk2.groups.io/g/devel/message/90819 Mute This Topic: https://groups.io/mt/92050012/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 11:58:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90820+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90820+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1656440435044705.4455547498013; Tue, 28 Jun 2022 11:20:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Cl9EYY1788612xzqFwdnXj6S; Tue, 28 Jun 2022 11:20:34 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.1748.1656440433869903548 for ; Tue, 28 Jun 2022 11:20:34 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE6C1153B; Tue, 28 Jun 2022 11:20:33 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 02C883F792; Tue, 28 Jun 2022 11:20:31 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar , Pierre Gondois , Thomas Abraham Subject: [edk2-devel] [edk2-platforms][PATCH V2 7/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2-Cfg1 Date: Tue, 28 Jun 2022 23:50:12 +0530 Message-Id: <20220628182012.1179982-8-pranav.madhu@arm.com> In-Reply-To: <20220628182012.1179982-1-pranav.madhu@arm.com> References: <20220628182012.1179982-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: gDTr76qplehZ4mANhzYkIZNyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656440434; bh=QwQH8Ji39C2OFZSgTFcwtkOU7vPaiQyhG0ELEN8Vt0c=; h=Cc:Date:From:Reply-To:Subject:To; b=LgE0CVLDJhha+Rk5HZng2wY8Z0VoYmy86zGE+3Nh/O7T9DlqPgari22SwaOuLbDwvUV 2z9UCzFQ0fCeFcXlC5n5XTabd6nF04EOYM23rgUwE6egExHhZekFafni2FO6RS95Um4HF hGQnvx2fOxvKd/MKn9BdShj3/4vl0v7N8MY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656440437222100031 Content-Type: text/plain; charset="utf-8" RD-N2-Cfg1 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. As the cpus are directly connected to the interconnect on this platform, remove the cluster _LPI control method as well. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl | 54 ++------------------ 1 file changed, 4 insertions(+), 50 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl b/Platform/AR= M/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl index b6decc77f480..2e9e588806c6 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl @@ -68,38 +68,16 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Return (Arg3) } =20 - Name (CLPI, Package () { /* LPI for Cluster, support 1 LPI state */ - 0, // Version - 0, // Level Index - 1, // Count - Package () { // Power Gating state for Cluster - 2500, // Min residency (uS) - 1150, // Wake latency (uS) - 1, // Flags - 1, // Arch Context Flags - 100, // Residency Counter Frequency - 0, // No Parent State - 0x00000020, // Integer Entry method - ResourceTemplate () { // Null Residency Counter - Register (SystemMemory, 0, 0, 0, 0) - }, - ResourceTemplate () { // Null Usage Counter - Register (SystemMemory, 0, 0, 0, 0) - }, - "LPI2-Cluster" - }, - }) - Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -122,8 +100,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency - 1, // Parent node can be in any shallower state + 0, // Residency Counter Frequency + 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, 32, // Bit Width @@ -145,9 +123,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL00) { // Cluster 0 Name (_HID, "ACPI0010") Name (_UID, 0) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP00) { // Neoverse N2 core 0 Name (_HID, "ACPI0007") @@ -172,9 +147,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL01) { // Cluster 1 Name (_HID, "ACPI0010") Name (_UID, 1) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP01) { // Neoverse N2 core 1 Name (_HID, "ACPI0007") @@ -199,9 +171,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL02) { // Cluster 2 Name (_HID, "ACPI0010") Name (_UID, 2) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP02) { // Neoverse N2 core 2 Name (_HID, "ACPI0007") @@ -226,9 +195,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL03) { // Cluster 3 Name (_HID, "ACPI0010") Name (_UID, 3) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP03) { // Neoverse N2 core 3 Name (_HID, "ACPI0007") @@ -253,9 +219,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL04) { // Cluster 4 Name (_HID, "ACPI0010") Name (_UID, 4) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP04) { // Neoverse N2 core 4 Name (_HID, "ACPI0007") @@ -280,9 +243,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL05) { // Cluster 5 Name (_HID, "ACPI0010") Name (_UID, 5) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP05) { // Neoverse N2 core 5 Name (_HID, "ACPI0007") @@ -307,9 +267,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL06) { // Cluster 6 Name (_HID, "ACPI0010") Name (_UID, 6) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP06) { // Neoverse N2 core 6 Name (_HID, "ACPI0007") @@ -334,9 +291,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL07) { // Cluster 7 Name (_HID, "ACPI0010") Name (_UID, 7) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP07) { // Neoverse N2 core 7 Name (_HID, "ACPI0007") --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90820): https://edk2.groups.io/g/devel/message/90820 Mute This Topic: https://groups.io/mt/92050014/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-