From nobody Fri May 17 10:44:27 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90809+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90809+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=kernel.org Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1656414111554925.9431734429785; Tue, 28 Jun 2022 04:01:51 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dqPkYY1788612xAhED1yYAEc; Tue, 28 Jun 2022 04:01:51 -0700 X-Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mx.groups.io with SMTP id smtpd.web12.53992.1656414110607745938 for ; Tue, 28 Jun 2022 04:01:50 -0700 X-Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AE2E1619A9 for ; Tue, 28 Jun 2022 11:01:49 +0000 (UTC) X-Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5977CC3411D; Tue, 28 Jun 2022 11:01:46 +0000 (UTC) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: maz@kernel.org, Ard Biesheuvel Subject: [edk2-devel] [PATCH] ArmVirtPkg: do not enable iSCSI driver by default Date: Tue, 28 Jun 2022 13:01:19 +0200 Message-Id: <20220628110119.2024701-1-ardb@kernel.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ardb@kernel.org X-Gm-Message-State: wpSuCKNBTz5jWUpJDWvHZ7DLx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1656414111; bh=XDFGDhA7ixcOu0rnqIFtbcu3oqhE94g0HPjq7a9mpEw=; h=Cc:Date:From:Reply-To:Subject:To; b=FBGMg0rhoTwTpHa9jTkbb4J9OyTcSrX44cw8OYVu+dbYLmTgIm1jbKpHgP8agsaox/g xJ/JzmaY4oWS0YNjcabRQG17g9SqcixaDjpVebH0zSVc3Q5LIZHzgGUBTxcz/p2qwwl0T JyZDWayWseZtN5YoYJ45n4jvWXuUSXMH5io= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1656414112178100001 Content-Type: text/plain; charset="utf-8" The iSCSI driver slows down the boot on a pristine variable store flash image, as it creates a couple of large EFI non-volatile variables to preserve state between boots. Since iSCSI boot for VMs is kind of niche anyway, let's default to disabled. If someone needs it in their build, they can use the -D build command option to re-enable it on the fly. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/ArmVirtQemu.dsc | 1 - ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - 2 files changed, 2 deletions(-) diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index 9369a88858fd..45c4a8fc84e0 100644 --- a/ArmVirtPkg/ArmVirtQemu.dsc +++ b/ArmVirtPkg/ArmVirtQemu.dsc @@ -40,7 +40,6 @@ [Defines] DEFINE NETWORK_SNP_ENABLE =3D FALSE DEFINE NETWORK_TLS_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE - DEFINE NETWORK_ISCSI_ENABLE =3D TRUE =20 !if $(NETWORK_SNP_ENABLE) =3D=3D TRUE !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKerne= l.dsc index 7f7d15d6eee3..66039f07f41b 100644 --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc @@ -38,7 +38,6 @@ [Defines] DEFINE NETWORK_SNP_ENABLE =3D FALSE DEFINE NETWORK_TLS_ENABLE =3D FALSE DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS =3D TRUE - DEFINE NETWORK_ISCSI_ENABLE =3D TRUE =20 !if $(NETWORK_SNP_ENABLE) =3D=3D TRUE !error "NETWORK_SNP_ENABLE is IA32/X64/EBC only" --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90809): https://edk2.groups.io/g/devel/message/90809 Mute This Topic: https://groups.io/mt/92041308/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-