[edk2-devel] [edk2-platforms][PATCH V4 0/9] Upadate the ACPI tables for RD platforms

Pranav Madhu posted 9 patches 1 year, 9 months ago
Failed in applying to current master (apply log)
Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h         | 252 +++++++++++---------
Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc            |  30 ++-
Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc            |  38 +--
Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc            |  69 +++---
Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc            |  26 +-
Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc   | 247 +++++++++----------
Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc   | 109 +++++----
Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Madt.aslc   | 105 ++++----
Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc   |  91 +++----
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Hmat.aslc |  52 ++--
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 151 ++++++------
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc |  96 ++++----
Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Srat.aslc |  74 +++---
Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc       | 163 +++++++------
Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc       |  80 ++++---
Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Madt.aslc   | 112 ++++-----
Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Pptt.aslc   |  76 +++---
Platform/ARM/SgiPkg/AcpiTables/RdV1/Madt.aslc       | 159 ++++++------
Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc       |  80 ++++---
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Hmat.aslc     |  64 ++---
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc     | 165 +++++++------
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc     |  84 +++----
Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Srat.aslc     |  82 ++++---
Platform/ARM/SgiPkg/AcpiTables/Sgi575/Madt.aslc     | 105 ++++----
Platform/ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc     |  87 +++----
Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc            |  29 ++-
26 files changed, 1399 insertions(+), 1227 deletions(-)
[edk2-devel] [edk2-platforms][PATCH V4 0/9] Upadate the ACPI tables for RD platforms
Posted by Pranav Madhu 1 year, 9 months ago
Changes since V3:
- Addressed comments from Pierre Gondois
- Rebased on top of latest master branch

Changes since V2:
- Rebased on top of latest master branch
- Update PPTT table with unique cache ID across the system for different
  levels of cache.

Changes since V1:
- Rebased on top of latest master branch.
- Rebased on top of patch to remove SLC cache entries from PPTT (link
  for the same in edk2.groups.io is provided below)

Arm infrastructure reference design platforms uses ACPI tables to
provide the hardware information to the operating system. Currently the
ACPI tables are aligned with ACPI v6.2 and v6.3 specification. This
patch series update the tables to ACPI v6.4 specificaion. Features like
MPAM relies on cache ID field of PPTT tables to distinguish between
different physical caches, which is introduced in PPTT table in ACPI
v6.4. Also ServerReady (SBBR compliaance) strictly recomments all the
tables in the system should allign with same version of ACPI. Hence
upgrade all ACPI tables mentioned in ACPI specification to v6.4.


The first patch in this series update the generic tables which are
common for all platfoms. The subsequent patches in this series update
platform specific ACPI tables to v6.4 for the respective platform.

This patch series also update the headers in the .aslc files to match
the coding style as per edk2 coding guidelines.

Link to github branch with the patches in this series -
https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/acpi64_for_rd_platforms

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

Pranav Madhu (9):
  Platform/Sgi: Update ACPI version to v6.4
  Platform/Sgi: Update ACPI version to v6.4 for SGI575 platform
  Platform/Sgi: Update ACPI version to v6.4 for RD-N1-Edge platform
  Platform/Sgi: Update ACPI version to v6.4 for RD-N1-Edge-X2 platform
  Platform/Sgi: Update ACPI version to v6.4 for RD-E1-Edge platform
  Platform/Sgi: Update ACPI version to v6.4 for RD-V1 platform
  Platform/Sgi: Update ACPI version to v6.4 for RD-V1-MC platform
  Platform/Sgi: Update ACPI version to v6.4 for RD-N2 platform
  Platform/Sgi: Update ACPI version to v6.4 for RD-N2-Cfg1 platform

 Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h         | 252 +++++++++++---------
 Platform/ARM/SgiPkg/AcpiTables/Dbg2.aslc            |  30 ++-
 Platform/ARM/SgiPkg/AcpiTables/Fadt.aslc            |  38 +--
 Platform/ARM/SgiPkg/AcpiTables/Gtdt.aslc            |  69 +++---
 Platform/ARM/SgiPkg/AcpiTables/Mcfg.aslc            |  26 +-
 Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Madt.aslc   | 247 +++++++++----------
 Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Pptt.aslc   | 109 +++++----
 Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Madt.aslc   | 105 ++++----
 Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Pptt.aslc   |  91 +++----
 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Hmat.aslc |  52 ++--
 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Madt.aslc | 151 ++++++------
 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Pptt.aslc |  96 ++++----
 Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Srat.aslc |  74 +++---
 Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc       | 163 +++++++------
 Platform/ARM/SgiPkg/AcpiTables/RdN2/Pptt.aslc       |  80 ++++---
 Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Madt.aslc   | 112 ++++-----
 Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Pptt.aslc   |  76 +++---
 Platform/ARM/SgiPkg/AcpiTables/RdV1/Madt.aslc       | 159 ++++++------
 Platform/ARM/SgiPkg/AcpiTables/RdV1/Pptt.aslc       |  80 ++++---
 Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Hmat.aslc     |  64 ++---
 Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Madt.aslc     | 165 +++++++------
 Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Pptt.aslc     |  84 +++----
 Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Srat.aslc     |  82 ++++---
 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Madt.aslc     | 105 ++++----
 Platform/ARM/SgiPkg/AcpiTables/Sgi575/Pptt.aslc     |  87 +++----
 Platform/ARM/SgiPkg/AcpiTables/Spcr.aslc            |  29 ++-
 26 files changed, 1399 insertions(+), 1227 deletions(-)

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90765): https://edk2.groups.io/g/devel/message/90765
Mute This Topic: https://groups.io/mt/92015130/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms][PATCH V4 0/9] Upadate the ACPI tables for RD platforms
Posted by Ard Biesheuvel 1 year, 9 months ago
On Mon, 27 Jun 2022 at 08:05, Pranav Madhu <pranav.madhu@arm.com> wrote:
>
> Changes since V3:
> - Addressed comments from Pierre Gondois
> - Rebased on top of latest master branch
>
> Changes since V2:
> - Rebased on top of latest master branch
> - Update PPTT table with unique cache ID across the system for different
>   levels of cache.
>
> Changes since V1:
> - Rebased on top of latest master branch.
> - Rebased on top of patch to remove SLC cache entries from PPTT (link
>   for the same in edk2.groups.io is provided below)
>
> Arm infrastructure reference design platforms uses ACPI tables to
> provide the hardware information to the operating system. Currently the
> ACPI tables are aligned with ACPI v6.2 and v6.3 specification. This
> patch series update the tables to ACPI v6.4 specificaion. Features like
> MPAM relies on cache ID field of PPTT tables to distinguish between
> different physical caches, which is introduced in PPTT table in ACPI
> v6.4. Also ServerReady (SBBR compliaance) strictly recomments all the
> tables in the system should allign with same version of ACPI. Hence
> upgrade all ACPI tables mentioned in ACPI specification to v6.4.
>
>
> The first patch in this series update the generic tables which are
> common for all platfoms. The subsequent patches in this series update
> platform specific ACPI tables to v6.4 for the respective platform.
>
> This patch series also update the headers in the .aslc files to match
> the coding style as per edk2 coding guidelines.
>
> Link to github branch with the patches in this series -
> https://github.com/Pranav-Madhu/edk2-platforms/tree/topics/acpi64_for_rd_platforms
>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>
>
> Pranav Madhu (9):
>   Platform/Sgi: Update ACPI version to v6.4
>   Platform/Sgi: Update ACPI version to v6.4 for SGI575 platform
>   Platform/Sgi: Update ACPI version to v6.4 for RD-N1-Edge platform
>   Platform/Sgi: Update ACPI version to v6.4 for RD-N1-Edge-X2 platform
>   Platform/Sgi: Update ACPI version to v6.4 for RD-E1-Edge platform
>   Platform/Sgi: Update ACPI version to v6.4 for RD-V1 platform
>   Platform/Sgi: Update ACPI version to v6.4 for RD-V1-MC platform
>   Platform/Sgi: Update ACPI version to v6.4 for RD-N2 platform
>   Platform/Sgi: Update ACPI version to v6.4 for RD-N2-Cfg1 platform
>

Merged as 433b5b1b0f7f..750f6807879b

Thanks all,


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90805): https://edk2.groups.io/g/devel/message/90805
Mute This Topic: https://groups.io/mt/92015130/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-