From nobody Tue May 7 08:52:24 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90574+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90574+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1655455318; cv=none; d=zohomail.com; s=zohoarc; b=ZtesJbwG9zgXB8CW31TfM724ZnJqzgOCXR5GsMf/D3ZDfcJ6pYLqw9p/K26qIJIYEj4ybRkQ1TBSDu3LRpigNV3F1AySeCq7e6DzNCVjuIIZ3EkIegqRv1SHPS22MiKYREBMdE8xDlmssjhy5lwnVy3FMtdD1i+q5S+5s64DLr8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655455318; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Om6DuzYQfB9AI9MAGKcYi8voH7udwinnJH9cOIxBO3k=; b=eMhO/zhAw7WrawAZMrU/JHvhucqozkn11Qo+kBccY5qYpdEtAKddXK/rtHZmPnH6OuKEzdMywl3O2T9jVSn7f/qIqu4oARcixqCSWOgAnpgIZR0iPj3O6Q3k1BO7LKikFs1exWeymX9Aj2r3fzSMifj/ZVgcQ1R87tIzsnHnwHo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90574+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1655455318021104.80036942544143; Fri, 17 Jun 2022 01:41:58 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id K9m3YY1788612xshnHPrGhXg; Fri, 17 Jun 2022 01:41:57 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.28192.1655455316498480717 for ; Fri, 17 Jun 2022 01:41:56 -0700 X-IronPort-AV: E=McAfee;i="6400,9594,10380"; a="304907072" X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="304907072" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 01:41:56 -0700 X-IronPort-AV: E=Sophos;i="5.92,306,1650956400"; d="scan'208";a="641952031" X-Received: from njayapra-mobl1.gar.corp.intel.com ([10.215.203.157]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2022 01:41:53 -0700 From: "Jayaprakash, N" To: devel@edk2.groups.io Cc: Michael D Kinney , Rebecca Cran , Jayaprakash N Subject: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc/StdLib : Changes to Std LibC to facilitate 32 bit GCC builds Date: Fri, 17 Jun 2022 14:11:35 +0530 Message-Id: <20220617084135.415-2-n.jayaprakash@intel.com> In-Reply-To: <20220617084135.415-1-n.jayaprakash@intel.com> References: <20220617084135.415-1-n.jayaprakash@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com X-Gm-Message-State: zJDxC0dBb9oEKM1EdzxvEXPIx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1655455317; bh=yTXqcVZrXL3wSYvAmbzAGxz/3B8gAZJLye9BofAZBRs=; h=Cc:Date:From:Reply-To:Subject:To; b=Y+40uZ5d6CfF5GZVXfd1RO7XmLV/1lkbSdLg0nT9fppN1REtbWmBS8qIRnrAGu3pc8k XFutOomf3fNDjbRdYG2RL7zpnm+wrT9ufOTM/K+AtNccISgXt3cmANOpo1x4wFk+3xLZa ntHgt/c4TVROKufoU9KJIyIBLdYnaYeHp6E= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1655455318903100002 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3779 This comit fixes the Python interpreter build issues with GCC 32 bit compiler tool chain. The changes are needed in StdLibC as given below * Add __divmoddi4 to Gcc.c produced by newer GCC compilers * Add -fno-lto to IA32 GCC builds of LibC.inf to support use of GCC intrinsics from Gcc.c. * Moved Main/Ia32/ftol2.obj in LibC.inf from binaries section to Sources.IA32 required only for MSFT IA32 compiler tool chain Cc: Michael D Kinney Cc: Rebecca Cran Signed-off-by: Jayaprakash N Reviewed-by: Michael D Kinney --- StdLib/LibC/CRT/Gcc.c | 7 +++++++ StdLib/LibC/LibC.inf | 7 +++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/StdLib/LibC/CRT/Gcc.c b/StdLib/LibC/CRT/Gcc.c index cbf4ec2..bc1a4b2 100644 --- a/StdLib/LibC/CRT/Gcc.c +++ b/StdLib/LibC/CRT/Gcc.c @@ -193,3 +193,10 @@ unsigned long long __umodti3(unsigned long long Divide= nd, unsigned long long Div =20 return (unsigned long long) Remainder; } + +INT64 __divmoddi4 (INT64 num, INT64 den, INT64 *rem_p) +{ + DEBUG((DEBUG_INFO, "%a:\n", __func__)); + return DivS64x64Remainder (num, den, rem_p); +} + diff --git a/StdLib/LibC/LibC.inf b/StdLib/LibC/LibC.inf index 5bb2053..4771204 100644 --- a/StdLib/LibC/LibC.inf +++ b/StdLib/LibC/LibC.inf @@ -46,7 +46,8 @@ Main/Ia32/fpu_rmode.S | GCC Main/Ia32/isinfl.c Main/Ia32/isnanl.c - + Main/Ia32/ftol2.obj | MSFT + =20 # Compiler helper (C RunTime) functions CRT/Ia32/llmul.c | MSFT # __allmul CRT/Ia32/llshl.c | MSFT # __allshl @@ -88,9 +89,6 @@ [Sources.AARCH64] Main/Arm/flt_rounds.c =20 -[Binaries.IA32] - LIB|Main/Ia32/ftol2.obj|*|MSFT - [Packages] StdLib/StdLib.dec StdLibPrivateInternalFiles/DoNotUse.dec @@ -116,4 +114,5 @@ # [BuildOptions] MSFT:*_*_IA32_CC_FLAGS =3D /GL- + GCC:*_*_IA32_CC_FLAGS =3D -fno-lto GCC:*_*_ARM_CC_FLAGS =3D -fno-lto --=20 2.33.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90574): https://edk2.groups.io/g/devel/message/90574 Mute This Topic: https://groups.io/mt/91817430/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-