From nobody Mon May 6 20:41:09 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90537+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90537+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1655314968; cv=none; d=zohomail.com; s=zohoarc; b=ZNx1cpomTA7VFdr/MVJeWInaH1wOoyWVZqVVoKwtWmMzWdEmYbnNvgDUtJM0c70+ePp1jXd7YtSJdZjlRVeNTW0ISFf3iiPV7150zhum4Cm04ZkTudvy0CLNjZnfL0F9GzOci+DNqBdxhp6BymvLmj18legIfPMzaiIkEhbGJE8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1655314968; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=xRRq+PZTO+wKpr58t5lQeUD/RpJ18WYDGu7Rc6R3Ao0=; b=D6Lfk6jpQwtGrzkc1gOt2UIPJEUDQ2dSnXKMM/um62sQrXp9I1ZIC4qyOQaR/UXP8eZKhUo1GWqj6tHFgRy6+kt5HTjZkBl13n/m76YnVEY+gr6ghr9RT2DWjt8L1ZpaF7Mv5pTtgNRAy/JJ5OaAkw9t2bWLbj3Uc7pgdFrOhGo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90537+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1655314968680421.0264156690638; Wed, 15 Jun 2022 10:42:48 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5GynYY1788612xC18Nf58thG; Wed, 15 Jun 2022 10:42:48 -0700 X-Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) by mx.groups.io with SMTP id smtpd.web11.7810.1655314967532670867 for ; Wed, 15 Jun 2022 10:42:47 -0700 X-Received: by mail-qk1-f178.google.com with SMTP id b142so9293898qkg.2 for ; Wed, 15 Jun 2022 10:42:47 -0700 (PDT) X-Gm-Message-State: RI7Q8hqV6f32GjH7n2MZQaqBx1787277AA= X-Google-Smtp-Source: AGRyM1teLBd9joiVsveqondfzoom6IeVpw2vfDNwGz1aE9bDWh0hekX2/HpY9q9sUG/Lr9SM7IYodA== X-Received: by 2002:a05:620a:25c6:b0:699:bc86:6c82 with SMTP id y6-20020a05620a25c600b00699bc866c82mr725727qko.44.1655314966292; Wed, 15 Jun 2022 10:42:46 -0700 (PDT) X-Received: from aturtleortwo-benjamindomain.. ([2607:f2c0:e98c:e:419d:696a:47d6:732a]) by smtp.gmail.com with ESMTPSA id n22-20020ac85a16000000b00304e2e4bf1esm10138290qta.88.2022.06.15.10.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 10:42:45 -0700 (PDT) From: "Benjamin Doron" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Isaac Oram , Liming Gao , Eric Dong , Ankit Sinha Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update FADT-related PCD defaults to restore behaviour Date: Wed, 15 Jun 2022 13:41:54 -0400 Message-Id: <20220615174154.417436-1-benjamin.doron00@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,benjamin.doron00@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1655314968; bh=gnAljbdZuwVbXCfYFqeXU/+qk6OL1t+SgdMnfHre4xY=; h=Cc:Date:From:Reply-To:Subject:To; b=eoi1ZuJU2tNF4RrMBnnHMTaNxiMOAU/lDxjOjU6eONy+Fzrt11zqz8TrLR651ljH7dQ p4JJUE3T9UHn+SkNqHUrU+CH2rSRFYeLHH6xUWP0uRa8KV0Rj4wFXmWFNHlFfRWuZzxvi Yvt0eXNMqYb6OAVY1BNZDpmJmFxXNLXNkDk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1655314969128100001 Content-Type: text/plain; charset="utf-8" Commit f427247 (MinPlatformPkg: Add PCDs to update FADT entries from board package) modified AcpiPlatform flow, altering the FADT for all platforms. Now, because `FadtHeader->Gpe0BlkLen =3D=3D 0`, the Linux kernel prints "irq 9: nobody cared ..." - GPE status cannot be retrieved and at least ACPI SCIs cannot be handled correctly. As the size of this register is the same on Skylake/Kabylake and TigerLake, update the PCD default value. Several FADT register block AccessSize PCDs are updated as well. These fields too are the same between Skylake/Kabylake and TigerLake. However, other fields differ between platforms, such as GPE0 address and the removal of PM{1,2}* addresses, which should be handled in a follow-up. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram Cc: Liming Gao Cc: Eric Dong Cc: Ankit Sinha Signed-off-by: Benjamin Doron Reviewed-by: Ankit Sinha --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec b/Platform/In= tel/MinPlatformPkg/MinPlatformPkg.dec index 68ab1d702d6a..9549c355b122 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec @@ -123,18 +123,18 @@ gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850|UINT1= 6|0x00010039 gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UINT16|0= x0001003A gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT16|0x00= 01003B - gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x000100= 3C + gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x20|UINT8|0x000100= 3C gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT16|0x00= 01003D gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x00010040 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x00|UINT8|0x000= 10042 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x01|UINT8|0x000= 10042 =20 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x00|UINT8|0x= 00010043 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x02|UINT8|0x= 00010043 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize|0x00|UINT8|0x= 00010044 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x00|UINT8|0x= 00010045 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x02|UINT8|0x= 00010045 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bCntBlkAccessSize|0x00|UINT8|0x= 00010046 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm2CntBlkAccessSize|0x00|UINT8|0x0= 0010047 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT8|0x00= 010048 - gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8|0x000= 10049 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x03|UINT8|0x00= 010048 + gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x01|UINT8|0x000= 10049 gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8|0x000= 1004A =20 gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId|0x00|= UINT8|0x0001004B --=20 2.36.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90537): https://edk2.groups.io/g/devel/message/90537 Mute This Topic: https://groups.io/mt/91781863/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-