[edk2-devel] [PATCH] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength

Yuanhao Xie posted 1 patch 1 year, 9 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [PATCH] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength
Posted by Yuanhao Xie 1 year, 9 months ago
Enable 4 socket stack setting for R1S cause HII Assert when entering
socket configuration menu. In order to solve this problem,
PcdMaximumUnicodeStringLength is increased to 1800000.
PcdMaximumUnicodeStringLength in universal payload should also be
increased to sync with other package.

Signed-off-by: Yuanhao <yuanhao.xie@intel.com>
Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
---
 UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
index 4d9bbc80c8..1f4fdbfc98 100644
--- a/UefiPayloadPkg/UefiPayloadPkg.dsc
+++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
@@ -411,6 +411,7 @@
   gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|$(ABOVE_4G_MEMORY)
   gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)
 
+  gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000
 [PcdsPatchableInModule.X64]
   gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
   gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)
-- 
2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90531): https://edk2.groups.io/g/devel/message/90531
Mute This Topic: https://groups.io/mt/91772247/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength
Posted by Ni, Ray 1 year, 9 months ago
Yuanhao,
R1S might be an internal project/board name. It's better not to mention that in open commit message😊

how about below commit message?
---
The maximum Unicode string could be as large as 1800000 in certain
platforms when HII code builds the configuration strings.
This causes assertion in PrintLib.
The patch increases the PcdMaximumUnicodeStringLength to 1800000
to avoid the assertion.


> -----Original Message-----
> From: Xie, Yuanhao <yuanhao.xie@intel.com>
> Sent: Wednesday, June 15, 2022 4:05 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Maurice Ma <maurice.ma@intel.com>; You, Benjamin
> <benjamin.you@intel.com>
> Subject: [PATCH] UefiPayloadPkg: Increase the PcdMaximumUnicodeStringLength
> 
> Enable 4 socket stack setting for R1S cause HII Assert when entering
> socket configuration menu. In order to solve this problem,
> PcdMaximumUnicodeStringLength is increased to 1800000.
> PcdMaximumUnicodeStringLength in universal payload should also be
> increased to sync with other package.
> 
> Signed-off-by: Yuanhao <yuanhao.xie@intel.com>
> Cc: Guo Dong <guo.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> ---
>  UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayloadPkg.dsc
> index 4d9bbc80c8..1f4fdbfc98 100644
> --- a/UefiPayloadPkg/UefiPayloadPkg.dsc
> +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc
> @@ -411,6 +411,7 @@
>    gUefiPayloadPkgTokenSpaceGuid.PcdDispatchModuleAbove4GMemory|$(ABOVE_4G_MEMORY)
>    gUefiPayloadPkgTokenSpaceGuid.PcdBootManagerEscape|$(BOOT_MANAGER_ESCAPE)
> 
> +  gEfiMdePkgTokenSpaceGuid.PcdMaximumUnicodeStringLength|1800000
>  [PcdsPatchableInModule.X64]
>    gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister|$(RTC_INDEX_REGISTER)
>    gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|$(RTC_TARGET_REGISTER)
> --
> 2.36.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90532): https://edk2.groups.io/g/devel/message/90532
Mute This Topic: https://groups.io/mt/91772247/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-