From nobody Mon May 20 16:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90412+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90412+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1654798808; cv=none; d=zohomail.com; s=zohoarc; b=LgxhVWNSxozDyPj9/Qe3xlwJG1pScs+xNpnqA6fYkJ1agyJQPsHIh4yRKchbBih+L7D7kXM7K5bRPH9fmi/8rqxLRcLLnIQI4F17jYbUlXnkt9qRqbfQzMFOz+OJIOSmYRiv8qwMMkTaTo6HbKA7HwwRJAGgJOqnYl44WJlDNHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654798808; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=nx8jLqv+nX/5f9W4dygGxaxUMBpGujRIo0TcHplx2XE=; b=T3q5+Y87ruItARYuq1C3T6WzMju/7aq35ftHT1B3E4NSBqLCZ4osSNN00W3qY9qPjIKva40A9FxDMdUoSnboqdiSDK90/8DkpBlkeURN8iSm8UhZ5btZW98n21hFnvRy+5hB6qV34C6Sodk47CXo0PHfJepmBLYWVKjgPzV+vR4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90412+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654798808786449.0680291415413; Thu, 9 Jun 2022 11:20:08 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Tho9YY1788612xwQ1MCkAhEN; Thu, 09 Jun 2022 11:20:08 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.17067.1654798807378905165 for ; Thu, 09 Jun 2022 11:20:07 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 43257139F; Thu, 9 Jun 2022 11:20:06 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F3B1F3F766; Thu, 9 Jun 2022 11:20:04 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [edk2-platforms][PATCH V1 1/7] Platform/Sgi: Fix ACPI Low Power Idle states for SGI575 Date: Thu, 9 Jun 2022 23:49:49 +0530 Message-Id: <20220609181955.3018033-2-pranav.madhu@arm.com> In-Reply-To: <20220609181955.3018033-1-pranav.madhu@arm.com> References: <20220609181955.3018033-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: fHnk9utNuf6q7LDWUOIxnnYox1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654798808; bh=9f99x5Xfz6ivKcKhMwsjLQFQkhmy4XjTgYpPlMSuMDk=; h=Cc:Date:From:Reply-To:Subject:To; b=RPq8bSz/DfHQPBY69OiCYD+rmVNkZlSQgPzPII/Bu0e5cQPuQDBkJDkECVzNk6cNyWE 4W4kGiagE9Y4ijGZ/JJRXVkgLa7bWk5MMfB4lhHZ+uODQb3T7/gTveMyQnosOGzgbZXt2 JrRBK/gZaRJDOEtteNAua/YVHPgajyWU3Bg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654798809571100004 Content-Type: text/plain; charset="utf-8" SGI-575 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham > Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl b/Platform/ARM/= SgiPkg/AcpiTables/Sgi575/Dsdt.asl index a292d20d8afb..a6187995be56 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl @@ -57,7 +57,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD", "AR= MSGI", EFI_ACPI_ARM_OEM 1150, // Wake latency (uS) 1, // Flags 1, // Arch Context Flags - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No Parent State 0x00000020, // Integer Entry method ResourceTemplate () { // Null Residency Counter @@ -72,14 +72,14 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD", "= ARMSGI", EFI_ACPI_ARM_OEM =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -102,7 +102,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 2, "ARMLTD", "= ARMSGI", EFI_ACPI_ARM_OEM 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 1, // Parent node can be in any shallower state ResourceTemplate () { // Register Entry method Register (FFixedHW, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90412): https://edk2.groups.io/g/devel/message/90412 Mute This Topic: https://groups.io/mt/91652411/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 20 16:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90413+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90413+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1654798810; cv=none; d=zohomail.com; s=zohoarc; b=V9xBTGvvESVKZWlX0RpvODP4RP88qMHrz/ZXPkcSCR6Um1o6Zv3TvGitY3bqEIRW2lA9oxhOZ/Y9CvIlUhoh7pUIeqO3MEMyY6Ne1K2yPQn1RHonKQ16X7F45HeU4bKcHzFboe83/BTT3Nhnz1elBjFylfTBpirDhv8aSHnD0y0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654798810; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=S3RaNXfssCQrI12ZlmAtJZwFDL5K6co2Oy/ucW+gPSc=; b=IqaupbkdaYJmMHWkCVcJPY1G246iwWiNwccVOunu9YEQUws/aPUDsQMy2/WRLrSBad6TE3QFyJV0B4XF0Se0bnaNBpsYfp82c738KdkKzOkIV2wZeKtCHkvIl0NP6Cwxdlsw/VsrNXxVMcOu9ytJK7tiwOpd01PJNVtNjgcvokY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90413+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654798810218731.5455419925104; Thu, 9 Jun 2022 11:20:10 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id zGInYY1788612xZ1Bn2Aja5Z; Thu, 09 Jun 2022 11:20:09 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.16920.1654798808137520471 for ; Thu, 09 Jun 2022 11:20:09 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E55F412FC; Thu, 9 Jun 2022 11:20:07 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9D8713F766; Thu, 9 Jun 2022 11:20:06 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [edk2-platforms][PATCH V1 2/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge Date: Thu, 9 Jun 2022 23:49:50 +0530 Message-Id: <20220609181955.3018033-3-pranav.madhu@arm.com> In-Reply-To: <20220609181955.3018033-1-pranav.madhu@arm.com> References: <20220609181955.3018033-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: OwwvlbeXix3f6aYchqcQHRK4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654798809; bh=K2mKoIm/QNR1h7znHHkITO6qBV/EQRuLqUW1jNdJdaU=; h=Cc:Date:From:Reply-To:Subject:To; b=KH5tmom5ObeViMgPEA+wguaFJY+5AbaRGoz3C+e2fI7qxMGytIMZHBNjO47WenieBoq X2Zt3x5b3VQ2c+Yr3ICOiV0g4ES48VBD7O7FG+Uaiu0ql8HnaqzVgMxdsUQrjyvJ+bTY0 4RJuW5m3za5uNdi6GLmC61G6mFtQwVRAg3U= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654798811576100009 Content-Type: text/plain; charset="utf-8" RD-N1-Edge platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham > Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl b/Platform/AR= M/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl index bd8efa544a59..7b4bbd36d8c0 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1Edge/Dsdt.asl @@ -58,7 +58,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "A= RMSGI", 1150, // Wake latency (uS) 1, // Flags 1, // Arch Context Flags - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No Parent State 0x00000020, // Integer Entry method ResourceTemplate () { // Null Residency Counter @@ -73,14 +73,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -103,7 +103,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 1, // Parent node can be in any shallower state ResourceTemplate () { // Register Entry method Register (FFixedHW, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90413): https://edk2.groups.io/g/devel/message/90413 Mute This Topic: https://groups.io/mt/91652413/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 20 16:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90414+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90414+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1654798811; cv=none; d=zohomail.com; s=zohoarc; b=cpvO7JhshaHDfMhwitjVPD2E7Iv+bZ51pkhf+9YFnaUHju+TEg72j++abhbZ9B8l7SgTWs3tQD+s5OvpptF6cdThI5H+3Rgju0A+LARG9iRlnXtkmGIKP6DCzuYgQjwdIJ90MlnDyWCrHezipf6spZhOusKKtJWZ3Urwiti8avc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654798811; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=a/CDjXyQz5RcC90wcUM11Pof4EH6IrvyJNtfa1bDasI=; b=XPnN4Brj0poG/yRxemGPZXW4owPt9oyntrh+p7tlHbz3HbvLrsecSEMDhVblHD7UKNQ26tKAEVKPrXOT9M4cEkSGK0Ijy2gyymo01hQ4DXwWFmOuLinfY5bksPOhzXMmKRVN451eA/kwgN/86myDzGluaaCzPkaLUhrQAnabkEc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90414+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654798811513135.27172094196646; Thu, 9 Jun 2022 11:20:11 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id UnTtYY1788612xgHmdr9LLrI; Thu, 09 Jun 2022 11:20:11 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.17200.1654798809915480028 for ; Thu, 09 Jun 2022 11:20:10 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 90DE8139F; Thu, 9 Jun 2022 11:20:09 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4B1C33F766; Thu, 9 Jun 2022 11:20:08 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [edk2-platforms][PATCH V1 3/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N1-Edge-X2 Date: Thu, 9 Jun 2022 23:49:51 +0530 Message-Id: <20220609181955.3018033-4-pranav.madhu@arm.com> In-Reply-To: <20220609181955.3018033-1-pranav.madhu@arm.com> References: <20220609181955.3018033-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: SA6RIjU5wKWb74x6PGBg9M8Px1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654798811; bh=ged5PSwQKwRF9wAqiHZyRmPiw8nFAMcAUBY0jHk/VTs=; h=Cc:Date:From:Reply-To:Subject:To; b=AyvdzkAsJ9rTWRuxDRh2e9h7fn5/ULIob+DDru7M+RkSZwkPPagmR5pk3wv6lApsQ+U Upu7T+tb8JTQ0q8K/pbYS/Dz4hGxeEQEA09RU269cOTTLkzxSS9XlKSZ7QXcy0u9h3Lu9 lMUUJwbEQYXiFEPZYivkAlKBK5NHyssK+HQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654798813585100015 Content-Type: text/plain; charset="utf-8" RD-N1-Edge-X2 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham > Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl b/Platform/= ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl index 9cb2b175418c..28e255c6de6e 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN1EdgeX2/Dsdt.asl @@ -60,7 +60,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "A= RMSGI", 1150, // Wake latency (uS) 1, // Flags 1, // Arch Context Flags - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No Parent State 0x00000020, // Integer Entry method ResourceTemplate () { // Null Residency Counter @@ -75,14 +75,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -105,7 +105,7 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 1, // Parent node can be in any shallower state ResourceTemplate () { // Register Entry method Register (FFixedHW, --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90414): https://edk2.groups.io/g/devel/message/90414 Mute This Topic: https://groups.io/mt/91652416/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 20 16:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90415+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90415+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1654798813; cv=none; d=zohomail.com; s=zohoarc; b=EPSmxSKQog7uXuXXe5n72l9yMuLgWQxHcu8Br8mfm6hGa0Ccjd9ZxuNlNsmOL1ZvdJLKXCEXsQn9l2/aR5SeqnKiNTX4Up752HZrzrfQEiiTER+3LdYZoejGXuRtfqUaH0XpdyOreH/6kqnodAQHSQi/WEAWU3bMzNLGX4h+/uI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654798813; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=JjKmS9Iot4h8S9bp98HDIVXtOWsceZSgODI97Y+/ky4=; b=eeKc6gdGQN6QwjWLebWdDOMlIg7did2D4BTytWPXEaCT7I/ZIx+C5xsohBFj+r5t9936lj0ztZ5nqKoY0ouyFkx1JLynxAX7vEHWJPRleegn8JOtWUs9BPdU3x1EKqSTmcFtS2OdEmHKkecGd8LomRDyviEzch5/aG4mmyy62Cw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90415+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654798813691412.34703089983657; Thu, 9 Jun 2022 11:20:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id NAa5YY1788612xtuUA9XT9ux; Thu, 09 Jun 2022 11:20:12 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.16921.1654798811447466098 for ; Thu, 09 Jun 2022 11:20:12 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4418D12FC; Thu, 9 Jun 2022 11:20:11 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E7DD73F766; Thu, 9 Jun 2022 11:20:09 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [edk2-platforms][PATCH V1 4/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1 Date: Thu, 9 Jun 2022 23:49:52 +0530 Message-Id: <20220609181955.3018033-5-pranav.madhu@arm.com> In-Reply-To: <20220609181955.3018033-1-pranav.madhu@arm.com> References: <20220609181955.3018033-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: EjiDkjXm9hoXoVKn23UV6pjPx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654798812; bh=AivFZWHFIpPwmecfvdkDbNCVfPlKznIGYPPWr+G3x5w=; h=Cc:Date:From:Reply-To:Subject:To; b=UknUKiWzGZwl8XI9nKEZpOKpR2CeC8J5KK1xK32R3iHqIRxPyqqzJnfRB0bh4G5eRYu boQxN3YCATJ2rfXx7YmQErriA2oV/5Lh+EDMZkmERhfNLTGjGQoOh3362O6z6SgLFIeA0 i6ayFtxFkbyoqQQrxWxORUKbgXTj91VFh9g= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654798815629100020 Content-Type: text/plain; charset="utf-8" RD-V1 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham > Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl b/Platform/ARM/Sg= iPkg/AcpiTables/RdV1/Dsdt.asl index db9c19780e16..3c9c878dd880 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1/Dsdt.asl @@ -64,14 +64,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -94,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "A= RMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency - 1, // Parent node can be in any shallower state + 0, // Residency Counter Frequency + 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, 32, // Bit Width --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90415): https://edk2.groups.io/g/devel/message/90415 Mute This Topic: https://groups.io/mt/91652417/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 20 16:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90416+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90416+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1654798814; cv=none; d=zohomail.com; s=zohoarc; b=htpXuush7vLxpWKdtiyLof0IH0synSXxbDlnoMNFl8Lzyw6v0JbdVhJsxTjcMyqgVxGM/rqkUpqmNfyFLel6DV7lYxJiGizcZz0JZbGAkm2sTg4+f+DKM2QvFVRyP4bl1xR+YAjwuS4SquU3i7uCz08/M/ZQRrVt1FJBiaijQy4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654798814; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=gYEzXiopAFbGNb9XLHH5QFLGeTC4Szx13kRKNYtXXJM=; b=AmsXu8ciPpMT1a5TNqtgyj8nj4atnwDSthcTGp0954pWvKaKO1H8e08yE484xVj8JeHn6rEPO7IbYnqw81+a9/+h4hL1+Bgsb5eb4GzAjVGqc/0UhMCHMO+GQ3G79mT5X7/BFqRjizCSOB6/IL8ONaEHhtHN26n7wjO0eFdolWo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90416+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654798814701557.2769453153346; Thu, 9 Jun 2022 11:20:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Wak4YY1788612xnfee0yE3mC; Thu, 09 Jun 2022 11:20:14 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.16922.1654798813022677568 for ; Thu, 09 Jun 2022 11:20:13 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D26A5139F; Thu, 9 Jun 2022 11:20:12 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 901933F766; Thu, 9 Jun 2022 11:20:11 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [edk2-platforms][PATCH V1 5/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-V1-MC Date: Thu, 9 Jun 2022 23:49:53 +0530 Message-Id: <20220609181955.3018033-6-pranav.madhu@arm.com> In-Reply-To: <20220609181955.3018033-1-pranav.madhu@arm.com> References: <20220609181955.3018033-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: xy1199U6mtRMlZpDFsQKY3Fnx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654798814; bh=NgXYKBYmTzsTkqaYvOWe2cZhuWfax5uGmi7NdOufH3w=; h=Cc:Date:From:Reply-To:Subject:To; b=NwMzFdpP9TotSFZNUOYb9vj+qH8wOKLxT3HlD2KL9w07CQrZWvnTh89iUJyZE+Tc6pO y/HG038t6gUr0CUQM3nPUuuN/L6D52LcJTDyyd82RQD2A5fzQ4Tug2/nXPRcw0sCRc6sf hbV4jSaX4LXIPuCWDJqDE87OOmdFcQHok8k= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654798815629100019 Content-Type: text/plain; charset="utf-8" RD-V1-MC platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham > Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl b/Platform/ARM/= SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl index e084d82de7c0..152a3076fedd 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdV1Mc/Dsdt.asl @@ -64,14 +64,14 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", =20 Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -94,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "A= RMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency - 1, // Parent node can be in any shallower state + 0, // Residency Counter Frequency + 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, 32, // Bit Width --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90416): https://edk2.groups.io/g/devel/message/90416 Mute This Topic: https://groups.io/mt/91652418/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 20 16:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90417+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90417+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1654798816; cv=none; d=zohomail.com; s=zohoarc; b=aedX/MT2/hmZwTpprNDQY3DoDvu8bYS2mIR8BTtFpKCHBCDLj9myHOd3h0WflzUjoYuKbwy84LqmdOoVCWK3yARghnmS3QwvYa3896x76w/ZHsqeIPjRuftKBSOlOpQQ/MCar9BTaVmeldrbu5f5Ka8tCPDFbL8JRpUIp76/vdA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654798816; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=g6rPN3wVUESOnulHzTJdFk+04mas41MnFHsCgIVceTU=; b=PZzxI0PGJIeA3pnLUg1SfcVm9wBUT8YUDP+sbCLoKye1zMi7z8NJa1TOtsq1jFGmTbkyVv8bb3xRSUFtz+bbWvxulOuWkNle1XcYeyx7THMMWjk4IS9pqPkfCIlOjHFTfu8qvYcox9qQQ9i6Yg9ptoN9Mi1vG0yp2ImLeX5EjEQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90417+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654798816504719.6233785184116; Thu, 9 Jun 2022 11:20:16 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id RTpuYY1788612xkExktWYVrg; Thu, 09 Jun 2022 11:20:15 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.16925.1654798814712386230 for ; Thu, 09 Jun 2022 11:20:15 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7AA9412FC; Thu, 9 Jun 2022 11:20:14 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 380B13F766; Thu, 9 Jun 2022 11:20:12 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [edk2-platforms][PATCH V1 6/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2 Date: Thu, 9 Jun 2022 23:49:54 +0530 Message-Id: <20220609181955.3018033-7-pranav.madhu@arm.com> In-Reply-To: <20220609181955.3018033-1-pranav.madhu@arm.com> References: <20220609181955.3018033-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: YuVZ3f3eppMReKwDMEHNcBEzx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654798815; bh=nj5wqFLpByUfULGy7VczBcwAM7Tg6UfGNfPW2eGHBwQ=; h=Cc:Date:From:Reply-To:Subject:To; b=EOy1Zk+ObYfl8EJFPJ1VUoC7jcbSIcMT5a53v8a3g/mQA5E6VVTL6yaBhXWXAsmgSDC 7GYPqMxlKqVy1PNygxfb+1RAhfEik/KWWljPsDDZwa4OF6VMYnkQJDsPcLCjij7nqLNGb +suRCPitPY+liaIXaqVn7HKIKwlnhzmFIKQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654798817685100025 Content-Type: text/plain; charset="utf-8" RD-N2 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. As the cpus are directly connected to the interconnect on this platform, remove the cluster _LPI control method as well. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham > Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl | 78 +------------------- 1 file changed, 4 insertions(+), 74 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl b/Platform/ARM/Sg= iPkg/AcpiTables/RdN2/Dsdt.asl index ccd98f829652..0f63ca42d505 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2/Dsdt.asl @@ -62,38 +62,16 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Return (Arg3) } =20 - Name (CLPI, Package () { /* LPI for Cluster, support 1 LPI state */ - 0, // Version - 0, // Level Index - 1, // Count - Package () { // Power Gating state for Cluster - 2500, // Min residency (uS) - 1150, // Wake latency (uS) - 1, // Flags - 1, // Arch Context Flags - 100, // Residency Counter Frequency - 0, // No Parent State - 0x00000020, // Integer Entry method - ResourceTemplate () { // Null Residency Counter - Register (SystemMemory, 0, 0, 0, 0) - }, - ResourceTemplate () { // Null Usage Counter - Register (SystemMemory, 0, 0, 0, 0) - }, - "LPI2-Cluster" - }, - }) - Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -116,8 +94,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", "= ARMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency - 1, // Parent node can be in any shallower state + 0, // Residency Counter Frequency + 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, 32, // Bit Width @@ -139,9 +117,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL00) { // Cluster 0 Name (_HID, "ACPI0010") Name (_UID, 0) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP00) { // Neoverse N2 core 0 Name (_HID, "ACPI0007") @@ -166,9 +141,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL01) { // Cluster 1 Name (_HID, "ACPI0010") Name (_UID, 1) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP01) { // Neoverse N2 core 1 Name (_HID, "ACPI0007") @@ -193,9 +165,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL02) { // Cluster 2 Name (_HID, "ACPI0010") Name (_UID, 2) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP02) { // Neoverse N2 core 2 Name (_HID, "ACPI0007") @@ -220,9 +189,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL03) { // Cluster 3 Name (_HID, "ACPI0010") Name (_UID, 3) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP03) { // Neoverse N2 core 3 Name (_HID, "ACPI0007") @@ -247,9 +213,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL04) { // Cluster 4 Name (_HID, "ACPI0010") Name (_UID, 4) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP04) { // Neoverse N2 core 4 Name (_HID, "ACPI0007") @@ -274,9 +237,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL05) { // Cluster 5 Name (_HID, "ACPI0010") Name (_UID, 5) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP05) { // Neoverse N2 core 5 Name (_HID, "ACPI0007") @@ -301,9 +261,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL06) { // Cluster 6 Name (_HID, "ACPI0010") Name (_UID, 6) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP06) { // Neoverse N2 core 6 Name (_HID, "ACPI0007") @@ -328,9 +285,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL07) { // Cluster 7 Name (_HID, "ACPI0010") Name (_UID, 7) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP07) { // Neoverse N2 core 7 Name (_HID, "ACPI0007") @@ -355,9 +309,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL08) { // Cluster 8 Name (_HID, "ACPI0010") Name (_UID, 8) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP08) { // Neoverse N2 core 8 Name (_HID, "ACPI0007") @@ -382,9 +333,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL09) { // Cluster 9 Name (_HID, "ACPI0010") Name (_UID, 9) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP09) { // Neoverse N2 core 9 Name (_HID, "ACPI0007") @@ -409,9 +357,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL10) { // Cluster 10 Name (_HID, "ACPI0010") Name (_UID, 10) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP10) { // Neoverse N2 core 10 Name (_HID, "ACPI0007") @@ -436,9 +381,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL11) { // Cluster 11 Name (_HID, "ACPI0010") Name (_UID, 11) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP11) { // Neoverse N2 core 11 Name (_HID, "ACPI0007") @@ -463,9 +405,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL12) { // Cluster 12 Name (_HID, "ACPI0010") Name (_UID, 12) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP12) { // Neoverse N2 core 12 Name (_HID, "ACPI0007") @@ -490,9 +429,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL13) { // Cluster 13 Name (_HID, "ACPI0010") Name (_UID, 13) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP13) { // Neoverse N2 core 13 Name (_HID, "ACPI0007") @@ -517,9 +453,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL14) { // Cluster 14 Name (_HID, "ACPI0010") Name (_UID, 14) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP14) { // Neoverse N2 core 14 Name (_HID, "ACPI0007") @@ -544,9 +477,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL15) { // Cluster 15 Name (_HID, "ACPI0010") Name (_UID, 15) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP15) { // Neoverse N2 core 15 Name (_HID, "ACPI0007") --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90417): https://edk2.groups.io/g/devel/message/90417 Mute This Topic: https://groups.io/mt/91652420/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 20 16:31:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+90418+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90418+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1654798817; cv=none; d=zohomail.com; s=zohoarc; b=E4LVZldvEOGnNREpLeiJwyjpk8c0hOXPvoa/fPkL2WOcuRzgTurifL3HnVKsZ2qVF0MFR2Ji4UIyNQvJKSd+r8PonV0hWBZ4vG96NxSwh6u0BxEmtanLBjY0rG0LxkZV93akSc7lxG0ybMstSOqLxRzOLT8W46RQnwsuFECRuoc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1654798817; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=lEXMYWBm2sC428oEsEd9+mjkBQsfYgzZ2+nX5o0vqw4=; b=MXd0QA89cHk20s8/yFf3UCBg5WCrmHsBcWXDqJ6IxnHUIX58Rouyuksw6BtS6zFzkoV3MndyjDMZocQRLXJiEWfGULLRoFtHBoTki+OdoDFL9L1qT3Rw+57DR6Ha0vxPQBUiCGSjbiEcfeAUfcV55pnOeM895GXEz5e2YlWEvqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+90418+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1654798817820300.58842766251485; Thu, 9 Jun 2022 11:20:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id hb9zYY1788612xYwCM8QglwU; Thu, 09 Jun 2022 11:20:17 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.17071.1654798816302336882 for ; Thu, 09 Jun 2022 11:20:16 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2352D139F; Thu, 9 Jun 2022 11:20:16 -0700 (PDT) X-Received: from usa.arm.com (unknown [10.162.16.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D45F13F766; Thu, 9 Jun 2022 11:20:14 -0700 (PDT) From: "Pranav Madhu" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Sami Mujawar Subject: [edk2-devel] [edk2-platforms][PATCH V1 7/7] Platform/Sgi: Fix ACPI Low Power Idle states for RD-N2-Cfg1 Date: Thu, 9 Jun 2022 23:49:55 +0530 Message-Id: <20220609181955.3018033-8-pranav.madhu@arm.com> In-Reply-To: <20220609181955.3018033-1-pranav.madhu@arm.com> References: <20220609181955.3018033-1-pranav.madhu@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pranav.madhu@arm.com X-Gm-Message-State: aHd8Bofr4NLSUTDPJyzu8ZxZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1654798817; bh=/tWmVRLvbE5ZaokgDHr9luyIE34JOhtOWEJSCZlHJHs=; h=Cc:Date:From:Reply-To:Subject:To; b=OK4tolZwqhZvOz8eIZDv9NOgEac7ZBIBWF/we9tpXtSInxiaRvPQjAjeCu2NHALt5xQ aBG6Ra/sWi8zYrMULrdWkmf1zqOVWLoMQaKVFm3ZRuz3sTDi7lrP6eqimQmPjAfl2NHTw 8fWga67+ZGgyHDcYykinBX3kvIjrpttpGf4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1654798819615100031 Content-Type: text/plain; charset="utf-8" RD-N2-Cfg1 platform supports only the platform co-ordinated LPI. So fix the LPI Level ID value accordingly. Additionally, as this platform does not support residency counter, clear the residency counter frequency from _LPI object's control method. As the cpus are directly connected to the interconnect on this platform, remove the cluster _LPI control method as well. Signed-off-by: Pranav Madhu Reviewed-by: Pierre Gondois Reviewed-by: Thomas Abraham > Reviewed-by: Thomas Abraham --- Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl | 54 ++------------------ 1 file changed, 4 insertions(+), 50 deletions(-) diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl b/Platform/AR= M/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl index b6decc77f480..2e9e588806c6 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg1/Dsdt.asl @@ -68,38 +68,16 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Return (Arg3) } =20 - Name (CLPI, Package () { /* LPI for Cluster, support 1 LPI state */ - 0, // Version - 0, // Level Index - 1, // Count - Package () { // Power Gating state for Cluster - 2500, // Min residency (uS) - 1150, // Wake latency (uS) - 1, // Flags - 1, // Arch Context Flags - 100, // Residency Counter Frequency - 0, // No Parent State - 0x00000020, // Integer Entry method - ResourceTemplate () { // Null Residency Counter - Register (SystemMemory, 0, 0, 0, 0) - }, - ResourceTemplate () { // Null Usage Counter - Register (SystemMemory, 0, 0, 0, 0) - }, - "LPI2-Cluster" - }, - }) - Name (PLPI, Package () { /* LPI for Processor, support 2 LPI states */ 0, // Version - 1, // Level Index + 0, // Level Index 2, // Count Package () { // WFI for CPU 1, // Min residency (uS) 1, // Wake latency (uS) 1, // Flags 0, // Arch Context lost Flags (no loss) - 100, // Residency Counter Frequency + 0, // Residency Counter Frequency 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, @@ -122,8 +100,8 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", 350, // Wake latency (uS) 1, // Flags 1, // Arch Context lost Flags (Core context los= t) - 100, // Residency Counter Frequency - 1, // Parent node can be in any shallower state + 0, // Residency Counter Frequency + 0, // No parent state ResourceTemplate () { // Register Entry method Register (FFixedHW, 32, // Bit Width @@ -145,9 +123,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL00) { // Cluster 0 Name (_HID, "ACPI0010") Name (_UID, 0) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP00) { // Neoverse N2 core 0 Name (_HID, "ACPI0007") @@ -172,9 +147,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL01) { // Cluster 1 Name (_HID, "ACPI0010") Name (_UID, 1) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP01) { // Neoverse N2 core 1 Name (_HID, "ACPI0007") @@ -199,9 +171,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL02) { // Cluster 2 Name (_HID, "ACPI0010") Name (_UID, 2) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP02) { // Neoverse N2 core 2 Name (_HID, "ACPI0007") @@ -226,9 +195,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL03) { // Cluster 3 Name (_HID, "ACPI0010") Name (_UID, 3) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP03) { // Neoverse N2 core 3 Name (_HID, "ACPI0007") @@ -253,9 +219,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL04) { // Cluster 4 Name (_HID, "ACPI0010") Name (_UID, 4) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP04) { // Neoverse N2 core 4 Name (_HID, "ACPI0007") @@ -280,9 +243,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL05) { // Cluster 5 Name (_HID, "ACPI0010") Name (_UID, 5) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP05) { // Neoverse N2 core 5 Name (_HID, "ACPI0007") @@ -307,9 +267,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL06) { // Cluster 6 Name (_HID, "ACPI0010") Name (_UID, 6) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP06) { // Neoverse N2 core 6 Name (_HID, "ACPI0007") @@ -334,9 +291,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 2, "ARMLTD", = "ARMSGI", Device (CL07) { // Cluster 7 Name (_HID, "ACPI0010") Name (_UID, 7) - Method (_LPI, 0, NotSerialized) { - Return (\_SB.CLPI) - } =20 Device (CP07) { // Neoverse N2 core 7 Name (_HID, "ACPI0007") --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90418): https://edk2.groups.io/g/devel/message/90418 Mute This Topic: https://groups.io/mt/91652421/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-