From nobody Sun Feb 8 19:39:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88724+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88724+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1649710731; cv=none; d=zohomail.com; s=zohoarc; b=R7eB+BOK3SjKaj7X28EXHKSPaMW6JGBDATxRUM/DC+MxOIXombbohDdSkl8KWWtzIt9vKISORGZHeagiWHaFFsqbuBEs5YEuI2usKxIf7m8JS7Vgpwkv7Qt0QajKA8UFtRYJWBwWpryPdcX/MnONgduU4umjT0BLqOzSAGJmV9s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649710731; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=YDLrkt4KTbZzaYzuynZYIsw2uCzxltz9vBTCR8ARRf4=; b=TgneJNB3BVLLqjp2HxoFeKNBrXJ5ewkvXPAD+KGo1aHg0ATVb4I3AxqpsiUVrltNxES/2cQp4T43N0i5+eOyehIaChiMQIJUGjDm/IdL1YrEPgFZYoWSYDOGc4nFj4DTy4FROlKqMKKpBvm8GCNClnF5MLxGpePJn5QWOVscJu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88724+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1649710731300736.2912588358308; Mon, 11 Apr 2022 13:58:51 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id gskqYY1788612xltLPOqQeeJ; Mon, 11 Apr 2022 13:58:50 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.2894.1649710729998419155 for ; Mon, 11 Apr 2022 13:58:50 -0700 X-Received: from localhost.localdomain (unknown [47.201.46.36]) by linux.microsoft.com (Postfix) with ESMTPSA id 20B3D209F585; Mon, 11 Apr 2022 13:58:49 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 20B3D209F585 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Nate DeSimone Subject: [edk2-devel] [edk2-platforms][PATCH v1 3/3] SimicsOpenBoardPkg/AcpiPlatform: Use FADT duty offset and width PCDs Date: Mon, 11 Apr 2022 16:58:13 -0400 Message-Id: <20220411205813.2908-4-mikuback@linux.microsoft.com> In-Reply-To: <20220411205813.2908-1-mikuback@linux.microsoft.com> References: <20220411205813.2908-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: 7H21n4KHOxjtQF7rSXXDHBI2x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1649710730; bh=IWBHAWNJMAE0azwxFHnisEfeK7bVQzfZTyf51YKY/UY=; h=Cc:Date:From:Reply-To:Subject:To; b=I6nCdPRwQS7B16MzLh7/f86YhMIqBz9RZPyLHkG3B0eZcTGWAHRTwEZQDBqynkwmh5n KIE0Gy47K93ek51VU/r5nj/ahKC8WUtI4MOXruwFOPolkgX29YwZTZQX/UOYwECYizENq eV7peWurGLhEZJ/FLWqhY6fW0T+7Cn6khyQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1649710731855100009 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3543 Updates the FADT DUTY_OFFSET and DUTY_WIDTH values during boot in the function PlatformUpdateTables() along with other previously updated values in the FADT. Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPla= tform.c | 3 +++ Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fadt/Fa= dt.c | 4 ++-- Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/AcpiPla= tform.inf | 2 ++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTa= bles/AcpiPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatf= ormAcpiTables/AcpiPlatform.c index 1edac89240fa..b06119f5eae7 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac= piPlatform.c +++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac= piPlatform.c @@ -1328,6 +1328,9 @@ PlatformUpdateTables ( FadtHeader->XGpe1Blk.AccessSize =3D 0; } =20 + FadtHeader->DutyOffset =3D PcdGet8 (PcdFadtDutyOffset); + FadtHeader->DutyWidth =3D PcdGet8 (PcdFadtDutyWidth); + DEBUG(( EFI_D_ERROR, "ACPI FADT table @ address 0x%x\n", Table )); DEBUG(( EFI_D_ERROR, " IaPcBootArch 0x%x\n", FadtHeader->IaPcBootArch= )); DEBUG(( EFI_D_ERROR, " Flags 0x%x\n", FadtHeader->Flags )); diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTa= bles/Fadt/Fadt.c b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatform= AcpiTables/Fadt/Fadt.c index d1fe98e24bc7..652f1f2e87af 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fa= dt/Fadt.c +++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Fa= dt/Fadt.c @@ -34,8 +34,8 @@ #define EFI_ACPI_P_LVL3_LAT 0x03E9 // 1001 #define EFI_ACPI_FLUSH_SIZE 0x0000 #define EFI_ACPI_FLUSH_STRIDE 0x0000 -#define EFI_ACPI_DUTY_OFFSET 0x01 -#define EFI_ACPI_DUTY_WIDTH 0x00 +#define EFI_ACPI_DUTY_OFFSET 0x00 // To be fixed during boot +#define EFI_ACPI_DUTY_WIDTH 0x00 // To be fixed during boot =20 #define EFI_ACPI_DAY_ALRM 0x0D #define EFI_ACPI_MON_ALRM 0x00 diff --git a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTa= bles/AcpiPlatform.inf b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPla= tformAcpiTables/AcpiPlatform.inf index 7dfd0832a308..c6198fb76307 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac= piPlatform.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/AcpiTables/MinPlatformAcpiTables/Ac= piPlatform.inf @@ -61,6 +61,8 @@ [Pcd] gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags + gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset + gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth =20 gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88724): https://edk2.groups.io/g/devel/message/88724 Mute This Topic: https://groups.io/mt/90405227/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-