From nobody Sun Feb 8 19:39:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88723+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88723+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1649710727; cv=none; d=zohomail.com; s=zohoarc; b=HVV0Kj1g0AXppVJxM7fmf4CiGZnZeXjCqSAyHPvbqA7OgJsRA6O1H+UKraCKP1qMNG5Xat2bmt6CfjfIUy3RVt6t2hSsKgaPBSQF98AHd/h7ul06NqTsNmz/HVmGpRgF3wjXKOYDgFnN+J1nYHv2oO7DsO9ey3aZkx/mqESSvD4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649710727; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=T/FqvkocQ/6FmqvRUAawbAnNRaxlyPqYjilVVWXvI88=; b=D/yB1dORen9LY2YH5AGlugscbElMV87TewzuzpH4ibiq6MG0om6iRpmToakJJKCMoXjqIRl5oYi5SCLmxUG8ugRjmbND2YMJrOPTmObtqnYx+YMZCYgKXSsZDCREDEJV9z3Az3qwgFegNp5vtFe7ODdMZ2Ja4nwkoOCAlHHq+qA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88723+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 164971072772349.974785335601155; Mon, 11 Apr 2022 13:58:47 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ug4IYY1788612xIbhYt0363O; Mon, 11 Apr 2022 13:58:47 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web09.2892.1649710726266624238 for ; Mon, 11 Apr 2022 13:58:46 -0700 X-Received: from localhost.localdomain (unknown [47.201.46.36]) by linux.microsoft.com (Postfix) with ESMTPSA id 3F49F209DDA2; Mon, 11 Apr 2022 13:58:45 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3F49F209DDA2 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel] [edk2-platforms][PATCH v1 2/3] MinPlatformPkg/AcpiPlatform: Use FADT duty offset and width PCDs Date: Mon, 11 Apr 2022 16:58:12 -0400 Message-Id: <20220411205813.2908-3-mikuback@linux.microsoft.com> In-Reply-To: <20220411205813.2908-1-mikuback@linux.microsoft.com> References: <20220411205813.2908-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: SR5xfQROCHzkMPpFGCoxUKSux1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1649710727; bh=gIi3Fn1+Voxq7hwniaF8f82D6PmzAAp+r9sMGi7mmWU=; h=Cc:Date:From:Reply-To:Subject:To; b=bjzXFcf8QkUd6rBV8Z2K4zqcXVf4NE+Rtp+7vJbrlbhGv4eU39JeUv0J38O6NAsv4P+ oB/ecMrT5Q8jetXwMWSCYHkrK6w/GpoClUbXBbrYOd8JvWNDBSqi8wnDB62iDVaDa1a/0 H+g38YZNdNWusPJ8k84XRufowKUaHMhc2Zo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1649710729869100007 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3543 Updates the FADT DUTY_OFFSET and DUTY_WIDTH values during boot in the function PlatformUpdateTables() along with other previously updated values in the FADT. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 3 +++ Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c | 4 ++-- Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf | 2 ++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c b= /Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c index 05fc7799fb13..508de9101306 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c @@ -1226,6 +1226,9 @@ PlatformUpdateTables ( FadtHeader->XGpe1Blk.AccessSize =3D 0; } =20 + FadtHeader->DutyOffset =3D PcdGet8 (PcdFadtDutyOffset); + FadtHeader->DutyWidth =3D PcdGet8 (PcdFadtDutyWidth); + DEBUG ((DEBUG_INFO, "ACPI FADT table @ address 0x%x\n", Table)); DEBUG ((DEBUG_INFO, " IaPcBootArch 0x%x\n", FadtHeader->IaPcBootArch)= ); DEBUG ((DEBUG_INFO, " Flags 0x%x\n", FadtHeader->Flags)); diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c b/Pl= atform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c index 3418e960972f..70b769b84693 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/Fadt/Fadt.c @@ -35,8 +35,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #define EFI_ACPI_P_LVL3_LAT 0x03E9 // 1001 #define EFI_ACPI_FLUSH_SIZE 0x0000 #define EFI_ACPI_FLUSH_STRIDE 0x0000 -#define EFI_ACPI_DUTY_OFFSET 0x01 -#define EFI_ACPI_DUTY_WIDTH 0x00 +#define EFI_ACPI_DUTY_OFFSET 0x00 // To be fixed during boot +#define EFI_ACPI_DUTY_WIDTH 0x00 // To be fixed during boot =20 #define EFI_ACPI_DAY_ALRM 0x0D #define EFI_ACPI_MON_ALRM 0x00 diff --git a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf= b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf index 99adf9c381c9..59ef5e2e544e 100644 --- a/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf +++ b/Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.inf @@ -64,6 +64,8 @@ [Pcd] gMinPlatformPkgTokenSpaceGuid.PcdFadtPreferredPmProfile gMinPlatformPkgTokenSpaceGuid.PcdFadtIaPcBootArch gMinPlatformPkgTokenSpaceGuid.PcdFadtFlags + gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyOffset + gMinPlatformPkgTokenSpaceGuid.PcdFadtDutyWidth =20 gPcAtChipsetPkgTokenSpaceGuid.PcdHpetBaseAddress gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88723): https://edk2.groups.io/g/devel/message/88723 Mute This Topic: https://groups.io/mt/90405222/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-