From nobody Mon Feb 9 22:38:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88673+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88673+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1649639844; cv=none; d=zohomail.com; s=zohoarc; b=NChooFjgG8P182qcfohj7rwmiIjIhBqC9K0Rb/6L6q233ZfLLSXPJqkqadMp+hhoEeTUiB2lU/X3ToegSlXD9hjXVlWRM9NvlrAuVR3SVWIUQXx/WvTjT678hKENR+BaAZrZwztf8vjWwL30f4q+uzr6yNFoEsxmDCRNGfV3VqA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1649639844; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=2Nne/pw3OBbcYfm1OSg+amv1jY9K6QiCUPCrjcBDPTM=; b=OYX5shONAF3F07R6HQ/m1FUWShoCtC69MPFMA+YPD/xc0Cdyps3SadGYf4dBhJX8G+8EWcZ4PklAHkDyeBXqunWgghqOETLF89M5MMq2v//3gWNv9aNW1JqWpRqTa8P4vQT1tXJuppJJlPHQ89sNmDeXViNU7qGCMM2omj6ad1o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88673+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1649639844881773.1447861518913; Sun, 10 Apr 2022 18:17:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id X0ODYY1788612xex1rYtGHrr; Sun, 10 Apr 2022 18:17:24 -0700 X-Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.24504.1649639843492322392 for ; Sun, 10 Apr 2022 18:17:23 -0700 X-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CED585C010D; Sun, 10 Apr 2022 21:17:22 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 10 Apr 2022 21:17:22 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudekhedgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomheptfgvsggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghs ughiohdrtghomheqnecuggftrfgrthhtvghrnhepveeiffeivdevudetueehiedthedthe fhtdehfeelkeeitdfhhfefleetieehgfevnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Apr 2022 21:17:22 -0400 (EDT) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel Subject: [edk2-devel] [PATCH 3/3] ArmPlatformPkg: Fix EDK2_DSC check in Scripts/Makefile Date: Sun, 10 Apr 2022 19:16:59 -0600 Message-Id: <20220411011659.191390-4-rebecca@bsdio.com> In-Reply-To: <20220411011659.191390-1-rebecca@bsdio.com> References: <20220411011659.191390-1-rebecca@bsdio.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@bsdio.com X-Gm-Message-State: FPAxeUtKGWX5YOZAhpoRiC2Wx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1649639844; bh=6lfBLQz/3R+2ySrLAmoZw08buDJ5f0WmCNI1cSLrWdc=; h=Cc:Date:From:Reply-To:Subject:To; b=W+0ZLqbdk2megbB6bp2M2kUB0wzuYKzktoD+Hoe/51x/OWVy496eP9VrlFqS9fTF8VC Bnmrpj6E+aBc6JvN7X8o2/kSgcbNgkr6aZww9AQrQzgJK5yZtG6kDXuKN+H7rAoxAS41t l273Izz9eJkZLLAOYnIP44ZtWJxoLU3vEu0= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1649639846305100015 Content-Type: text/plain; charset="utf-8" With GNU Make 4.2.1, ifeq ($(EDK2_DSC),"") doesn't catch the case where EDK2_DSC isn't defined. So, switch to using ifndef. Signed-off-by: Rebecca Cran --- ArmPlatformPkg/Scripts/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPlatformPkg/Scripts/Makefile b/ArmPlatformPkg/Scripts/Makef= ile index da949dc1ed56..270fc80b6ae8 100644 --- a/ArmPlatformPkg/Scripts/Makefile +++ b/ArmPlatformPkg/Scripts/Makefile @@ -12,7 +12,7 @@ EDK2_TOOLCHAIN ?=3D RVCTLINUX EDK2_ARCH ?=3D ARM EDK2_BUILD ?=3D DEBUG =20 -ifeq ($(EDK2_DSC),"") +ifndef EDK2_DSC $(error The Makfile macro 'EDK2_DSC' must be defined with an EDK2 DSC fi= le.) endif ifeq ("$(EDK2_DSC)","ArmPlatformPkg/ArmVExpressPkg/ArmVExpress-FVP-AArch64= .dsc") --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88673): https://edk2.groups.io/g/devel/message/88673 Mute This Topic: https://groups.io/mt/90385958/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-