From nobody Fri May 17 03:00:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88261+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88261+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1648654110; cv=none; d=zohomail.com; s=zohoarc; b=hsxcbDA/Nrc7rmfTQdXz0gsVY5xYGDSr5hS4qZIWMRZGyGWh/QuVQ+yXx/HAZFEdX60B/37t9tFn7CtYKFoOcc/rENjld1NfMKP+1nvH3UW95VBr/5y9SFarjitWgopHemlsuecfeZAqlbqwrkJvpUZupxkVQNWmr2AgTUlPCGM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648654110; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=b8+MGyzpT3BdprJDmCaEHKN6fo76dteF1ogSRf49/h4=; b=jrdaJmetwsnZ2/baa9DyJD1hCNDD8WEDCUeM87PHBH5Mle22dUsvOdEStvMVuqpmaaG73XFutF7O7c8vNJWH830ZcxsKl7B2bBS1rF9ZML/3Tt8h0/n4D1w9wKOmchsU7javpbGmObP4Z2H51slr9KPGT/MOaoJxX1NCiz02SdQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88261+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1648654110847151.1387406211436; Wed, 30 Mar 2022 08:28:30 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id BKucYY1788612xI3GqvU1Ogv; Wed, 30 Mar 2022 08:28:30 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web12.210.1648654109763097946 for ; Wed, 30 Mar 2022 08:28:29 -0700 X-Received: from localhost.localdomain (unknown [47.202.59.224]) by linux.microsoft.com (Postfix) with ESMTPSA id A267020DEE2D; Wed, 30 Mar 2022 08:28:28 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A267020DEE2D From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/2] MinPlatformPkg/TestPointCheckLib: Prevent MemTypeInfo HOB modification Date: Wed, 30 Mar 2022 11:28:02 -0400 Message-Id: <20220330152803.1919-2-mikuback@linux.microsoft.com> In-Reply-To: <20220330152803.1919-1-mikuback@linux.microsoft.com> References: <20220330152803.1919-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: g8Y1gdOgxiFfjKe3OhAjJ8u4x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1648654110; bh=WJoz8FJlLt1ZB0bWmod41+LDk9HrKHeyhAYSbMcFKII=; h=Cc:Date:From:Reply-To:Subject:To; b=q2uFxgYpZlFBUGx7kgHrLWNH7SeItEpFlHU9FCneo9KU8ds1Oo7EfMt7NzvwUKZcy+M K1U9LidDPbJwNMz4/SMOfVEeqcLrnXjz2xFD6rkDOqprRZlnkM7AaTpfcCqX6j6uuNbKS bxmhLitBv6srldYiiAxmecsr7fKunFTizzY= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1648654111564100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The function DumpMemoryTypeInfoSummary() is written to dump data from the memory type information HOB. However, it actually modifies the HOB data. This can be logic later in boot dependent on the HOB value. This change removes modification of the HOB data. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemor= yTypeInformation.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library= /TestPointCheckLib/DxeCheckMemoryTypeInformation.c index 9ee9dd252c7e..c4dd3c7c9519 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c @@ -22,8 +22,8 @@ ShortNameOfMemoryType( =20 VOID DumpMemoryTypeInfoSummary ( - IN EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation, - IN EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation + IN CONST EFI_MEMORY_TYPE_INFORMATION *CurrentMemoryTypeInformation, + IN CONST EFI_MEMORY_TYPE_INFORMATION *PreviousMemoryTypeInformation ) { UINTN Index; @@ -83,7 +83,6 @@ DumpMemoryTypeInfoSummary ( } =20 if (Next !=3D Previous) { - PreviousMemoryTypeInformation[Index].NumberOfPages =3D Next; MemoryTypeInformationModified =3D TRUE; } =20 @@ -110,7 +109,7 @@ TestPointCheckMemoryTypeInformation ( VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; VOID *VariableMemoryTypeInformation; - =20 + DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckMemoryTypeInformation - = Enter\n")); CurrentMemoryTypeInformation =3D NULL; PreviousMemoryTypeInformation =3D NULL; --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88261): https://edk2.groups.io/g/devel/message/88261 Mute This Topic: https://groups.io/mt/90133982/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Fri May 17 03:00:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+88262+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88262+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1648654115; cv=none; d=zohomail.com; s=zohoarc; b=DS5d2RscbAN/mQaTlL8MQFuLaEwmXBnxpEzIW4UQRhHBEYIijMq7lbLSEqDpFKTL93SMe6kvOZnZzc/IjsQw593sJ+ACrxuU89kozBr9vfy4LgnxDq/Btgky8Pcec66ppgAGl/H/0HM4AG+YPe4GFuys64Vtdyua+KdTd12dyUM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648654115; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=g6PPeRnodNyViQUkefbfOYAUhRStcCWqlz9rtVTDXLM=; b=dIEDf88jcsuGO69pBQCXGbSHRosMbfwCwMI9JWqd8nLi1AcBLin9fLtuZoJcu99WjO0K1flGVC/kWwCOh2Ra99BLoi4UQt1Crotq0mnfbAotXPDY7EF+JlIerZ3NZmdP8ZRVeeX+1cOJ9tAsFfiW74+HahKI61j7ucFh1yX4smE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+88262+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1648654115943390.5607028820041; Wed, 30 Mar 2022 08:28:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id agg5YY1788612xcKNfbokxr2; Wed, 30 Mar 2022 08:28:35 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web08.233.1648654114469967427 for ; Wed, 30 Mar 2022 08:28:34 -0700 X-Received: from localhost.localdomain (unknown [47.202.59.224]) by linux.microsoft.com (Postfix) with ESMTPSA id 3F8B920DEE50; Wed, 30 Mar 2022 08:28:33 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3F8B920DEE50 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel] [edk2-platforms][PATCH v1 2/2] MinPlatformPkg/TestPointCheckLib: Remove unused variable Date: Wed, 30 Mar 2022 11:28:03 -0400 Message-Id: <20220330152803.1919-3-mikuback@linux.microsoft.com> In-Reply-To: <20220330152803.1919-1-mikuback@linux.microsoft.com> References: <20220330152803.1919-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: pU6jsSk1t1YOo7T86m3nkwHEx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1648654115; bh=0KJBxLmZ+MoTViijAmsTCwnI1XL+F6GZgSTyoIHQxRI=; h=Cc:Date:From:Reply-To:Subject:To; b=SxfFA5jAZ+vvZrj6rT7uIYC7grAM71lF1n3I05Z8XdS/rNNJl/1J52I0sE7NmyGRIaL CCNfecbfHd21v5/B7m1+ySNDE2B+16OUAsKJ2GVCA37Hy51YPBmKxUW+NmLn3ndwRwrm4 MsVwdLlnw1Dx3nkp3BYj5eBekYvuYYA8x6s= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1648654117596100003 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki The variable VariableMemoryTypeInformation is set but never used. This change removes the variable. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Michael Kubacki --- Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckMemor= yTypeInformation.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/D= xeCheckMemoryTypeInformation.c b/Platform/Intel/MinPlatformPkg/Test/Library= /TestPointCheckLib/DxeCheckMemoryTypeInformation.c index c4dd3c7c9519..0d3da7320fdd 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheck= MemoryTypeInformation.c @@ -108,7 +108,6 @@ TestPointCheckMemoryTypeInformation ( EFI_HOB_GUID_TYPE *GuidHob; VOID *CurrentMemoryTypeInformation; VOID *PreviousMemoryTypeInformation; - VOID *VariableMemoryTypeInformation; =20 DEBUG ((DEBUG_INFO, "=3D=3D=3D=3D TestPointCheckMemoryTypeInformation - = Enter\n")); CurrentMemoryTypeInformation =3D NULL; @@ -127,13 +126,6 @@ TestPointCheckMemoryTypeInformation ( goto Done; } =20 - GetVariable2 ( - EFI_MEMORY_TYPE_INFORMATION_VARIABLE_NAME, - &gEfiMemoryTypeInformationGuid, - &VariableMemoryTypeInformation, - NULL - ); - if ((CurrentMemoryTypeInformation !=3D NULL) && (PreviousMemoryTypeInfor= mation !=3D NULL)) { DumpMemoryTypeInfoSummary(CurrentMemoryTypeInformation, PreviousMemory= TypeInformation); } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88262): https://edk2.groups.io/g/devel/message/88262 Mute This Topic: https://groups.io/mt/90133986/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-