From nobody Mon Feb 9 19:05:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87983+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87983+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1648123485; cv=none; d=zohomail.com; s=zohoarc; b=WowbluN/kOBrXxT6aLGEqf76gICGMUuMhjjBnWPq+Yi26IL15lV2HW5lXgFt257LmyZIexU5F9WD7T3iwxTkGoYTkzZhvIW/xDdDuAO5mzEKQd3hgNz5a23G7kaFA1mpRM2qoBh4jRia5jYkTd4CDChTkQty+u+qGaT/jwShNho= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1648123485; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Zj7+eHlxBFe5F7QeyE7vL05GriwHYKeJYLiSCSjSzpI=; b=Vk+OrWgIXtlfjHWN63OqlKukKh177JoUGBECmt7It7TmN6p6a//gKKQz6RIkUn7aSjhPy39Qti0c786qkExHB8/nIHcbrI8unxvZn0hbhkBDatJWqHpsHS63Vr1WyY3hvbYNm96u2D4LucjOaGL5w2xcp+794kXlvqF9zucyR1U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87983+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16481234856921010.7971584119105; Thu, 24 Mar 2022 05:04:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id fMGaYY1788612xfa5LuMqLEp; Thu, 24 Mar 2022 05:04:45 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.9783.1648123484037938204 for ; Thu, 24 Mar 2022 05:04:44 -0700 X-Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-564-rat00wuJOtGIdLEekxgWMw-1; Thu, 24 Mar 2022 08:04:39 -0400 X-MC-Unique: rat00wuJOtGIdLEekxgWMw-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 748F43C163E1; Thu, 24 Mar 2022 12:04:39 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.196.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3606C698CF0; Thu, 24 Mar 2022 12:04:39 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 511121800614; Thu, 24 Mar 2022 13:04:36 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: Pawel Polawski , Liming Gao , Yuwei Chen , Oliver Steffen , Bob Feng , Gerd Hoffmann Subject: [edk2-devel] [PATCH 1/3] BaseTools: fix gcc12 warning Date: Thu, 24 Mar 2022 13:04:34 +0100 Message-Id: <20220324120436.939688-2-kraxel@redhat.com> In-Reply-To: <20220324120436.939688-1-kraxel@redhat.com> References: <20220324120436.939688-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com X-Gm-Message-State: O9oT1zIku0uI0MVVKi80WR4Cx1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1648123485; bh=3AH1UZEQcV0WdbGFZoddbQGdfzCg4YCPJDpjSrjd5D4=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=ib+Z3bA0FOtDS/lF3QDW6aM6eyobiUCQYdwqqHtGyUSkvPWG1nT5Pyej7uanUsKYYnz Rr6XQLI9N83URi6seE+POE0Hp1j2im/FVLba9oEFB3ZtLDCejC5wl13XeBSeqSgD/IRPL MfNrBnvcNssXCzr4ydCOCSHtWbBZouk6jOs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1648123486940100001 GenFfs.c:545:5: error: pointer =E2=80=98InFileHandle=E2=80=99 used after = =E2=80=98fclose=E2=80=99 [-Werror=3Duse-after-free] 545 | Error(NULL, 0, 4001, "Resource", "memory cannot be allocated o= f %s", InFileHandle); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~~~~~~~~~~~ GenFfs.c:544:5: note: call to =E2=80=98fclose=E2=80=99 here 544 | fclose (InFileHandle); | ^~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Gerd Hoffmann --- BaseTools/Source/C/GenFfs/GenFfs.c | 2 +- BaseTools/Source/C/GenSec/GenSec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFfs/GenFfs.c b/BaseTools/Source/C/GenFfs= /GenFfs.c index 949025c33325..d78d62ab3689 100644 --- a/BaseTools/Source/C/GenFfs/GenFfs.c +++ b/BaseTools/Source/C/GenFfs/GenFfs.c @@ -542,7 +542,7 @@ GetAlignmentFromFile(char *InFile, UINT32 *Alignment) PeFileBuffer =3D (UINT8 *) malloc (PeFileSize); if (PeFileBuffer =3D=3D NULL) { fclose (InFileHandle); - Error(NULL, 0, 4001, "Resource", "memory cannot be allocated of %s", = InFileHandle); + Error(NULL, 0, 4001, "Resource", "memory cannot be allocated for %s", = InFile); return EFI_OUT_OF_RESOURCES; } fread (PeFileBuffer, sizeof (UINT8), PeFileSize, InFileHandle); diff --git a/BaseTools/Source/C/GenSec/GenSec.c b/BaseTools/Source/C/GenSec= /GenSec.c index d54a4f9e0a7d..b1d05367ec0b 100644 --- a/BaseTools/Source/C/GenSec/GenSec.c +++ b/BaseTools/Source/C/GenSec/GenSec.c @@ -1062,7 +1062,7 @@ GetAlignmentFromFile(char *InFile, UINT32 *Alignment) PeFileBuffer =3D (UINT8 *) malloc (PeFileSize); if (PeFileBuffer =3D=3D NULL) { fclose (InFileHandle); - Error(NULL, 0, 4001, "Resource", "memory cannot be allocated of %s", = InFileHandle); + Error(NULL, 0, 4001, "Resource", "memory cannot be allocated for %s", = InFile); return EFI_OUT_OF_RESOURCES; } fread (PeFileBuffer, sizeof (UINT8), PeFileSize, InFileHandle); --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87983): https://edk2.groups.io/g/devel/message/87983 Mute This Topic: https://groups.io/mt/89997410/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-