From nobody Sun Feb 8 06:05:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87813+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87813+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1647914348064809.1996602385774; Mon, 21 Mar 2022 18:59:08 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id oWriYY1788612xyaRrMCdaZm; Mon, 21 Mar 2022 18:59:09 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.4781.1647914348746664614 for ; Mon, 21 Mar 2022 18:59:08 -0700 X-Received: from localhost.localdomain (unknown [47.202.59.224]) by linux.microsoft.com (Postfix) with ESMTPSA id 8A84420DE47F; Mon, 21 Mar 2022 18:59:07 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8A84420DE47F From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Rebecca Cran , Peter Grehan , Laszlo Ersek Subject: [edk2-devel] [PATCH v1 4/4] OvmfPkg: Do not check VbeShim.h formatting with Uncrustify Date: Mon, 21 Mar 2022 21:58:14 -0400 Message-Id: <20220322015814.9182-5-mikuback@linux.microsoft.com> In-Reply-To: <20220322015814.9182-1-mikuback@linux.microsoft.com> References: <20220322015814.9182-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: ACSospip52E03u5tiYcYaA4Rx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1647914349; bh=AUSQJsO1KBWIvU8djQQFNLQOwWAH0mvXp/gxmbFfDzA=; h=Cc:Date:From:Reply-To:Subject:To; b=IL6J4BI9qcHnsmP6iY+PiRhjjS3ow45lanq7FxGpWMp3zat4OFhqhSQRnGWyjdosZI5 Re+TyvAUoCXmHybLBEowj/E+Kn5kNDpsIitcXc2HYlGbQ95LH4bTLzXn6IZhWQQVOC7eG KECaZ1xkP9668kTvu4gRrFRMtE62ZP7YUlM= X-ZohoMail-DKIM: fail (Signature date is -1 seconds in the future.) X-ZM-MESSAGEID: 1647914350043100005 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3875 The following files: OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h OvmfPkg/QemuVideoDxe/VbeShim.h Are auto generated by the following generators: OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.sh OvmfPkg/QemuVideoDxe/VbeShim.sh Therefore, Uncrustify causes a file update to produce a very large diff due to formatting changes. This change does the following: 1. Reverts the Uncrustify changes applied to the files in commit ac0a286f4d74. 2. Uses a new UncrustifyCheck CI plugin configuration option to exclude the files from future formatting checks. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Rebecca Cran Cc: Peter Grehan Cc: Laszlo Ersek Signed-off-by: Michael Kubacki Acked-by: Gerd Hoffmann Acked-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.ci.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml index 7459b84d8090..ff022242b018 100644 --- a/OvmfPkg/OvmfPkg.ci.yaml +++ b/OvmfPkg/OvmfPkg.ci.yaml @@ -97,5 +97,10 @@ ], # words to extend to the dictionary for this package "IgnoreStandardPaths": [], # Standard Plugin defined paths that = should be ignore "AdditionalIncludePaths": [] # Additional paths to spell check (wi= ldcards supported) + }, + + # options defined in .pytool/Plugin/UncrustifyCheck + "UncrustifyCheck": { + "IgnoreFiles": ["VbeShim.h"] } } --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87813): https://edk2.groups.io/g/devel/message/87813 Mute This Topic: https://groups.io/mt/89944186/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-