From nobody Sun Feb 8 07:07:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87810+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87810+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.microsoft.com ARC-Seal: i=1; a=rsa-sha256; t=1647914336; cv=none; d=zohomail.com; s=zohoarc; b=jJaZrAv1d7kbcCnT8fIL4p3cLAaHMJo6VURTVoMRBOZk229VrDpXoYLVLiK1EF86uXURohCZnt+ZCizJ/m1NQCTQQ9PmjeEYzyGIfkeLPr4GDWwSJ7qP81wpGZXyAxSh5DDP2eqY06PysJWCONj4l7XLHLrUZPSYbPTzs7XlZhk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647914336; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=mZdj7GpRT+XlMFMLPIFu5sfOdTx1fBTtSTNH8Cz2yF8=; b=iyAJO9bRlFByrYLAGE/whzHidRTD5Y0tBOBPoHMvUv0cVh03Xs0IzCL38Ok/MArDfaT76P9iH2q2TIAcJj0JW7fPT1mEzLND1GPWG4UeapE3KQa8oYwzL8IbpM9sxXioyjLoUWlh4zBmfBF9UFBsKrJf2B3AQpCkcqtYNGqSVwQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87810+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1647914336753723.2409452923001; Mon, 21 Mar 2022 18:58:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id pi5OYY1788612xAOzzSTWihN; Mon, 21 Mar 2022 18:58:56 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.4851.1647914335711900134 for ; Mon, 21 Mar 2022 18:58:55 -0700 X-Received: from localhost.localdomain (unknown [47.202.59.224]) by linux.microsoft.com (Postfix) with ESMTPSA id 7320E20DE474; Mon, 21 Mar 2022 18:58:54 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7320E20DE474 From: "Michael Kubacki" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Sean Brogan , Bret Barkelew Subject: [edk2-devel] [PATCH v1 1/4] .pytool/Plugin/UncrustifyCheck: Update func to return absolute paths Date: Mon, 21 Mar 2022 21:58:11 -0400 Message-Id: <20220322015814.9182-2-mikuback@linux.microsoft.com> In-Reply-To: <20220322015814.9182-1-mikuback@linux.microsoft.com> References: <20220322015814.9182-1-mikuback@linux.microsoft.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com X-Gm-Message-State: iD8oxOEEMX0Xcmghh50q94VIx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1647914336; bh=PNaIfs/UPrvbvg4uHoKjm8r7suCkKSPQnwf+QnyuYVM=; h=Cc:Date:From:Reply-To:Subject:To; b=NZBk1wUdLriZohZsN/dZB4OoZl8lTWcszHlvrtPUxxEkoSfef+lr3wXaCGqjs79jLi2 M+aza1Rl2lNEG+13FKAzKAn7v82nvvohbnJ8LvDYMZuZ8piSaVVCIbulXAg/1NH6gm+9n vZ8s4HJFTIwHNw5AFyNuufmqmwXqNV86nhg= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1647914337963100001 Content-Type: text/plain; charset="utf-8" From: Michael Kubacki Currently, UncrustifyCheck._get_git_ignored_paths() is documented to return a list of absolute file paths but it currently returns a list of relative file paths. This change updates the function to return a list of absolute file paths. The result is later compared to the list of absolute file paths for files to run against Uncrustify. Cc: Michael D Kinney Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael Kubacki Reviewed-by: Michael D Kinney --- .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Pl= ugin/UncrustifyCheck/UncrustifyCheck.py index 82db7a5a438b..dc133fecc4b2 100644 --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py @@ -292,7 +292,11 @@ class UncrustifyCheck(ICiBuildPlugin): f"An error occurred reading git ignore settings. This will= prevent Uncrustify from running against the expected set of files.") =20 # Note: This will potentially be a large list, but at least sorted - return outstream_buffer.getvalue().strip().splitlines() + rel_paths =3D outstream_buffer.getvalue().strip().splitlines() + abs_paths =3D [] + for path in rel_paths: + abs_paths.append(os.path.join(self._abs_workspace_path, path)) + return abs_paths =20 def _get_git_submodule_paths(self) -> List[str]: """ --=20 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87810): https://edk2.groups.io/g/devel/message/87810 Mute This Topic: https://groups.io/mt/89944182/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-