From nobody Mon Feb 9 19:30:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87546+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87546+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1647272340592221.9307917166151; Mon, 14 Mar 2022 08:39:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id kNJEYY1788612x6inuB4xswx; Mon, 14 Mar 2022 08:39:01 -0700 X-Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mx.groups.io with SMTP id smtpd.web11.27842.1647272340092751863 for ; Mon, 14 Mar 2022 08:39:00 -0700 X-Received: by mail-lf1-f46.google.com with SMTP id n19so27847109lfh.8 for ; Mon, 14 Mar 2022 08:38:59 -0700 (PDT) X-Gm-Message-State: OpdNDNWioTuEvAyCaPrvUVxrx1787277AA= X-Google-Smtp-Source: ABdhPJz+L6q7IfA5Z5SKs7v4PeZ6GU3iB3Lh3fXfIvgRvbB7jvy/LK2dR9u4JizC9uhdjXlMENBgUw== X-Received: by 2002:a05:6512:a81:b0:445:c06b:a531 with SMTP id m1-20020a0565120a8100b00445c06ba531mr14090939lfu.364.1647272338339; Mon, 14 Mar 2022 08:38:58 -0700 (PDT) X-Received: from gilgamesh.lab.semihalf.net ([83.142.187.85]) by smtp.gmail.com with ESMTPSA id b8-20020ac25628000000b004484bd1be5esm3325401lff.256.2022.03.14.08.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 08:38:58 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, mw@semihalf.com, jaz@semihalf.com, gjb@semihalf.com, upstream@semihalf.com, sunny.Wang@arm.com Subject: [edk2-devel] [edk2-platforms PATCH 7/8] Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReset Date: Mon, 14 Mar 2022 16:38:36 +0100 Message-Id: <20220314153837.1885852-8-mw@semihalf.com> In-Reply-To: <20220314153837.1885852-1-mw@semihalf.com> References: <20220314153837.1885852-1-mw@semihalf.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mw@semihalf.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1647272341; bh=lCc8v8rpn0MEDADN61Okv2yAYR1eG+W2N39GWzU2HUE=; h=Cc:Date:From:Reply-To:Subject:To; b=VWItcQu1xIW95LfSidylrGm4IVCvzg1re8TAUandhYPVFiofv2t1tPRshCQp53hbVNN CJK+2wxYuCORuFKhmHuCxeyuTWZdgJTMWn1oxXBRRr5DVnqQfbNncdUaHDIrFWwNIGeUr eYS+8WW8JrgB0gg3z2ZrYR+okzvib77ueWI= X-ZohoMail-DKIM: fail (Signature date is -1 seconds in the future.) X-ZM-MESSAGEID: 1647272344558100004 Content-Type: text/plain; charset="utf-8" This patch adds missing parameter's and SNP instance status checks. igned-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 27 ++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c b/Silicon/Marvell/= Drivers/Net/Pp2Dxe/Pp2Dxe.c index deb3f34625..841a1c8f84 100644 --- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c +++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c @@ -647,6 +647,33 @@ Pp2SnpReset ( IN BOOLEAN ExtendedVerification ) { + PP2DXE_CONTEXT *Pp2Context; + + /* Check This Instance. */ + if (This =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + Pp2Context =3D INSTANCE_FROM_SNP (This); + + /* Check that driver was started and initialized. */ + if (This->Mode->State !=3D EfiSimpleNetworkInitialized) { + switch (This->Mode->State) { + case EfiSimpleNetworkStopped: + DEBUG ((DEBUG_WARN, "Pp2Dxe%d: not started\n", Pp2Context->Instance)= ); + return EFI_NOT_STARTED; + case EfiSimpleNetworkStarted: + DEBUG ((DEBUG_WARN, "Pp2Dxe%d: not initialized\n", Pp2Context->Insta= nce)); + return EFI_DEVICE_ERROR; + default: + DEBUG ((DEBUG_WARN, + "Pp2Dxe%d: wrong state: %u\n", + Pp2Context->Instance, + This->Mode->State)); + return EFI_DEVICE_ERROR; + } + } + return EFI_SUCCESS; } =20 --=20 2.29.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87546): https://edk2.groups.io/g/devel/message/87546 Mute This Topic: https://groups.io/mt/89776258/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-