From nobody Mon Feb 9 19:30:16 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87542+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87542+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1647272336; cv=none; d=zohomail.com; s=zohoarc; b=VCc/fkybtUkUvisdDTJ0rR/MKhETlevFn0uxGgTiTPda90ThCKLwC8EGHNI3k7/O80nh4+hbgFDZ7AIi3a57MvDULenK5TcopRr3wCk9GeJ9VCmws4pWKdv4E2hvxo5bstXRLcadJVwyNP2rq8PO/U9FOlghtdcJP2ovMHSoGaU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647272336; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=OHkY3OE3gT95OLrQm2ue9CpvDTYCxg1AMKP4f25AEaI=; b=GmqRPqPzWaDzEbr+/ZBN9x7e9kdxwY6K170jUZ6kXWswWsVK397yJkGDSmcY7VeAWMOS7nAXigYfXOi4clBkRsw3TQXZtmBZCcb0YcvsDHS3zxvTjdi7iLKnP47mPLOhOTolO0Cb1uCuhvZRMJZ1KMovDWGzUfrjuTG8hzY1mOA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87542+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1647272336926605.3243100046271; Mon, 14 Mar 2022 08:38:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id jedUYY1788612xniy3q9DYVm; Mon, 14 Mar 2022 08:38:56 -0700 X-Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mx.groups.io with SMTP id smtpd.web10.27653.1647272335721630571 for ; Mon, 14 Mar 2022 08:38:56 -0700 X-Received: by mail-lf1-f49.google.com with SMTP id bt26so27901553lfb.3 for ; Mon, 14 Mar 2022 08:38:55 -0700 (PDT) X-Gm-Message-State: JuE1nwkcs0l11aC74Ex46Snfx1787277AA= X-Google-Smtp-Source: ABdhPJz96KRXfeVrhXObx17kOUrGwuxHTNlOpiQA6eDbFBYCLlc6Cxe6FCEtZNq6j2iH6Rd1X0pirw== X-Received: by 2002:a05:6512:401f:b0:448:429f:186a with SMTP id br31-20020a056512401f00b00448429f186amr13886181lfb.414.1647272333867; Mon, 14 Mar 2022 08:38:53 -0700 (PDT) X-Received: from gilgamesh.lab.semihalf.net ([83.142.187.85]) by smtp.gmail.com with ESMTPSA id b8-20020ac25628000000b004484bd1be5esm3325401lff.256.2022.03.14.08.38.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 08:38:53 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, mw@semihalf.com, jaz@semihalf.com, gjb@semihalf.com, upstream@semihalf.com, sunny.Wang@arm.com Subject: [edk2-devel] [edk2-platforms PATCH 3/8] Marvell/Drivers: Pp2Dxe: Fix Pp2SnpStart & Pp2SnpStop Date: Mon, 14 Mar 2022 16:38:32 +0100 Message-Id: <20220314153837.1885852-4-mw@semihalf.com> In-Reply-To: <20220314153837.1885852-1-mw@semihalf.com> References: <20220314153837.1885852-1-mw@semihalf.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mw@semihalf.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1647272336; bh=EysDVnmLRGoU35i/0Yyq42lq9bS1VFZKBZe3nHp147s=; h=Cc:Date:From:Reply-To:Subject:To; b=in3haW7jc5jMObmvdQohrPq9w6vK1qZavIiox5lElRFjMaRt+STULWugzNeGUTC4XGm cbwC69QGqA88YGCUB8K9zc2lbJUY+vFBToTireAmj58UZgcbh4La0C1ENFVNd2UEwSCIf 7gzLpASxpApvM+1fwS5Q6XOFYmtrEGJdNVM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1647272338483100015 Content-Type: text/plain; charset="utf-8" Add sanity check if the SNP instance pointer is not NULL in SnpStart/Stop callbacks. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 23 +++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c b/Silicon/Marvell/= Drivers/Net/Pp2Dxe/Pp2Dxe.c index 3e09fafc4c..5f487c4dc6 100644 --- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c +++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c @@ -575,11 +575,19 @@ Pp2SnpStart ( ) { PP2DXE_CONTEXT *Pp2Context; - UINT32 State =3D This->Mode->State; EFI_TPL SavedTpl; + UINT32 State; + + /* Check Snp Instance. */ + if (This =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + =20 SavedTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + Pp2Context =3D INSTANCE_FROM_SNP(This); + State =3D This->Mode->State; =20 if (State !=3D EfiSimpleNetworkStopped) { switch (State) { @@ -604,9 +612,18 @@ Pp2SnpStop ( ) { EFI_TPL SavedTpl; + PP2DXE_CONTEXT *Pp2Context; + UINT32 State; + + // Check Snp Instance + if (This =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + SavedTpl =3D gBS->RaiseTPL (TPL_CALLBACK); - PP2DXE_CONTEXT *Pp2Context =3D INSTANCE_FROM_SNP(This); - UINT32 State =3D This->Mode->State; + + Pp2Context =3D INSTANCE_FROM_SNP(This); + State =3D This->Mode->State; =20 if (State !=3D EfiSimpleNetworkStarted && State !=3D EfiSimpleNetworkIni= tialized) { switch (State) { --=20 2.29.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87542): https://edk2.groups.io/g/devel/message/87542 Mute This Topic: https://groups.io/mt/89776252/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-