From nobody Mon Feb 9 16:34:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87541+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87541+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1647272335; cv=none; d=zohomail.com; s=zohoarc; b=IW+xoJdBX8axOKk31YJOyUgHAii8OpYIlkAs9Ne6kivMqRxkZRup3MSLhLvphvdUtvWiiWO+0mUOpK5fiByWA5lvo7v5KdFkLqtmpsgRayJ3ooL7sJ+zyJqOjEI0703mN1sljrEp3nFTvRllwn/RRpQhMD/DwCNMrwh56Ul0I+Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1647272335; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=xJFUp9asAuKj5Bkfmv2wgX0dzZw+NSZlFDUuS9gzAK4=; b=Yu9uEf/Qh6iCT2RMPYRwj0Nx3r590odVH+yCscdpjv2VRwFZWa42ye9BoTiU2YCyuYdenYpuuB975EjD1Ceqm6hmytFy3qp9jfnlL8JnM8oH7KBK+wzkch5O/AIKAt5dM+o5UHNh8AzQtuwamRqKaeIEEWSu6FRgAnRcsj5Co5k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87541+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1647272335841178.90288869557594; Mon, 14 Mar 2022 08:38:55 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id H8lEYY1788612xg4Vs5yAhvE; Mon, 14 Mar 2022 08:38:55 -0700 X-Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mx.groups.io with SMTP id smtpd.web09.27887.1647272334527429946 for ; Mon, 14 Mar 2022 08:38:54 -0700 X-Received: by mail-lf1-f54.google.com with SMTP id n19so27846531lfh.8 for ; Mon, 14 Mar 2022 08:38:54 -0700 (PDT) X-Gm-Message-State: TX1eeiXYsBxnobWJmwtrKOQVx1787277AA= X-Google-Smtp-Source: ABdhPJx5D2N5kbGMQ6lT/On9rBkK1ddcj/ze3o6FxpFXd+GTf9Qt6xjOGR5e00zoFMvMOkP2wHKVhw== X-Received: by 2002:ac2:544e:0:b0:448:4baf:a9e8 with SMTP id d14-20020ac2544e000000b004484bafa9e8mr13941566lfn.63.1647272332691; Mon, 14 Mar 2022 08:38:52 -0700 (PDT) X-Received: from gilgamesh.lab.semihalf.net ([83.142.187.85]) by smtp.gmail.com with ESMTPSA id b8-20020ac25628000000b004484bd1be5esm3325401lff.256.2022.03.14.08.38.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Mar 2022 08:38:52 -0700 (PDT) From: "Marcin Wojtas" To: devel@edk2.groups.io Cc: quic_llindhol@quicinc.com, ardb+tianocore@kernel.org, mw@semihalf.com, jaz@semihalf.com, gjb@semihalf.com, upstream@semihalf.com, sunny.Wang@arm.com Subject: [edk2-devel] [edk2-platforms PATCH 2/8] Marvell/Drivers: Pp2Dxe: Fix Pp2SnpReceiveFilters Date: Mon, 14 Mar 2022 16:38:31 +0100 Message-Id: <20220314153837.1885852-3-mw@semihalf.com> In-Reply-To: <20220314153837.1885852-1-mw@semihalf.com> References: <20220314153837.1885852-1-mw@semihalf.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mw@semihalf.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1647272335; bh=llfPlE6eyorU/S93PH/IbUv1Oxqv1gUBUqSrjLt/UDM=; h=Cc:Date:From:Reply-To:Subject:To; b=Dwt/1YELeaLkwC15PCMThgkWNfVnv8Zseo8Ycwba+dqIzmXnj8ace16d9Gjz0KvkXqv 4ucbUQC2Iv0iL52bkR1y2En29lT+0T40ruH7Jpcmc9dVitnyCT7SKrtUPJuG+3jDCpBWc yiyE+j1GCPQOM3k2l+vMx6NttbXJvz7kxzs= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1647272336467100007 Content-Type: text/plain; charset="utf-8" Until now the Pp2SnpReceiveFilters callback unconditionally returned EFI_SUCCESS. Allow proper handling of the input values on the protocol level. Keep the HW registers intact. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 62 +++++++++++++++++++- 1 file changed, 61 insertions(+), 1 deletion(-) diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c b/Silicon/Marvell/= Drivers/Net/Pp2Dxe/Pp2Dxe.c index 30e091f807..3e09fafc4c 100644 --- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c +++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c @@ -725,7 +725,67 @@ Pp2SnpReceiveFilters ( IN EFI_MAC_ADDRESS *MCastFilter OPTIONAL ) { - return EFI_SUCCESS; + PP2DXE_CONTEXT *Pp2Context; + EFI_TPL SavedTpl; + UINTN Count; + + /* Check Snp Instance. */ + if (This =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + SavedTpl =3D gBS->RaiseTPL (TPL_CALLBACK); + + Pp2Context =3D INSTANCE_FROM_SNP(This); + + /* Check whether the driver was started and initialized. */ + if (This->Mode->State !=3D EfiSimpleNetworkInitialized) { + switch (This->Mode->State) { + case EfiSimpleNetworkStopped: + DEBUG ((DEBUG_WARN, "Pp2Dxe%d: not started\n", Pp2Context->Instance)= ); + ReturnUnlock (SavedTpl, EFI_NOT_STARTED); + case EfiSimpleNetworkStarted: + DEBUG ((DEBUG_WARN, "Pp2Dxe%d: not initialized\n", Pp2Context->Insta= nce)); + ReturnUnlock (SavedTpl, EFI_DEVICE_ERROR); + default: + DEBUG ((DEBUG_WARN, + "Pp2Dxe%d: wrong state: %u\n", + Pp2Context->Instance, + This->Mode->State)); + ReturnUnlock (SavedTpl, EFI_DEVICE_ERROR); + } + } + + if (((Enable | Disable) & ~This->Mode->ReceiveFilterMask) !=3D 0) { + ReturnUnlock (SavedTpl, EFI_INVALID_PARAMETER); + } + + if (!ResetMCastFilter && + (Disable & EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST) =3D=3D 0 && + (Enable & EFI_SIMPLE_NETWORK_RECEIVE_MULTICAST) !=3D 0) { + if (MCastFilterCnt =3D=3D 0 || + MCastFilterCnt > This->Mode->MaxMCastFilterCount || + MCastFilter =3D=3D NULL) { + ReturnUnlock (SavedTpl, EFI_INVALID_PARAMETER); + } + + for (Count =3D 0; Count < MCastFilterCnt; Count++) { + if ((MCastFilter[Count].Addr[0] & 1) =3D=3D 0) { + ReturnUnlock (SavedTpl, EFI_INVALID_PARAMETER); + } + CopyMem (&This->Mode->MCastFilter[Count], + &MCastFilter[Count], + sizeof (EFI_MAC_ADDRESS)); + } + This->Mode->MCastFilterCount =3D MCastFilterCnt; + } else if (ResetMCastFilter) { + This->Mode->MCastFilterCount =3D 0; + } + + This->Mode->ReceiveFilterSetting |=3D Enable; + This->Mode->ReceiveFilterSetting &=3D ~Disable; + + ReturnUnlock (SavedTpl, EFI_SUCCESS); } =20 EFI_STATUS --=20 2.29.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87541): https://edk2.groups.io/g/devel/message/87541 Mute This Topic: https://groups.io/mt/89776251/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-