From nobody Sun May 19 16:31:30 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87404+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87404+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1646911595; cv=none; d=zohomail.com; s=zohoarc; b=iuUqI43yWFnmYWnzyy/Tu84pEOaIYNMlePDyDQg4KvnG2OlgiDSHS6qMHI9mUg4ylsma09F5SnX1bRMhyH5iA3tIgXCYZYOjrjh+IeBWeS8PgDhdIKm0RGYh10Ufev8QXA0WIw3OaanO1DbDfC/pXhjum5WV4hhz31GFOXfivTs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646911595; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=pC4EGkHBv2hQiRkB/6Z5yNNzN+t6D0MXVLIF1YHBCTQ=; b=XEpnUDgc3aauDjE2IezpPkdgTKdtDIaFx9+iLBDxcsw9aKI+t4Qpj3AJP/A7s0rzcMbcqMDankeF0qupyOEwzVd4V5V5OMgSZMVTWBG9EZX1wLweiJnH61/6K/UjYtWw9qPWss3nRIqrNBeZMygd19BGxmf9uPd/QHRGL5tyxU4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87404+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1646911595236683.8124379275655; Thu, 10 Mar 2022 03:26:35 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id dk4AYY1788612xTwmpFxBeSp; Thu, 10 Mar 2022 03:26:35 -0800 X-Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mx.groups.io with SMTP id smtpd.web12.8433.1646911594171021802 for ; Thu, 10 Mar 2022 03:26:34 -0800 X-Received: from kwepemi100025.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4KDmq93zjRzcZy8; Thu, 10 Mar 2022 19:21:41 +0800 (CST) X-Received: from kwepemm600004.china.huawei.com (7.193.23.242) by kwepemi100025.china.huawei.com (7.221.188.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Thu, 10 Mar 2022 19:26:31 +0800 X-Received: from kwephisprg16640.huawei.com (10.247.83.252) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 10 Mar 2022 19:26:31 +0800 From: "wenyi,xie via groups.io" To: , , CC: , Subject: [edk2-devel] [PATCH EDK2 v1 1/1] RedfishPkg: fix memory leak issue Date: Thu, 10 Mar 2022 19:25:34 +0800 Message-ID: <20220310112534.2952545-2-xiewenyi2@huawei.com> In-Reply-To: <20220310112534.2952545-1-xiewenyi2@huawei.com> References: <20220310112534.2952545-1-xiewenyi2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.247.83.252] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,xiewenyi2@huawei.com X-Gm-Message-State: jROrkqTDhoE9rClu7vw8t6U6x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1646911595; bh=oMi078Aryo6cAfsrsnCvczZVATsY3GP3gbVRk1mG9Rw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=JPuXQijOxv6cKxBEKsyXv3jp02DfmH+jsJXwcxPmsGj3oXMroJ3f5IjfcSbg79XhOE9 C9CQsVdDpCux7D8UYTXQaWSWmlAIsH6xn2/bGGj2TQu+gs3ab4s+ZZrljWd419VdEyBMX NFOe3AMwQ7ifsLQJb5UCVVrXf6Ov6+P8LuM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1646911597221100002 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The calloc memory is not free when function collectionEvalOp return in the halfway. Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Wenyi Xie Reviewed-by: Abner Chang --- RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c | 16 +++= ++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payloa= d.c b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c index 3f2b83e834d0..6c6e2246abe3 100644 --- a/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c +++ b/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/payload.c @@ -620,6 +620,7 @@ collectionEvalOp ( if (((*StatusCode =3D=3D NULL) && (members =3D=3D NULL)) || ((*StatusCode !=3D NULL) && ((**StatusCode < HTTP_STATUS_200_OK) || = (**StatusCode > HTTP_STATUS_206_PARTIAL_CONTENT)))) { + free (valid); return members; } =20 @@ -633,6 +634,7 @@ collectionEvalOp ( if (((*StatusCode =3D=3D NULL) && (tmp =3D=3D NULL)) || ((*StatusCode !=3D NULL) && ((**StatusCode < HTTP_STATUS_200_OK) |= | (**StatusCode > HTTP_STATUS_206_PARTIAL_CONTENT)))) { + free (valid); return tmp; } =20 @@ -658,19 +660,15 @@ collectionEvalOp ( =20 cleanupPayload (members); if (validCount =3D=3D 0) { - free (valid); - return NULL; - } - - if (validCount =3D=3D 1) { + ret =3D NULL; + } else if (validCount =3D=3D 1) { ret =3D valid[0]; - free (valid); - return ret; } else { ret =3D createCollection (payload->service, validCount, valid); - free (valid); - return ret; } + + free (valid); + return ret; } =20 static redfishPayload * --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87404): https://edk2.groups.io/g/devel/message/87404 Mute This Topic: https://groups.io/mt/89683950/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-