From nobody Mon Feb 9 23:39:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+87352+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87352+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646745681; cv=none; d=zohomail.com; s=zohoarc; b=RD+v5NxGMUn/wW5LTqBibfa8dezZSK5eMNWzlQNuWSV6MXdj/62BGk4jxd1EQhgmkPZwir99bBIad97V4aqRxwlgJmAJXdQLE81zYfYXFyW6GP6ykuQkI3Ovkf1w6mHBq3qL6Y21nwDOnhnryzhddHeRneApjeIaicx6rfgPDL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646745681; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=pXt3Wapiyii0vzYMh6amLFASmJwub5s25xBbb0HftUk=; b=B2IIWhm/Kj/T5TTRTAJk1pNO5zR6LkZILTggi/Qf3UItkyMG+MseSXsWuWutE0rCg6JWN0TQCjot2kpF2uWNW5WX1NFVwloKOoP6obkNynyZulc0nenJamFUbhGGrEkv64Lr5PqwRE7KLCR8faKtwZF7azvNE3GG76PgnOH4ZZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+87352+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1646745681509890.5264003534302; Tue, 8 Mar 2022 05:21:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 6PvXYY1788612x8NLboM6UD0; Tue, 08 Mar 2022 05:21:21 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web08.7651.1646745678886171872 for ; Tue, 08 Mar 2022 05:21:19 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-179-GBTahR16Pw2FUvfge8Zgkw-1; Tue, 08 Mar 2022 08:21:15 -0500 X-MC-Unique: GBTahR16Pw2FUvfge8Zgkw-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 575E81091DA3 for ; Tue, 8 Mar 2022 13:21:14 +0000 (UTC) X-Received: from osteffen-laptop.fritz.box (unknown [10.39.193.224]) by smtp.corp.redhat.com (Postfix) with ESMTP id A440C7D3C9; Tue, 8 Mar 2022 13:21:13 +0000 (UTC) From: "Oliver Steffen" To: devel@edk2.groups.io Cc: Oliver Steffen Subject: [edk2-devel] [PATCH v2 1/4] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring Date: Tue, 8 Mar 2022 14:21:01 +0100 Message-Id: <20220308132104.407800-2-osteffen@redhat.com> In-Reply-To: <20220308132104.407800-1-osteffen@redhat.com> References: <20220304130403.47832-1-osteffen@redhat.com> <20220308132104.407800-1-osteffen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,osteffen@redhat.com X-Gm-Message-State: Lx5IfbdItTrYVITdMyJzkOrJx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1646745681; bh=IgyxABFp7Zxk/BDiVk88f8GtkvH5QKXs4ZGrSeClkzI=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=brm13BV3DV/nB0m2gK5fz3okg04NOWg1c7Jc/pPBXfRxMnlnZZe8Wa6SBdHApU4h9D+ 5N6gaxM7fVIqwCVOkpW17qCi/nxsoo4M8jcanuXelK39PJVT50POCW2HUEY+c7laE9w39 yhVH+wupQVnhUZ3DckmAhgZLpx0WRfRDht4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1646745682675100007 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2720 Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before configuring it again. Signed-off-by: Oliver Steffen Reviewed-by: Gerd Hoffmann --- NetworkPkg/HttpDxe/HttpProto.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NetworkPkg/HttpDxe/HttpProto.c b/NetworkPkg/HttpDxe/HttpProto.c index 9457dd2623d3..cd54c574044b 100644 --- a/NetworkPkg/HttpDxe/HttpProto.c +++ b/NetworkPkg/HttpDxe/HttpProto.c @@ -1086,6 +1086,18 @@ HttpConfigureTcp4 ( Tcp4Option->EnableNagle =3D TRUE; Tcp4CfgData->ControlOption =3D Tcp4Option; =20 + if ((HttpInstance->State =3D=3D HTTP_STATE_TCP_CONNECTED) || + (HttpInstance->State =3D=3D HTTP_STATE_TCP_CLOSED)) + { + Status =3D HttpInstance->Tcp4->Configure (HttpInstance->Tcp4, NULL); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "HttpConfigureTcp4(NULL) - %r\n", Status)); + return Status; + } + + HttpInstance->State =3D HTTP_STATE_TCP_UNCONFIGED; + } + Status =3D HttpInstance->Tcp4->Configure (HttpInstance->Tcp4, Tcp4CfgDat= a); if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "HttpConfigureTcp4 - %r\n", Status)); --=20 2.35.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#87352): https://edk2.groups.io/g/devel/message/87352 Mute This Topic: https://groups.io/mt/89636384/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-