From nobody Sun Feb 8 17:48:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+86069+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86069+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1643139559; cv=none; d=zohomail.com; s=zohoarc; b=HTo+Dqqto/bKf61FsvZ/c3TtyJm1Av48bfGLa5gzICNbNGJdaW2qF7SovzZDZhqRli2PMKOZU44IdBTYpFFZVfkulA7Ry4pfe+xF95tXpqRWwya28Z26RLQn1LSNnl0oPN1vvaGdI+lD9t4L/WRfNOzujdF6Lw0w2dN1Y3Qizg0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643139559; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=IlMgdgbN0bK1xkBuG9082YKLmjwQdXhaAJ7rFeGq0N8=; b=WFX9mqyEx3ItY9nAgr478WKUVzum/js6HcS0QE4VQbTHo72kacPIJeS0CsRhdQwu8uOL/GiB4+i3RYG/QQJU+5/Q1GvNDMkMuitjF6YoFHS9n7ohqJxWaTF2fCPNIpIoOPKsl6S7BTZv6ESTEx2ITONsSPT1wBqLF5bJ2UoldrQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+86069+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1643139559429142.0049391707929; Tue, 25 Jan 2022 11:39:19 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id RfxjYY1788612x2n0bVydEpO; Tue, 25 Jan 2022 11:39:18 -0800 X-Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mx.groups.io with SMTP id smtpd.web12.1943.1643139558271877052 for ; Tue, 25 Jan 2022 11:39:18 -0800 X-Received: by mail-pj1-f52.google.com with SMTP id d5so18542460pjk.5 for ; Tue, 25 Jan 2022 11:39:18 -0800 (PST) X-Gm-Message-State: SbwLtrhuo8ITW4CvFhe7Ob4Zx1787277AA= X-Google-Smtp-Source: ABdhPJwtgrxXBgkzK9vNRT2sBrS2O2dTlB4iZtMvJqIFy7kUjXUOxXppwKHK+Pm0NkJd0CH/GbsvJQ== X-Received: by 2002:a17:902:704a:b0:14a:b62b:f41b with SMTP id h10-20020a170902704a00b0014ab62bf41bmr20140833plt.93.1643139557593; Tue, 25 Jan 2022 11:39:17 -0800 (PST) X-Received: from gem-name-lb-02.localdomain ([50.35.74.198]) by smtp.gmail.com with ESMTPSA id v8sm1036929pju.51.2022.01.25.11.39.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 11:39:17 -0800 (PST) From: "Kun Qin" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Bret Barkelew , Michael Kubacki , Sami Mujawar Subject: [edk2-devel] [PATCH v3 4/6] ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**` checks Date: Tue, 25 Jan 2022 11:39:07 -0800 Message-Id: <20220125193909.491-5-kuqin12@gmail.com> In-Reply-To: <20220125193909.491-1-kuqin12@gmail.com> References: <20220125193909.491-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1643139558; bh=xIdmPl3g/TobV5mlWleVpZ1vLfbbtYUblv7IaajSddM=; h=Cc:Date:From:Reply-To:Subject:To; b=h1ANQEmuALu2R9V05ZRfZtoUfz4vg+oQMfRh/DEKmzLaZ8ty4fJqd/P/OuhlEW2AVfI fqrcz8JNbC5o+RJUaIl47aZoKBdqplIMXjoc2RK5pc81Ecud9vrvtsZUzDJReV1HDtyT6 zqwquo38mcz0dFGZ1A8ycpLsNps05R7UIiA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1643139560191100014 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3751 Current MM communicate routine from ArmPkg would conduct few checks prior to proceeding with SMC calls. However, the inspection step is different from PI specification. This patch updated MM communicate input argument inspection routine to assure that return code `EFI_INVALID_PARAMETER` represents "the `CommBuffer**` parameters do not refer to the same location in memory", as described by `EFI_MM_COMMUNICATION2_PROTOCOL.Communicate()` section in PI specification. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bret Barkelew Cc: Michael Kubacki Cc: Sami Mujawar Signed-off-by: Kun Qin Reviewed-by: Sami Mujawar --- Notes: v2: - Splitting patch into 2 of 4 [Ard] - Uncrustify style update =20 v3: - Added cc entry and reviewed-by tag [Sami] ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c b/ArmPkg/D= rivers/MmCommunicationDxe/MmCommunication.c index 7f756a32d4e0..0283be430dff 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c @@ -83,7 +83,7 @@ MmCommunication2Communicate ( // // Check parameters // - if (CommBufferVirtual =3D=3D NULL) { + if ((CommBufferVirtual =3D=3D NULL) || (CommBufferPhysical =3D=3D NULL))= { return EFI_INVALID_PARAMETER; } =20 --=20 2.34.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86069): https://edk2.groups.io/g/devel/message/86069 Mute This Topic: https://groups.io/mt/88680223/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-