From nobody Sun May 5 05:35:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85885+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85885+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1642726683; cv=none; d=zohomail.com; s=zohoarc; b=TOKD0Y6L060CBflqa1TUIfzgD95KkgQIXw34mQl26y4BzUIpTgSAlwqLGRj+iYPZ/vr2nYFop3FlQOBJt1F7Euamb7YscRu/W5A1ZuAqE8coXsq+UgZ9zKXD+mwNJMN7c8PG5N59nfTJInEbX+yQaHcdf+Js171kdS45DNkVWk4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642726683; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Wl7mP8Sz6OLu4/9hTlI3uRN6DC4V/C3IRdbSfPITsTU=; b=gsHeVhXxqmNRkZN88DGJA4EBEN4N7I2t3sKkEA5sYyVClPJMYKucEFvPLSZgdmvVbSg/gcJSyAkpWjYANA11J3kju8O0pOGwvCWQbXdKxY1t9SpUquLJDuDyOogF7qIDh6jhv+eFh+1E7ySJA37ZN/wekvgcNm5rt6jk5TILZZ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85885+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1642726683949719.8102364116979; Thu, 20 Jan 2022 16:58:03 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id lZNmYY1788612xGrpPKe62gn; Thu, 20 Jan 2022 16:58:03 -0800 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.5382.1642726681430622846 for ; Thu, 20 Jan 2022 16:58:03 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10233"; a="306256162" X-IronPort-AV: E=Sophos;i="5.88,303,1635231600"; d="scan'208";a="306256162" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 16:58:02 -0800 X-IronPort-AV: E=Sophos;i="5.88,303,1635231600"; d="scan'208";a="475756130" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.9.87]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 16:58:00 -0800 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: GuoMinJ , Nate DeSimone , Guomin Jiang Subject: [edk2-devel] [ed2-platforms][PATCH 1/2] Platform/Intel/SimicsOpenBoardPkg: Remove all UGA support Date: Fri, 21 Jan 2022 08:56:32 +0800 Message-Id: <20220121005633.1018-2-guomin.jiang@intel.com> In-Reply-To: <20220121005633.1018-1-guomin.jiang@intel.com> References: <20220121005633.1018-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: E4GD0p3ekMB2PhBopOk6fBXHx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1642726683; bh=F6zE/dK2WKqp/lQU5tUkeb2aDIFSt5Df3XxQxS5F+Ec=; h=Cc:Date:From:Reply-To:Subject:To; b=Lsd5vktjiAJTKhGmk32mDJEmEcRm5nJ0Vp4JSpRjvqIntby3wUkBM2U0Q+0wYQbO+0W lAUpPtqBhdj4/bmTecUu1b30VcsCCesseszpuiXFktHHKRY2NzgqKZG/NjuqzGWCu2YMV suDNNpv/79da/JKAmFbtWObMqyjfn4x2LNA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1642726684507100005 Content-Type: text/plain; charset="utf-8" From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2368 Cc: Nate DeSimone Signed-off-by: Guomin Jiang Reviewed-by: Nate DeSimone --- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 4 +- .../Library/DxeLogoLib/DxeLogoLib.inf | 6 +-- .../Library/DxeLogoLib/Logo.c | 45 +------------------ 3 files changed, 3 insertions(+), 52 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPc= d.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc index 88009b8f1022..9b81726623dc 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.dsc @@ -1,7 +1,7 @@ ## @file # PCD configuration build description file for the X58Ich10 board. # -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2022, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -31,8 +31,6 @@ [PcdsFeatureFlag.common] # Edk2 Configuration ###################################### gEfiMdeModulePkgTokenSpaceGuid.PcdBrowerGrayOutReadOnlyMenu|TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE - gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSupportUefiDecompress|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/DxeLogoLi= b.inf b/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/DxeLogoLib.inf index ff08c385b3a0..cd9565e123db 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/DxeLogoLib.inf +++ b/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/DxeLogoLib.inf @@ -6,7 +6,7 @@ # 2) BDS boot device connect interface; # 3) BDS Misc interfaces for mainting boot variable, ouput string, etc. # -# Copyright (c) 2007 - 2019 Intel Corporation. All rights reserved.
+# Copyright (c) 2007 - 2022 Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -41,15 +41,11 @@ [Packages] MdeModulePkg/MdeModulePkg.dec SimicsOpenBoardPkg/OpenBoardPkg.dec =20 -[FeaturePcd] - gEfiMdePkgTokenSpaceGuid.PcdUgaConsumeSupport - [Sources] Logo.c =20 [Protocols] gEfiGraphicsOutputProtocolGuid ## SOMETIMES_CONSUMES - gEfiUgaDrawProtocolGuid ## SOMETIMES_CONSUMES gEfiBootLogoProtocolGuid ## SOMETIMES_CONSUMES gEfiUserManagerProtocolGuid ## CONSUMES gEfiOemBadgingProtocolGuid ## CONSUMES diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c b/= Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c index 48a718a90d46..9cea5f4665d0 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c +++ b/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c @@ -1,7 +1,7 @@ /** @file BDS Lib functions which contain all the code to connect console device =20 - Copyright (c) 2006 - 2019 Intel Corporation. All rights reserved.
+ Copyright (c) 2006 - 2022 Intel Corporation. All rights reserved.
=20 SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -10,7 +10,6 @@ #include #include #include -#include #include #include #include @@ -300,9 +299,6 @@ EnableBootLogo ( UINTN Height; UINTN Width; EFI_GRAPHICS_OUTPUT_BLT_PIXEL *Blt; - EFI_UGA_DRAW_PROTOCOL *UgaDraw; - UINT32 ColorDepth; - UINT32 RefreshRate; EFI_GRAPHICS_OUTPUT_PROTOCOL *GraphicsOutput; EFI_BOOT_LOGO_PROTOCOL *BootLogo; UINTN NumberOfLogos; @@ -317,18 +313,10 @@ EnableBootLogo ( UINTN NewWidth; UINT64 BufferSize; =20 - UgaDraw =3D NULL; // // Try to open GOP first // Status =3D gBS->HandleProtocol (gST->ConsoleOutHandle, &gEfiGraphicsOutp= utProtocolGuid, (VOID **) &GraphicsOutput); - if (EFI_ERROR (Status) && FeaturePcdGet (PcdUgaConsumeSupport)) { - GraphicsOutput =3D NULL; - // - // Open GOP failed, try to open UGA - // - Status =3D gBS->HandleProtocol (gST->ConsoleOutHandle, &gEfiUgaDrawPro= tocolGuid, (VOID **) &UgaDraw); - } if (EFI_ERROR (Status)) { return EFI_UNSUPPORTED; } @@ -351,11 +339,6 @@ EnableBootLogo ( SizeOfX =3D GraphicsOutput->Mode->Info->HorizontalResolution; SizeOfY =3D GraphicsOutput->Mode->Info->VerticalResolution; =20 - } else if (UgaDraw !=3D NULL && FeaturePcdGet (PcdUgaConsumeSupport)) { - Status =3D UgaDraw->GetMode (UgaDraw, &SizeOfX, &SizeOfY, &ColorDepth,= &RefreshRate); - if (EFI_ERROR (Status)) { - return EFI_UNSUPPORTED; - } } else { return EFI_UNSUPPORTED; } @@ -503,19 +486,6 @@ EnableBootLogo ( Height, Width * sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXEL) ); - } else if (UgaDraw !=3D NULL && FeaturePcdGet (PcdUgaConsumeSupport)= ) { - Status =3D UgaDraw->Blt ( - UgaDraw, - (EFI_UGA_PIXEL *) Blt, - EfiUgaBltBufferToVideo, - 0, - 0, - (UINTN) DestX, - (UINTN) DestY, - Width, - Height, - Width * sizeof (EFI_UGA_PIXEL) - ); } else { Status =3D EFI_UNSUPPORTED; } @@ -620,19 +590,6 @@ EnableBootLogo ( LogoHeight, LogoWidth * sizeof (EFI_GRAPHICS_OUTPUT_BLT_PIXE= L) ); - } else if (UgaDraw !=3D NULL && FeaturePcdGet (PcdUgaConsumeSupport)) { - Status =3D UgaDraw->Blt ( - UgaDraw, - (EFI_UGA_PIXEL *) LogoBlt, - EfiUgaVideoToBltBuffer, - LogoDestX, - LogoDestY, - 0, - 0, - LogoWidth, - LogoHeight, - LogoWidth * sizeof (EFI_UGA_PIXEL) - ); } else { Status =3D EFI_UNSUPPORTED; } --=20 2.30.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85885): https://edk2.groups.io/g/devel/message/85885 Mute This Topic: https://groups.io/mt/88573988/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 05:35:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85886+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85886+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1642726686; cv=none; d=zohomail.com; s=zohoarc; b=eFnO+jCN7kHehRSoBAVrMd+MTgRWqFGr4DgTpYslS/1ihlbYruIfVrxn95Acl3N2b6T6t+SmYfOAGeTy2fQ4oVtQV6ig8e4iMM0a031kQzuJj1jezL93YyNKjX5a7kZ5aEZjJq2VyDGN8CN1YPAfHxDckqAsEytkBhto7QQs+Yo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642726686; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=b4RWubSvGHZeWwCimeiCVv8mfFqhERPYSX6l5/KsP9I=; b=i/IZzk0/LWcNE3a/ucl2O9nkPfj/ift0cG6exni07H6vl0JLUufY9gIhpiLgdq3RMjCZ//UmCYq7iF4ADTsj8WRimUzHaEqHgCVbm+1HK+nGY84nIyC6gkS97QxeQRARo7HsrbaUSom5JqdLQgGSKZsLXdEaWNJ6UZhbBo8J1Cg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85886+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 16427266859971022.7292879420918; Thu, 20 Jan 2022 16:58:05 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 97nWYY1788612xo8nTHK7bDn; Thu, 20 Jan 2022 16:58:05 -0800 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.5382.1642726681430622846 for ; Thu, 20 Jan 2022 16:58:05 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10233"; a="306256198" X-IronPort-AV: E=Sophos;i="5.88,303,1635231600"; d="scan'208";a="306256198" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 16:58:04 -0800 X-IronPort-AV: E=Sophos;i="5.88,303,1635231600"; d="scan'208";a="475756146" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.9.87]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2022 16:58:02 -0800 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: GuoMinJ , Nate DeSimone , Zailiang Sun , Yi Qian , Guomin Jiang Subject: [edk2-devel] [ed2-platforms][PATCH 2/2] Platform/Intel: Remove All UGA Support Date: Fri, 21 Jan 2022 08:56:33 +0800 Message-Id: <20220121005633.1018-3-guomin.jiang@intel.com> In-Reply-To: <20220121005633.1018-1-guomin.jiang@intel.com> References: <20220121005633.1018-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: bDrx3zE0BTC0XnRduBp6Giexx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1642726685; bh=gwYq0Ks1t4sEdf8KkVyqIVqIFili1A50Xzq4WlgzZ9g=; h=Cc:Date:From:Reply-To:Subject:To; b=ElSDBWwk6Or3AzNOCEzhQei7KrnqAFu0fBtGuprFSc2JWoP+NzKSqnN+LqgN2A8awfR nmXWrP7BYhZ5KTBrSeKsIhowBIZ4qvX3SkTgFnfzaD37aGBwMaMNIzyCBnOKd/Qo251D3 qSIV16pdpapNxRGiVFNBaEeMmCQK7jxeHXM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1642726686772100002 Content-Type: text/plain; charset="utf-8" From: GuoMinJ REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2368 Remove all UGA Support in INTEL platform. Cc: Nate DeSimone Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Guomin Jiang Reviewed-by: Nate DeSimone --- .../Library/DxePlatformBootManagerLib/BdsPlatform.h | 1 - 1 file changed, 1 deletion(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManage= rLib/BdsPlatform.h b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBo= otManagerLib/BdsPlatform.h index 0bdc11bdd824..6cc4e3acf279 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/Bd= sPlatform.h +++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/DxePlatformBootManagerLib/Bd= sPlatform.h @@ -19,7 +19,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include -#include #include #include #include --=20 2.30.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85886): https://edk2.groups.io/g/devel/message/85886 Mute This Topic: https://groups.io/mt/88573989/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-