From nobody Fri May 3 16:42:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85809+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85809+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1642583824; cv=none; d=zohomail.com; s=zohoarc; b=mej7HzatFpdxsIbm1r14CGbUE2stdAnaFKvsgpkdiYIu5KlvDB9/y665FR7DQKP4ejZ2BrfBS8wfcI/VYZB0NQFrPvBshdo3G42Pv4a+Jw1vV2UbFcD3b4AqQZHy4LEk8VaveE96j2uZc+Rz+ugku3byW7DKW00p66rHrVhpd5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1642583824; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=cflQ8DnNE06J5uC+QQBWvRkMwAtw6tn3U02J434x1rk=; b=hmHTLSdJ/kPIROspYv9nvoJuokqO/JJ72kQwBnvzXxnlW4IkMP5z+sMb/eKcojEwamZmBMj9rLKYEgYOBVvabYXEXwCocASTDJBNid6wXvbmqyRIGgu186zUCdyYvclsF068U3XwwWhvYkF0D7L5Obyh6Dfx87Kmo68gXlmOnz0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85809+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1642583824580713.7239785444857; Wed, 19 Jan 2022 01:17:04 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4Ot8YY1788612xE3JmW3hPhw; Wed, 19 Jan 2022 01:17:04 -0800 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.4085.1642583821757757700 for ; Wed, 19 Jan 2022 01:17:02 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="305754508" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="305754508" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:17:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="518101733" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.158]) by orsmga007.jf.intel.com with ESMTP; 19 Jan 2022 01:16:59 -0800 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Guo Dong , Ray Ni , Maurice Ma , Benjamin You Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Use BaseCpuTimerLib for Universal Payload by default Date: Wed, 19 Jan 2022 17:16:46 +0800 Message-Id: <20220119091646.130-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: jdlF6lbV8MRBKTN2QzyYeSiZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1642583824; bh=nTuTOa8x4xiCaw+KTjiGm5Ji69Ee4w0wkuL9/4zlAQk=; h=Cc:Date:From:Reply-To:Subject:To; b=RSTWjd9R+aYasgqIV3qZRpiIMabdk9CczNhaazbE0kXS4abqsz9GKaFX4ywMTIWGO61 8rKZ48lQS9RynleMGH+Rnf8Rkx3mhhOxq8RZhov4tWBxKUtquvbyHWgUO72q5iihlBLJd gNJy+g26l2YvFViYJg79G19S8j/PY8eRvbU= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1642583826614100002 Content-Type: text/plain; charset="utf-8" Current, a macro CPU_TIMER_LIB_ENABLE is added to determine which timerlib is used. BaseCpuTimerLib.inf is a better way and only fit for recent CPU. Meanwhile, Universal Payload are only aimed to work with recent CPU. Therefore, for Universal Payload, use the BaseCpuTimerLib by default Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Zhiguang Liu Reviewed-by: Ray Ni --- UefiPayloadPkg/UefiPayloadPkg.dsc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc b/UefiPayloadPkg/UefiPayload= Pkg.dsc index 65c1bd610e..1ce96a51c1 100644 --- a/UefiPayloadPkg/UefiPayloadPkg.dsc +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc @@ -111,10 +111,10 @@ DEFINE SERIAL_DRIVER_ENABLE =3D TRUE DEFINE PERFORMANCE_MEASUREMENT_ENABLE =3D FALSE =20 - # For recent X86 CPU, 0x15 CPUID instruction will return Time Stamp Coun= ter. - # This is recommended way to get the time, and also how BaseCpuTimerLib = works. - # However, some CPU doesn't support this feature, so disable it by defau= lt. - DEFINE CPU_TIMER_LIB_ENABLE =3D FALSE + # For recent X86 CPU, 0x15 CPUID instruction will return Time Stamp Coun= ter Frequence. + # This is how BaseCpuTimerLib works, and a recommended way to get Freque= nce, so set the default value as TRUE. + # Note: for emulation platform such as QEMU, this may not work and shoul= d set it as FALSE + DEFINE CPU_TIMER_LIB_ENABLE =3D TRUE =20 [BuildOptions] *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES @@ -222,7 +222,7 @@ # # Platform # -!if $(CPU_TIMER_LIB_ENABLE) =3D=3D TRUE +!if $(CPU_TIMER_LIB_ENABLE) =3D=3D TRUE && $(UNIVERSAL_PAYLOAD) =3D=3D TRUE TimerLib|UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf !else TimerLib|UefiPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf --=20 2.32.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85809): https://edk2.groups.io/g/devel/message/85809 Mute This Topic: https://groups.io/mt/88530668/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-