From nobody Wed Apr 24 00:43:56 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85435+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85435+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1641785149; cv=none; d=zohomail.com; s=zohoarc; b=PPr1xoP4IZ6KiOesD2+w9jEjshTt8fh5undwQlJdiIML0ZY06qy7tC2bKwIhz/ifBa/u2nVVwAKg0APkZqODRp64+EqAdvnhOos8XmmyiLNJOEGr/7QjtRq0OO5C0vbY9MuQayp+PyMM4o8sH8iSiTZfj4+57O8Sma3bhkJ8wno= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641785149; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=JSj0fpDHzwAwiFlVXdbGaifIYwi1mxZZi6klGvMe6UY=; b=C4JlpfiNUAZt2ZiEo0v4G+DYqOR8nANIYW5bSUaR3kvZPGVJvBGggk/JbYgcP1+f/oMZ22spBHrFFAtKsqS/YRv9c0/OT1sXHLWBiKRhCvMixBeuhEOVyA0a20vgPc6NRjltV64JdGX6Ztivv35ntP3+zTxel7wNZ5m2qV0XHjM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85435+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1641785149605426.74028940003404; Sun, 9 Jan 2022 19:25:49 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id a1UGYY1788612xJMAI2MyDl6; Sun, 09 Jan 2022 19:25:49 -0800 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.27000.1641785147526775833 for ; Sun, 09 Jan 2022 19:25:48 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10222"; a="240694200" X-IronPort-AV: E=Sophos;i="5.88,275,1635231600"; d="scan'208";a="240694200" X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2022 19:25:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,275,1635231600"; d="scan'208";a="690430058" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.158]) by orsmga005.jf.intel.com with ESMTP; 09 Jan 2022 19:25:45 -0800 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Liming Gao Subject: [edk2-devel] [PATCH] Wiki: Add optional steps for developer to run CI test before sending Date: Mon, 10 Jan 2022 11:25:35 +0800 Message-Id: <20220110032535.232-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com X-Gm-Message-State: WGcVsdW2CzuzC9H7xPv0HczNx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1641785149; bh=pL8OaLsdawurfcLPT7zjzjpeYVD3p8Tvzs5e1KsTx3g=; h=Cc:Date:From:Reply-To:Subject:To; b=Y37HJd7WHzURZzNYgnbg7lsDN+DHfG/D4byk09Ulo8lT3NffKxCJOLGtc4/6QTUmUBT ADj1lluyKG7e1cTxVLT/lpu3V0VHmdiTT7bIcQOyNKz4I+v4VJxJkx9PBcNt0AagngvDx 0HdFuyRwBoRS2TGkbNgNli+DO6CQg0KSsns= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1641785151359100001 Content-Type: text/plain; charset="utf-8" Cc: Liming Gao Signed-off-by: Zhiguang Liu Reviewed-by: Guomin Jiang --- EDK-II-Development-Process.md | 60 +++++++++++++++++++++++++++++++++++++++= ++++++--------------- 1 file changed, 45 insertions(+), 15 deletions(-) diff --git a/EDK-II-Development-Process.md b/EDK-II-Development-Process.md index 469a979..747c6e1 100644 --- a/EDK-II-Development-Process.md +++ b/EDK-II-Development-Process.md @@ -59,20 +59,50 @@ The developer process for the EDK II project =20 `$ git rebase origin/master` =20 -9. Run the automated code formatting tool (Uncrustify) against your changes - - - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink") - - - The changes must pass local CI which includes a code formatting check - in order to be merged into the code base. - - - It is strongly recommended that you format the code after each commit. - The code can then be easily amended with the formatted output. Some - developers might also prefer to format frequently while writing the - code using the plugin instructions described in the code formatting - wiki page. - -10. Create patch (serial) to the [[edk2-devel]] mailing list +9. Run the automated code formatting tool (Uncrustify) against your changes + + - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink") + + - The changes must pass local CI which includes a code formatting check + in order to be merged into the code base. + + - It is strongly recommended that you format the code after each commit. + The code can then be easily amended with the formatted output. Some + developers might also prefer to format frequently while writing the + code using the plugin instructions described in the code formatting + wiki page. + +10. (Optional) Push changes to the developer's fork of the EDK II project + repository. + + - How to create a [GitHub fork](https://help.github.com/en/github/gett= ing-started-with-github/fork-a-repo) + - **NOTE:** A GitHub fork can also be created using the command line + utility called [`hub`](https://github.com/github/hub/releases). T= he + `hub` usage information can be found [here](https://hub.github.com= /hub.1.html). + + - Add remote to the developer's fork of the EDK II project + + `$ git remote add https://github.com//edk= 2.git` + + - Push the integration branch. + + `$ git push ` + +11. (Optional) Create a GitHub pull request from the developer's + to edk2/master to run CI check. + + - How to create a [GitHub pull request](https://help.github.com/en/git= hub/collaborating-with-issues-and-pull-requests/creating-a-pull-request) + - **NOTE:** A GitHub pull request can also be created using the comm= and + line utility called [`hub`](https://github.com/github/hub/releases= ). + The `hub` usage information can be found [here](https://hub.github= .com/hub.1.html). + + - Declare that it is for CI check test in the pull request title and + description. + + - Resolve GitHub pull request issues if it fails. Please refrence step= 8 + in the below **The maintainer process for the EDK II project** + +12. Create patch (serial) to the [[edk2-devel]] mailing list =20 - Clean out any old patches: `$ rm *.patch` =20 @@ -86,7 +116,7 @@ The developer process for the EDK II project =20 - `$ git send-email *.patch` =20 -11. Modify local commits based on the review feedbacks and repeat steps +13. Modify local commits based on the review feedbacks and repeat steps 3 to 9 =20 - For the latest commit, you can use `$ git commit --amend` --=20 2.32.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85435): https://edk2.groups.io/g/devel/message/85435 Mute This Topic: https://groups.io/mt/88316431/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-