From nobody Thu Apr 25 19:50:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85303+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85303+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1641517400; cv=none; d=zohomail.com; s=zohoarc; b=AEDA1fZQSqYj0dP4sMIB5kdDEeWL9YVpoJI1zI1q0BMBULuXwCyhjY0nPapc5kAcpV75Fj8jd1DA+tplLUn2Re4qnYpOXIi/dPnsZ2yXaqHC7oSNC9CNZzgVCTbjs9C/dXMCUQ6YWVRT3il/KLo/Mw33LJEClY/dGigi/nfWUt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641517400; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=N/Akt2hsdaU/z2lODvixZsEwXyrIB2Vdix6i4ZtJEyc=; b=mB5F5PBhvUSzlwvY209ozAoBBkAI4WuueXPd1MdsqtUFI+XA/dFCu0v7H1Ha2TWbpuWYbxTb1AC7tBJ1pMZnb3UtnCYQ0AOH22tNa5QcR9hDWEforerxI5+s2xljurt4RETdlitSWQ066pY+UDYrAbtIDkA3MQVsAAWieOAKWPI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85303+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1641517400343990.9688477039524; Thu, 6 Jan 2022 17:03:20 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5JZUYY1788612xOLYlGqzJLe; Thu, 06 Jan 2022 17:03:20 -0800 X-Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mx.groups.io with SMTP id smtpd.web11.763.1641517399300503964 for ; Thu, 06 Jan 2022 17:03:19 -0800 X-Received: by mail-pl1-f172.google.com with SMTP id c3so3694536pls.5 for ; Thu, 06 Jan 2022 17:03:19 -0800 (PST) X-Gm-Message-State: phWT1wWRYl9uF65FP4RDS851x1787277AA= X-Google-Smtp-Source: ABdhPJwOHcoyiTGty1WrpZpGIAiYGu0oxTm7Qo5z9LUMeBWqUPzHYrQniS8qppBypeeZgn2E1l9R4g== X-Received: by 2002:a17:902:f68f:b0:14a:76c:c55a with SMTP id l15-20020a170902f68f00b0014a076cc55amr402202plg.106.1641517398692; Thu, 06 Jan 2022 17:03:18 -0800 (PST) X-Received: from localhost.localdomain ([50.35.74.198]) by smtp.gmail.com with ESMTPSA id n14sm2907385pgd.80.2022.01.06.17.03.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 17:03:18 -0800 (PST) From: "Kun Qin" To: devel@edk2.groups.io Cc: Andrew Fish , Leif Lindholm , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v1 1/2] EDK2 Code First: PI Specification: New error codes of Host Software class Date: Thu, 6 Jan 2022 17:03:05 -0800 Message-Id: <20220107010306.1253-2-kuqin12@gmail.com> In-Reply-To: <20220107010306.1253-1-kuqin12@gmail.com> References: <20220107010306.1253-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1641517400; bh=h/HT7s5z0VP8xr3tq/MLhplMSHLs15lxPfaH2jUAgFI=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=MsxMy6SAZWaXu5P6NHeu1CvXrMCiyanAjw32phZu9RexqpvRDqRoeEYkdVzwWnb0ZNZ dwK6QENQ8gn0lJBtlVWijMwM+yNOt26OnlIIM4Twnn5B87BhWb6z+TbmZ19/qgFhr5BjI Tlk3esmc9ADy1/rVtN/RZxjOJYQJ1JU2Cl4= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1641517402580100005 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3794 This change includes specification update markdown file that describes the proposed PI Specification v1.7 Errata A in detail and potential impact to the existing codebase. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Kun Qin --- CodeFirst/BZ3794-SpecChange.md | 60 ++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/CodeFirst/BZ3794-SpecChange.md b/CodeFirst/BZ3794-SpecChange.md new file mode 100644 index 000000000000..bbb526896795 --- /dev/null +++ b/CodeFirst/BZ3794-SpecChange.md @@ -0,0 +1,60 @@ +# Title: Introduction of `EFI_MM_COMMUNICATE_HEADER_V3` and `MM_COMMUNICAT= E3_*` interface + +## Status: Draft + +## Document: UEFI Platform Initialization Specification Version 1.7 Errata= A + +## License + +SPDX-License-Identifier: CC-BY-4.0 + +## Submitter: [TianoCore Community](https://www.tianocore.org) + +## Summary of the change + +Introduce `EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE` and `EFI_SW_EC_RELEAS= E_ASSERT` into Status Codes definition. + +## Benefits of the change + +Current Status Codes covered various [software class error code definition= s](https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Pi/PiStatus= Code.h). + +However, there are a few critical instances where the software could trigg= er system reboots while the corresponding case was not covered by the alrea= dy defined status codes: + +1. Memory type information change triggered system reboot; +2. Assert triggered reboot on systems that did not enable system halts; + +The unexpected system reboots above could indicate decay of system health = and reporting of such generic events would provide helpful information to O= EMs to investigate/prevent system failures in general. + +The request of this change intends to expand definitions of `EFI_SW_EC_**`= under Status Codes to cover more unexpected system reboot events, which co= uld improve Status Code futility and readability. + +## Impact of the change + +Occupy 2 new macro definitions of Error Codes under Software class Status = Codes. + +## Detailed description of the change [normative updates] + +### Specification Changes + +1. In PI Specification v1.7 Errata A: Vol. 3, Table 3-61: Error Code Opera= tions: Host Software Class, add 2 new rows below `EFI_SW_EC_FV_CORRUPTED` d= efinition: + + | Operation | Description | Extended Data | + | --- | --- | --- | + | EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE | System will reboot due to= memory type information changes | None | + | EFI_SW_EC_RELEASE_ASSERT | System software asserted | None | + +1. In PI Specification v1.7 Errata A: Vol. 3, Table 3-61: Error Code Opera= tions: Host Software Class, replace the row of `0x0014=E2=80=930x00FF` to: + + | Operation | Description | Extended Data | + | --- | --- | --- | + | 0x0016=E2=80=930x00FF | Reserved for future use by this specificatio= n for Host Software class error codes. | None | + +1. In PI Specification v1.7 Errata A: Vol. 3, Section 6.7.4.3 Error Code D= efinitions: Prototype, add 2 new definitions below `EFI_SW_EC_FV_CORRUPTED`= definition: + + ```c + #define EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE 0x00000014 + #define EFI_SW_EC_RELEASE_ASSERT 0x00000015 + ``` + +### Code Changes + +1. Add macro definitions in `MdePkg/Include/Pi/PiStatusCode.h` to match ne= w specification. --=20 2.34.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85303): https://edk2.groups.io/g/devel/message/85303 Mute This Topic: https://groups.io/mt/88252485/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Thu Apr 25 19:50:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85304+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85304+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1641518103; cv=none; d=zohomail.com; s=zohoarc; b=LzW5h0+QJTg+Bxmv1a9L7TB8/mb9E69QfPiUfSq10Rmflbr1T0aGZyrFBboWhv8WKxUb/2izaLwm8Nb8wIYrXQYjHBwbG0gGTSpui2N9StrVA9bfeME55bSPdJ9Bp4hmqtjso/wiuASYbgEIknTYamFyNncVP/wdJIiGh6KRD48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641518103; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=38sdRKXbt9U9LWrSpihY6/IywaPZnbQcYYTQqd3y2sw=; b=b4W3Y6NLhwolpi38Dz3sRMh7lg4XnOp1tliroCi0JtbEHZb3ksHOKyBUjggGNUdUZohGtTKAJDkw1EBhB0pCm9g0YaxJJh1nUb7Y1OXLThCjinqPIF2spJUyluzerSYMbMuslsxH24kTaVJu6RrSX97hBvzxiZ8zBscey8N1kPA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85304+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1641518103807312.52482921452565; Thu, 6 Jan 2022 17:15:03 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 1xlPYY1788612xRE85o7cQya; Thu, 06 Jan 2022 17:15:03 -0800 X-Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mx.groups.io with SMTP id smtpd.web12.746.1641517399797902034 for ; Thu, 06 Jan 2022 17:03:19 -0800 X-Received: by mail-pg1-f172.google.com with SMTP id z30so571097pge.4 for ; Thu, 06 Jan 2022 17:03:19 -0800 (PST) X-Gm-Message-State: tji7k41IGooT1XicC0VEvsrFx1787277AA= X-Google-Smtp-Source: ABdhPJwRvsP0vwcKsH8FNswK29gZpAe5Xio1uBDpqf2ooU0gpc+vOHUxeG/Q5SJNLzuUHjx28HD08A== X-Received: by 2002:a63:7318:: with SMTP id o24mr3487500pgc.194.1641517399267; Thu, 06 Jan 2022 17:03:19 -0800 (PST) X-Received: from localhost.localdomain ([50.35.74.198]) by smtp.gmail.com with ESMTPSA id n14sm2907385pgd.80.2022.01.06.17.03.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 17:03:18 -0800 (PST) From: "Kun Qin" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH v1 2/2] MdePkg: MmCommunication: Add new Host Software class Error Codes to MdePkg Date: Thu, 6 Jan 2022 17:03:06 -0800 Message-Id: <20220107010306.1253-3-kuqin12@gmail.com> In-Reply-To: <20220107010306.1253-1-kuqin12@gmail.com> References: <20220107010306.1253-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1641518103; bh=l3ya0bCtq96Z3uazkfkoZROSMcpAOzH0A0jv2c5gGS0=; h=Cc:Date:From:Reply-To:Subject:To; b=fzcvZ1fhBz+a27+W60jPrCHfp0fOOClG8/kf3ZYJriOMDgMhUj+aIuKd2p/XsVrKsHs u7cRhSAXCHRRqpQmgnzA0unY+Bod0LTxDntDMK3aWJ/JQTd1V0Z4st/ERK3yZV76LYBhl WCcCBT6+Dntu2PnVLo73nMBt6LGCU6qjXdM= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1641518105863100006 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3794 This change introduces two new error code definitions under Host Software class. The new error code definitions will cover system reboot events under the conditions of memory type information change and software asserts when system did not enable system halts. These error codes could provide helpful datapoints to OEMs to investigate and prevent system failures in general. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Kun Qin --- MdePkg/Include/Pi/PiStatusCode.h | 42 ++++++++++---------- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/MdePkg/Include/Pi/PiStatusCode.h b/MdePkg/Include/Pi/PiStatusC= ode.h index ef2aea7364bc..6a1c9cc30f52 100644 --- a/MdePkg/Include/Pi/PiStatusCode.h +++ b/MdePkg/Include/Pi/PiStatusCode.h @@ -965,26 +965,28 @@ typedef struct { /// These are shared by all subclasses. /// ///@{ -#define EFI_SW_EC_NON_SPECIFIC 0x00000000 -#define EFI_SW_EC_LOAD_ERROR 0x00000001 -#define EFI_SW_EC_INVALID_PARAMETER 0x00000002 -#define EFI_SW_EC_UNSUPPORTED 0x00000003 -#define EFI_SW_EC_INVALID_BUFFER 0x00000004 -#define EFI_SW_EC_OUT_OF_RESOURCES 0x00000005 -#define EFI_SW_EC_ABORTED 0x00000006 -#define EFI_SW_EC_ILLEGAL_SOFTWARE_STATE 0x00000007 -#define EFI_SW_EC_ILLEGAL_HARDWARE_STATE 0x00000008 -#define EFI_SW_EC_START_ERROR 0x00000009 -#define EFI_SW_EC_BAD_DATE_TIME 0x0000000A -#define EFI_SW_EC_CFG_INVALID 0x0000000B -#define EFI_SW_EC_CFG_CLR_REQUEST 0x0000000C -#define EFI_SW_EC_CFG_DEFAULT 0x0000000D -#define EFI_SW_EC_PWD_INVALID 0x0000000E -#define EFI_SW_EC_PWD_CLR_REQUEST 0x0000000F -#define EFI_SW_EC_PWD_CLEARED 0x00000010 -#define EFI_SW_EC_EVENT_LOG_FULL 0x00000011 -#define EFI_SW_EC_WRITE_PROTECTED 0x00000012 -#define EFI_SW_EC_FV_CORRUPTED 0x00000013 +#define EFI_SW_EC_NON_SPECIFIC 0x00000000 +#define EFI_SW_EC_LOAD_ERROR 0x00000001 +#define EFI_SW_EC_INVALID_PARAMETER 0x00000002 +#define EFI_SW_EC_UNSUPPORTED 0x00000003 +#define EFI_SW_EC_INVALID_BUFFER 0x00000004 +#define EFI_SW_EC_OUT_OF_RESOURCES 0x00000005 +#define EFI_SW_EC_ABORTED 0x00000006 +#define EFI_SW_EC_ILLEGAL_SOFTWARE_STATE 0x00000007 +#define EFI_SW_EC_ILLEGAL_HARDWARE_STATE 0x00000008 +#define EFI_SW_EC_START_ERROR 0x00000009 +#define EFI_SW_EC_BAD_DATE_TIME 0x0000000A +#define EFI_SW_EC_CFG_INVALID 0x0000000B +#define EFI_SW_EC_CFG_CLR_REQUEST 0x0000000C +#define EFI_SW_EC_CFG_DEFAULT 0x0000000D +#define EFI_SW_EC_PWD_INVALID 0x0000000E +#define EFI_SW_EC_PWD_CLR_REQUEST 0x0000000F +#define EFI_SW_EC_PWD_CLEARED 0x00000010 +#define EFI_SW_EC_EVENT_LOG_FULL 0x00000011 +#define EFI_SW_EC_WRITE_PROTECTED 0x00000012 +#define EFI_SW_EC_FV_CORRUPTED 0x00000013 +#define EFI_SW_EC_MEMORY_TYPE_INFORMATION_CHANGE 0x00000014 +#define EFI_SW_EC_RELEASE_ASSERT 0x00000015 ///@} =20 // --=20 2.34.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85304): https://edk2.groups.io/g/devel/message/85304 Mute This Topic: https://groups.io/mt/88252486/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-