From nobody Tue Feb 10 01:15:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85120+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85120+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1640050454; cv=none; d=zohomail.com; s=zohoarc; b=nHsb4bghHGbh36yw4LqxaL06Oo/isIrD8T4wJo+f3t1Jj/g3vpbjI1OA+Xr5jJ0RezWjaZ33cGi4fzijY9kPuC4G4Epiaf2K4Es7jDypV0gu+nAIGJV+/agkI6Xa/8MhWPoya1lJS8q9eIznoCYiL/KsL1S1OGi/Ppj4BnLYmmw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1640050454; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=N0bXoBYbKJjdHu8mRzg8X/ZvWQGoUpbifVX7d6ZTJLo=; b=AScXwwSYoJJ5KrO99BpTzbSfHTU4tZ2r0c503nHIV8UJRUT12c2P5UzKXUR1TLreaTh5ngoJB9rs+J5HMlcR8Uu1fv0cV3ODgQOaPXGWS5PBHIk37RHlcVD8vCw9WbjoJ08vhVjp0R4wL5Qh2eQjaTT+pc/Tr3E8f928Y1dsWQc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85120+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 164005045450079.48822367378273; Mon, 20 Dec 2021 17:34:14 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9mD2YY1788612xvvjD4SP5Vl; Mon, 20 Dec 2021 17:34:14 -0800 X-Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mx.groups.io with SMTP id smtpd.web11.751.1640050453513536920 for ; Mon, 20 Dec 2021 17:34:13 -0800 X-Received: by mail-pj1-f41.google.com with SMTP id co15so11040141pjb.2 for ; Mon, 20 Dec 2021 17:34:13 -0800 (PST) X-Gm-Message-State: IpLpWT9HnCgCS3LhDBLy563kx1787277AA= X-Google-Smtp-Source: ABdhPJzqNHZHYTmx4E5rQZOIH4N51gPbIysjI7MoFxYWCXJNccu6PU3bz4CANTeht7ipacrr4YK4iw== X-Received: by 2002:a17:90a:db0f:: with SMTP id g15mr1213813pjv.76.1640050452986; Mon, 20 Dec 2021 17:34:12 -0800 (PST) X-Received: from localhost.localdomain ([50.35.74.198]) by smtp.gmail.com with ESMTPSA id m10sm17389189pgv.75.2021.12.20.17.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 17:34:12 -0800 (PST) From: "Kun Qin" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Bret Barkelew , Michael Kubacki Subject: [edk2-devel] [PATCH v2 4/6] ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**` checks Date: Mon, 20 Dec 2021 17:33:32 -0800 Message-Id: <20211221013334.1751-5-kuqin12@gmail.com> In-Reply-To: <20211221013334.1751-1-kuqin12@gmail.com> References: <20211221013334.1751-1-kuqin12@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kuqin12@gmail.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1640050454; bh=dg1QSzCcHQAr6B2ez6nqQtVHHJ1J09dOBTVld2kSca8=; h=Cc:Date:From:Reply-To:Subject:To; b=JPkiJDfSC1+WGsDQdJwvwmEMoN4kGP0YeGNUVi7ZaIczkatfdP6aUjTDBcZMi5RZC5T +wcZsfS3IUHYe8kFX+TJitLoYKLr+rAouWlyEwtHvswKd65QKUjV582/uyartpFbugrYq qH8TnC3ptWEZnQpKeMgOL7nnaDc9L9rxAxo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1640050455370100018 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3751 Current MM communicate routine from ArmPkg would conduct few checks prior to proceeding with SMC calls. However, the inspection step is different from PI specification. This patch updated MM communicate input argument inspection routine to assure that return code `EFI_INVALID_PARAMETER` represents "the `CommBuffer**` parameters do not refer to the same location in memory", as described by `EFI_MM_COMMUNICATION2_PROTOCOL.Communicate()` section in PI specification. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bret Barkelew Cc: Michael Kubacki Signed-off-by: Kun Qin --- Notes: v2: - Splitting patch into 2 of 4 [Ard] - Uncrustify style update ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c b/ArmPkg/D= rivers/MmCommunicationDxe/MmCommunication.c index 7f756a32d4e0..0283be430dff 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c @@ -83,7 +83,7 @@ MmCommunication2Communicate ( // // Check parameters // - if (CommBufferVirtual =3D=3D NULL) { + if ((CommBufferVirtual =3D=3D NULL) || (CommBufferPhysical =3D=3D NULL))= { return EFI_INVALID_PARAMETER; } =20 --=20 2.32.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85120): https://edk2.groups.io/g/devel/message/85120 Mute This Topic: https://groups.io/mt/87869776/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-