From nobody Mon Apr 29 18:54:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85034+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85034+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1639708650; cv=none; d=zohomail.com; s=zohoarc; b=k/dj+6U48f0oavhqAFom4Efw1oxn7S1emgLgFCpbH6prydDK95k78Rcrh/ReVFay0y/7jEEFfD1n25XMCepxEQgSg6bFH9qcoRS97TsED0vL2PN5QrHUQZX3uQxLynCuz/s96elNaz6sYdVIjXuORX6U8cLAH8N30MZMrnx4up0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639708650; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=BdSOWu8GJkbqi6uvOPEZAwB+CmUiUFO6g9tGwkKYMic=; b=n+1dkx/xS67MegAumOvS5t3B9QjeJNlwxNkOX2TGDqdxXvPT2HiMrLShLEeulluCq/hE+0NP1eN8ICr9dFvXPAipRtoV1Ft/+ji8wBZJj6Tl/MxXeSD2qbPaD4kV3C3YAMuTAGupUtmLv5HiAUdXUZEJ8L2wyfCnNseZ0CJNgPQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85034+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639708650548755.4800198615985; Thu, 16 Dec 2021 18:37:30 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id cn13YY1788612xWiIhWik2QA; Thu, 16 Dec 2021 18:37:30 -0800 X-Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mx.groups.io with SMTP id smtpd.web11.1534.1639708648874949969 for ; Thu, 16 Dec 2021 18:37:29 -0800 X-Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1BH0e2cJ004321 for ; Fri, 17 Dec 2021 02:37:27 GMT X-Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3cypc7aqd4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 17 Dec 2021 02:37:27 +0000 X-Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 1BH2bQUH020235 for ; Fri, 17 Dec 2021 02:37:27 GMT X-Received: from ppma03wdc.us.ibm.com (ba.79.3fa9.ip4.static.sl-reverse.com [169.63.121.186]) by mx0a-001b2d01.pphosted.com with ESMTP id 3cypc7aqcn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Dec 2021 02:37:26 +0000 X-Received: from pps.filterd (ppma03wdc.us.ibm.com [127.0.0.1]) by ppma03wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 1BH2Dnjo029367; Fri, 17 Dec 2021 02:37:25 GMT X-Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma03wdc.us.ibm.com with ESMTP id 3cy7gc98hh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Dec 2021 02:37:25 +0000 X-Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 1BH2bO7712976574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Dec 2021 02:37:25 GMT X-Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DFD16BE090; Fri, 17 Dec 2021 02:37:24 +0000 (GMT) X-Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9319CBE062; Fri, 17 Dec 2021 02:37:24 +0000 (GMT) X-Received: from sbct-2.pok.ibm.com (unknown [9.47.158.152]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 17 Dec 2021 02:37:24 +0000 (GMT) From: "Stefan Berger" To: devel@edk2.groups.io Cc: marcandre.lureau@redhat.com, shivanshu3@gmail.com, Stefan Berger Subject: [edk2-devel] [PATCH v2] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case Date: Thu, 16 Dec 2021 21:37:22 -0500 Message-Id: <20211217023722.280863-1-stefanb@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: C1_HsiX_vnybuNulBA36kFo2EfTqnVxs X-Proofpoint-GUID: tNQPXbIMVARJ8yvccuQ-rU3JuVvF_9dn Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,stefanb@linux.ibm.com X-Gm-Message-State: 7Qcqs5xWeCtDu7COhroscB65x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639708650; bh=mBVlGtACSc35EQFLO50JHzu4xL8R3xv3fRX90wFc+68=; h=Cc:Date:From:Reply-To:Subject:To; b=mfGybqemMx+UJ7tEhyDf3m0Id5rE8j2mwubF89KsePqjCOdy9Wbosg7bEEUKlgIW/TE XD7z6DPAQc5N90fMVA1hQUzMvGCGG6tFFh6PX36LnlvAZ0cZu+aDCMczwUgMqccXaFaQ+ Hn9L1UaOdCFvBvZ+niI8YFWYqswAHGOgOAQ= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639708652788100001 Content-Type: text/plain; charset="utf-8" For GPU passthrough support we have to initialize the console after EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after this. This was the calling order before the TCG physical presence support had to be moved and the console initialized earlier so user interaction could be supported before processing TCG physical presence opcodes. Signed-off-by: Stefan Berger Tested-by: Shivanshu Goyal --- OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 7 +++++++ OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 5 +++++ OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c | 5 +++++ 3 files changed, 17 insertions(+) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg= /Library/PlatformBootManagerLib/BdsPlatform.c index 5feadc51d7..0918c35f1f 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -448,6 +448,13 @@ PlatformBootManagerBeforeConsole ( // EfiBootManagerDispatchDeferredImages (); =20 + // + // GPU passthrough only allows Console enablement after ROM image load + // + PlatformInitializeConsole ( + XenDetected () ? gXenPlatformConsole : gPlatformConsole + ); + FrontPageTimeout =3D GetFrontPageTimeoutFromQemu (); PcdStatus =3D PcdSet16S (PcdPlatformBootTimeOut, FrontPageTimeout= ); ASSERT_RETURN_ERROR (PcdStatus); diff --git a/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c b/Ov= mfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c index 119f24b330..bf2701965f 100644 --- a/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c @@ -434,6 +434,11 @@ PlatformBootManagerBeforeConsole ( // EfiBootManagerDispatchDeferredImages (); =20 + // + // GPU passthrough only allows Console enablement after ROM image load + // + PlatformInitializeConsole (gPlatformConsole); + PlatformRegisterOptionsAndKeys (); =20 // diff --git a/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c b/Ovm= fPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c index 9c6848bbff..a402589206 100644 --- a/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c @@ -392,6 +392,11 @@ PlatformBootManagerBeforeConsole ( // EfiBootManagerDispatchDeferredImages (); =20 + // + // GPU passthrough only allows Console enablement after ROM image load + // + PlatformInitializeConsole (gPlatformConsole); + Status =3D gRT->SetVariable ( EFI_TIME_OUT_VARIABLE_NAME, &gEfiGlobalVariableGuid, --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85034): https://edk2.groups.io/g/devel/message/85034 Mute This Topic: https://groups.io/mt/87782120/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-